« previous next »
Pages: [1]   Go Down

Author Topic: Help - Illegal function call on a simple if  (Read 1361 times)

0 Members and 1 Guest are viewing this topic.

Offline 191Brian

  • Newbie
  • Posts: 91
    • My Itch page
Help - Illegal function call on a simple if
« on: February 24, 2021, 06:00:19 am »
Hi All

I guess I am missing something obvious but I must be going code blind.

I am getting a runtime error #5 illegal function call on line 39 which is just "        IF chg = 1 THEN   " in the YesNoBox function.

I use the same logic in the other function TextInputBox in this test program without error.

I am using version 1.5

Brian ...

Code: QB64: [Select]
  2.  
  3. CONST qbWHITE = _RGB32(255)
  4. CONST qbGREY = _RGB32(127)
  5. CONST qbBLACK = _RGB32(0)
  6. CONST qbDARKGREY = _RGB32(67, 67, 67)
  7. CONST qbORANGE = _RGB32(255, 128, 0)
  8. CONST qbYELLOW = _RGB32(255, 255, 0)
  9. CONST qbLIGHTGREY = _RGB32(64)
  10. CONST qbCHARS = "12345d67890-=qwertyuiop[]asdfghjkl;#\zxcvbnm,./QWERTYUIOPASDFGHJKLZXCVBNM!$%^&*()_+{}:@~|<>? "
  11.  
  13.  
  14. SCREEN _NEWIMAGE(800, 600, 32)
  15.  
  16. test = TextInputBox(200, 200, "some text", "")
  17.  
  18. PRINT YesNoBox(100, 100, "test")
  19.  
  20.  
  21.  
  22. FUNCTION YesNoBox$ (xPos AS INTEGER, yPos AS INTEGER, promptText AS STRING)
  23.     DIM char AS STRING
  24.     DIM chg AS INTEGER
  25.  
  26.     _KEYCLEAR
  27.     chg = 0
  28.     DO
  29.         char = INKEY$
  30.  
  31.         IF char <> YesNoBox THEN
  32.             chg = 1
  33.             YesNoBox = char
  34.         ELSEIF ASC(char) = 8 THEN 'backspace
  35.             YesNoBox = ""
  36.             chg = 1
  37.         END IF
  38.  
  39.         IF chg = 1 THEN
  40.             LINE (xPos, yPos)-(xPos + LEN(promptText) * 17, yPos + 50), qbLIGHTGREY, BF
  41.             LINE (xPos, yPos)-(xPos + LEN(promptText) * 17, yPos + 50), qbWHITE, B
  42.             _PRINTSTRING (xPos + 2, yPos + 5), promptText
  43.             _PRINTSTRING (xPos + 2, yPos + 30), YesNoBox
  44.             _DISPLAY
  45.         END IF
  46.  
  47.         chg = 0
  48.  
  49.  
  50.     LOOP UNTIL UCASE$(YesNoBox) = "Y" OR UCASE$(YesNoBox) = "N"
  51.  
  53.  
  54. FUNCTION TextInputBox$ (xPos AS INTEGER, yPos AS INTEGER, promptText AS STRING, defaultInput AS STRING)
  55.  
  56.     DIM charCount AS INTEGER
  57.     DIM char AS STRING
  58.     DIM chg AS INTEGER
  59.     charCount = 1
  60.     chg = 0
  61.     TextInputBox = defaultInput
  62.  
  63.     _KEYCLEAR
  64.     DO
  65.         char = INKEY$
  66.  
  67.         IF INSTR(qbCHARS, char) THEN
  68.             TextInputBox = TextInputBox + char
  69.             chg = 1
  70.         ELSEIF ASC(char) = 8 THEN
  71.             TextInputBox = LEFT$(TextInputBox, LEN(TextInputBox) - 1)
  72.             chg = 1
  73.         END IF
  74.         IF chg = 1 THEN
  75.             LINE (xPos, yPos)-(xPos + 300, yPos + 50), qbLIGHTGREY, BF
  76.             LINE (xPos, yPos)-(xPos + 300, yPos + 50), qbWHITE, B
  77.             _PRINTSTRING (xPos + 2, yPos + 5), promptText
  78.             _PRINTSTRING (xPos + 2, yPos + 30), TextInputBox
  79.             _DISPLAY
  80.         END IF
  81.         chg = 0
  82.     LOOP UNTIL _KEYDOWN(13)
  83.     _KEYCLEAR
  85.  

  [ You are not allowed to view this attachment ]  
Logged
Brian ...
Marked as best answer by 191Brian on February 24, 2021, 05:57:48 am

FellippeHeitor

  • Guest
Re: Help - Illegal function call on a simple if
« Reply #1 on: February 24, 2021, 07:40:44 am »
I don't know why it's picking the wrong line, but the error is happening in the line that checks ELSEIF ASC(char) = 8 THEN. ASC will fail if the string passed to it is empty, which will happen immediately in your code because char = INKEY$ and when the procedure is started, no key has been pressed yet. Use this change instead:

Code: QB64: [Select]
  2.  
  3. Const qbWHITE = _RGB32(255)
  4. Const qbGREY = _RGB32(127)
  5. Const qbBLACK = _RGB32(0)
  6. Const qbDARKGREY = _RGB32(67, 67, 67)
  7. Const qbORANGE = _RGB32(255, 128, 0)
  8. Const qbYELLOW = _RGB32(255, 255, 0)
  9. Const qbLIGHTGREY = _RGB32(64)
  10. Const qbCHARS = "12345d67890-=qwertyuiop[]asdfghjkl;#\zxcvbnm,./QWERTYUIOPASDFGHJKLZXCVBNM!$%^&*()_+{}:@~|<>? "
  11.  
  13.  
  14. Screen _NewImage(800, 600, 32)
  15.  
  16. test = TextInputBox(200, 200, "some text", "")
  17.  
  18. Print YesNoBox(100, 100, "test")
  19.  
  20.  
  21.  
  22. Function YesNoBox$ (xPos As Integer, yPos As Integer, promptText As String)
  23.     Dim char As String
  24.     Dim chg As Integer
  25.  
  26.     _KeyClear
  27.     chg = 0
  28.     Do
  29.         char = InKey$
  30.  
  31.         If char <> YesNoBox Then
  32.             chg = 1
  33.             YesNoBox = char
  34.         ElseIf char = Chr$(8) Then 'backspace
  35.             YesNoBox = ""
  36.             chg = 1
  37.         End If
  38.  
  39.         If chg = 1 Then
  40.             Line (xPos, yPos)-(xPos + Len(promptText) * 17, yPos + 50), qbLIGHTGREY, BF
  41.             Line (xPos, yPos)-(xPos + Len(promptText) * 17, yPos + 50), qbWHITE, B
  42.             _PrintString (xPos + 2, yPos + 5), promptText
  43.             _PrintString (xPos + 2, yPos + 30), YesNoBox
  44.             _Display
  45.         End If
  46.  
  47.         chg = 0
  48.  
  49.  
  50.     Loop Until UCase$(YesNoBox) = "Y" Or UCase$(YesNoBox) = "N"
  51.  
  53.  
  54. Function TextInputBox$ (xPos As Integer, yPos As Integer, promptText As String, defaultInput As String)
  55.  
  56.     Dim charCount As Integer
  57.     Dim char As String
  58.     Dim chg As Integer
  59.     charCount = 1
  60.     chg = 0
  61.     TextInputBox = defaultInput
  62.  
  63.     _KeyClear
  64.     Do
  65.         char = InKey$
  66.  
  67.         If InStr(qbCHARS, char) Then
  68.             TextInputBox = TextInputBox + char
  69.             chg = 1
  70.         ElseIf char = Chr$(8) Then
  71.             TextInputBox = Left$(TextInputBox, Len(TextInputBox) - 1)
  72.             chg = 1
  73.         End If
  74.         If chg = 1 Then
  75.             Line (xPos, yPos)-(xPos + 300, yPos + 50), qbLIGHTGREY, BF
  76.             Line (xPos, yPos)-(xPos + 300, yPos + 50), qbWHITE, B
  77.             _PrintString (xPos + 2, yPos + 5), promptText
  78.             _PrintString (xPos + 2, yPos + 30), TextInputBox
  79.             _Display
  80.         End If
  81.         chg = 0
  82.     Loop Until _KeyDown(13)
  83.     _KeyClear
  85.  
  86.  
Logged

Offline 191Brian

  • Newbie
  • Posts: 91
    • My Itch page
Re: Help - Illegal function call on a simple if
« Reply #2 on: February 24, 2021, 10:57:31 am »
Thank you Fellippe I went around in circles trying to find the problem.

Brian ...
Quote from: FellippeHeitor on February 24, 2021, 07:40:44 am
I don't know why it's picking the wrong line, but the error is happening in the line that checks ELSEIF ASC(char) = 8 THEN. ASC will fail if the string passed to it is empty, which will happen immediately in your code because char = INKEY$ and when the procedure is started, no key has been pressed yet. Use this change instead:

Code: QB64: [Select]
  2.  
  3. Const qbWHITE = _RGB32(255)
  4. Const qbGREY = _RGB32(127)
  5. Const qbBLACK = _RGB32(0)
  6. Const qbDARKGREY = _RGB32(67, 67, 67)
  7. Const qbORANGE = _RGB32(255, 128, 0)
  8. Const qbYELLOW = _RGB32(255, 255, 0)
  9. Const qbLIGHTGREY = _RGB32(64)
  10. Const qbCHARS = "12345d67890-=qwertyuiop[]asdfghjkl;#\zxcvbnm,./QWERTYUIOPASDFGHJKLZXCVBNM!$%^&*()_+{}:@~|<>? "
  11.  
  13.  
  14. Screen _NewImage(800, 600, 32)
  15.  
  16. test = TextInputBox(200, 200, "some text", "")
  17.  
  18. Print YesNoBox(100, 100, "test")
  19.  
  20.  
  21.  
  22. Function YesNoBox$ (xPos As Integer, yPos As Integer, promptText As String)
  23.     Dim char As String
  24.     Dim chg As Integer
  25.  
  26.     _KeyClear
  27.     chg = 0
  28.     Do
  29.         char = InKey$
  30.  
  31.         If char <> YesNoBox Then
  32.             chg = 1
  33.             YesNoBox = char
  34.         ElseIf char = Chr$(8) Then 'backspace
  35.             YesNoBox = ""
  36.             chg = 1
  37.         End If
  38.  
  39.         If chg = 1 Then
  40.             Line (xPos, yPos)-(xPos + Len(promptText) * 17, yPos + 50), qbLIGHTGREY, BF
  41.             Line (xPos, yPos)-(xPos + Len(promptText) * 17, yPos + 50), qbWHITE, B
  42.             _PrintString (xPos + 2, yPos + 5), promptText
  43.             _PrintString (xPos + 2, yPos + 30), YesNoBox
  44.             _Display
  45.         End If
  46.  
  47.         chg = 0
  48.  
  49.  
  50.     Loop Until UCase$(YesNoBox) = "Y" Or UCase$(YesNoBox) = "N"
  51.  
  53.  
  54. Function TextInputBox$ (xPos As Integer, yPos As Integer, promptText As String, defaultInput As String)
  55.  
  56.     Dim charCount As Integer
  57.     Dim char As String
  58.     Dim chg As Integer
  59.     charCount = 1
  60.     chg = 0
  61.     TextInputBox = defaultInput
  62.  
  63.     _KeyClear
  64.     Do
  65.         char = InKey$
  66.  
  67.         If InStr(qbCHARS, char) Then
  68.             TextInputBox = TextInputBox + char
  69.             chg = 1
  70.         ElseIf char = Chr$(8) Then
  71.             TextInputBox = Left$(TextInputBox, Len(TextInputBox) - 1)
  72.             chg = 1
  73.         End If
  74.         If chg = 1 Then
  75.             Line (xPos, yPos)-(xPos + 300, yPos + 50), qbLIGHTGREY, BF
  76.             Line (xPos, yPos)-(xPos + 300, yPos + 50), qbWHITE, B
  77.             _PrintString (xPos + 2, yPos + 5), promptText
  78.             _PrintString (xPos + 2, yPos + 30), TextInputBox
  79.             _Display
  80.         End If
  81.         chg = 0
  82.     Loop Until _KeyDown(13)
  83.     _KeyClear
  85.  
  86.  
Logged
Brian ...
Pages: [1]   Go Up
« previous next »