I can't decide which I like best...

[Pete]

I actually kept two ways of determining running accounts of instances of phone numbers in one of my database programs. I seldom if never do that, but I couldn't decide which one I liked the best, so I used each one in two separate parts of the program. Any thoughts of one being better than the other, or maybe another method?

Code: QB64: [Select]

1. WIDTH 144, 25
2. _SCREENMOVE 0, 0
3. DO
4.     READ mydata$
5.     IF mydata$ = "EOF" THEN EXIT DO
6.     j = 1: occ% = 0
7.     dataconcat$ = mydata$ + "|" + dataconcat$
8.     DO UNTIL j > LEN(dataconcat$)
9.         IF INSTR(j, dataconcat$, mydata$ + "|") - j = 0 THEN occ% = occ% + 1
10.         j = INSTR(j, dataconcat$, "|") + 1
11.     LOOP
12.     PRINT mydata$; "#"; LTRIM$(STR$(occ%)); ", ";
13. LOOP
14. dataconcat$ = ""
15. PRINT "End Method #1."
16.  
17. PRINT: RESTORE
18.  
19. DO
20.     READ mydata$
21.     IF mydata$ = "EOF" THEN EXIT DO
22.     j = 0: occ% = 0
23.     dataconcat$ = mydata$ + "|" + dataconcat$
24.     DO UNTIL j > LEN(dataconcat$)
25.         k = INSTR(j, dataconcat$, "|") - j
26.         IF MID$(dataconcat$, j, k) = mydata$ THEN occ% = occ% + 1
27.         j = j + k + 1
28.     LOOP
29.     PRINT mydata$; "#"; LTRIM$(STR$(occ%)); ", ";
30. LOOP
31. dataconcat$ = ""
32. PRINT "End Method #2."
33.  
34. DATA dog,cat,rabbit,frog,horse,dog,mouse,pig,cat,bat,cat,dog,bird,fish,cat,pig,dog
35. DATA EOF

Pete

[bplus]

Do you like alphabetic order?

loadsort demo:

Code: QB64: [Select]

1. REDIM dat$(0)
2. DO
3.     READ insert$
4.     IF insert$ <> "EOD" THEN loadSort insert$, dat$() ELSE EXIT DO
5. LOOP
6. FOR i = LBOUND(dat$) TO UBOUND(dat$)
7.     IF dat$(i) <> "" THEN
8.         PRINT dat$(i)
9.         IF concat$ = "" THEN concat$ = dat$(i) ELSE concat$ = concat$ + ", " + dat$(i)
10.     END IF
11. NEXT
12. PRINT: PRINT concat$
13.  
14. DATA dog,cat,rabbit,frog,horse,dog,mouse,pig,cat,bat,cat,dog,bird,fish,cat,pig,dog,EOD
15.  
16. SUB loadSort (insertN AS STRING, dynArr() AS STRING) '  version 2020-06-07
17.     'note this leaves dynArr(0) empty! so ubound of array is also number of items in list
18.     DIM ub, j, k
19.     ub = UBOUND(dynArr) + 1
20.     REDIM _PRESERVE dynArr(LBOUND(dynArr) TO ub) AS STRING
21.     FOR j = 1 TO ub - 1
22.         IF insertN < dynArr(j) THEN '  GT to LT according to descending or ascending sort
23.             FOR k = ub TO j + 1 STEP -1
24.                 dynArr(k) = dynArr(k - 1)
25.             NEXT
26.             EXIT FOR
27.         END IF
28.     NEXT
29.     dynArr(j) = insertN
30. END SUB
31.  
32.  

with animal counts:

Code: QB64: [Select]

1. REDIM dat$(0)
2. DO
3.     READ insert$
4.     IF insert$ <> "EOD" THEN loadSort insert$, dat$() ELSE EXIT DO
5. LOOP
6. FOR i = LBOUND(dat$) TO UBOUND(dat$)
7.     IF dat$(i) <> "" THEN
8.         PRINT dat$(i)
9.         IF concat$ = "" THEN
10.             lastWord$ = dat$(i)
11.             cntWord = 1
12.             concat$ = dat$(i) + "#" + _TRIM$(STR$(cntWord))
13.         ELSE
14.             IF dat$(i) = lastWord$ THEN cntWord = cntWord + 1 ELSE cntWord = 1: lastWord$ = dat$(i)
15.             concat$ = concat$ + ", " + dat$(i) + "#" + _TRIM$(STR$(cntWord))
16.         END IF
17.     END IF
18. NEXT
19. PRINT: PRINT concat$
20.  
21. DATA dog,cat,rabbit,frog,horse,dog,mouse,pig,cat,bat,cat,dog,bird,fish,cat,pig,dog,EOD
22.  
23. SUB loadSort (insertN AS STRING, dynArr() AS STRING) '  version 2020-06-07
24.     'note this leaves dynArr(0) empty! so ubound of array is also number of items in list
25.     DIM ub, j, k
26.     ub = UBOUND(dynArr) + 1
27.     REDIM _PRESERVE dynArr(LBOUND(dynArr) TO ub) AS STRING
28.     FOR j = 1 TO ub - 1
29.         IF insertN < dynArr(j) THEN '  GT to LT according to descending or ascending sort
30.             FOR k = ub TO j + 1 STEP -1
31.                 dynArr(k) = dynArr(k - 1)
32.             NEXT
33.             EXIT FOR
34.         END IF
35.     NEXT
36.     dynArr(j) = insertN
37. END SUB
38.  
39.  

[Pete]

Nice, Mark.

My way to add an array and place the results in alphabetical order would be as follows...

Code: QB64: [Select]

1. WIDTH 144, 25
2. _SCREENMOVE 0, 0
3. j = 0
4. DO
5.     READ mydata$
6.     IF mydata$ = "EOF" THEN EXIT DO
7.     j = j + 1
8. LOOP
9. RESTORE
10. DIM myarray$(j)
11.  
12. DO
13.     READ mydata$
14.     IF mydata$ = "EOF" THEN EXIT DO
15.     j = 1: occ% = 0: h = h + 1
16.     dataconcat$ = mydata$ + "|" + dataconcat$
17.     DO UNTIL j > LEN(dataconcat$)
18.         IF INSTR(j, dataconcat$, mydata$ + "|") - j = 0 THEN occ% = occ% + 1
19.         j = INSTR(j, dataconcat$, "|") + 1
20.     LOOP
21.     myarray$(h) = mydata$ + "#" + LTRIM$(STR$(occ%))
22. LOOP
23. dataconcat$ = ""
24. FOR i = 1 TO h
25.     FOR j = 1 TO h
26.         IF i <> j THEN
27.             IF myarray$(i) < myarray$(j) THEN SWAP myarray$(i), myarray$(j)
28.         END IF
29. NEXT j, i
30. FOR i = 1 TO h
31.     PRINT myarray$(i); ", ";
32. NEXT
33. PRINT "End Method #1."
34.  
35. DATA dog,cat,rabbit,frog,horse,dog,mouse,pig,cat,bat,cat,dog,bird,fish,cat,pig,dog
36. DATA EOF
37.  

Pete

[SpriggsySpriggs]

I'd use PowerShell to sort the data :)
https://stackoverflow.com/questions/32385611/sort-very-large-text-file-in-powershell

[bplus]

Hi Pete,

Line 5 is out of data even when I add the data line?

Never mind, you are looking for EOF, my End Of Data is EOD

[bplus]

I'd use PowerShell to sort the data :)
https://stackoverflow.com/questions/32385611/sort-very-large-text-file-in-powershell

But powershell can't load the data from a bas file.


I'd use qsort for a more serious array size, something more than Pete's Ark.

[Pete]

PowerShell? Where's the fun in that? You'd probably use a rifle to hunt deer, too. Sigh. Just do what I do. Run them down and tear them apart with your bare hands. So you take a few hoof kicks to the head, so what? So you take a few hoof kicks to the head, so what? So you take a few hoof kicks to the head, so what?

Pete

[STxAxTIC]

This response made me genuinely LOL.

[Pete]

Hi Pete,

Line 5 is out of data even when I add the data line?

Never mind, you are looking for EOF, my End Of Data is EOD

I've always used EOF from 20 years back, as: "End of File"  I like EOD, though. Anyway, you must have cut and pasted my code just before I edited in the data!


@Bill: Glad you liked it. Glad you liked it. Glad you liked it.

Pete

[bplus]

It's difficult to see a great difference between Method#1 and Method#2 but it's interesting you chose Method#1 for the sort demo.

[Pete]

I chose #1, because I thought it was a bit cleaner of an approach, but I also liked #2, because it used MID$() to chop away at the concatenated string. My guess is with any code, it all comes down to which would perform the fastest in a speed test, maybe matched with the elegance of the code, itself. Still, if there was a bathing suit contest, I'd be more prone to watch.

Pete

[bplus]

I kinda like #1 because no extra variable k.

Are you going to try a speed test?

[Pete]

Not on my computers. Long gone are the days where I used to have state of the art systems. Right now, it mostly depends on what the OS is up to, how my programs respond. I've noticed with some of the speed tests we did around here in the past, my results were way to inconsistent to be of any use. Since I'm not a gamer, it doesn't bother me in the least but I do get a kick out of the responsiveness in high end systems. I mean from my days of coding with a tape recorder as a drive, and 4K of memory, we've come a long way.

Yeah, I liked being rid of that "k" as well.

Pete

[bplus]

Make sure I am around when you try the swimsuit contest :)

[Pete]

'K.