Blocking stuff D:

[TempodiBasic]

Hi Prithak

you're welcome!
I can see that you go over very well choosing your  solution for the logical issue.
I'll wait news on this you project.

Good Luck

[TempodiBasic]

Hi Prithak

looking at your new code I have got the error of Read past end of file...
it seems a glicth of EOF in fact if you see the debug output after reading the second line of data correctly EOF gives still 0 as output and not -1! so the loop tries to read another time and Runtime error!

here code with a raw tracing debug session

Code: QB64: [Select]

1. SCREEN _NEWIMAGE(1280, 720, 32)
2.  
3. TYPE vec1
4.     x AS INTEGER
5.     y AS INTEGER
6.     speed AS INTEGER
7. END TYPE
8.  
9. TYPE vec2
10.     x1 AS INTEGER
11.     y1 AS INTEGER
12.     x2 AS INTEGER
13.     y2 AS INTEGER
14.     r AS INTEGER
15.     g AS INTEGER
16.     b AS INTEGER
17.     btype AS STRING
18.     oldx AS INTEGER
19.     oldy AS INTEGER
20.     wl AS STRING
21. END TYPE
22.  
23.  
24. DIM SHARED player AS vec1
25. DIM SHARED map AS STRING
26. DIM SHARED obstacle(9) AS vec2
27. player.speed = 5
28.  
29. DIM SHARED i AS INTEGER
30.  
31. map = "map1.txt"
32.  
33. player.x = _WIDTH / 2
34. player.y = _HEIGHT / 2
35.  
36. openMap
37. j = 1
38. DO
39.     CLS
40.  
41.     makeplayer
42.     playerMovement
43.  
44.     FOR j = 1 TO i
45.         IF obstacle(j).btype = "obs" THEN
46.             LINE (obstacle(j).x1, obstacle(j).y1)-(obstacle(j).x2, obstacle(j).y2), _RGB32(obstacle(j).r, obstacle(j).g, obstacle(j).b), BF
47.             IF player.x + 10 >= obstacle(j).x1 AND player.x - 10 <= obstacle(j).x2 AND player.y + 10 >= obstacle(j).y1 AND player.y - 10 <= obstacle(j).y2 THEN
48.                 player.x = obstacle(j).oldx
49.                 player.y = obstacle(j).oldy
50.             ELSE
51.                 obstacle(j).oldx = player.x
52.                 obstacle(j).oldy = player.y
53.             END IF
54.         ELSEIF obstacle(j).btype = "warp" THEN
55.             LINE (obstacle(j).x1, obstacle(j).y1)-(obstacle(j).x2, obstacle(j).y2), _RGB32(obstacle(j).r, obstacle(j).g, obstacle(j).b), BF
56.             IF collision%(obstacle(j).x1, obstacle(j).y1, obstacle(j).x2, obstacle(j).y2) THEN
57.                 map = obstacle(j).wl ' here there was a mystyping i for j
58.                 openMap
59.             END IF
60.         END IF
61.     NEXT j
62.  
63.     _DISPLAY
64.     _LIMIT 120
65. LOOP
66.  
67. SUB openMap ' the program gets past end of file but reads obstacle(i).wl warps
68.     i = 0
69.     OPEN map FOR INPUT AS #1
70.     LOCATE 10
71.     WHILE NOT EOF(1)
72.         i = i + 1
73.         INPUT #1, obstacle(i).btype, obstacle(i).x1, obstacle(i).y1, obstacle(i).x2, obstacle(i).y2, obstacle(i).r, obstacle(i).g, obstacle(i).b
74.         IF obstacle(i).btype = "warp" THEN INPUT #1, obstacle(i).wl
75.         ' just some debug prints...
76.         PRINT "i = ", i
77.         PRINT obstacle(i).btype, obstacle(i).x1, obstacle(i).y1, obstacle(i).x2, obstacle(i).y2, obstacle(i).r, obstacle(i).g, obstacle(i).b, obstacle(i).wl
78.         PRINT "EOF"; EOF(1); " press a key for the next run of cycle"
79.         SLEEP ' just to trace into loop
80.     WEND
81.     CLOSE #1
82. END SUB
83.  
84. SUB makeplayer
85.     CIRCLE (player.x, player.y), 10, _RGB32(100, 200, 255)
86.     PAINT (player.x, player.y), _RGB32(100, 200, 255), _RGB32(100, 200, 255)
87. END SUB
88.  
89. SUB playerMovement
90.     IF _KEYDOWN(18432) THEN player.y = player.y - player.speed
91.     IF _KEYDOWN(20480) THEN player.y = player.y + player.speed
92.     IF _KEYDOWN(19200) THEN player.x = player.x - player.speed
93.     IF _KEYDOWN(19712) THEN player.x = player.x + player.speed
94. END SUB
95.  
96. FUNCTION collision% (x1, y1, x2, y2)
97.     IF player.x >= x1 AND player.x <= x2 AND player.y >= y1 AND player.y <= y2 THEN
98.         collision% = 1
99.     END IF
100. END FUNCTION
101.  

But in your PC do all run good?
I have saved the map1.txt and map2.txt copying them and pasting into QB64IDE and after saving to the HDD as txt files.
Can this make a difference? (QB64ide adds something at the end of the file?... just a minute to create another 2 files using notepad.exe of windows....
Yes the solution is that QB64 adds something at the end of the file... now your code works very good

[Ashish]

QB64 adds extra one line at the end of the file and this line just contain CRLF. Due to this, EOF(1) still give 0. Now, since EOF(1) is still false or 0,
input #1,.... is again executed but there are no data due to which "input past end of file" occur.

[Prithak]

Well, that was odd but glad you got that sorted out lol

[TempodiBasic]

Hi Ashish
thanks to confirm my hypothesis...
so it can be useful to have the option in QB64IDE to save simple TXT file without this CFRL at the end... as can do Qbasic and QB45.

Yes we can do this using another editor for creating and modifing  simple text files... but is it the same thing?

[EricE]

You could use LINE INPUT to read entire line into a string variable.
If the string variable is equal to CRLF, then read another line from the file.

[TempodiBasic]

@EricE 
thanks for your idea
but I'm focusing on the fact that for now it is better to use a filedata.txt made by notepad.exe  and not with QB64IDE to not get an error read past of end of file .
Then we can argue about if it is the best way to store informations for a program, but that is another issue about talk.

[Unseen Machine]

Then we can argue about if it is the best way to store informations for a program, but that is another issue about talk.

Glad to see this progressing, great work...now as for storing the data, now your using TYPE's to store the information i'd suggest a binary file and just use PUT/GET, it's easier and file reads are much much faster than INPUT/LINE INPUT.

Unseen

[TempodiBasic]

@Unseen Machine
yes this argument is interesting
about using GET and PUT and a different access to the file we must be careful to the UDT with string with variable lenght,
it is easy to GET wrong value from file. It is safe to use Fixed string.

  [ You are not allowed to view this attachment ]  

[luke]

Please note that a variable-length UDT (one with a variable-length string in it) cannot be used with GET or PUT.

[TempodiBasic]

Hi Luke
Thanks to reply
I agree with you at 90%  for these two experiences .


this is about OPEN RANDOM and GET

Code: QB64: [Select]

1. SCREEN _NEWIMAGE(1280, 720, 32)
2. $CONSOLE
3.  
4. TYPE vec1
5.     x AS INTEGER
6.     y AS INTEGER
7.     speed AS INTEGER
8. END TYPE
9.  
10. TYPE vec2
11.     x1 AS INTEGER
12.     y1 AS INTEGER
13.     x2 AS INTEGER
14.     y2 AS INTEGER
15.     r AS INTEGER
16.     g AS INTEGER
17.     b AS INTEGER
18.     btype AS STRING
19.     oldx AS INTEGER
20.     oldy AS INTEGER
21.     wl AS STRING
22. END TYPE
23.  
24.  
25. DIM SHARED player AS vec1
26. DIM SHARED map AS STRING
27. DIM SHARED obstacle(9) AS vec2
28. player.speed = 5
29.  
30. DIM SHARED i AS INTEGER
31.  
32. map = "map1.new"
33.  
34. player.x = _WIDTH / 2
35. player.y = _HEIGHT / 2
36.  
37. openMap
38. j = 1
39. DO
40.     CLS
41.     makeplayer
42.     playerMovement
43.  
44.     FOR j = 1 TO i
45.         IF obstacle(j).btype = "obs" THEN
46.             LINE (obstacle(j).x1, obstacle(j).y1)-(obstacle(j).x2, obstacle(j).y2), _RGB32(obstacle(j).r, obstacle(j).g, obstacle(j).b), BF
47.             IF player.x + 10 >= obstacle(j).x1 AND player.x - 10 <= obstacle(j).x2 AND player.y + 10 >= obstacle(j).y1 AND player.y - 10 <= obstacle(j).y2 THEN
48.                 player.x = obstacle(j).oldx
49.                 player.y = obstacle(j).oldy
50.             ELSE
51.                 obstacle(j).oldx = player.x
52.                 obstacle(j).oldy = player.y
53.             END IF
54.         ELSEIF obstacle(j).btype = "warp" THEN
55.             LINE (obstacle(j).x1, obstacle(j).y1)-(obstacle(j).x2, obstacle(j).y2), _RGB32(obstacle(j).r, obstacle(j).g, obstacle(j).b), BF
56.             IF collision%(obstacle(j).x1, obstacle(j).y1, obstacle(j).x2, obstacle(j).y2) THEN
57.                 map = obstacle(j).wl ' here there was a mystyping i for j
58.                 openMap
59.             END IF
60.         END IF
61.     NEXT j
62.  
63.     _DISPLAY
64.     _LIMIT 120
65. LOOP
66.  
67. SUB openMap ' the program gets past end of file but reads obstacle(i).wl warps
68.     i = 0
69.     OPEN map FOR RANDOM AS #1
70.     'len  = len(obstacle()) len of record is managed at level of parser
71.     'but you can open a file in RANDOM mode without say  how is the size of UDT
72.     ' if you use the default size or if you use the single fields
73.     WHILE NOT EOF(1)
74.         i = i + 1
75.         ' get #1, , obstacle()  <--  this is managed at level of parser
76.         GET #1, , obstacle(i).btype
77.         GET #1, , obstacle(i).x1
78.         GET #1, , obstacle(i).y1
79.         GET #1, , obstacle(i).x2
80.         GET #1, , obstacle(i).y2
81.         GET #1, , obstacle(i).r
82.         GET #1, , obstacle(i).g
83.         GET #1, , obstacle(i).b
84.         GET #1, , obstacle(i).wl '  <-- this is not managed at level of parser
85.         ' so a dummy use of GET (like me in this example),
86.         'reading each field at a time, reads until out of file
87.  
88.         ' just some debug prints...
89.         _DEST _CONSOLE
90.         PRINT "i = ", i
91.         PRINT obstacle(i).btype, obstacle(i).x1, obstacle(i).y1, obstacle(i).x2, obstacle(i).y2, obstacle(i).r, obstacle(i).g, obstacle(i).b, obstacle(i).wl
92.         PRINT "EOF"; EOF(1); " press a key for the next run of cycle"
93.         _DEST 0
94.     WEND
95.     CLOSE #1
96. END SUB
97.  
98. SUB makeplayer
99.     CIRCLE (player.x, player.y), 10, _RGB32(100, 200, 255)
100.     PAINT (player.x, player.y), _RGB32(100, 200, 255), _RGB32(100, 200, 255)
101. END SUB
102.  
103. SUB playerMovement
104.     IF _KEYDOWN(18432) THEN player.y = player.y - player.speed
105.     IF _KEYDOWN(20480) THEN player.y = player.y + player.speed
106.     IF _KEYDOWN(19200) THEN player.x = player.x - player.speed
107.     IF _KEYDOWN(19712) THEN player.x = player.x + player.speed
108. END SUB
109.  
110. FUNCTION collision% (x1, y1, x2, y2)
111.     IF player.x >= x1 AND player.x <= x2 AND player.y >= y1 AND player.y <= y2 THEN
112.         collision% = 1
113.     END IF
114. END FUNCTION
115.  

and this with OPEN BINARY and GET

Code: QB64: [Select]

1. SCREEN _NEWIMAGE(1280, 720, 32)
2. $CONSOLE
3.  
4. TYPE vec1
5.     x AS INTEGER
6.     y AS INTEGER
7.     speed AS INTEGER
8. END TYPE
9.  
10. TYPE vec2
11.     x1 AS INTEGER
12.     y1 AS INTEGER
13.     x2 AS INTEGER
14.     y2 AS INTEGER
15.     r AS INTEGER
16.     g AS INTEGER
17.     b AS INTEGER
18.     btype AS STRING
19.     oldx AS INTEGER
20.     oldy AS INTEGER
21.     wl AS STRING
22. END TYPE
23.  
24.  
25. DIM SHARED player AS vec1
26. DIM SHARED map AS STRING
27. DIM SHARED obstacle(9) AS vec2
28. player.speed = 5
29.  
30. DIM SHARED i AS INTEGER
31.  
32. map = "map1.new"
33.  
34. player.x = _WIDTH / 2
35. player.y = _HEIGHT / 2
36.  
37. openMap
38. j = 1
39. DO
40.     CLS
41.     makeplayer
42.     playerMovement
43.  
44.     FOR j = 1 TO i
45.         IF obstacle(j).btype = "obs" THEN
46.             LINE (obstacle(j).x1, obstacle(j).y1)-(obstacle(j).x2, obstacle(j).y2), _RGB32(obstacle(j).r, obstacle(j).g, obstacle(j).b), BF
47.             IF player.x + 10 >= obstacle(j).x1 AND player.x - 10 <= obstacle(j).x2 AND player.y + 10 >= obstacle(j).y1 AND player.y - 10 <= obstacle(j).y2 THEN
48.                 player.x = obstacle(j).oldx
49.                 player.y = obstacle(j).oldy
50.             ELSE
51.                 obstacle(j).oldx = player.x
52.                 obstacle(j).oldy = player.y
53.             END IF
54.         ELSEIF obstacle(j).btype = "warp" THEN
55.             LINE (obstacle(j).x1, obstacle(j).y1)-(obstacle(j).x2, obstacle(j).y2), _RGB32(obstacle(j).r, obstacle(j).g, obstacle(j).b), BF
56.             IF collision%(obstacle(j).x1, obstacle(j).y1, obstacle(j).x2, obstacle(j).y2) THEN
57.                 map = obstacle(j).wl ' here there was a mystyping i for j
58.                 openMap
59.             END IF
60.         END IF
61.     NEXT j
62.  
63.     _DISPLAY
64.     _LIMIT 120
65. LOOP
66.  
67. SUB openMap ' the program gets past end of file but reads obstacle(i).wl warps
68.     i = 0
69.     OPEN map FOR BINARY AS #1
70.     WHILE NOT EOF(1)
71.         i = i + 1
72.         ' get #1, , obstacle()  <--  this is managed at level of parser
73.         GET #1, , obstacle(i).btype
74.         GET #1, , obstacle(i).x1
75.         GET #1, , obstacle(i).y1
76.         GET #1, , obstacle(i).x2
77.         GET #1, , obstacle(i).y2
78.         GET #1, , obstacle(i).r
79.         GET #1, , obstacle(i).g
80.         GET #1, , obstacle(i).b
81.         GET #1, , obstacle(i).wl '  <-- this is not managed at level of parser
82.         ' so a dummy use of GET (like me in this example),
83.         'reading each field at a time, reads until out of file
84.  
85.         ' just some debug prints...
86.         _DEST _CONSOLE
87.         PRINT "i = ", i
88.         PRINT obstacle(i).btype, obstacle(i).x1, obstacle(i).y1, obstacle(i).x2, obstacle(i).y2, obstacle(i).r, obstacle(i).g, obstacle(i).b, obstacle(i).wl
89.         PRINT "EOF"; EOF(1); " press a key for the next run of cycle"
90.         _DEST 0
91.     WEND
92.     CLOSE #1
93. END SUB
94.  
95. SUB makeplayer
96.     CIRCLE (player.x, player.y), 10, _RGB32(100, 200, 255)
97.     PAINT (player.x, player.y), _RGB32(100, 200, 255), _RGB32(100, 200, 255)
98. END SUB
99.  
100. SUB playerMovement
101.     IF _KEYDOWN(18432) THEN player.y = player.y - player.speed
102.     IF _KEYDOWN(20480) THEN player.y = player.y + player.speed
103.     IF _KEYDOWN(19200) THEN player.x = player.x - player.speed
104.     IF _KEYDOWN(19712) THEN player.x = player.x + player.speed
105. END SUB
106.  
107. FUNCTION collision% (x1, y1, x2, y2)
108.     IF player.x >= x1 AND player.x <= x2 AND player.y >= y1 AND player.y <= y2 THEN
109.         collision% = 1
110.     END IF
111. END FUNCTION
112.  

to run these two examples you must use these two map files attached (so anybody cannot copy and past them into QB64Ide and live a different nightmare about code not working, think about EOF failure <-- also this is a possible not ordinary use of the QB64IDE).

in the two examples the code works bad, but that is the issue of coder, while the possibility to GET a variable string in RANDOM and BINARY mode is an issue of language.

Thanks to read and to talk

PS
I agree that best practice is to use RANDOM and BINARY mode with arrays loading in one shot the whole array, and with UDT loading in one shot the whole UDT, but the other way (using the single Field of an UDT) is there from so far time and it is possible.
I agree that best practice is to save/load data to/from file RANDOM and BINARY by code and not for working with a txt file created by text editor, but it is possible. So can be put a forbidden limit to the use of variable string in a BINARY/RANDOM mode?