I seem to be sinning against syntax for UBOUND

[OldMoses]

[UPDATE: Problems solved, two unrelated bugs that had nothing at all to do with UBOUND, thanks for all your help, guys.]

Doing a rewrite of an old grain harvest database program that I've using for the last twenty years or so. I want to take advantage of the new screen modes, mouse support and graphics that QB64 brings to the table. I'm having a myriad of issues with the graphics and color, which is completely expected and I'm prepared to slog along, paying my dues until I learn the new systems, but.....

I seem to be missing something that may be related to the UBOUND command and iteration of arrays. In one array example, the routine stops 1 short of UBOUND and in another it generates a subscript out of range error. I'm putting in all the code that I believe is relevant to my issue, along with some comments on what it's doing, but it's just snippets out of a 1800+ line, hot mess of a program, but it worked fine before...

If anyone can see what I'm doing wrong (other than being a complete coding neandertal), I'd appreciate any insights or advise. I've never had these problems from UBOUND before.

Code: QB64: [Select]

1. 'From Main Module
2.  
3. ' Data type for truck list array
4. TYPE Vehicle
5.     trucknm AS STRING * 10 'Truck name
6.     tare AS LONG 'Tare weight
7. END TYPE
8.  
9. DIM SHARED farmindex(x) AS STRING 'Farm index array
10. DIM SHARED truck(x) AS Vehicle 'Truck index array  
11.  
12. 'Initialize truck list from truck.txt
13. OPEN "truck.txt" FOR RANDOM AS #3 LEN = LEN(truck(0))
14. IF LOF(3) = 0 THEN 'TRUCK.TXT is empty/not present
15.     REDIM truck(1) AS Vehicle
16.     truck(1).trucknm = "default" 'create blank truck record
17.     truck(1).tare = 0
18.     PUT #3, 1, truck(1)
19. ELSE 'TRUCK.TXT is present
20.     y% = LOF(3) / LEN(truck(0)) 'retrieve truck records
21.     REDIM truck(y%) AS Vehicle
22.     FOR x = 1 TO y%
23.         GET #3, x, truck(x)
24.     NEXT x
25.     CLOSE #3
26. END IF
27.  
28. 'Initialize farm list into farmindex array
29. OPEN "farm.txt" FOR RANDOM AS #4 LEN = 20
30. IF LOF(4) = 0 THEN 'FARM.TXT is empty/not present
31.     REDIM farmindex(1) AS STRING
32.     farmindex(1) = "Main" 'create blank farm record
33.     PUT #4, 1, farmindex(1)
34. ELSE 'FARM.TXT is present
35.     y% = LOF(4) / 20 'retrieve farm records
36.     REDIM farmindex(y%) AS STRING
37.     FOR x = 1 TO y%
38.         GET #4, x, farmindex(x)
39.     NEXT x
40.     CLOSE #4
41. END IF
42.  
43. 'End Main Module code
44.  
45.  
46. 'This code executed in SUB ConfigRun which runs in a
47. '_NEWIMAGE (50, 20, 0)screen
48.     DO
49.         _PRINTSTRING (19, 1), "SELECT FARM"
50.         LOCATE 1, 31: PRINT UBOUND(farmindex)
51.         FOR x = 1 TO UBOUND(farmindex)
52.             LOCATE x + 2, 25 - (LEN(farmindex(x)) / 2) 'center justify
53.             IF mouse_x > 20 AND mouse_x < 30 THEN
54.                 IF mouse_y = x + 2 THEN COLOR 12, 0
55.             END IF
56.             PRINT farmindex(x)
57.             COLOR 7, 4
58.         NEXT x
59.  
60.         Mouse_Loop 0, 0
61.         cho% = Mouse_Point%(2, UBOUND(farmindex), 20, 30)
62.         _LIMIT 50
63.     LOOP UNTIL cho% <> 0
64. 'It refuses to print the last farmindex value. I added a dummy
65. 'value at the end of the file to make it do so as a work around.
66.  
67. 'Then this one from SUB TruckIn same screen parameters
68.        DO
69.         LOCATE 5, 1
70.         PRINT "Choose Truck:"
71.         FOR x = 1 TO UBOUND(truck)
72.             IF editmode AND var.truck = truck(x).trucknm THEN COLOR 14 'original truck in yellow
73.             IF mouse_y > 14 AND mouse_y < 24 THEN
74.                 IF mouse_x = x + 4 THEN COLOR 12, 0 'mouseover highlight
75.             END IF
76.             LOCATE x + 4, 15
77.             PRINT truck(x).trucknm
78.             COLOR 0, 3
79.         NEXT x
80.  
81.         Mouse_Loop 0, 0
82.         cho% = MousePoint%(4, UBOUND(truck), 14, 24)
83.  
84.         _LIMIT 50
85.     LOOP UNTIL x% <> 0
86. 'It throws a subscript out of range error at MousePoint% call
87.  
88.  
89. 'including the Mouse_Loop and MousePoint% in case of relevance
90. SUB Mouse_Loop (var AS INTEGER, var2 AS INTEGER)
91.  
92.     '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
93.     ' SUB: Mouse_Loop
94.     '
95.     ' Purpose:
96.     ' Primary mouse input loop. Controls mousewheel scrolling and conditions
97.     ' x,y position data.
98.     '
99.     ' Passed Variables:
100.     ' var sends whether data list is extensive enough for using offset printing values
101.     ' var2 sends maximum allowed offset value
102.     '
103.     '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
104.  
105.  
106.     'scan for changes in mouse position and save to global variables
107.     DO WHILE _MOUSEINPUT
108.         IF var = 1 THEN
109.             offset = offset + _MOUSEWHEEL 'mousewheel offset only works in the loop
110.             IF offset < 0 THEN offset = 0 'otherwise would SUB to Mouse_Loop
111.             IF offset > var2 THEN offset = var2
112.         END IF
113.         IF _MOUSEY - INT(_MOUSEY) >= .5 THEN
114.             mouse_y = INT(_MOUSEY + 1)
115.         ELSE
116.             mouse_y = INT(_MOUSEY)
117.         END IF
118.         mouse_x = INT(_MOUSEX)
119.     LOOP
120.  
121. END SUB 'Mouse_Loop
122.  
123. FUNCTION Mouse_Point% (trim_top AS INTEGER, last_item AS INTEGER, left_x AS INTEGER, right_x AS INTEGER)
124.  
125.     '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
126.     ' FUNCTION: Mouse_Point%
127.     '
128.     ' Purpose:
129.     ' Returns the row position and column range of a mouse pointer on left click.
130.     ' Used for drop down choice routines.
131.     '
132.     ' Passed Variables:
133.     ' trim_top sends value to be trimmed from row position to mark start of data list
134.     ' last item sends value of last data item displayed
135.     ' left_x sends leftmost allowed point of selection of data element
136.     ' right_x sends rightmost allowed point of selection of data element
137.     '
138.     '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
139.  
140.     mouse_in = _MOUSEBUTTON(1)
141.     IF mouse_in = -1 THEN
142.         ypos = mouse_y - trim_top
143.         IF ypos > 0 AND ypos < last_item + 1 THEN
144.             IF mouse_x > left_x AND mouse_x < right_x THEN
145.                 Mouse_Point% = ypos
146.             END IF
147.         END IF
148.     END IF
149.  
150. END FUNCTION 'Mouse_Point%
151.  

[TerryRitchie]

I'm looking at your code now.

line 72 errors out. var.truck is not referring to anything. A typo perhaps. I remarked the line out for now.

One thing I noticed is at the top of your code you DIM SHARED your arrays.  You should REDIM SHARED those arrays instead.

edit: Do you have some dummy text I can use to run with the program? farm.txt and truck.txt

[SMcNeill]

One point of immediate interest to me:

DIM SHARED farmindex(x) AS STRING 'Farm index array
OPEN "farm.txt" FOR RANDOM AS #4 LEN = 20 

You're setting a limit of 20 characters with the OPEN statement, but you're allowing the farmindex() to be a variable length string.  I think I'd make it AS STRING * 20 to be certain to avoid any issues from length.

Here's a perfect example for you, which I wrote using your own variable types:

Code: QB64: [Select]

1. ' Data type for truck list array
2. TYPE Vehicle
3.     trucknm AS STRING * 10 'Truck name
4.     tare AS LONG 'Tare weight
5. END TYPE
6.  
7. REDIM SHARED farmindex(10) AS STRING '* 20 'Farm index array
8. REDIM SHARED truck(10) AS Vehicle 'Truck index array
9.  
10. 'Initialize truck list from truck.txt
11. OPEN "truck.txt" FOR OUTPUT AS #1: CLOSE #1
12. OPEN "truck.txt" FOR RANDOM AS #1 LEN = LEN(truck(0))
13.  
14.  
15. FOR i = 1 TO 10
16.     truck(i).trucknm = "Truck " + STR$(i)
17.     truck(i).tare = i
18.     PUT #1, , truck(i)
19.  
20.     PRINT truck(i).trucknm, truck(i).tare, LOF(1)
21.     GET #1, i, truck(i)
22.     PRINT truck(i).trucknm, truck(i).tare, LOF(1)
23. NEXT
24. CLOSE #1
25.  
26. SLEEP
27. CLS
28. OPEN "farm.txt" FOR OUTPUT AS #1: CLOSE #1
29. OPEN "farm.txt" FOR RANDOM AS #1 LEN = 20
30. DIM temp AS STRING '* 20
31. FOR i = 1 TO 10
32.     temp = STR$(10 ^ (i - 1))
33.     PUT #1, i, temp
34.     PRINT i, temp, LOF(1)
35.     GET #1, i, farmindex(i)
36.     PRINT i, farmindex(i), LOF(1)
37. NEXT
38. CLOSE #1

Run the above as it is, and see what the length of "farm.txt" is after each PUT statement.  Then, unremark the * 20 which I used to make the variables limited to 20 characters.


If you want to keep the LEN = 20, set the string length to 20 as well, or else you're not going to be able to just divide LOF by 20 to get the correct number of records.

[OldMoses]

Yes indeed, I have tried setting the string length to 20, twice. Each time I got a C++ compilation error, so I'm thinking that avenue isn't available to me... unless there's just a glitch where I can put the statement elsewhere and get away with it, I might give that a try. I will give it your approach first and see if it likes that better, Thanks.

One point of immediate interest to me:

DIM SHARED farmindex(x) AS STRING 'Farm index array
OPEN "farm.txt" FOR RANDOM AS #4 LEN = 20 

You're setting a limit of 20 characters with the OPEN statement, but you're allowing the farmindex() to be a variable length string.  I think I'd make it AS STRING * 20 to be certain to avoid any issues from length.

[OldMoses]

Sorry about that. var.truck references, in the particular SUB, another user defined variable, the main data variable in fact, which receives the results of the routine, I should have either remarked it out or posted the whole kit and kaboodle, but my approach is to shoe horn the new display stuff into the old working version's algorithms and it's a big fat mess right now. I'm tackling it one step at a time and seeing how far it goes before it crashes. I don't want to really fatigue anyone with my problems, but the UBOUND thing has got me stumped... I was kinda hoping that it was a QB64 quirk and someone would say "Oh, you just have to do 'X'"....;)

I'm looking at your code now.

line 72 errors out. var.truck is not referring to anything. A typo perhaps. I remarked the line out for now.

One thing I noticed is at the top of your code you DIM SHARED your arrays.  You should REDIM SHARED those arrays instead.

edit: Do you have some dummy text I can use to run with the program? farm.txt and truck.txt

Anyway, for anyone who is interested in this particular train wreck, I'll attach the whole awful thing. It's been a long term work in progress by a guy with meager skills.

The old working version (written under 4.5) "GRAIN321.bas" along with "farm.txt" and "truck.txt". As our truck loads come in from the field, they are weighed and a sample is taken for moisture testing. The program accepts the gross weight and moisture test and then determines net weight and shrinkage of the bushels from the drying process, and stores the results by truckload in a file for each farm, crop and harvest year. I'm seeking to consolidate all farms and crops in a single year file to clean up the file clutter that this scheme creates. After 20 some years of harvests I have significant clutter.

"Grain4.bas" is to be, one day hopefully, the new and improved version, incorporating mouse support, less cryptic looking graphic display and the ability to print hardcopy without the need to create html files as the workaround of the fact that Windows doesn't want to print my output.

[bplus]

First error I hit is missing "dumper.bmp".

Those 2 lines commented out and the the editor says OK.

[OldMoses]

First error I hit is missing "dumper.bmp".

Oops, forgot that one too. It's just an image for _ICON. I've been playing around with too many things at once.

[OldMoses]

I've had one of those Doh! moments.

Instead of:
REDIM SHARED farmindex(x) AS STRING * 20 'Farm index array 

I was doing:
REDIM SHARED farmindex(x) * 20 AS STRING 'Farm index array 

except that upon changing it, it still gives me a C++ compilation error. The log reads:

In file included from qbx.cpp:2120:0:
..\\temp\\main.txt: In function 'void QBMAIN(void*)':
..\\temp\\main.txt:286:5: error: '__ARRAY_STRING_FARMINDEX' was not declared in this scope
compilation terminated due to -Wfatal-errors.

[bplus]

Grain4.bas is the one you are trying to fix up, right?

All farmindex() are AS STRING in code you have attached. My copy compiles.

[OldMoses]

Grain4.bas is the one you are trying to fix up, right?

All farmindex() are AS STRING in code you have attached. My copy compiles.

Correct. "GRAIN321.bas" works as needed, and I'll be using that one for this season. It's cryptic interface keeps my folks from using it, so it's been my baby exclusively. Grain4 will be for next year if I can get it humming. I'm hoping that it will be user friendly enough that everyone will use it, instead of me coming back later and adding the loads when I'm not too busy driving.

Maybe I should try downloading QB64 again, just in case something is corrupted.

Downloaded again....Well that took a lot longer to come to the same end.

[bplus]

I am rusty with Random access files. When you dim or redim an array to hold a random access file with nRecords, do you use
redim myArray(0 to nRecords -1)

or

redim myArray(1 to nRecords) so the array index matches the record numbers

?

this is not doing either, assuming y% is number of records:

Code: QB64: [Select]

1. ELSE 'TRUCK.TXT is present
2.     y% = LOF(3) / LEN(truck(0)) 'retrieve truck records
3.     REDIM truck(y%) AS Vehicle
4.     FOR x = 1 TO y%
5.         GET #3, x, truck(x)
6.     NEXT x
7.     CLOSE #3
8. END IF

append: eh! that won't cause an error

[bplus]

Hi OldMoses,

So you are putting up a list from an array to select with a mouse click and the mouse click alignment is not matching the array limits? ie you mouse click is one item too many or too short of array index item.

[OldMoses]

The mouse aligns ok and clicks will select the proper array element. The issue I have is that when I iterate the array with FOR...NEXT from 1 to UBOUND(farmindex) the iteration stops 1 short of the final array element. There are three farm names in "farm.txt" but only two are output for mouse selection. That's the first case.

The second case, iterating a list of truck name identifiers, the program hangs with a subscript out of range error before the mouse action can even occur.

I generally match my arrays to the random access files, i.e. 1 to nRecords and have never had a problem doing it. In fact, I was using OPTION BASE 1 (which I had never done in the past) when the bug appeared, and I thought it might have something to do with it. However, commenting that command out didn't change anything. Nothing I've tried so far has.

Progress update:

The code in the first case is good. I grabbed an older version of "farm.txt" and it worked properly. It was a corrupted txt file.

Now to chase the next gremlin...

bplus, thank you. I got to thinking about the mouse alignment issue you mention and looked a little harder. I got my x and y positions switched and fixing that cleared up the problem in the second case. I don't know if I would have caught that one otherwise, I was so sure of myself and my x and y.

Two unrelated bugs that I thought were related.

[bplus]

Hi OldMoses,

Glad you found the cause of the problems!
Man that code had me scratching my head! Something about that Mouse_Point% sub was surely causing a problem.

I reworked the code example in original post with a different routine for getting menu item numbers, where the menu is some item in an array you want user to select with mouse or by entered number.

Code: QB64: [Select]

1. 'Bplus overhauled OldMoses code 2018-08-31
2. SCREEN _NEWIMAGE(800, 600, 32)
3. _SCREENMOVE 200, 60
4.  
5. '' Data type for truck list array
6. TYPE Vehicle
7.     trucknm AS STRING * 10 'Truck name
8.     tare AS LONG 'Tare weight
9. END TYPE
10.  
11. DIM SHARED farmindex(x) AS STRING 'Farm index array
12. DIM SHARED truck(x) AS Vehicle 'Truck index array
13.  
14. ''Initialize truck list from truck.txt
15. OPEN "truck.txt" FOR RANDOM AS #3 LEN = LEN(truck(0))
16. IF LOF(3) = 0 THEN 'TRUCK.TXT is empty/not present
17.     REDIM truck(1) AS Vehicle
18.     truck(1).trucknm = "default" 'create blank truck record
19.     truck(1).tare = 0
20.     PUT #3, 1, truck(1)
21. ELSE 'TRUCK.TXT is present
22.     y% = LOF(3) / LEN(truck(0)) 'retrieve truck records
23.     REDIM truck(y%) AS Vehicle
24.     FOR x = 1 TO y%
25.         GET #3, x, truck(x)
26.     NEXT x
27.     CLOSE #3
28. END IF
29.  
30. ''Initialize farm list into farmindex array
31. OPEN "farm.txt" FOR RANDOM AS #4 LEN = 20
32. IF LOF(4) = 0 THEN 'FARM.TXT is empty/not present
33.     REDIM farmindex(1) AS STRING
34.     farmindex(1) = "Main" 'create blank farm record
35.     PUT #4, 1, farmindex(1)
36. ELSE 'FARM.TXT is present
37.     y% = LOF(4) / 20 'retrieve farm records
38.     REDIM farmindex(y%) AS STRING
39.     FOR x = 1 TO y%
40.         GET #4, x, farmindex(x)
41.     NEXT x
42.     CLOSE #4
43. END IF
44.  
45. 'End Main Module code
46.  
47.  
48. 'This code executed in SUB ConfigRun which runs in a
49. LOCATE 2, 10: PRINT "SELECT FARM"
50. ch = getMenuItemNumber(3, 7, farmindex())
51. PRINT: PRINT "          The farm you selected was "; farmindex(ch)
52.  
53. DIM menutruck(UBOUND(truck)) AS STRING
54. FOR i = 1 TO UBOUND(truck)
55.     menutruck(i) = truck(i).trucknm
56. NEXT
57.  
58. LOCATE 15, 10: PRINT "CHOOSE TRUCK"
59. ch = getMenuItemNumber(16, 7, menutruck())
60. PRINT: PRINT "         You chose truck: "; truck(ch).trucknm
61.  
62. FUNCTION getMenuItemNumber (locateRow, locateColumn, menu() AS STRING)
63.     FOR m = 1 TO UBOUND(menu)
64.         LOCATE locateRow + m - 1, locateColumn: PRINT LTRIM$(STR$(m)) + ") " + menu(m)
65.     NEXT
66.     LOCATE locateRow + m + 1, locateColumn: PRINT "To select: Enter number or click item."
67.     DO
68.         k$ = INKEY$
69.         IF LEN(k$) THEN
70.             IF INSTR("0123456789", k$) > 0 THEN b$ = b$ + k$
71.             IF ASC(k$) = 13 THEN
72.                 IF VAL(b$) >= 1 AND VAL(b$) <= UBOUND(menu) THEN choice = VAL(b$): EXIT DO ELSE b$ = ""
73.             END IF
74.             IF ASC(k$) = 8 THEN
75.                 IF LEN(b$) THEN b$ = LEFT$(b$, LEN(b$) - 1)
76.             END IF
77.         END IF
78.         WHILE _MOUSEINPUT: WEND
79.         IF _MOUSEBUTTON(1) THEN
80.             mx = INT((_MOUSEX - locateColumn * 8) / 8) + 2: my = INT((_MOUSEY - locateRow * 16) / 16) + 2
81.             IF mx >= 1 AND my >= 1 AND my <= UBOUND(menu) THEN
82.                 choice = my
83.             END IF
84.         END IF
85.         _LIMIT 200
86.     LOOP UNTIL choice
87.     getMenuItemNumber = choice
88. END FUNCTION
89.  
90.  

If you like it, we can figure a way to highlight the mouse over item and color it better.
  [ You are not allowed to view this attachment ]  

[OldMoses]

Hi OldMoses,

Glad you found the cause of the problems!
Man that code had me scratching my head! Something about that Mouse_Point% sub was surely causing a problem.

Yeah, I think because I mixed up x and y, it was always looking for the x value instead. With the drop down list always tabbed in x farther than the upper range of the array, it couldn't begin to function.

I reworked the code example in original post with a different routine for getting menu item numbers, where the menu is some item in an array you want user to select with mouse or by entered number.

That's great, thanks for your help, it gives me back the option of hotkey choices on the numberpad. I always preferred doing it that way, it being faster than fiddling with a mouse, but I wanted mouse support for my folks to use. That was just an impossible dream before QB64.

If you like it, we can figure a way to highlight the mouse over item and color it better.

I have been putting the list printing iteration within the DO...LOOP and then testing, within that iteration, if _MOUSEX and _MOUSEY were within certain limits. If they were then I would set colors accordingly. Maybe that would work with your mods? If there's a better way, I would certainly be interested in incorporating it. I always had the suspicion that my method was too processor intensive, because in another program I've been working on, one of my drop down list routines is very long and puts out a lot of screen flicker, which I could reduce (but not eliminate) with _LIMIT.