Issue with _PUTIMAGE and XOR plus issue loading PNG files [FIXED]

[Cobalt]

okay part one. Im trying to write a little program to rip the Tile sprites from an image for WarCraft 1. and I'm using PUT with the XOR option to eliminate duplicate tiles(cause when you XOR a sprite over the same sprite all the pixels are set to 0 and the image erases) however it seems that _PUTIMAGE can not see an image that has been PUT with the XOR option(or PRESET too)
here is the code, it has other issues but they are mine and caused by not being finished yet and not QB64s.

Code: QB64: [Select]

1. map& = _LOADIMAGE("warmap01error.png", 32)
2. tile& = _NEWIMAGE(640, 480, 32)
3. Zoom& = _NEWIMAGE(128, 128, 32)
4.  
5. SCREEN _NEWIMAGE(1024, 480, 32)
6. DIM SHARED mapval(64, 64) AS SINGLE, temp(1032) AS LONG
7. 'KILL "debug.txt"
8. 'OPEN "debug.txt" FOR BINARY AS #1
9.  
10. FOR Y%% = 0 TO 7
11.  LINE (0, 400)-(1023, 415), _RGB32(0, 0, 0), BF
12.  _PUTIMAGE (0, 400), map&, _DISPLAY, (0, 0 + 16 * Y%%)-(1023, 15 + 16 * Y%%)
13.  
14.  FOR X%% = 0 TO 63
15.   'debug information
16.   LOCATE 10, 1: PRINT peices%; X%%; Y%%
17.  
18.   'clear and display progress area
19.   LINE (0, 416)-(1023, 431), _RGB(0, 0, 0), BF
20.   LINE (0 + 16 * X%%, 416)-(15 + 16 * X%%, 431), _RGB32(200, 200, 15), BF
21.  
22.   _SOURCE map& 'get next test peice
23.   GET (0 + (X%% * 16), 0 + (Y%% * 16))-(15 + (X%% * 16), 15 + (Y%% * 16)), temp()
24.   'clear test area
25.   LINE (300, 180)-(336, 216), _RGB32(0, 0, 0), BF
26.   'put test peice for reference
27.   PUT (320, 180), temp()
28.  
29.  
30.   IF peices% = 0 THEN
31.    'the first peice put straight to packlayer
32.    _DEST tile&
33.    PUT (0 + tx%% * 16, 0 + ty%% * 16), temp()
34.    tx%% = tx%% + 1: peices% = 1
35.    IF tx%% = 40 THEN ty%% = ty%% + 1: tx%% = 0
36.    _DEST _DISPLAY
37.   ELSE
38.    'test the peice placing 2 copies of each found tile and XOR the test peice
39.    ' over to see if it erases
40.    px%% = 0: py%% = 0
41.  
42.    FOR i% = 0 TO peices%
43.     LOCATE 11, 1: PRINT i%, px%%, py%%
44.     'clear test area
45.     LINE (300, 200)-(336, 216), _RGB32(0, 0, 0), BF
46.  
47.     'current check image
48.     LINE (299, 199)-(316, 216), _RGB32(255, 255, 0), B
49.     _PUTIMAGE (300, 200), tile&, _DISPLAY, (0 + px%% * 16, 0 + py%% * 16)-(15 + px%% * 16, 15 + py%% * 16)
50.     'place the test copy
51.     LINE (319, 199)-(336, 216), _RGB32(RND * 255, 255, RND * 255), B
52.     _PUTIMAGE (320, 200), tile&, _DISPLAY, (0 + px%% * 16, 0 + py%% * 16)-(15 + px%% * 16, 15 + py%% * 16)
53.  
54.     'put the tile to check over the test copy with XOR
55.     PUT (320, 200), temp(), XOR
56.     'zoom in on that area
57.     _DEST Zoom&
58.     LINE (0, 0)-(127, 127), _RGB32(0, 0, 0), BF 'clear zoom layer
59.     _DEST _DISPLAY
60.     _PUTIMAGE (0, 0), _DISPLAY, Zoom&, (299, 200)-(336, 215) 'put test area in zoom layer
61.     _PUTIMAGE (0, 0)-(128, 64), Zoom&, _DISPLAY, (0, 0)-(37, 15) 'put enlarged image back on display
62.  
63.     _SOURCE _DISPLAY
64.     'get the test copy to see if it was erased
65.     GET (320, 200)-(335, 215), temp(257)
66.     IF TileCount2 <> 0 THEN 'peice did not match
67.      LOCATE 12, 1: PRINT TileCount2
68.      _DELAY 2.5
69.      '     SLEEP
70.  
71.      _DEST tile&
72.      PUT (0 + tx%% * 16, 0 + ty%% * 16), temp()
73.      tx%% = tx%% + 1: peices% = peices% + 1
74.      IF tx%% = 40 THEN ty%% = ty%% + 1: tx%% = 0
75.      _DEST _DISPLAY
76.      i% = peices% + 1
77.     END IF
78.    NEXT i%
79.   END IF
80.   _DELAY .005
81.   IF INKEY$ = CHR$(27) THEN Y%% = 65: X%% = 65
82.   px%% = px%% + 1
83.   IF px%% = 40 THEN py%% = py%% + 1: px%% = 0
84.  
85.  NEXT X%%
86. NEXT Y%%
87. 'CLS
88. '_PUTIMAGE , tile&, _DISPLAY
89.  
90. FUNCTION TileCount
91.  FOR i% = 1 TO 255
92.   ' V! = V! + temp(i%)
93.   r~%% = _RED(temp(i%))
94.   g~%% = _GREEN(temp(i%))
95.   b~%% = _BLUE(temp(i%))
96.   v& = v& + (r~%% + b~%% + g~%%)
97.  NEXT i%
98.  TileCount = v&
99. END FUNCTION
100.  
101. FUNCTION TileCount2
102.  FOR i% = 258 TO 513
103.   ' V! = V! + temp(i%)
104.   r~%% = _RED(temp(i%))
105.   g~%% = _GREEN(temp(i%))
106.   b~%% = _BLUE(temp(i%))
107.   v& = v& + (r~%% + b~%% + g~%%)
108.  NEXT i%
109.  TileCount2 = v&
110. END FUNCTION
111.  

the image is linked below(warmap01error.png) along with a descriptive image of the output screen.

now part Two, I have been working on this code in QB64 version 20171106/82 so I downloaded the 'stable' release off the .org page  20180202/85 and ... it wont work! it will not load the PNG image but it does load the BMP version I have.(I made the PNG so that it would be a smaller upload here, I mainly work with BMP and PCX{yeah I know! I'm OLD okay}) now I have this code and images in there own folder to keep the QB64 folder clean so this stuff is not within the QB64 folder ,is this an issue now?

just out of curiosity why can is there no posting to the BUGs section?

[Petr]

Hello. Actually, I did not understand exactly what the program was supposed to do. Smaller could not do that anymore? :-D Maybe, but I say maybe, it's using _DISPLAY. I have not seen that yet. When you import SCREEN NEWIMAGE, the link to it is _DEST 0. When you enter it as M& = _NEWIMAGE: SCREEN M&, the link then is  _DEST M& So the combination of _DEST _DISPLAY, that's new to me. Maybe it may be, but I have not seen it yet. I would rather put DEST 0, because at the beginning is NEWIMAGE without a pointer. GET and PUT work properly on automatic control screens, so if you use _DISPLAY, first cancel it using _AUTODISPLAY. Or, just use _PUTIMAGE instead of GET / PUT, it's much faster. And you use _DISPLAY in _PUTIMAGE in target place? Really, this i am not seen yet. (Dont know if it is correct or not)

But maybe I'm not right.

[Petr]

So i test it, _DEST and _DISPLAY return the same values...

[Petr]

Sorry for previous post...

Code: QB64: [Select]

1. map& = _LOADIMAGE("warmap01error.png", 32)
2. tile& = _NEWIMAGE(640, 480, 32)
3. Zoom& = _NEWIMAGE(128, 128, 32)
4.  
5. SCREEN _NEWIMAGE(1024, 480, 32)
6. DIM SHARED mapval(64, 64) AS SINGLE, temp(1032) AS LONG
7. 'KILL "debug.txt"
8. 'OPEN "debug.txt" FOR BINARY AS #1
9.  
10. FOR Y%% = 0 TO 7
11.     LINE (0, 400)-(1023, 415), _RGB32(0, 0, 0), BF
12.     _PUTIMAGE (0, 400), map&, _DISPLAY, (0, 0 + 16 * Y%%)-(1023, 15 + 16 * Y%%)
13.  
14.     FOR X%% = 0 TO 63
15.         'debug information
16.         LOCATE 10, 1: PRINT peices%; X%%; Y%%
17.  
18.         'clear and display progress area
19.         LINE (0, 416)-(1023, 431), _RGB(0, 0, 0), BF
20.         LINE (0 + 16 * X%%, 416)-(15 + 16 * X%%, 431), _RGB32(200, 200, 15), BF
21.  
22.         _SOURCE map& 'get next test peice
23.         GET (0 + (X%% * 16), 0 + (Y%% * 16))-(15 + (X%% * 16), 15 + (Y%% * 16)), temp&()
24.         'clear test area
25.         LINE (300, 180)-(336, 216), _RGB32(0, 0, 0), BF
26.         'put test peice for reference
27.         PUT (320, 180), temp&()
28.  
29.  
30.         IF peices% = 0 THEN
31.             'the first peice put straight to packlayer
32.             _DEST tile&
33.             PUT (0 + tx%% * 16, 0 + ty%% * 16), temp&()
34.             tx%% = tx%% + 1: peices% = 1
35.             IF tx%% = 40 THEN ty%% = ty%% + 1: tx%% = 0
36.             _DEST 0
37.         ELSE
38.             'test the peice placing 2 copies of each found tile and XOR the test peice
39.             ' over to see if it erases
40.             px%% = 0: py%% = 0
41.  
42.             FOR i% = 0 TO peices%
43.                 LOCATE 11, 1: PRINT i%, px%%, py%%
44.                 'clear test area
45.                 LINE (300, 200)-(336, 216), _RGB32(0, 0, 0), BF
46.  
47.                 'current check image
48.                 LINE (299, 199)-(316, 216), _RGB32(255, 255, 0), B
49.                 _PUTIMAGE (300, 200), tile&, _DISPLAY, (0 + px%% * 16, 0 + py%% * 16)-(15 + px%% * 16, 15 + py%% * 16)
50.                 'place the test copy
51.                 LINE (319, 199)-(336, 216), _RGB32(RND * 255, 255, RND * 255), B
52.                 _PUTIMAGE (320, 200), tile&, _DISPLAY, (0 + px%% * 16, 0 + py%% * 16)-(15 + px%% * 16, 15 + py%% * 16)
53.  
54.                 'put the tile to check over the test copy with XOR
55.                 PUT (320, 200), temp(), XOR
56.                 'zoom in on that area
57.  
58.                 v& = _NEWIMAGE(38, 16, 32)
59.                 _DEST v&
60.                 PUT (0, 0), temp&()
61.  
62.                 _PUTIMAGE (0, 0)-(127, 127), v&, Zoom&, (0, 0)-(37, 15)
63.                 _DEST 0
64.                 _FREEIMAGE v&
65.                 _PUTIMAGE (0, 0), Zoom&, 0, (0, 0)-(127, 127) 'put test area in zoom layer
66.                 '               _PUTIMAGE (0, 0)-(128, 64), Zoom&, _DISPLAY, (0, 0)-(37, 15) 'put enlarged image back on display
67.  
68.                 _SOURCE _DISPLAY
69.                 'get the test copy to see if it was erased
70.                 GET (320, 200)-(335, 215), temp(257)
71.                 IF TileCount2 <> 0 THEN 'peice did not match
72.                     LOCATE 12, 1: PRINT TileCount2
73.                     _DELAY 2.5
74.                     '     SLEEP
75.  
76.                     _DEST tile&
77.                     PUT (0 + tx%% * 16, 0 + ty%% * 16), temp()
78.                     tx%% = tx%% + 1: peices% = peices% + 1
79.                     IF tx%% = 40 THEN ty%% = ty%% + 1: tx%% = 0
80.                     _DEST _DISPLAY
81.                     i% = peices% + 1
82.                 END IF
83.             NEXT i%
84.         END IF
85.         _DELAY .005
86.         IF INKEY$ = CHR$(27) THEN Y%% = 65: X%% = 65
87.         px%% = px%% + 1
88.         IF px%% = 40 THEN py%% = py%% + 1: px%% = 0
89.  
90.     NEXT X%%
91. NEXT Y%%
92. 'CLS
93. '_PUTIMAGE , tile&, _DISPLAY
94.  
95. FUNCTION TileCount
96.     FOR i% = 1 TO 255
97.         ' V! = V! + temp(i%)
98.         r~%% = _RED(temp(i%))
99.         g~%% = _GREEN(temp(i%))
100.         b~%% = _BLUE(temp(i%))
101.         v& = v& + (r~%% + b~%% + g~%%)
102.     NEXT i%
103.     TileCount = v&
104. END FUNCTION
105.  
106. FUNCTION TileCount2
107.     FOR i% = 258 TO 513
108.         ' V! = V! + temp(i%)
109.         r~%% = _RED(temp(i%))
110.         g~%% = _GREEN(temp(i%))
111.         b~%% = _BLUE(temp(i%))
112.         v& = v& + (r~%% + b~%% + g~%%)
113.     NEXT i%
114.     TileCount2 = v&
115. END FUNCTION
116.  
117.  

[FellippeHeitor]

Two initial questions:

1- You guys sure that mixing GET/PUT and 32bit mode and _PUTIMAGE is the best approach?

2- if you really are sure, then are  you sure  that temp&() array is big enough for 64x64 32bit image data?

[Petr]

Ou yes! I did not notice it. Of course, 4 bytes per pixel in 32 bit mode .... And what you say for this use  _DISPLAY?

[SMcNeill]

Question:  Is it an issue with color values and XOR?

 LINE (0, 400)-(1023, 415), _RGB32(0, 0, 0), BF

The color here is 255 Alpha(&HFF000000), so is NOT &H00000000, and that could be the source of your issue.

I'd suggest trying:

_DONTBLEND
 LINE (0, 400)-(1023, 415), _RGBA32(0, 0, 0,0), BF
_BLEND

Clear that section of screen with a 0 RGBA (clear) box instead of a 0 RBG (black) color box.

[SMcNeill]

With _DONTBLEND and transparent color instead of black color, see if this isn't what you'd expect:

Code: QB64: [Select]

1. map& = _LOADIMAGE("warmap01error.png", 32)
2. tile& = _NEWIMAGE(640, 480, 32)
3. Zoom& = _NEWIMAGE(128, 128, 32)
4.  
5. SCREEN _NEWIMAGE(1024, 480, 32)
6. DIM SHARED mapval(64, 64) AS SINGLE, temp(1032) AS LONG
7. 'KILL "debug.txt"
8. 'OPEN "debug.txt" FOR BINARY AS #1
9. _DONTBLEND
10. FOR Y%% = 0 TO 7
11.     LINE (0, 400)-(1023, 415), 0, BF
12.     _PUTIMAGE (0, 400), map&, _DISPLAY, (0, 0 + 16 * Y%%)-(1023, 15 + 16 * Y%%)
13.  
14.     FOR X%% = 0 TO 63
15.         'debug information
16.         LOCATE 10, 1: PRINT peices%; X%%; Y%%
17.  
18.         'clear and display progress area
19.  
20.         LINE (0, 416)-(1023, 431), 0, BF
21.         LINE (0 + 16 * X%%, 416)-(15 + 16 * X%%, 431), _RGB32(200, 200, 15), BF
22.  
23.         _SOURCE map& 'get next test peice
24.         GET (0 + (X%% * 16), 0 + (Y%% * 16))-(15 + (X%% * 16), 15 + (Y%% * 16)), temp()
25.         'clear test area
26.         LINE (300, 180)-(336, 216), 0, BF
27.         'put test peice for reference
28.         PUT (320, 180), temp()
29.  
30.  
31.         IF peices% = 0 THEN
32.             'the first peice put straight to packlayer
33.             _DEST tile&
34.             PUT (0 + tx%% * 16, 0 + ty%% * 16), temp()
35.             tx%% = tx%% + 1: peices% = 1
36.             IF tx%% = 40 THEN ty%% = ty%% + 1: tx%% = 0
37.             _DEST _DISPLAY
38.         ELSE
39.             'test the peice placing 2 copies of each found tile and XOR the test peice
40.             ' over to see if it erases
41.             px%% = 0: py%% = 0
42.  
43.             FOR i% = 0 TO peices%
44.                 LOCATE 11, 1: PRINT i%, px%%, py%%
45.                 'clear test area
46.                 LINE (300, 200)-(336, 216), 0, BF
47.  
48.                 'current check image
49.                 LINE (299, 199)-(316, 216), _RGB32(255, 255, 0), B
50.                 _PUTIMAGE (300, 200), tile&, _DISPLAY, (0 + px%% * 16, 0 + py%% * 16)-(15 + px%% * 16, 15 + py%% * 16)
51.                 'place the test copy
52.                 LINE (319, 199)-(336, 216), _RGB32(RND * 255, 255, RND * 255), B
53.                 _PUTIMAGE (320, 200), tile&, _DISPLAY, (0 + px%% * 16, 0 + py%% * 16)-(15 + px%% * 16, 15 + py%% * 16)
54.  
55.                 'put the tile to check over the test copy with XOR
56.                 PUT (320, 200), temp(), XOR
57.                 'zoom in on that area
58.                 _DEST Zoom&
59.                 LINE (0, 0)-(127, 127), 0, BF 'clear zoom layer
60.                 _DEST _DISPLAY
61.                 _PUTIMAGE (0, 0), _DISPLAY, Zoom&, (299, 200)-(336, 215) 'put test area in zoom layer
62.                 _PUTIMAGE (0, 0)-(128, 64), Zoom&, _DISPLAY, (0, 0)-(37, 15) 'put enlarged image back on display
63.  
64.                 _SOURCE _DISPLAY
65.                 'get the test copy to see if it was erased
66.                 GET (320, 200)-(335, 215), temp(257)
67.                 IF TileCount2 <> 0 THEN 'peice did not match
68.                     LOCATE 12, 1: PRINT TileCount2
69.                     _DELAY 2.5
70.                     '     SLEEP
71.  
72.                     _DEST tile&
73.                     PUT (0 + tx%% * 16, 0 + ty%% * 16), temp()
74.                     tx%% = tx%% + 1: peices% = peices% + 1
75.                     IF tx%% = 40 THEN ty%% = ty%% + 1: tx%% = 0
76.                     _DEST _DISPLAY
77.                     i% = peices% + 1
78.                 END IF
79.             NEXT i%
80.         END IF
81.         _DELAY .005
82.         IF INKEY$ = CHR$(27) THEN Y%% = 65: X%% = 65
83.         px%% = px%% + 1
84.         IF px%% = 40 THEN py%% = py%% + 1: px%% = 0
85.  
86.     NEXT X%%
87. NEXT Y%%
88. 'CLS
89. '_PUTIMAGE , tile&, _DISPLAY
90.  
91. FUNCTION TileCount
92.     FOR i% = 1 TO 255
93.         ' V! = V! + temp(i%)
94.         r~%% = _RED(temp(i%))
95.         g~%% = _GREEN(temp(i%))
96.         b~%% = _BLUE(temp(i%))
97.         v& = v& + (r~%% + b~%% + g~%%)
98.     NEXT i%
99.     TileCount = v&
100. END FUNCTION
101.  
102. FUNCTION TileCount2
103.     FOR i% = 258 TO 513
104.         ' V! = V! + temp(i%)
105.         r~%% = _RED(temp(i%))
106.         g~%% = _GREEN(temp(i%))
107.         b~%% = _BLUE(temp(i%))
108.         v& = v& + (r~%% + b~%% + g~%%)
109.     NEXT i%
110.     TileCount2 = v&
111. END FUNCTION
112.  

[Cobalt]

Two initial questions:

1- You guys sure that mixing GET/PUT and 32bit mode and _PUTIMAGE is the best approach?

2- if you really are sure, then are  you sure  that temp&() array is big enough for 64x64 32bit image data?

1- the array is set with LONG(technically is should be _UNSIGNED but it works as is) so it should be storing the 32bit color values correctly with GET\PUT and when placed(PUT) they appear normally.

2- TEMP() only needs to store a 16x16 pixel area so its more than big enough at 1024 (16x16=256)

3- The issue is why doesn't _PUTIMAGE see the area that is in the right hand box when PUT is used with XOR? there are some green pixels left but _PUTIMAGE doesn't show them in the zoomed area in the top left corner of the screen, it just shows an empty space between the two light colored lines. the lines randomly change color as it progresses so I could tell that it was actually updating and not just displaying the same image over and over.

SO why does _PUTIMAGE not see the pixels that are lit green in that space after PUT is used with the XOR option. if PUT is used normally or with the PSET option _PUTIMAGE shows the correct pixels.

4- you forgot about part 2, why wouldn't the current 'stable' build load the PNG?

none of this affects my programs final function this is just cosmetic, but it could show a potential problem with _putimage if someone is porting some really old qb45 game that uses XOR(and PRESET) option to QB64. (as putimage doesn't support the PUT options as per the wiki, and nor can you _putimage from and to the same layer)

[Cobalt]

With _DONTBLEND and transparent color instead of black color, see if this isn't what you'd expect:

that is what I expected to see, but why wasn't working without _DONTBLEND? why couldn't _PUTIMAGE see those pixels without it?

Question:  Is it an issue with color values and XOR?

 LINE (0, 400)-(1023, 415), _RGB32(0, 0, 0), BF

actually I missed that, that should be causing me a problem else where(that clears the progress marker area) oddly it was working normaly so I missed that I used 0 instead of _RGB32(0,0,0)!

[FellippeHeitor]

4- you forgot about part 2, why wouldn't the current 'stable' build load the PNG?

There has been an image library replacement recently. Please check if the development build will load your png before we can discuss it further.

Let's just remember that stable means that no significative bugs were found up until the moment we tagged it 'stable', but that, of course, doesn't equal "bug free", as no one here would be that pretentious.

[Cobalt]

4- you forgot about part 2, why wouldn't the current 'stable' build load the PNG?

There has been an image library replacement recently. Please check if the development build will load your png before we can discuss it further.

Gotcha, trying that now..

sure enough the latest DB works fine.

[SMcNeill]

With _DONTBLEND and transparent color instead of black color, see if this isn't what you'd expect:

that is what I expected to see, but why wasn't working without _DONTBLEND? why couldn't _PUTIMAGE see those pixels without it?

It's not a PUTIMAGE issue, but the XOR issue.   You weren't comparing against COLOR 0, you were comparing against COLOR &HFF000000.

LINE draws on the screen. 
LINE _RGB(0,0,0) draws a BLACK color box on the screen.   
LINE _RGBA(0,0,0,0) blends a 0 alpha BLACK box on the screen.

Only by using _DONTBLEND will you actually draw that  LINE _RGBA(0,0,0,0) box onto the screen, rather than blending it into the background.

You basically need 0 as your color value for XOR to work as you were intending, and instead you were clearing the screen with a shade of black.

[Cobalt]

It's not a PUTIMAGE issue, but the XOR issue.   You weren't comparing against COLOR 0, you were comparing against COLOR &HFF000000.

LINE draws on the screen. 
LINE _RGB(0,0,0) draws a BLACK color box on the screen.   
LINE _RGBA(0,0,0,0) blends a 0 alpha BLACK box on the screen.

Only by using _DONTBLEND will you actually draw that  LINE _RGBA(0,0,0,0) box onto the screen, rather than blending it into the background.

You basically need 0 as your color value for XOR to work as you were intending, and instead you were clearing the screen with a shade of black.

I think I understand... maybe.
so if I filled the screen with tiles using: PUT(x,y),a(),XOR
and tried to copy that to another image: _PUTIMAGE (0,0), _DISPLAY, Other&, (0,0)-(640,400)
Other& would remain blank because of the way XOR places the pixel color value?

I guess because I can visually see the pixels in the original location but not in the _PUTIMAGE location is what is got me confused. doesn't putimage just copy the memory area for that image handle and pop it in to the other image handle memory location?

[SMcNeill]

I'm thinking it's basically this line:


                'put the tile to check over the test copy with XOR
                PUT (320, 200), temp(), XOR
                'zoom in on that area

The XOR here fails to behave as you'd expect and turns the screen segment black.

******************

Question:


                'get the test copy to see if it was erased
                GET (320, 200)-(335, 215), temp(257)


In the above, shouldn't you GET temp()?  Why get temp(257)?   What am I missing here?