A Rnd bug in qb64 v 1.4

[neelst123]

Code: QB64: [Select]

1. INPUT "What is your name"; name$
2. PRINT "Hi "; name$
3. INPUT "Want to play a game (y/n)"; game$
4. IF game$ = "y" THEN GOTO 2
5. PRINT ":("
6. 1 END
7. 2 PRINT "let the wheel spin!!!"
8. numa% = INT(RND * 3) + 1
9. numb% = INT(RND * 3) + 1
10. numc% = INT(RND * 6) + 1
11. fnum% = numa% + numb% + numc%
12. IF fnum% = 1 OR 4 OR 7 OR 10 THEN num% = 1
13. IF fnum% = 2 OR 5 OR 8 OR 11 THEN num% = 2
14. IF fnum% = 3 OR 6 OR 9 OR 12 THEN num% = 3
15. IF num% = 1 GOTO 5 ELSE GOTO 3
16. 3 IF num% = 2 GOTO 6 ELSE GOTO 4
17. 4 IF num% = 3 GOTO 7 ELSE GOTO 2
18. 5 PRINT "you get stone-paper-scissors (with the computer)"
19. 6 PRINT "hi"
20. 7 PRINT "yo"

I don't know if it is just me but this always says "yo" for some reason although it is a randomiser. Please tell me if it is a mistake or a bug (or just bad luck I am facing) and if a bug fix t as soon as feasible.

[TerryRitchie]

Code: QB64: [Select]

1. INPUT "What is your name"; NAME$
2. PRINT "Hi "; NAME$
3. INPUT "Want to play a game (y/n)"; game$
4. IF game$ = "y" THEN GOTO 2
5. PRINT ":("
6. 1 END
7. 2 PRINT "let the wheel spin!!!"
8. RANDOMIZE TIMER
9. numa% = INT(RND(1) * 3) + 1
10. numb% = INT(RND(1) * 3) + 1
11. numc% = INT(RND(1) * 6) + 1
12. fnum% = numa% + numb% + numc%
13. SELECT CASE fnum%
14.     CASE 1, 4, 7, 10
15.         num% = 1
16.     CASE 2, 5, 8, 11
17.         num% = 2
18.     CASE 3, 6, 9, 12
19.         num% = 3
20. END SELECT
21. IF num% = 1 GOTO 5 ELSE GOTO 3
22. 3 IF num% = 2 GOTO 6 ELSE GOTO 4
23. 4 IF num% = 3 GOTO 7 ELSE GOTO 2
24. 5 PRINT "you get stone-paper-scissors (with the computer)": END
25. 6 PRINT "hi": END
26. 7 PRINT "yo"
27.  

[bplus]

IF fnum% = 1 OR 4 OR 7 OR 10 THEN num% = 1

you probably want:

If fnum% = 1 or fnum% = 4 or fnum% = 7 or fnum% = 10 then ...

Code: QB64: [Select]

1. INPUT "What is your name"; NAME$
2. PRINT "Hi "; NAME$
3. INPUT "Want to play a game (y/n)"; game$
4. IF game$ = "y" THEN GOTO 2
5. PRINT ":("
6. 1 END
7. 2 PRINT "let the wheel spin!!!"
8. RANDOMIZE TIMER
9. numa% = INT(RND(1) * 3) + 1
10. numb% = INT(RND(1) * 3) + 1
11. numc% = INT(RND(1) * 6) + 1
12. fnum% = numa% + numb% + numc%
13. SELECT CASE fnum% mod 3
14.     CASE 1
15.         num% = 1
16.     CASE 2
17.         num% = 2
18.     CASE 0
19.         num% = 3
20. END SELECT
21. IF num% = 1 GOTO 5 ELSE GOTO 3
22. 3 IF num% = 2 GOTO 6 ELSE GOTO 4
23. 4 IF num% = 3 GOTO 7 ELSE GOTO 2
24. 5 PRINT "you get stone-paper-scissors (with the computer)": END
25. 6 PRINT "hi": END
26. 7 PRINT "yo"
27.  

[CBTJD]

Yep, they nailed it. The problem is two-fold;
1) The RND functions need to be properly initialized, and
2) The multiple ORs in the IF statements are calculating instead of comparing.
The line

• IF fnum% = 1 OR 4 OR 7 OR 10 THEN num% = 1

Is the same as saying

• IF fnum% = 15 THEN num% = 1

If you wanted to use the IF statement instead of the SELECT CASE option, the code would have to be more specific

• IF fnum% = 1 OR fnum% = 4 OR fnum% = 7 OR fnum% = 10 THEN num% = 1

[bplus]

You could cut a bunch of lines and just did:

r = int(rnd * 3) + 1 = 1, 2, 3

2 beats 1 and 3 beats 2 but 1 beats 3. What's a cool way to code that?

[CBTJD]

r = int(rnd * 3) + 1 = 1, 2, 3

Please forgive my ignorance. How does this work? At first glance, it looks like a calculated GOTO, but I feel I missed something.

[TerryRitchie]

Please forgive my ignorance. How does this work? At first glance, it looks like a calculated GOTO, but I feel I missed something.

I'm thoroughly confused as well :)

[SMcNeill]

R  = INT(RND * 3) + 1

Value is either 1, 2, or 3 for R.

R = 1, 2, 3

[SMcNeill]

You could cut a bunch of lines and just did:

r = int(rnd * 3) + 1 = 1, 2, 3

2 beats 1 and 3 beats 2 but 1 beats 3. What's a cool way to code that?

IF num1 = 1 AND num2 = 3 THEN '1 BEATS 3
    num1 = WINNER
ELSEIF num1 > num2 THEN '2 BEATS 1, 3 BEATS 2
    num1 = WINNER
ELSE 'ELSE
    num2 = WINNER
END IF

[bplus]

Please forgive my ignorance. How does this work? At first glance, it looks like a calculated GOTO, but I feel I missed something.

I'm thoroughly confused as well :)

R  = INT(RND * 3) + 1

Value is either 1, 2, or 3 for R.

R = 1, 2, 3

Sorry Terry and CBTJD late at night my brain starts a race with my fingers and typing.

Steve has the interpretation, OP could as easily written fnum% = Int(rnd*3) + 1 without all the run around and goto's and such.

IF num1 = 1 AND num2 = 3 THEN '1 BEATS 3
    num1 = WINNER
ELSEIF num1 > num2 THEN '2 BEATS 1, 3 BEATS 2
    num1 = WINNER
ELSE 'ELSE
    num2 = WINNER
END IF

And Steve has a solution to name winner. I think we might do better but I have to work it out myself.

I am keeping in mind OP is setting up to do a Rock, Paper, Scissors contest with the computer.

[TempodiBasic]

Hi guys

it seems that you have turned the spaghetti code into a soup with little pasta within!

There are so many ways to write something, it stands to us choosing that is clearer and more suitable than others.

[bplus]

2 beats 1 and 3 beats 2 but 1 beats 3. What's a cool way to code that?

What I meant was, "After Computer chooses and Human chooses, what is a cool way to determine the result of a game?

Here is what I had in mind:

Code: QB64: [Select]

1. 1 computer$ = MID$("rps", INT(RND * 3) + 1, 1)
2. INPUT "Human please enter r for rock, p for paper, s for scissors any other looses "; human$
3. PRINT "Computer picked: "; computer$
4. IF human$ = computer$ THEN PRINT "Tie" + CHR$(10): GOTO 1
5. IF INSTR(INSTR("rps", computer$), "rpsr", human$) = INSTR("rps", computer$) + 1 THEN PRINT "Human wins" + CHR$(10) ELSE PRINT "Computer wins" + CHR$(10)
6. GOTO 1
7.  

Whole game in 6 lines with 1 colon = 7.