Anyone else do what I'll call coding by substitution?

[Pete]

I'm reworking a string math rounding and display limit routine, and I decided to take it easy on myself, for a change, so, I started with this...

Code: QB64: [Select]

1. LINE INPUT n$
2. IF LEN(n$) > 2 AND INSTR(n$, ".") <> 0 AND RIGHT$(n$, 1) > "4" THEN
3.     a# = LEN(n$)
4.     b# = INSTR(n$, ".")
5.     c# = a# - b#
6.     x$ = MID$(n$, 1, b# - 1) + MID$(n$, b# + 1)
7.     y$ = RIGHT$(n$, 1)
8.     d# = 10 - VAL(y$)
9.     e# = VAL(x$) + d#
10.     n2$ = LTRIM$(STR$(e#))
11.     f# = LEN(n2$) - c#
12.     n2$ = MID$(n2$, 1, f#) + "." + MID$(n2$, f# + 1)
13.     DO UNTIL RIGHT$(n2$, 1) <> "0"
14.         n2$ = MID$(n2$, 1, LEN(n2$) - 1)
15.     LOOP
16.     IF RIGHT$(n2$, 1) = "." THEN n2$ = MID$(n2$, 1, LEN(n2$) - 1)
17.    n$ = n2$
18. END IF
19. PRINT n$

That code uses a variable for just about every step. Normally, I just write long string arguments, which is the next example, without the need for doing the above. I have to admit, doing the above made it easier. By substitution, I mean I took what the variable was equal to, an substituted that part of the statement (cut and paste) wherever the variable letter occurred.

Code: QB64: [Select]

1. LINE INPUT n$
2. IF LEN(n$) > 2 AND INSTR(n$, ".") <> 0 AND RIGHT$(n$, 1) > "4" THEN
3.     n2$ = LTRIM$(STR$(VAL(MID$(n$, 1, INSTR(n$, ".") - 1) + MID$(n$, INSTR(n$, ".") + 1)) + 10 - VAL(RIGHT$(n$, 1))))
4.     n2$ = MID$(n2$, 1, LEN(n2$) - (LEN(n$) - INSTR(n$, "."))) + "." + MID$(n2$, LEN(n2$) - (LEN(n$) - INSTR(n$, ".")) + 1)
5.     DO UNTIL RIGHT$(n2$, 1) <> "0" ' Remove trailing zeros.
6.         n2$ = MID$(n2$, 1, LEN(n2$) - 1)
7.     LOOP
8.     IF RIGHT$(n2$, 1) = "." THEN n2$ = MID$(n2$, 1, LEN(n2$) - 1) ' Remove a trailing decimal point.
9.     n$ = n2$
10. END IF
11. PRINT n$

Anyway, I'm pretty sure I haven't invented anything new in the way of coding, but I was curious if any of you guys have taken similar approach, or use other helpful methods to make complicated coding work a bit easier.

Pete

[bplus]

I would go with the first code example with more descriptive variables if I wanted to explain the code to others or myself at a later date.

I would go the 2nd code example route to eliminate as many variables for most efficient processing from less variable assignments.