gwbasic's if statement doesn't work on qb64

[Kiara87]

I'm talking about this code

Code: QB64: [Select]

1. 10 PRINT TAB(32); "WEEKDAY"
2. 20 PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
3. 30 PRINT: PRINT: PRINT
4. 100 PRINT "WEEKDAY IS A COMPUTER DEMONSTRATION THAT"
5. 110 PRINT "DA FATTI SU UNA DATA DI INTERESSE PER VOI."
6. 120 PRINT
7. 130 PRINT "INSERISCI LA DATA DI OGGI NEL MODULO: 3,24,1979  ";
8. 140 INPUT M1, D1, Y1
9. 150 REM THIS PROGRAM DETERMINES THE DAY OF THE WEEK
10. 160 REM  FOR A DATE AFTER 1582
11. 180 DIM T(12)
12.  
13. 200 REM SPACE OUTPUT AND READ IN INITIAL VALUES FOR MONTHS.
14. 210 FOR I = 1 TO 12
15.    220 READ T(I)
16. 230 NEXT I
17. 240 PRINT "INSERISCI GIORNO DI NASCITA (O ALTRO GIORNO DI INTERESSE)";
18. 250 INPUT M, D, Y
19. 260 PRINT
20. 270 LET I1 = INT((Y - 1500) / 100)
21. 280 REM TEST FOR DATE BEFORE CURRENT CALENDAR.
22. 290 IF Y - 1582 < 0 THEN 1300
23. 300 LET A = I1 * 5 + (I1 + 3) / 4
24. 310 LET I2 = INT(A - fnb(A) * 7)
25. 320 LET Y2 = INT(Y / 100)
26. 330 LET Y3 = INT(Y - Y2 * 100)
27. 340 LET A = Y3 / 4 + Y3 + D + T(M) + I2
28. 350 LET B = INT(A - fnb(A) * 7) + 1
29. 360 IF M > 2 THEN 470
30. 370 IF Y3 = 0 THEN 440
31. 380 LET T1 = INT(Y - fna(Y) * 4)
32. 390 IF T1 <> 0 THEN 470
33. 400 IF B <> 0 THEN 420
34. 410 LET B = 6
35. 420 LET B = B - 1
36. 430 GOTO 470
37. 440 LET A = I1 - 1
38. 450 LET T1 = INT(A - fna(A) * 4)
39. 460 IF T1 = 0 THEN 400
40. 470 IF B <> 0 THEN 490
41. 480 LET B = 7
42. 490 IF (Y1 * 12 + M1) * 31 + D1 < (Y * 12 + M) * 31 + D THEN 550
43. 500 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 530
44. 510 PRINT M; "/"; D; "/"; Y; " ERA UN ";
45. 520 GOTO 570
46. 530 PRINT M; "/"; D; "/"; Y; " E UN ";
47. 540 GOTO 570
48. 550 PRINT M; "/"; D; "/"; Y; " SARA UN ";
49. 560 REM PRINT THE DAY OF THE WEEK THE DATE FALLS ON.
50. 570 IF B <> 1 THEN 590
51. 580 PRINT "DOMENICA."
52. 590 IF B <> 2 THEN 610
53. 600 PRINT "LUNEDI."
54. 610 IF B <> 3 THEN 630
55. 620 PRINT "MARTEDI."
56. 630 IF B <> 4 THEN 650
57. 640 PRINT "MERCOLEDI."
58. 650 IF B <> 5 THEN 670
59. 660 PRINT "GIOVEDI."
60. 670 IF B <> 6 THEN 690
61. 680 GOTO 1250
62. 690 IF B <> 7 THEN 710
63. 700 PRINT "SABATO."
64. 710 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 1120
65. 720 LET I5 = Y1 - Y
66. 730 PRINT
67. 740 LET I6 = M1 - M
68. 750 LET I7 = D1 - D
69. 760 IF I7 >= 0 THEN 790
70. 770 LET I6 = I6 - 1
71. 780 LET I7 = I7 + 30
72. 790 IF I6 >= 0 THEN 820
73. 800 LET I5 = I5 - 1
74. 810 LET I6 = I6 + 12
75. 820 IF I5 < 0 THEN 1310
76. 830 IF I7 <> 0 THEN 850
77. 835 IF I6 <> 0 THEN 850
78. 840 PRINT "***HAPPY BIRTHDAY***"
79. 850 PRINT " ", " ", "ANNI", "MESI", "GIORNI"
80. 855 PRINT " ", " ", "-----", "------", "----"
81. 860 PRINT "LA TUA ETA      ", I5, I6, I7
82. 870 LET A8 = (I5 * 365) + (I6 * 30) + I7 + INT(I6 / 2)
83. 880 LET K5 = I5
84. 890 LET K6 = I6
85. 900 LET K7 = I7
86. 910 REM CALCULATE RETIREMENT DATE.
87. 920 LET E = Y + 65
88. 930 REM CALCULATE TIME SPENT IN THE FOLLOWING FUNCTIONS.
89. 940 LET F = .35
90. 950 PRINT "HAI DORMITO     ",
91. 960 GOSUB 1370
92. 970 LET F = .17
93. 980 PRINT "TU HAI MANGIATO ",
94. 990 GOSUB 1370
95. 1000 LET F = .23
96. 1010 IF K5 > 3 THEN 1040
97. 1020 PRINT "HAI GIOCATO",
98. 1030 GOTO 1080
99. 1040 IF K5 > 9 THEN 1070
100. 1050 PRINT "HAI GIOCATO / STUDIATO",
101. 1060 GOTO 1080
102. 1070 PRINT "HAI LAVORATO / GIOCATO",
103. 1080 GOSUB 1370
104. 1085 GOTO 1530
105. 1090 PRINT "TI SEI RILASSATO ", K5, K6, K7
106. 1100 PRINT
107. 1110 PRINT TAB(16); "***  PUOI ANDARE IN PENSIONE"; E; " ***"
108. 1120 PRINT
109. 1140 PRINT
110. 1200 PRINT
111. 1210 PRINT
112. 1220 PRINT
113. 1230 PRINT
114. 1240 END
115. 1250 IF D = 13 THEN 1280
116. 1260 PRINT "VENERDI."
117. 1270 GOTO 710
118. 1280 PRINT "VENERDI TREDICESIMO --- ATTENZIONE!"
119. 1290 GOTO 710
120. 1300 PRINT "NON PREPARATI A DARE GIORNO DELLA SETTIMANA PRIMA DI MDLXXXII. "
121. 1310 GOTO 1140
122. 1320 REM TABLE OF VALUES FOR THE MONTHS TO BE USED IN CALCULATIONS.
123. 1330 DATA 0,3,3,6,1,4,6,2,5,0,3,5
124. 1340 REM THIS IS THE CURRENT DATE USED IN THE CALCULATIONS.
125. 1350 REM THIS IS THE DATE TO BE CALCULATED ON.
126. 1360 REM CALCULATE TIME IN YEARS, MONTHS, AND DAYS
127. 1370 LET K1 = INT(F * A8)
128. 1380 LET I5 = INT(K1 / 365)
129. 1390 LET K1 = K1 - (I5 * 365)
130. 1400 LET I6 = INT(K1 / 30)
131. 1410 LET I7 = K1 - (I6 * 30)
132. 1420 LET K5 = K5 - I5
133. 1430 LET K6 = K6 - I6
134. 1440 LET K7 = K7 - I7
135. 1450 IF K7 >= 0 THEN 1480
136. 1460 LET K7 = K7 + 30
137. 1470 LET K6 = K6 - 1
138. 1480 IF K6 > 0 THEN 1510
139. 1490 LET K6 = K6 + 12
140. 1500 LET K5 = K5 - 1
141. 1510 PRINT I5, I6, I7
142. 1520 RETURN
143. 1530 IF K6 = 12 THEN 1550
144. 1540 GOTO 1090
145. 1550 LET K5 = K5 + 1
146. 1560 LET K6 = 0
147. 1570 GOTO 1090
148. 1580 REM
149. 1590 END
150. FUNCTION fna (A)
151.     fna = INT(A / 4)
152. END FUNCTION
153. FUNCTION fnb (A)
154.     fnb = INT(A / 4)
155. END FUNCTION

this is the code that I think does not execute well

Code: QB64: [Select]

1. 550 PRINT M; "/"; D; "/"; Y; " SARA UN ";
2. 560 REM PRINT THE DAY OF THE WEEK THE DATE FALLS ON.
3. 570 IF B <> 1 THEN 590
4. 580 PRINT "DOMENICA."
5. 590 IF B <> 2 THEN 610
6. 600 PRINT "LUNEDI."
7. 610 IF B <> 3 THEN 630
8. 620 PRINT "MARTEDI."
9. 630 IF B <> 4 THEN 650
10. 640 PRINT "MERCOLEDI."
11. 650 IF B <> 5 THEN 670
12. 660 PRINT "GIOVEDI."
13. 670 IF B <> 6 THEN 690
14. 680 GOTO 1250
15. 690 IF B <> 7 THEN 710
16. 700 PRINT "SABATO."
17. 710 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 1120
18. 720 LET I5 = Y1 - Y
19. 730 PRINT

because when I run the program it should tell me if it was a Sunday or a Monday or a Tuesday any day after the if statement why shouldn't it be executed?


i know it's old code but i am using this to learn and understand better

[Cobalt]

The only thing to learn from that is how NOT to do things like that anymore.

[STxAxTIC]

I'm with Cobalt. This code should just be "looked at", not "read".

[Pete]

Use SELECT CASE, instead of IF/THEN, as in: SELECT CASE of dynamite and blow that code to hell.

Code: QB64: [Select]

1. B = 3
2. SELECT CASE B
3. CASE 1
4. PRINT "Monday"
5. CASE 2
6. PRINT "Tuesday"
7. CASE 3
8. PRINT "Wednesday"
9. CASE 4
10. PRINT "Thursday"
11. CASE 5
12. PRINT "Friday"
13. CASE 6
14. PRINT "Saturday"
15. CASE 7
16. PRINT "Sunday"
17. END SELECT

Pete

[SMcNeill]

Or toss that whole program.

Code: QB64: [Select]

1.  
2. INPUT “Enter month”, m
3. INPUT “Enter day”, d
4. INPUT “Enter year (all 4 digits”, y
5.  
6. PRINT GetDay$(m, d, y)
7.  
8. FUNCTION GetDay$ (m, d, y) 'use 4 digit year
9.     'From Zeller's congruence: https://en.wikipedia.org/wiki/Zeller%27s_congruence
10.     mm = m: dd = d: yyyy = y
11.     IF mm < 3 THEN mm = mm + 12: yyyy = yyyy - 1
12.     century = yyyy MOD 100
13.     zerocentury = yyyy \ 100
14.     result = (dd + INT(13 * (mm + 1) / 5) + century + INT(century / 4) + INT(zerocentury / 4) + 5 * zerocentury) MOD 7
15.     'Function changed to return a numeric value instead of a string for this program
16.         SELECT CASE result
17.             CASE 0: GetDay$ = "Saturday"
18.             CASE 1: GetDay$ = "Sunday"
19.             CASE 2: GetDay$ = "Monday"
20.             CASE 3: GetDay$ = "Tuesday"
21.             CASE 4: GetDay$ = "Wednesday"
22.             CASE 5: GetDay$ = "Thursday"
23.             CASE 6: GetDay$ = "Friday"
24.         END SELECT
25. END FUNCTION

[bplus]

Hey what's this saying about this date?

  [ You are not allowed to view this attachment ]  

I think GWBasic's IF works fine in QB64 :)

[bplus]

Kiara did you add this onto the end of the Morristown code because QB64 does not do DEF FN... ?

Code: QB64: [Select]

1. FUNCTION fna (A)
2.     fna = INT(A / 4)
3. END FUNCTION
4. FUNCTION fnb (A)
5.     fnb = INT(A / 4)
6. END FUNCTION
7.  

This does not look right, why define two functions that do exactly the same thing? That's wasting time.

I suspect fna() was suppose to calculate something different than fnb().

Looks like a leap year calculation where these are being used?

[Adrian]

GWBASIC... what memories :)

[SMcNeill]

Best I can tell, now that I'm at home and have a had a chance to look at this, the code itself is simply buggy somewhere.

The reason why we're not seeing any date being printed, is simply because we're not generating a day value from 1 to 7, as I illustrate here:

Code: QB64: [Select]

1. 10 PRINT TAB(32); "WEEKDAY"
2. 20 PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
3. 30 PRINT: PRINT: PRINT
4. 100 PRINT "WEEKDAY IS A COMPUTER DEMONSTRATION THAT"
5. 110 PRINT "FROM FACTS ON A DATE OF INTEREST FOR YOU."
6. 120 PRINT
7. 130 PRINT "ENTER THE DATE OF TODAY IN THE FORM: 3,24,1979  ";
8. 140 INPUT M1, D1, Y1
9. 150 REM THIS PROGRAM DETERMINES THE DAY OF THE WEEK
10. 160 REM  FOR A DATE AFTER 1582
11. 180 DIM T(12)
12.  
13. 200 REM SPACE OUTPUT AND READ IN INITIAL VALUES FOR MONTHS.
14. 210 FOR I = 1 TO 12
15.    220 READ T(I)
16. 230 NEXT I
17. 240 PRINT "ENTER DAY OF BIRTH (OR OTHER DAY OF INTEREST)";
18. 250 INPUT M, D, Y 'let's say I'm going to use 1, 1, 2021
19. 260 PRINT
20. 270 LET I1 = INT((Y - 1500) / 100) 'so 5 for 2021?
21. 280 REM TEST FOR DATE BEFORE CURRENT CALENDAR.
22. 290 IF Y - 1582 < 0 THEN 1300
23. 300 LET A = I1 * 5 + (I1 + 3) / 4 '5 * 5 + 8 / 4 = 25 + 2 = 27
24. 310 LET I2 = INT(A - fnb(A) * 7) 'int (27 - 6 * 7) = 27 - 42 = -15
25. 320 LET Y2 = INT(Y / 100) '20
26. 330 LET Y3 = INT(Y - Y2 * 100) 'int(2021 - 20 * 100) = 21
27. 340 LET A = Y3 / 4 + Y3 + D + T(M) + I2 'WAIT??  WHAT?? Why did we calculate A before, just to replace it completely here??
28. ' A = 21 / 4 + 21 + 1 + T(M) + (-15)
29. ' T(1) = 0 for the above, so A = 5 + 21 + 1 + 0 - 15
30. ' Which makes A = 12?
31. 350 LET B = INT(A - fnb(A) * 7) + 1 '12 - 3 * 7 = `12 - 21 = -9
32. 360 IF M > 2 THEN 470 'month is only 1; skip this
33. 370 IF Y3 = 0 THEN 440 'y3 is 21; skip this
34. 380 LET T1 = INT(Y - fna(Y) * 4) 'T1 = 2021 - 504 * 4 = 1
35. 390 IF T1 <> 0 THEN 470 'T1 = 1, so we goto 470
36. 400 IF B <> 0 THEN 420
37. 410 LET B = 6
38. 420 LET B = B - 1
39. 430 GOTO 470
40. 440 LET A = I1 - 1
41. 450 LET T1 = INT(A - fna(A) * 4)
42. 460 IF T1 = 0 THEN 400
43. 470 IF B <> 0 THEN 490 'B = -9, so we goto 490
44. 480 LET B = 7
45. 490 IF (Y1 * 12 + M1) * 31 + D1 < (Y * 12 + M) * 31 + D THEN 550 'these just gives us a formatting for grammer
46. 500 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 530 'both end up going to 570
47. 510 PRINT M; "/"; D; "/"; Y; " WAS A "; B
48. 520 GOTO 570
49. 530 PRINT M; "/"; D; "/"; Y; " IT'S A "; B
50. 540 GOTO 570
51. 550 PRINT M; "/"; D; "/"; Y; " IT WILL BE A "; B
52. 560 REM PRINT THE DAY OF THE WEEK THE DATE FALLS ON.
53. 570 IF B <> 1 THEN 590 '-9 is not 1, so goto 590
54. 580 PRINT "SUNDAY."
55. 590 IF B <> 2 THEN 610 '-9 is not 2, so goto 610
56. 600 PRINT "MONDAY."
57. 610 IF B <> 3 THEN 630 '-9 is not 3, so goto 630
58. 620 PRINT "TUESDAY."
59. 630 IF B <> 4 THEN 650 '-9 is not 4, so goto 650
60. 640 PRINT "WEDNESDAY."
61. 650 IF B <> 5 THEN 670 '-9 is not 5, so goto 670
62. 660 PRINT "THURSDAY."
63. 670 IF B <> 6 THEN 690 '-9 is not 6, so goto 690
64. 680 GOTO 1250
65. 690 IF B <> 7 THEN 710 '-9 is not 7, so goto 710
66. 700 PRINT "SATURDAY."
67. 710 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 1120
68. 720 LET I5 = Y1 - Y
69. 730 PRINT
70. 740 LET I6 = M1 - M
71. 750 LET I7 = D1 - D
72. 760 IF I7 >= 0 THEN 790
73. 770 LET I6 = I6 - 1
74. 780 LET I7 = I7 + 30
75. 790 IF I6 >= 0 THEN 820
76. 800 LET I5 = I5 - 1
77. 810 LET I6 = I6 + 12
78. 820 IF I5 < 0 THEN 1310
79. 830 IF I7 <> 0 THEN 850
80. 835 IF I6 <> 0 THEN 850
81. 840 PRINT "***HAPPY BIRTHDAY***"
82. 850 PRINT " ", " ", "ANNI", "MESI", "GIORNI"
83. 855 PRINT " ", " ", "-----", "------", "----"
84. 860 PRINT "LA TUA ETA      ", I5, I6, I7
85. 870 LET A8 = (I5 * 365) + (I6 * 30) + I7 + INT(I6 / 2)
86. 880 LET K5 = I5
87. 890 LET K6 = I6
88. 900 LET K7 = I7
89. 910 REM CALCULATE RETIREMENT DATE.
90. 920 LET E = Y + 65
91. 930 REM CALCULATE TIME SPENT IN THE FOLLOWING FUNCTIONS.
92. 940 LET F = .35
93. 950 PRINT "HAI DORMITO     ",
94. 960 GOSUB 1370
95. 970 LET F = .17
96. 980 PRINT "TU HAI MANGIATO ",
97. 990 GOSUB 1370
98. 1000 LET F = .23
99. 1010 IF K5 > 3 THEN 1040
100. 1020 PRINT "HAI GIOCATO",
101. 1030 GOTO 1080
102. 1040 IF K5 > 9 THEN 1070
103. 1050 PRINT "HAI GIOCATO / STUDIATO",
104. 1060 GOTO 1080
105. 1070 PRINT "HAI LAVORATO / GIOCATO",
106. 1080 GOSUB 1370
107. 1085 GOTO 1530
108. 1090 PRINT "TI SEI RILASSATO ", K5, K6, K7
109. 1100 PRINT
110. 1110 PRINT TAB(16); "***  PUOI ANDARE IN PENSIONE"; E; " ***"
111. 1120 PRINT
112. 1140 PRINT
113. 1200 PRINT
114. 1210 PRINT
115. 1220 PRINT
116. 1230 PRINT
117. 1240 END
118. 1250 IF D = 13 THEN 1280
119. 1260 PRINT "FRIDAY."
120. 1270 GOTO 710
121. 1280 PRINT "FRIDAY THE 13TH -- ATTENTION!"
122. 1290 GOTO 710
123. 1300 PRINT "NON PREPARATI A DARE GIORNO DELLA SETTIMANA PRIMA DI MDLXXXII. "
124. 1310 GOTO 1140
125. 1320 REM TABLE OF VALUES FOR THE MONTHS TO BE USED IN CALCULATIONS.
126. 1330 DATA 0,3,3,6,1,4,6,2,5,0,3,5
127. 1340 REM THIS IS THE CURRENT DATE USED IN THE CALCULATIONS.
128. 1350 REM THIS IS THE DATE TO BE CALCULATED ON.
129. 1360 REM CALCULATE TIME IN YEARS, MONTHS, AND DAYS
130. 1370 LET K1 = INT(F * A8)
131. 1380 LET I5 = INT(K1 / 365)
132. 1390 LET K1 = K1 - (I5 * 365)
133. 1400 LET I6 = INT(K1 / 30)
134. 1410 LET I7 = K1 - (I6 * 30)
135. 1420 LET K5 = K5 - I5
136. 1430 LET K6 = K6 - I6
137. 1440 LET K7 = K7 - I7
138. 1450 IF K7 >= 0 THEN 1480
139. 1460 LET K7 = K7 + 30
140. 1470 LET K6 = K6 - 1
141. 1480 IF K6 > 0 THEN 1510
142. 1490 LET K6 = K6 + 12
143. 1500 LET K5 = K5 - 1
144. 1510 PRINT I5, I6, I7
145. 1520 RETURN
146. 1530 IF K6 = 12 THEN 1550
147. 1540 GOTO 1090
148. 1550 LET K5 = K5 + 1
149. 1560 LET K6 = 0
150. 1570 GOTO 1090
151. 1580 REM
152. 1590 END
153. FUNCTION fna (A)
154.     fna = INT(A / 4)
155. END FUNCTION
156. FUNCTION fnb (A)
157.     fnb = INT(A / 4)
158. END FUNCTION
159.  

By running the program, we generate a B value for the day, and our calculation ends up returning negative values to us.  (For 1/1/2021, the value ends up telling us that our day is the -9th day, which is completely meaningless.)  Now, what's glitched here, I have no clue.  Perhaps, it's like STx has suggested and one of the FUNCTIONS is wrong, or perhaps it's something else completely.  If you've translated this code from some original QB45 source, kindly share the source so we can compare the two versions, otherwise, I'm afraid, about all you can get here is some basic confirmation:  "Yep, it's buggy."

The IF statements work fine; but there's something in the math that simply doesn't compute properly, as written.

[Adrian]

ok, i think the problem was function fnb(A). changing it to fnb=INT(A/7) seems to work.

Code: QB64: [Select]

1. 10 PRINT TAB(32); "WEEKDAY"
2. 20 PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
3. 30 PRINT: PRINT: PRINT
4. 100 PRINT "WEEKDAY IS A COMPUTER DEMONSTRATION THAT"
5. 110 PRINT "FROM FACTS ON A DATE OF INTEREST FOR YOU."
6. 120 PRINT
7. 130 PRINT "ENTER THE DATE OF TODAY IN THE FORM (M,D,Y): 3,24,1979  ";
8. 140 INPUT M1, D1, Y1
9. 150 REM THIS PROGRAM DETERMINES THE DAY OF THE WEEK
10. 160 REM  FOR A DATE AFTER 1582
11. 180 DIM T(12)
12.  
13. 200 REM SPACE OUTPUT AND READ IN INITIAL VALUES FOR MONTHS.
14. 210 FOR I = 1 TO 12
15.    220 READ T(I)
16. 230 NEXT I
17. 240 PRINT "ENTER DAY OF BIRTH (OR OTHER DAY OF INTEREST)";
18. 250 INPUT M, D, Y
19. 260 PRINT
20. 270 LET I1 = INT((Y - 1500) / 100)
21. 280 REM TEST FOR DATE BEFORE CURRENT CALENDAR.
22. 290 IF Y - 1582 < 0 THEN 1300
23. 300 LET A = I1 * 5 + (I1 + 3) / 4
24. 310 LET I2 = INT(A - fnb(A) * 7)
25. 320 LET Y2 = INT(Y / 100)
26. 330 LET Y3 = INT(Y - Y2 * 100)
27. 340 LET A = Y3 / 4 + Y3 + D + T(M) + I2
28. 350 LET B = INT(A - fnb(A) * 7) + 1
29. 360 IF M > 2 THEN 470
30. 370 IF Y3 = 0 THEN 440
31. 380 LET T1 = INT(Y - fna(Y) * 4)
32. 390 IF T1 <> 0 THEN 470
33. 400 IF B <> 0 THEN 420
34. 410 LET B = 6
35. 420 LET B = B - 1
36. 430 GOTO 470
37. 440 LET A = I1 - 1
38. 450 LET T1 = INT(A - fna(A) * 4)
39. 460 IF T1 = 0 THEN 400
40. 470 IF B <> 0 THEN 490
41. 480 LET B = 7
42. 490 IF (Y1 * 12 + M1) * 31 + D1 < (Y * 12 + M) * 31 + D THEN 550
43. 500 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 530
44. 510 PRINT M; "/"; D; "/"; Y; " WAS A ";
45. 520 GOTO 570
46. 530 PRINT M; "/"; D; "/"; Y; " IT'S A ";
47. 540 GOTO 570
48. 550 PRINT M; "/"; D; "/"; Y; " IT WILL BE A ";
49. 560 REM PRINT THE DAY OF THE WEEK THE DATE FALLS ON.
50. 570 IF B <> 1 THEN 590
51. 580 PRINT "SUNDAY."
52. 590 IF B <> 2 THEN 610
53. 600 PRINT "MONDAY."
54. 610 IF B <> 3 THEN 630
55. 620 PRINT "TUESDAY."
56. 630 IF B <> 4 THEN 650
57. 640 PRINT "WEDNESDAY."
58. 650 IF B <> 5 THEN 670
59. 660 PRINT "THURSDAY."
60. 670 IF B <> 6 THEN 690
61. 680 GOTO 1250
62. 690 IF B <> 7 THEN 710
63. 700 PRINT "SATURDAY."
64. 710 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 1120
65. 720 LET I5 = Y1 - Y
66. 730 PRINT
67. 740 LET I6 = M1 - M
68. 750 LET I7 = D1 - D
69. 760 IF I7 >= 0 THEN 790
70. 770 LET I6 = I6 - 1
71. 780 LET I7 = I7 + 30
72. 790 IF I6 >= 0 THEN 820
73. 800 LET I5 = I5 - 1
74. 810 LET I6 = I6 + 12
75. 820 IF I5 < 0 THEN 1310
76. 830 IF I7 <> 0 THEN 850
77. 835 IF I6 <> 0 THEN 850
78. 840 PRINT "***HAPPY BIRTHDAY***"
79. 850 PRINT " ", " ", "ANNI", "MESI", "GIORNI"
80. 855 PRINT " ", " ", "-----", "------", "----"
81. 860 PRINT "LA TUA ETA      ", I5, I6, I7
82. 870 LET A8 = (I5 * 365) + (I6 * 30) + I7 + INT(I6 / 2)
83. 880 LET K5 = I5
84. 890 LET K6 = I6
85. 900 LET K7 = I7
86. 910 REM CALCULATE RETIREMENT DATE.
87. 920 LET E = Y + 65
88. 930 REM CALCULATE TIME SPENT IN THE FOLLOWING FUNCTIONS.
89. 940 LET F = .35
90. 950 PRINT "HAI DORMITO     ",
91. 960 GOSUB 1370
92. 970 LET F = .17
93. 980 PRINT "TU HAI MANGIATO ",
94. 990 GOSUB 1370
95. 1000 LET F = .23
96. 1010 IF K5 > 3 THEN 1040
97. 1020 PRINT "HAI GIOCATO",
98. 1030 GOTO 1080
99. 1040 IF K5 > 9 THEN 1070
100. 1050 PRINT "HAI GIOCATO / STUDIATO",
101. 1060 GOTO 1080
102. 1070 PRINT "HAI LAVORATO / GIOCATO",
103. 1080 GOSUB 1370
104. 1085 GOTO 1530
105. 1090 PRINT "TI SEI RILASSATO ", K5, K6, K7
106. 1100 PRINT
107. 1110 PRINT TAB(16); "***  PUOI ANDARE IN PENSIONE"; E; " ***"
108. 1120 PRINT
109. 1140 PRINT
110. 1200 PRINT
111. 1210 PRINT
112. 1220 PRINT
113. 1230 PRINT
114. 1240 END
115. 1250 IF D = 13 THEN 1280
116. 1260 PRINT "FRIDAY."
117. 1270 GOTO 710
118. 1280 PRINT "FRIDAY THE 13TH -- ATTENTION!"
119. 1290 GOTO 710
120. 1300 PRINT "NON PREPARATI A DARE GIORNO DELLA SETTIMANA PRIMA DI MDLXXXII. "
121. 1310 GOTO 1140
122. 1320 REM TABLE OF VALUES FOR THE MONTHS TO BE USED IN CALCULATIONS.
123. 1330 DATA 0,3,3,6,1,4,6,2,5,0,3,5
124. 1340 REM THIS IS THE CURRENT DATE USED IN THE CALCULATIONS.
125. 1350 REM THIS IS THE DATE TO BE CALCULATED ON.
126. 1360 REM CALCULATE TIME IN YEARS, MONTHS, AND DAYS
127. 1370 LET K1 = INT(F * A8)
128. 1380 LET I5 = INT(K1 / 365)
129. 1390 LET K1 = K1 - (I5 * 365)
130. 1400 LET I6 = INT(K1 / 30)
131. 1410 LET I7 = K1 - (I6 * 30)
132. 1420 LET K5 = K5 - I5
133. 1430 LET K6 = K6 - I6
134. 1440 LET K7 = K7 - I7
135. 1450 IF K7 >= 0 THEN 1480
136. 1460 LET K7 = K7 + 30
137. 1470 LET K6 = K6 - 1
138. 1480 IF K6 > 0 THEN 1510
139. 1490 LET K6 = K6 + 12
140. 1500 LET K5 = K5 - 1
141. 1510 PRINT I5, I6, I7
142. 1520 RETURN
143. 1530 IF K6 = 12 THEN 1550
144. 1540 GOTO 1090
145. 1550 LET K5 = K5 + 1
146. 1560 LET K6 = 0
147. 1570 GOTO 1090
148. 1580 REM
149. 1590 END
150. FUNCTION fna (A)
151.     fna = INT(A / 4)
152. END FUNCTION
153. FUNCTION fnb (A)
154.     fnb = INT(A / 7)
155. END FUNCTION
156.  

[Richard Frost]

Aye, that code isn't worth trying to figure out.  The only purpose such code serves is
to show a person how NOT to program.  To "learn" from that code is like learning all
about toaster ovens when one wants to learn how to fix a car.  Study the code on
these forums.  It's all far better stuff.

Do look up the LET command in the Wiki here.  It's hilarious.  And true.

[_vince]

my favourite gwbasic-style line of code is this:

Code: QB64: [Select]

1. 1 IF 1 THEN 1
2.  

[bplus]

I was correct the 2 define functions were different and Adrian has the difference exactly:

Code: QB64: [Select]

1. 10 PRINT TAB(32); "WEEKDAY"
2. 20 PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
3. 30 PRINT: PRINT: PRINT
4. 100 PRINT "WEEKDAY IS A COMPUTER DEMONSTRATION THAT"
5. 110 PRINT "GIVES FACTS ABOUT A DATE OF INTEREST TO YOU."
6. 120 PRINT
7. 130 PRINT "ENTER TODAY'S DATE IN THE FORM: 3,24,1979  ";
8. 140 INPUT M1, D1, Y1
9. 150 REM THIS PROGRAM DETERMINES THE DAY OF THE WEEK
10. 160 REM  FOR A DATE AFTER 1582
11. 170 DEF FNA(A)=INT(A/4)
12. 180 DIM T(12)
13. 190 DEF FNB(A)=INT(A/7)
14. 200 REM SPACE OUTPUT AND READ IN INITIAL VALUES FOR MONTHS.
15. 210 FOR I= 1 TO 12
16. 220 READ T(I)
17. 230 NEXT I
18. 240 PRINT"ENTER DAY OF BIRTH (OR OTHER DAY OF INTEREST)";
19. 250 INPUT M,D,Y
20. 260 PRINT
21. 270 LET I1 = INT((Y-1500)/100)
22. 280 REM TEST FOR DATE BEFORE CURRENT CALENDAR.
23. 290 IF Y-1582 <0 THEN 1300
24. 300 LET A = I1*5+(I1+3)/4
25. 310 LET I2=INT(A-FNB(A)*7)
26. 320 LET Y2=INT(Y/100)
27. 330 LET Y3 =INT(Y-Y2*100)
28. 340 LET A =Y3/4+Y3+D+T(M)+I2
29. 350 LET B=INT(A-FNB(A)*7)+1
30. 360 IF M > 2 THEN 470
31. 370 IF Y3 = 0 THEN 440
32. 380 LET T1=INT(Y-FNA(Y)*4)
33. 390 IF T1 <> 0 THEN 470
34. 400 IF B<>0 THEN 420
35. 410 LET B=6
36. 420 LET B = B-1
37. 430 GOTO 470
38. 440 LET A = I1-1
39. 450 LET T1=INT(A-FNA(A)*4)
40. 460 IF T1 = 0 THEN 400
41. 470 IF B <>0 THEN 490
42. 480 LET B = 7
43. 490 IF (Y1*12+M1)*31+D1<(Y*12+M)*31+D THEN 550
44. 500 IF (Y1*12+M1)*31+D1=(Y*12+M)*31+D THEN 530
45. 510 PRINT M;"/";D;"/";Y;" WAS A ";
46. 520 GOTO 570
47. 530 PRINT M;"/";D;"/";Y;" IS A ";
48. 540 GOTO 570
49. 550 PRINT M;"/";D;"/";Y;" WILL BE A ";
50. 560 REM PRINT THE DAY OF THE WEEK THE DATE FALLS ON.
51. 570 IF B <>1 THEN 590
52. 580 PRINT "SUNDAY."
53. 590 IF B<>2 THEN 610
54. 600 PRINT "MONDAY."
55. 610 IF B<>3 THEN 630
56. 620 PRINT "TUESDAY."
57. 630 IF B<>4 THEN 650
58. 640 PRINT "WEDNESDAY."
59. 650 IF B<>5 THEN 670
60. 660 PRINT "THURSDAY."
61. 670 IF B<>6 THEN 690
62. 680 GOTO 1250
63. 690 IF B<>7 THEN 710
64. 700 PRINT "SATURDAY."
65. 710 IF (Y1*12+M1)*31+D1=(Y*12+M)*31+D THEN 1120
66. 720 LET I5=Y1-Y
67. 730 PRINT
68. 740 LET I6=M1-M
69. 750 LET I7=D1-D
70. 760 IF I7>=0 THEN 790
71. 770 LET I6= I6-1
72. 780 LET I7=I7+30
73. 790 IF I6>=0 THEN 820
74. 800 LET I5=I5-1
75. 810 LET I6=I6+12
76. 820 IF I5<0 THEN 1310
77. 830 IF I7 <> 0 THEN 850
78. 835 IF I6 <> 0 THEN 850
79. 840 PRINT"***HAPPY BIRTHDAY***"
80. 850 PRINT " "," ","YEARS","MONTHS","DAYS"
81. 855 PRINT " "," ","-----","------","----"
82. 860 PRINT "YOUR AGE (IF BIRTHDATE) ",I5,I6,I7
83. 870 LET A8 = (I5*365)+(I6*30)+I7+INT(I6/2)
84. 880 LET K5 = I5
85. 890 LET K6 = I6
86. 900 LET K7 = I7
87. 910 REM CALCULATE RETIREMENT DATE.
88. 920 LET E = Y+65
89. 930 REM CALCULATE TIME SPENT IN THE FOLLOWING FUNCTIONS.
90. 940 LET F = .35
91. 950 PRINT "YOU HAVE SLEPT ",
92. 960 GOSUB 1370
93. 970 LET F = .17
94. 980 PRINT "YOU HAVE EATEN ",
95. 990 GOSUB 1370
96. 1000 LET F = .23
97. 1010 IF K5 > 3 THEN 1040
98. 1020 PRINT "YOU HAVE PLAYED",
99. 1030 GOTO 1080
100. 1040 IF K5 > 9 THEN 1070
101. 1050 PRINT "YOU HAVE PLAYED/STUDIED",
102. 1060 GOTO  1080
103. 1070 PRINT "YOU HAVE WORKED/PLAYED",
104. 1080 GOSUB 1370
105. 1085 GOTO 1530
106. 1090 PRINT "YOU HAVE RELAXED ",K5,K6,K7
107. 1100 PRINT
108. 1110 PRINT TAB(16);"***  YOU MAY RETIRE IN";E;" ***"
109. 1120 PRINT
110. 1140 PRINT
111. 1200 PRINT
112. 1210 PRINT
113. 1220 PRINT
114. 1230 PRINT
115. 1240 END
116. 1250 IF D=13 THEN 1280
117. 1260 PRINT "FRIDAY."
118. 1270 GOTO 710
119. 1280 PRINT "FRIDAY THE THIRTEENTH---BEWARE!"
120. 1290 GOTO 710
121. 1300 PRINT "NOT PREPARED TO GIVE DAY OF WEEK PRIOR TO MDLXXXII. "
122. 1310 GOTO 1140
123. 1320 REM TABLE OF VALUES FOR THE MONTHS TO BE USED IN CALCULATIONS.
124. 1330 DATA 0, 3, 3, 6, 1, 4, 6, 2, 5, 0, 3, 5
125. 1340 REM THIS IS THE CURRENT DATE USED IN THE CALCULATIONS.
126. 1350 REM THIS IS THE DATE TO BE CALCULATED ON.
127. 1360 REM CALCULATE TIME IN YEARS, MONTHS, AND DAYS
128. 1370 LET K1=INT(F*A8)
129. 1380 LET I5 = INT(K1/365)
130. 1390 LET K1 = K1- (I5*365)
131. 1400 LET I6 = INT(K1/30)
132. 1410 LET I7 = K1 -(I6*30)
133. 1420 LET K5 = K5-I5
134. 1430 LET K6 =K6-I6
135. 1440 LET K7 = K7-I7
136. 1450 IF K7>=0 THEN 1480
137. 1460 LET K7=K7+30
138. 1470 LET K6=K6-1
139. 1480 IF K6>0 THEN 1510
140. 1490 LET K6=K6+12
141. 1500 LET K5=K5-1
142. 1510 PRINT I5,I6,I7
143. 1520 RETURN
144. 1530 IF K6=12 THEN 1550
145. 1540 GOTO 1090
146. 1550 LET K5=K5+1
147. 1560 LET K6=0
148. 1570 GOTO 1090
149. 1580 REM
150. 1590 END
151.  

This was from Kiara's post of Dec 24,  ...\HPSource\Basic_source_code\BCG  weekday.bas, line 190 was supposed to be:

Code: QB64: [Select]

1. 190 DEF FNB(A)=INT(A/7)
2.  

line 170 was properly translated to the other function.

[Kiara87]

thank you all for replying
the problem was as adrian and bplus says
here was the reason that I don't notice the day of variable b
FUNCTION fnb (A)
    fnb = INT(A / 7)
END FUNCTION

Code: QB64: [Select]

1. 10 PRINT TAB(32); "WEEKDAY"
2. 20 PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
3. 30 PRINT: PRINT: PRINT
4. 100 PRINT "WEEKDAY IS A COMPUTER DEMONSTRATION THAT"
5. 110 PRINT "DA FATTI SU UNA DATA DI INTERESSE PER VOI."
6. 120 PRINT
7. 130 PRINT "INSERISCI LA DATA DI OGGI NEL MODULO: 3,24,1979  ";
8. 140 INPUT M1, D1, Y1
9. 150 REM THIS PROGRAM DETERMINES THE DAY OF THE WEEK
10. 160 REM  FOR A DATE AFTER 1582
11. 180 DIM T(12)
12.  
13. 200 REM SPACE OUTPUT AND READ IN INITIAL VALUES FOR MONTHS.
14. 210 FOR I = 1 TO 12
15.    220 READ T(I)
16. 230 NEXT I
17. 240 PRINT "INSERISCI GIORNO DI NASCITA (O ALTRO GIORNO DI INTERESSE)";
18. 250 INPUT M, D, Y
19. 260 PRINT
20. 270 LET I1 = INT((Y - 1500) / 100)
21. 280 REM TEST FOR DATE BEFORE CURRENT CALENDAR.
22. 290 IF Y - 1582 < 0 THEN 1300
23. 300 LET A = I1 * 5 + (I1 + 3) / 4
24. 310 LET I2 = INT(A - fnb(A) * 7)
25. 320 LET Y2 = INT(Y / 100)
26. 330 LET Y3 = INT(Y - Y2 * 100)
27. 340 LET A = Y3 / 4 + Y3 + D + T(M) + I2
28. 350 LET B = INT(A - fnb(A) * 7) + 1
29. 360 IF M > 2 THEN 470
30. 370 IF Y3 = 0 THEN 440
31. 380 LET T1 = INT(Y - fna(Y) * 4)
32. 390 IF T1 <> 0 THEN 470
33. 400 IF B <> 0 THEN 420
34. 410 LET B = 6
35. 420 LET B = B - 1
36. 430 GOTO 470
37. 440 LET A = I1 - 1
38. 450 LET T1 = INT(A - fna(A) * 4)
39. 460 IF T1 = 0 THEN 400
40. 470 IF B <> 0 THEN 490
41. 480 LET B = 7
42. 490 IF (Y1 * 12 + M1) * 31 + D1 < (Y * 12 + M) * 31 + D THEN 550
43. 500 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 530
44. 510 PRINT M; "/"; D; "/"; Y; " ERA UN ";
45. 520 GOTO 570
46. 530 PRINT M; "/"; D; "/"; Y; " E UN ";
47. 540 GOTO 570
48. 550 PRINT M; "/"; D; "/"; Y; " SARA UN ";
49. 560 REM PRINT THE DAY OF THE WEEK THE DATE FALLS ON.
50. 570 IF B <> 1 THEN 590
51. 580 PRINT "DOMENICA."
52. 590 IF B <> 2 THEN 610
53. 600 PRINT "LUNEDI."
54. 610 IF B <> 3 THEN 630
55. 620 PRINT "MARTEDI."
56. 630 IF B <> 4 THEN 650
57. 640 PRINT "MERCOLEDI."
58. 650 IF B <> 5 THEN 670
59. 660 PRINT "GIOVEDI."
60. 670 IF B <> 6 THEN 690
61. 680 GOTO 1250
62. 690 IF B <> 7 THEN 710
63. 700 PRINT "SABATO."
64. 710 IF (Y1 * 12 + M1) * 31 + D1 = (Y * 12 + M) * 31 + D THEN 1120
65. 720 LET I5 = Y1 - Y
66. 730 PRINT
67. 740 LET I6 = M1 - M
68. 750 LET I7 = D1 - D
69. 760 IF I7 >= 0 THEN 790
70. 770 LET I6 = I6 - 1
71. 780 LET I7 = I7 + 30
72. 790 IF I6 >= 0 THEN 820
73. 800 LET I5 = I5 - 1
74. 810 LET I6 = I6 + 12
75. 820 IF I5 < 0 THEN 1310
76. 830 IF I7 <> 0 THEN 850
77. 835 IF I6 <> 0 THEN 850
78. 840 PRINT "***HAPPY BIRTHDAY***"
79. 850 PRINT " ", " ", "ANNI", "MESI", "GIORNI"
80. 855 PRINT " ", " ", "-----", "------", "----"
81. 860 PRINT "LA TUA ETA      ", I5, I6, I7
82. 870 LET A8 = (I5 * 365) + (I6 * 30) + I7 + INT(I6 / 2)
83. 880 LET K5 = I5
84. 890 LET K6 = I6
85. 900 LET K7 = I7
86. 910 REM CALCULATE RETIREMENT DATE.
87. 920 LET E = Y + 65
88. 930 REM CALCULATE TIME SPENT IN THE FOLLOWING FUNCTIONS.
89. 940 LET F = .35
90. 950 PRINT "HAI DORMITO     ",
91. 960 GOSUB 1370
92. 970 LET F = .17
93. 980 PRINT "TU HAI MANGIATO ",
94. 990 GOSUB 1370
95. 1000 LET F = .23
96. 1010 IF K5 > 3 THEN 1040
97. 1020 PRINT "HAI GIOCATO",
98. 1030 GOTO 1080
99. 1040 IF K5 > 9 THEN 1070
100. 1050 PRINT "HAI GIOCATO / STUDIATO",
101. 1060 GOTO 1080
102. 1070 PRINT "HAI LAVORATO / GIOCATO",
103. 1080 GOSUB 1370
104. 1085 GOTO 1530
105. 1090 PRINT "TI SEI RILASSATO ", K5, K6, K7
106. 1100 PRINT
107. 1110 PRINT TAB(16); "***  PUOI ANDARE IN PENSIONE"; E; " ***"
108. 1120 PRINT
109. 1140 PRINT
110. 1200 PRINT
111. 1210 PRINT
112. 1220 PRINT
113. 1230 PRINT
114. 1240 END
115. 1250 IF D = 13 THEN 1280
116. 1260 PRINT "VENERDI."
117. 1270 GOTO 710
118. 1280 PRINT "VENERDI TREDICESIMO --- ATTENZIONE!"
119. 1290 GOTO 710
120. 1300 PRINT "NON PREPARATI A DARE GIORNO DELLA SETTIMANA PRIMA DI MDLXXXII. "
121. 1310 GOTO 1140
122. 1320 REM TABLE OF VALUES FOR THE MONTHS TO BE USED IN CALCULATIONS.
123. 1330 DATA 0,3,3,6,1,4,6,2,5,0,3,5
124. 1340 REM THIS IS THE CURRENT DATE USED IN THE CALCULATIONS.
125. 1350 REM THIS IS THE DATE TO BE CALCULATED ON.
126. 1360 REM CALCULATE TIME IN YEARS, MONTHS, AND DAYS
127. 1370 LET K1 = INT(F * A8)
128. 1380 LET I5 = INT(K1 / 365)
129. 1390 LET K1 = K1 - (I5 * 365)
130. 1400 LET I6 = INT(K1 / 30)
131. 1410 LET I7 = K1 - (I6 * 30)
132. 1420 LET K5 = K5 - I5
133. 1430 LET K6 = K6 - I6
134. 1440 LET K7 = K7 - I7
135. 1450 IF K7 >= 0 THEN 1480
136. 1460 LET K7 = K7 + 30
137. 1470 LET K6 = K6 - 1
138. 1480 IF K6 > 0 THEN 1510
139. 1490 LET K6 = K6 + 12
140. 1500 LET K5 = K5 - 1
141. 1510 PRINT I5, I6, I7
142. 1520 RETURN
143. 1530 IF K6 = 12 THEN 1550
144. 1540 GOTO 1090
145. 1550 LET K5 = K5 + 1
146. 1560 LET K6 = 0
147. 1570 GOTO 1090
148. 1580 REM
149. 1590 END
150. FUNCTION fna (A)
151.     fna = INT(A / 4)
152. END FUNCTION
153. FUNCTION fnb (A)
154.     fnb = INT(A / 7)
155. END FUNCTION
156.  
157.  
158.