Pig

[bplus]

Wow that is nice! Not a single statement is double parked! :) 22 lines.

Thanks!

Well, down in low 20's could loose title and make it legal 21. ;)

Code: QB64: [Select]

1. RANDOMIZE TIMER 'pig from Rosetta v4  B+ started 2018-10-16, Steve McNeill finished 2018-10-18
2. WHILE player < 100 AND AI < 100
3.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
4.     accum = 0
5.     FOR i = 1 TO 100
6.         di = INT(RND * 6) + 1
7.         IF di = 1 THEN accum = 0 ELSE accum = accum + di
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
9.         IF di = 1 THEN INPUT "The turn is over, press enter...", wate$
10.         IF di = 1 THEN EXIT FOR
11.         IF Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
12.         IF Who$ = "Player" AND choice$ <> "r" THEN player = player + accum
13.         IF Who$ = "Player" AND choice$ <> "r" THEN EXIT FOR
14.         IF Who$ <> "Player" AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
15.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
16.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
17.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN EXIT FOR
18.     NEXT
19.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
20. WEND
21. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"
22.  

I am finding the AI pretty easy to beat, so I will see if I can find a more competitive strategy for AI.

[SMcNeill]

I lied...   After going to bed, a thought hit me, so I hopped back up and made a few other small changes:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN accum = 0 ELSE accum = accum + di
9.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
10.         IF di = 1 THEN INPUT "The turn is over, press enter...", wate$
11.         IF di > 1 AND Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
12.         IF di > 1 AND Who$ = "Player" AND choice$ <> "r" THEN player = player + accum
13.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
14.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
15.         IF (Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
16.     NEXT
17.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
18. WEND
19. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

19 lines...  It now works for the 20-line challenge, so I think this is *IT* for me.  :D

[SMcNeill]

OK, so I managed to drop one more line -- though the logic here is becoming so obtuse that I'm afraid it'll obfuscate the code beyond any sort of readability for folks in the future...

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     FOR i = 1 TO 100
6.         di = INT(RND * 6) + 1
7.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
9.         IF di = 1 THEN INPUT "The turn is over, press enter...", wate$
10.         IF di > 1 AND Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
11.         IF di > 1 AND Who$ = "Player" AND choice$ <> "r" THEN player = player + accum
12.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
13.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
14.         IF (Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
15.     NEXT
16.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
17. WEND
18. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

How's this beauty for a singular statement, that's almost impossible to look at and figure out what the heck it's doing:

        IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di

All that to get rid of the simple command which reset the value of accum for us each loop...  accum = 0

BUT... 

18 lines!

[bplus]

Well that accum = 0 line was sticking out like a sore thumb anyway! ;D

Man, unbelievable, amazing, .... wow!

So 17 now? because I dropped the _TITLE and settled for a comment after Randomize Timer.
Now. I don't know if necessary.

[SMcNeill]

You could get 17 if you merged the lines with the PRINT statements, though it'd give the user redundant information with the overall total more often.  Otherwise, I really don't see anything else much which we can cut out easily or compress.

[bplus]

I like the title, there was some poor wording I changed and I got everything off the edge of the screen, maybe even more margin would be nice.

Code: QB64: [Select]

1. _TITLE "Pig 5 (Rosetta task)" ' B+ started 2018-10-17 Steve McNeill finished 2018-10-19
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100
4.     IF Who$ <> "   Player" THEN Who$ = "   Player" ELSE Who$ = "   AI"
5.     FOR i = 1 TO 100
6.         di = INT(RND * 6) + 1
7.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
9.         IF di = 1 THEN INPUT "   The turn is over, press enter...", wate$
10.         IF di > 1 AND Who$ = "   Player" THEN INPUT "   Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "   AI is rolling again, press enter... ", wate$
11.         IF di > 1 AND Who$ = "   Player" AND choice$ <> "r" THEN player = player + accum
12.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
13.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "   AI is holding so accumulated amount is scored, press enter", wate$
14.         IF (Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "   Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
15.     NEXT
16.     PRINT CHR$(10) + "   Player =" + STR$(player) + "  AI =" + STR$(AI)
17. WEND
18. IF player > AI THEN PRINT "   Player wins!" ELSE PRINT " AI wins!"
19.  

EDIT: Yeah more margin and fix a space before a comma.

[SMcNeill]

If you don't mind the player getting a free, static, roll on the very first turn, you could also change:

IF di = 1 THEN INPUT " The turn is over, press enter...", wate$

To:

IF di = 1 THEN INPUT " The turn is over, press enter...", wate$ ELSE RANDOMIZE TIMER

The first roll would be predictable when the game starts, but since it's not going to be 1, you'd randomize timer to make all the rolls afterwards difficult to predict.

Can drop 1 more line that way, as well.

[bplus]

Yeah, OK 17! that's less than half the IDE screen.

I started a little out-dentation to signal the end of a turn:

Code: QB64: [Select]

1. _TITLE "Pig 5 (Rosetta task)" ' B+ started 2018-10-17 Steve McNeill finished 2018-10-19
2. WHILE player < 100 AND AI < 100
3.     IF Who$ <> "   Player" THEN Who$ = "   Player" ELSE Who$ = "   AI"
4.     FOR i = 1 TO 100
5.         di = INT(RND * 6) + 1
6.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
7.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
8.         IF di = 1 THEN INPUT " The turn is over, press enter...", wate$ ELSE RANDOMIZE TIMER
9.         IF di > 1 AND Who$ = "   Player" THEN INPUT "   Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "   AI is rolling again, press enter... ", wate$
10.         IF di > 1 AND Who$ = "   Player" AND choice$ <> "r" THEN player = player + accum
11.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
12.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT " AI is holding so accumulated amount is scored, press enter", wate$
13.         IF (Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "   Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
14.     NEXT
15.     PRINT CHR$(10) + "   Player =" + STR$(player) + "  AI =" + STR$(AI)
16. WEND
17. IF player > AI THEN PRINT " Player wins!" ELSE PRINT " AI wins!"
18.  
19.  

EDIT: change a spacing on last line.

[SMcNeill]

Question:

Can't the last line just be:  PRINT Who$; " wins!"

Is the IF necessary there?  (I'm in bed, on the iPad, so can't test it ATM.  :P )

[bplus]

Also good!

Code: QB64: [Select]

1. _TITLE "Pig 5 (Rosetta task)" ' B+ started 2018-10-17 Steve McNeill finished 2018-10-19
2. WHILE player < 100 AND AI < 100
3.     IF Who$ <> "   Player" THEN Who$ = "   Player" ELSE Who$ = "   AI"
4.     FOR i = 1 TO 100
5.         di = INT(RND * 6) + 1
6.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
7.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
8.         IF di = 1 THEN INPUT " The turn is over, press enter...", wate$ ELSE RANDOMIZE TIMER
9.         IF di > 1 AND Who$ = "   Player" THEN INPUT "   Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "   AI is rolling again, press enter... ", wate$
10.         IF di > 1 AND Who$ = "   Player" AND choice$ <> "r" THEN player = player + accum
11.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
12.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT " AI is holding so accumulated amount is scored, press enter", wate$
13.         IF (Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "   Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
14.     NEXT
15.     PRINT CHR$(10) + "   Player =" + STR$(player) + "  AI =" + STR$(AI)
16. WEND
17. PRINT Who$; " wins!"
18.  

Nice touch at end. :)

I am calling it a night, very fun night! Thanks

[johnno56]

I have converted, albeit crudely, an old TRS80 (1980) game called Groan.

It's similar to Pig but uses a pair of dice against AI. Select a score total; Roll dice; Pass and accumulate; Roll again. If a one is rolled, the total for that 'hand,' is lost. If a pair of one's are rolled then all of the roller's score is lost and reset to zero. First to total wins. It is spaghetti and has line numbers.

If anyone is interested I will post the listing. If not, no big deal... Just thought I would mention it...

J

[bplus]

Yeah, Johnno, I was reading the Wiki for Pig Game: https://en.wikipedia.org/wiki/Pig_(dice_game)
and I wouldn't mind exploring variations of the game.

So if you need help removing spaghetti, I will butcher your pig. ;)

I was thinking of hamming it up with a variation to the multi-di game where you choose in advance the amount of dice, but 1 Ace you score nothing, 2 Ace's you loose your whole score 3 Ace's and your game is over! What do you think?

[johnno56]

bplus,

As per your request.

Code: QB64: [Select]

1. '                   GROAN
2. '   (c) 1979 by Phil Feldman and Tom Rugg
3. '
4. 120 RANDOMIZE TIMER: DEFINT W: DIM SHARED Z
5. 140 B$ = CHR$(219): C$ = CHR$(254): L$ = CHR$(220): M$ = "="
6. 150 U$ = CHR$(223): N$ = " ": F3$ = B$ + STRING$(40, "=") + B$
7. 160 D1$ = B$ + STRING$(7, 223) + B$: D2$ = B$ + STRING$(7, 32) + B$
8. 170 D3$ = B$ + STRING$(7, 220) + B$: E1$ = STRING$(4, 32) + L$ + M$ + L$ + STRING$(4, 32)
9. 180 E2$ = N$ + L$ + M$ + U$ + N$ + N$ + N$ + U$ + M$ + L$ + N$: E3$ = U$ + M$ + L$ + STRING$(5, 32) + L$ + M$ + U$
10. 185 E4$ = N$ + N$ + N$ + U$ + M$ + L$ + M$ + U$ + N$ + N$ + N$
11. 190 F1$ = B$ + STRING$(40, 223) + B$: F2$ = B$ + STRING$(40, 220) + B$
12. 200 CLS: PRINT TAB(25); "G R O A N"
13. 210 PRINT "HOW MUCH NEEDED TO WIN"
14. 220 INPUT "(BETWEEN 50-100 IS BEST) "; W: IF W <= 0 THEN GOTO 200
15. 230 PRINT: PRINT "LET'S TOSS FOR FIRST ROLL": GOSUB 830
16. 240 PRINT: PRINT "THE COIN IS IN THE AIR AND"
17. 250 Q$ = "YOU": Q = INT(RND * 2) + 1: IF Q = 2 THEN Q$ = "I"
18. 260 PRINT TAB(8);: FOR J = 1 TO 5: PRINT ". ";: GOSUB 830: NEXT
19.  
20.  
21. 270 PRINT Q$; " GET FIRST ROLL": GOSUB 840: T = 0: IF Q = 2 THEN GOTO 400
22. 300 P$ = " YOU": CLS: PRINT TAB(25); "YOU'RE ROLLING": GOSUB 830: GOSUB 500
23. 310 T = T + R1 + R2: IF F > 0 THEN T = 0
24. 320 IF F = 2 THEN H = 0
25. 330 GOSUB 850: IF F > 0 THEN PRINT "DICE PASS TO ME": GOSUB 840: GOTO 400
26. 340 PRINT "(P=PASS DICE - R=ROLL AGAIN)": PRINT "YOUR CHOICE (P OR R) ?"
27. 350 Q$ = INKEY$: Q$ = UCASE$(Q$): IF Q$ = "" THEN GOTO 350
28. 360 IF Q$ = "R" THEN GOTO 300
29. 370 IF Q$ <> "P" THEN GOTO 350
30. 380 PRINT: H = H + T: IF H >= W THEN GOTO 970
31. 390 T = 0: F = 1: CLS: GOTO 330
32. 400 T = 0: P$ = "I"
33. 410 CLS: PRINT TAB(26); "I'M ROLLING": GOSUB 830: GOSUB 500
34. 420 T = T + R1 + R2: IF F > 0 THEN T = 0
35. 430 IF F = 2 THEN P = 0
36. 440 GOSUB 850: IF F > 0 THEN PRINT "DICE PASS TO YOU": GOSUB 840: T = 0: GOTO 300
37. 450 GOSUB 1000: IF X = 1 THEN PRINT "I'LL ROLL AGAIN": GOSUB 840: GOTO 410
38. 460 PRINT "I'LL STOP WITH THIS": GOSUB 830: P = P + T: IF P >= W THEN GOTO 970
39. 470 PRINT: PRINT "DICE PASS TO YOU": T = 0: GOSUB 840: GOTO 300
40. 500 D = 266: R1 = INT(RND * 6) + 1: R2 = INT(RND * 6) + 1: GOTO 540
41. 530 C = D + K: GOSUB 650: C = C + 384: GOSUB 650: GOSUB 600: CLS
42. 535 GOSUB 660: C = C - 384: GOSUB 660: GOSUB 600: CLS
43. 540 C = D + 48: GOSUB 650: C = C + 384: GOSUB 650
44. 550 C = D + 48: R = R1: GOSUB 700
45. 560 C = C + 384: R = R2: GOSUB 700: F = 0: IF R1 = 1 THEN F = 1: GOSUB 800
46. 570 IF R2 = 1 THEN F = F + 1: GOSUB 810
47. 580 IF F = 2 THEN GOSUB 820: GOSUB 830
48. 590 RETURN
49. 600 FOR J = 1 TO DL: NEXT: RETURN
50. 650 PRINTAT C - 136: PRINT D1$: PRINTAT C - 72: PRINT D2$: PRINTAT C - 8: PRINT D3$: RETURN
51. 660 PRINTAT C - 192: PRINT E1$: PRINTAT C - 133: PRINT E2$: PRINTAT C - 69: PRINT E3$
52. 670 PRINTAT C - 5: PRINT E4$: RETURN
53. 700 ON R GOSUB 710, 730, 740, 750, 760, 770: RETURN
54. 710 PRINTAT C - 134: PRINT C$;: PRINTAT C - 130: PRINT C$;: PRINTAT C - 68: PRINT "(";: PRINTAT C - 6: PRINT "/";
55.  
56. 720 FOR Q = 3 TO 5: PRINTAT C - Q: PRINT C$;: NEXT: PRINTAT C - 2: PRINT "\";: RETURN
57. 730 PRINTAT C - 134: PRINT C$;: PRINTAT C - 2: PRINT C$;: RETURN
58. 740 PRINTAT C - 68: PRINT "=";: GOSUB 730: RETURN
59. 750 PRINTAT C - 130: PRINT C$;: PRINTAT C - 6: PRINT C$: GOSUB 730: RETURN
60. 760 GOSUB 740: GOSUB 750: RETURN
61. 770 PRINTAT C - 70: PRINT "=";: PRINTAT C - 66: PRINT "=";: GOSUB 750: RETURN
62. 800 PRINTAT 52: PRINT "GROAN";: RETURN
63. 810 PRINTAT 820: PRINT "GROAN";: RETURN
64. 820 PRINTAT 434: PRINT "-DESPAIR-";: RETURN
65. 830 _DELAY 2: RETURN
66. 840 _DELAY 3: RETURN
67. 850 PRINTAT 64: PRINT F1$;: G = 128: GOSUB 960: PRINTAT 135: PRINT "- - S C O R E B O A R D - -";
68. 860 PRINTAT 192: PRINT F3$;: G = 256: GOSUB 960: PRINTAT 264: PRINT W; "POINTS NEEDED TO WIN";
69. 870 PRINTAT 320: PRINT F3$;: G = 384: GOSUB 960
70. 880 PRINTAT 386: PRINT "   POINTS SCORED         YOU     ME";: G = 448
71. 890 GOSUB 960: PRINTAT 450: PRINT "BEFORE THIS SERIES";: PRINTAT 475: PRINT H;
72. 900 PRINTAT 482: PRINT P;: PRINTAT 512: PRINT F3$;: G = 576: GOSUB 960
73. 910 PRINTAT 582: PRINT P$; " HAVE"; T; "POINTS THIS SERIES";
74. 920 PRINTAT 640: PRINT F2$;: PRINTAT 768: PRINT "";: RETURN
75. 960 PRINTAT G: PRINT B$;: PRINTAT G + 41: PRINT B$;: RETURN
76. 970 T = 0: CLS: GOSUB 850: IF P >= W THEN PRINTAT 768: PRINT "SKILL WINS AGAIN"
77. 980 IF H >= W THEN PRINTAT 768: PRINT "YOU WIN - IT WAS SHEER LUCK!"
78. 990 END
79. 1000 V = P + T: IF V >= W THEN GOTO 1100
80. 1010 IF (W - H) < 10 THEN GOTO 1110
81. 1020 IF P >= H THEN L = T / 25: GOTO 1050
82. 1030 IF V < H THEN L = T / 35: GOTO 1050
83. 1040 L = T / 30
84. 1050 IF RND > L THEN GOTO 1110
85. 1100 X = 0: RETURN
86. 1110 X = 1: RETURN
87.  
88. SUB PRINTAT (Z)
89.     LOCATE INT(Z / 64) + 1, (Z MOD 64 + 1)
90. END SUB
91.  

As you are probably aware, TRS80 uses 'print@ x' to position the text on the screen, so I have added a subroutine to simulate the command. The graphics are ugly because I cannot duplicate the TRS80 character set. If you can 'de-spaghetti' the listing that would be great. Demonstrating how you do that would be even better. That way, eventually, I will not have to pester you (or others) to do it for me... Nudge. Nudge. Wink. Wink. Say no more...

Happy butchering... lol

ps:  I have a PDF copy of the book this program came from. If you are interested, let me know, and I will post it...

[bplus]

Hi Johnno,

Oh so you want me to fix this thing? Are those two things on the right suppose to be dice?

I think this code is purposely designed to demonstrate the worst of spaghetti. I mean who would in their right mind would call a gosub to do one freakin line of code?

Code: QB64: [Select]

1. 1100 X = 0: RETURN
2. 1110 X = 1: RETURN

The quickest way to fix this code is to scrap it and start over using variables and subs that are descriptive.

Johnno break this game down into steps. Get the essence of the game working and then refine adding bells and whistles.
 
OK here is 2 dice Pig game:

Code: QB64: [Select]

1. _TITLE "Pig with 2 Dice" 'get Johnno setup with 2 di version of Pig B+ started 2018-10-19
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         d1 = INT(RND * 6) + 1: d2 = INT(RND * 6) + 1
8.         PRINT CHR$(10) + "The dice are:"; d1; "and"; d2
9.         IF d1 = 1 OR d2 = 1 THEN
10.             PRINT Who$ + " rolled a 1, the turn is over, press enter...";
11.             INPUT "", wate$
12.             EXIT FOR
13.         ELSE
14.             accum = accum + d1 + d2
15.             PRINT Who$ + " accumulated total is" + STR$(accum)
16.             IF Who$ = "Player" THEN
17.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
18.                 IF choice$ <> "r" THEN player = player + accum
19.                 IF choice$ <> "r" THEN EXIT FOR
20.             ELSE
21.                 IF i < 3 AND accum + AI < 100 THEN
22.                     INPUT "AI is rolling again, press enter... ", wate$
23.                 ELSE
24.                     AI = AI + accum
25.                     INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
26.                     EXIT FOR
27.                 END IF
28.             END IF
29.         END IF
30.     NEXT
31.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
32. WEND
33. PRINT Who$; " wins!"
34.  

If you want to see dice and nice scoreboard be my guest! :)

[johnno56]

I am not 'expecting' you to fix it... lol  A refresher: I 'did' use the conditional statement, "IF you can..."  The choice is yours... I can, and prefer to use, subs or functions but as I have stated in the past, I struggle with 'gotos' particularly when jumping out of "if...then's"

I have a 'list' of 'main routines' (as laid out in the book) and will try my best to convert. You are correct when it comes to refining the 'working' of the game 'before' adding the 'bells and whistles'.

The "right mind" gosub incorporates line numbers 1000-1110 and is only called when the computer rolls in line number 450.

Yep. "Those two things" are indeed meant to be dice... TRS80 'graphics', as you are probably familiar with, are 2 by 3 'blocks'. The current dice conversion are made by using the closest extended character set as possible (in my opinion...) and hence the "ugly". I know there are better ways but will leave that until I have finished my attempt at converting... (in the book... the dice roll is animated across an empty screen - the option to omit the roll is included in the book... Maybe it will be added in the updated version? (fingers crossed)...)

I am SO used to 'line numbers' (and that kind of thinking) that I find it difficult to convert it to something more structured like QB64, Naalaa and SDLBasic... So I don't 'normally' opt for converting unless there are no goto's... lol  (old dogs: new tricks) That doesn't mean I'm not keen to change... For me change is not so easy... but I try...

I will break it down as you suggest and go from there... Do not hold your breath waiting... lol

Thanks for the advise.

J