Need basic help (pun intended)

[thelowerrhythm]

Beginner here, messing around with this simple sequencer. I first posted about not being able to get the sound to stop at the end (after key press), and I *sort of* figured that out. However, it only works when the cycle rate (variable R) is high (slow) enough. For example, it works as intended when cycle rate is 8, but not when .1.

Code: QB64: [Select]

1.  
2. CLEAR
3. SCREEN 8
4. 1 CLS
5. COLOR 10, 0
6. 2 PRINT "±±±±± ²²²²²² °°°°°°"
7. 3 PRINT "±     ²    ² °"
8. 4 PRINT "±±±±± ²    ² °°°°°°"
9. 5 PRINT "    ± ²  ² ²      °"
10. 6 PRINT "±±±±± ²²²²²² °°°°°°"
11. COLOR 11, 0
12. PRINT ""
13. PRINT "8 step waveform generator for toned sequences"
14. PRINT "or drones at faster speeds (lower cycle)."
15. PRINT ""
16. PRINT "Input frequencies in Hz from 40 - 16000."
17. PRINT ""
18. PRINT "Press any key to stop sequence."
19. COLOR 1, 0
20. PRINT ""
21. 7 INPUT "FREQ A: ", S1
22. 8 IF S1 < 40 OR S1 > 16000 THEN GOTO 4
23. COLOR 2, 0
24. 10 INPUT "FREQ B: ", S2
25.  
26. 11 IF S2 < 40 OR S2 > 16000 THEN GOTO 10
27. COLOR 3, 0
28. 16 INPUT "FREQ C: ", S3
29. 17 IF S3 < 40 OR S3 > 16000 THEN GOTO 16
30. COLOR 4, 0
31. 22 INPUT "FREQ D: ", S4
32. 23 IF S4 < 40 OR S4 > 16000 THEN GOTO 22
33. COLOR 5, 0
34. 28 INPUT "FREQ E: ", S5
35. 29 IF S5 < 40 OR S5 > 16000 THEN GOTO 28
36. COLOR 6, 0
37. 32 INPUT "FREQ F: ", S6
38. 33 IF S6 < 40 OR S6 > 16000 THEN GOTO 32
39. COLOR 7, 0
40. 36 INPUT "FREQ G: ", S7
41. 37 IF S7 < 40 OR S7 > 16000 THEN GOTO 36
42. COLOR 8, 0
43. 39 INPUT "FREQ H: ", S8
44. 41 IF S8 < 40 OR S8 > 16000 THEN GOTO 39
45. COLOR 9, 0
46. INPUT "CYCLE RATE(.023+): ", R
47. DO
48.     LET k$ = INKEY$
49.     SOUND S1, R
50.     COLOR 1, 0
51.     PRINT "Generating Tone A"
52.     SOUND S2, R
53.     COLOR 2, 0
54.     PRINT "Generating Tone B"
55.     SOUND S3, R
56.     COLOR 3, 0
57.     PRINT "Generating Tone C"
58.     SOUND S4, R
59.     COLOR 4, 0
60.     PRINT "Generating Tone D"
61.     SOUND S5, R
62.     COLOR 5, 0
63.     PRINT "Generating Tone E"
64.     SOUND S6, R
65.     COLOR 6, 0
66.     PRINT "Generating Tone F"
67.     SOUND S7, R
68.     COLOR 7, 0
69.     PRINT "Generating Tone G"
70.     SOUND S8, R
71.     COLOR 8, 0
72.     PRINT "Generating Tone H"
73.  
74. LOOP UNTIL k$ <> ""
75. X = 1
76. IF X = 1 THEN SOUND 0, 0
77. INPUT "Enter Q / q to EXIT, anything else to RESTART: ", I$
78. SELECT CASE I$
79.     CASE "Q"
80.         GOTO 666
81.     CASE "q"
82.         GOTO 666
83. END SELECT
84. CLEAR
85. GOTO 1
86.  
87. 666 END
88.  
89.  
90.  
91.  
92.  

[johnno56]

I am no musician or an expert in using QB64, but my first guesses would be... Your DO..LOOP is continuously queuing sound commands and when you press a key, "Hey! Get to the end of the queue."  and when the sounds are finished playing, the loop ends. That's what happened on my machine. As to a solution... I may not be the best choice to ask... No. That's not correct. I 'am not' the best person to ask.

Here is a link to Terry's "simple" piano... (I would hate to see a complicated one... lol) https://www.qb64.org/forum/index.php?topic=2537.msg117793#msg117793

Based on Terry's experience with sound, I would point you in his direction... I apologise for not be able to be of help.

[thelowerrhythm]

I'm nowhere even near being a novice, so there's that. It's doing what it is supposed to do for you, but it only happens for me at higher cycle rates (=slower sequences). When it's sped up a keypress doesn't end the sound, and when the software restarts its still playing. Not sure why the different cycle speeds would make a difference. Maybe when it's going really fast it isn't pausing to see if its supposed to stop? I don't even know if that makes sense.

[TempodiBasic]

Hi thelowerrhythm

please say me
1. why do you like spaghetti code versus modular code?
2. do you try to make a flowchart or mindmap of your code to follow the flow? at a first rapid look it seems that you make a chain of SOUNDs statements so you can stop sound at the end of the chain....
3. if you like use the SOUND keyword, have you seen the difference between QB and QB64? https://www.qb64.org/wiki/index.php/SOUND

Good Coding

[bplus]

Hi thelowerrhythm

please say me
1. why do you like spaghetti code versus modular code?
2. do you try to make a flowchart or mindmap of your code to follow the flow? at a first rapid look it seems that you make a chain of SOUNDs statements so you can stop sound at the end of the chain....
3. if you like use the SOUND keyword, have you seen the difference between QB and QB64? https://www.qb64.org/wiki/index.php/SOUND

Good Coding

I thought spaghetti too but he is just checking each input before moving to next, not so bad.

Yeah wiki says sound duration is in units of 1/18 of sec as I understood it. So why .023 as lowest accepted, shouldn't it be 1 as Sound cant do any less?

Could put pauses between sounds to hear what is what.

For all this:

Code: QB64: [Select]

1. INPUT "Enter Q / q to EXIT, anything else to RESTART: ", I$
2. SELECT CASE I$
3.     CASE "Q"
4.         GOTO 666
5.     CASE "q"
6.         GOTO 666
7. END SELECT
8. CLEAR
9. GOTO 1
10.  
11. 666 END
12.  

2 lines:

Code: QB64: [Select]

1. INPUT "Enter Q / q to EXIT, anything else to RESTART: ", I$
2. IF UCASE$(I$) = "Q" THEN END ELSE GOTO 1
3.  

But then you cant say GOTO 666 (twice!)  ;-))

[Petr]

Try this:

Maybe you ask: Why SOUND output is different than _SNDRAW? Its, because SOUND create stereo output but SNDRAW contains stereo bug.

Now is possible using sound lenght less than 1.

Code: QB64: [Select]

1.  
2. CLEAR
3. SCREEN 8
4. 1 CLS
5. COLOR 10, 0
6. 2 PRINT "±±±±± 222222 °°°°°°"
7. 3 PRINT "±     2    2 °"
8. 4 PRINT "±±±±± 2    2 °°°°°°"
9. 5 PRINT "    ± 2  2 2      °"
10. 6 PRINT "±±±±± 222222 °°°°°°"
11. COLOR 11, 0
12. PRINT ""
13. PRINT "8 step waveform generator for toned sequences"
14. PRINT "or drones at faster speeds (lower cycle)."
15. PRINT ""
16. PRINT "Input frequencies in Hz from 40 - 16000."
17. PRINT ""
18. PRINT "Press any key to stop sequence."
19. COLOR 1, 0
20. PRINT ""
21. 7 INPUT "FREQ A: ", S1
22. 8 IF S1 < 40 OR S1 > 16000 THEN GOTO 4
23. COLOR 2, 0
24. 10 INPUT "FREQ B: ", S2
25.  
26. 11 IF S2 < 40 OR S2 > 16000 THEN GOTO 10
27. COLOR 3, 0
28. 16 INPUT "FREQ C: ", S3
29. 17 IF S3 < 40 OR S3 > 16000 THEN GOTO 16
30. COLOR 4, 0
31. 22 INPUT "FREQ D: ", S4
32. 23 IF S4 < 40 OR S4 > 16000 THEN GOTO 22
33. COLOR 5, 0
34. 28 INPUT "FREQ E: ", S5
35. 29 IF S5 < 40 OR S5 > 16000 THEN GOTO 28
36. COLOR 6, 0
37. 32 INPUT "FREQ F: ", S6
38. 33 IF S6 < 40 OR S6 > 16000 THEN GOTO 32
39. COLOR 7, 0
40. 36 INPUT "FREQ G: ", S7
41. 37 IF S7 < 40 OR S7 > 16000 THEN GOTO 36
42. COLOR 8, 0
43. 39 INPUT "FREQ H: ", S8
44. 41 IF S8 < 40 OR S8 > 16000 THEN GOTO 39
45. COLOR 9, 0
46. INPUT "CYCLE RATE(.023+): ", R
47. DO
48.     LET k$ = INKEY$
49.     SOUND2 S1, R
50.     COLOR 1, 0
51.     PRINT "Generating Tone A"
52.     SOUND2 S2, R
53.     COLOR 2, 0
54.     PRINT "Generating Tone B"
55.     SOUND2 S3, R
56.     COLOR 3, 0
57.     PRINT "Generating Tone C"
58.     SOUND2 S4, R
59.     COLOR 4, 0
60.     PRINT "Generating Tone D"
61.     SOUND2 S5, R
62.     COLOR 5, 0
63.     PRINT "Generating Tone E"
64.     SOUND2 S6, R
65.     COLOR 6, 0
66.     PRINT "Generating Tone F"
67.     SOUND2 S7, R
68.     COLOR 7, 0
69.     PRINT "Generating Tone G"
70.     SOUND2 S8, R
71.     COLOR 8, 0
72.     PRINT "Generating Tone H"
73.  
74. LOOP UNTIL k$ <> ""
75. X = 1
76. IF X = 1 THEN SOUND 0, 0
77. INPUT "Enter Q / q to EXIT, anything else to RESTART: ", I$
78. SELECT CASE I$
79.     CASE "Q"
80.         GOTO 666
81.     CASE "q"
82.         GOTO 666
83. END SELECT
84. CLEAR
85. GOTO 1
86.  
87. 666 END
88.  
89.  
90.  
91.  
92. SUB SOUND2 (frequency AS INTEGER, lenght AS SINGLE)
93.     STATIC u
94.     l = lenght / 18
95.     samples = _SNDRATE * l
96.     s = _PI / (_SNDRATE / frequency) * 2
97.  
98.     DO UNTIL plsam >= samples
99.         _SNDRAW SIN(u) * .8, SIN(u) * .8
100.         u = u + s
101.         IF ABS(s) >= _SNDRATE / frequency THEN s = s * -1
102.         plsam = plsam + 1
103.     LOOP
104.     DO UNTIL _SNDRAWLEN = 0: LOOP 'comment this row and play in background. BUT, if you call often SNDRAW, is this very memory offensive, therefore is very recomended controlling SNDRAW cache using SNDRAWLEN!
105.    END SUB
106.  

[TempodiBasic]

@bplus

I thought spaghetti too but he is just checking each input before moving to next, not so bad.

yes so I like SOS trough the lines 6-10

1. but also if thelowerrhythm uses finely the GOTO to creates loops that control data input he has put a first error with GOTO 4 that must be converted into GOTO 1  at first control of input data.

Code: QB64: [Select]

1. 4 PRINT "±±±±± 2    2 °°°°°°"
2. 5 PRINT "    ± 2  2 2      °"
3. 6 PRINT "±±±±± 222222 °°°°°°"
4. COLOR 11, 0
5. PRINT ""
6. PRINT "8 step waveform generator for toned sequences"
7. PRINT "or drones at faster speeds (lower cycle)."
8. PRINT ""
9. PRINT "Input frequencies in Hz from 40 - 16000."
10. PRINT ""
11. PRINT "Press any key to stop sequence."
12. COLOR 1, 0
13. PRINT ""
14. 7 INPUT "FREQ A: ", S1
15. 8 IF S1 < 40 OR S1 > 16000 THEN GOTO 4

2. But the user cannot stop the cycle of input data... better to use a default value if user mystype the value...
I hate how INPUT going to head of line letting shift to up the screen output

Code: QB64: [Select]

1. 10 INPUT "FREQ B: ", S2
2.  IF S2 = 0 then S2 = 40
3. 11 IF S2 < 40 OR S2 > 16000 THEN GOTO 10

3. the single chain of sounds (sound S1, R....sound R8,R) in the loop  cannot be interrupted!

Code: QB64: [Select]

1. DO
2.     LET k$ = INKEY$
3.     SOUND S1, R
4.     COLOR 1, 0
5.     PRINT "Generating Tone A"
6.     SOUND S2, R
7.     COLOR 2, 0
8.     PRINT "Generating Tone B"
9.     SOUND S3, R
10.     COLOR 3, 0
11.     PRINT "Generating Tone C"
12.     SOUND S4, R
13.     COLOR 4, 0
14.     PRINT "Generating Tone D"
15.     SOUND S5, R
16.     COLOR 5, 0
17.     PRINT "Generating Tone E"
18.     SOUND S6, R
19.     COLOR 6, 0
20.     PRINT "Generating Tone F"
21.     SOUND S7, R
22.     COLOR 7, 0
23.     PRINT "Generating Tone G"
24.     SOUND S8, R
25.     COLOR 8, 0
26.     PRINT "Generating Tone H"
27.  
28. LOOP UNTIL k$ <> ""
29.  

4. pressing a key the sound doesn't stop until the buffer of sound becomes void
in my MOD it is possible if  SOUND 0,0 would work fine.
5. all sounds have the same duration of time, so little variation of sound generated

6. what is it?

Code: QB64: [Select]

1. X = 1
2. IF X = 1 THEN SOUND 0, 0

it seems this

Code: QB64: [Select]

1. SOUND 0,0

.... so here my version of this spaghetti program.

Code: QB64: [Select]

1. CLEAR
2. SCREEN 8
3. DIM S(1 TO 8) AS INTEGER
4. NameTone$ = "ABCDEFGH"
5. FOR a = 1 TO 8 STEP 1
6.    1 CLS
7.     COLOR 10, 0
8.    2 PRINT "±±±±± ²²²²²² °°°°°°"
9.    3 PRINT "±     ²    ² °"
10.    4 PRINT "±±±±± ²    ² °°°°°°"
11.    5 PRINT "    ± ²  ² ²      °"
12.    6 PRINT "±±±±± ²²²²²² °°°°°°"
13.     COLOR 11, 0
14.     PRINT ""
15.     PRINT "8 step waveform generator for toned sequences"
16.     PRINT "or drones at faster speeds (lower cycle)."
17.     PRINT ""
18.     PRINT "Input frequencies in Hz from 40 - 16000."
19.     PRINT ""
20.     PRINT "Press any key to stop sequence."
21.     COLOR a, 0
22.     PRINT ""
23.    7 PRINT "FREQ " + MID$(NameTone$, a, 1) + " : ";: INPUT S(a)
24.     IF S(a) = 0 THEN S(a) = 40 ' user press Enter to use default value
25.    8 IF S(a) < 40 OR S(a) > 16000 THEN GOTO 1
26. NEXT a
27. COLOR 9, 0
28. INPUT "CYCLE RATE(.023+): ", R
29. FOR a = 1 TO 8 STEP 1
30.     LET k$ = INKEY$
31.     SOUND S(a), R
32.     COLOR a, 0
33.     PRINT "Generating Tone " + MID$(NameTone$, a, 1)
34.     IF a = 8 THEN a = 1 'infinite loop
35.     IF k$ <> "" THEN EXIT FOR
36. NEXT a
37. SOUND 0, 0 ' this statement doesn't work
38. INPUT "Enter Q / q to EXIT, anything else to RESTART: ", I$
39. IF LCASE$(I$) = "q" THEN CLEAR: END ELSE GOTO 1
40.  

Enjoy Coding Basic

[bplus]

@TempodiBasic again an admirable amount of detail analysis but some of your changes strike me as odd too. For instance:

Code: QB64: [Select]

1.    
2.    IF S(a) = 0 THEN S(a) = 40 ' user press Enter to use default value
3.   8 IF S(a) < 40 OR S(a) > 16000 THEN GOTO 1

I think it cruel and unusual punishment to redo all inputs if you make a mistake with one.
Oh wait, I confused line 1 in qb64 code and line 1 in GOTO code, you only go back to just after start of loop.
OK bad example, (mostly... ;)
I do like how you made half a dozen plus variables into one array, no, I love that!

OK what about this line:

Code: QB64: [Select]

1. SOUND 0, 0 ' this statement doesn't work

Why put it in when you know it doesn't work?

Oh well practice makes perfect.

B+ to both of you :)

Oh I just figured out SOS dahhh... cant see the forest for the trees. bplus getting old, no I never ran the dang code! ;-))

[bplus]

@Petr  your reply #5 sounds great and looks like drawing keeps going with sound, nice one!

[TempodiBasic]

Hi Bplus
glad to enjoy you.
but do you must think that this is my spaghetti code... not a modular code :-))
all changes are to shrink the number of line not to save RAM or modularity
I thank you for feedback, so with practice I can improve my coding.

@Petr
great new _SOUND function for QB64  with a third parameter optional "_DONTWAIT" while in default it is _WAIT

this is your prototype at my eyes

Code: QB64: [Select]

1. CONST P_WAIT = -1 , P_DONTWAIT = 0
2. SUB SOUND2 (frequency AS INTEGER, lenght AS SINGLE, PWait AS INTEGER)
3.     STATIC u
4.     l = lenght / 18
5.     samples = _SNDRATE * l
6.     s = _PI / (_SNDRATE / frequency) * 2
7.  
8.     DO UNTIL plsam >= samples
9.         _SNDRAW SIN(u) * .8, SIN(u) * .8
10.         u = u + s
11.         IF ABS(s) >= _SNDRATE / frequency THEN s = s * -1
12.         plsam = plsam + 1
13.     LOOP
14.  if PWait then   DO UNTIL _SNDRAWLEN = 0: LOOP 'comment this row and play in background. BUT, if you call often SNDRAW, is this very memory offensive, therefore is very recomended controlling SNDRAW cache using SNDRAWLEN!
15. END SUB
16.  

here in the original spaghetti code

Code: QB64: [Select]

1. CONST P_WAIT = -1, P_DONTWAIT = 0
2.  
3. CLEAR
4. SCREEN 8
5. 1 CLS
6. COLOR 10, 0
7. 2 PRINT "±±±±± 222222 °°°°°°"
8. 3 PRINT "±     2    2 °"
9. 4 PRINT "±±±±± 2    2 °°°°°°"
10. 5 PRINT "    ± 2  2 2      °"
11. 6 PRINT "±±±±± 222222 °°°°°°"
12. COLOR 11, 0
13. PRINT ""
14. PRINT "8 step waveform generator for toned sequences"
15. PRINT "or drones at faster speeds (lower cycle)."
16. PRINT ""
17. PRINT "Input frequencies in Hz from 40 - 16000."
18. PRINT ""
19. PRINT "Press any key to stop sequence."
20. COLOR 1, 0
21. PRINT ""
22. 7 INPUT "FREQ A: ", S1
23. 8 IF S1 < 40 OR S1 > 16000 THEN GOTO 4
24. COLOR 2, 0
25. 10 INPUT "FREQ B: ", S2
26.  
27. 11 IF S2 < 40 OR S2 > 16000 THEN GOTO 10
28. COLOR 3, 0
29. 16 INPUT "FREQ C: ", S3
30. 17 IF S3 < 40 OR S3 > 16000 THEN GOTO 16
31. COLOR 4, 0
32. 22 INPUT "FREQ D: ", S4
33. 23 IF S4 < 40 OR S4 > 16000 THEN GOTO 22
34. COLOR 5, 0
35. 28 INPUT "FREQ E: ", S5
36. 29 IF S5 < 40 OR S5 > 16000 THEN GOTO 28
37. COLOR 6, 0
38. 32 INPUT "FREQ F: ", S6
39. 33 IF S6 < 40 OR S6 > 16000 THEN GOTO 32
40. COLOR 7, 0
41. 36 INPUT "FREQ G: ", S7
42. 37 IF S7 < 40 OR S7 > 16000 THEN GOTO 36
43. COLOR 8, 0
44. 39 INPUT "FREQ H: ", S8
45. 41 IF S8 < 40 OR S8 > 16000 THEN GOTO 39
46. COLOR 9, 0
47. INPUT "CYCLE RATE(.023+): ", R
48. DO
49.     LET k$ = INKEY$
50.     SOUND2 S1, R, P_DONTWAIT
51.     COLOR 1, 0
52.     PRINT "Generating Tone A"
53.     SOUND2 S2, R, P_WAIT
54.     COLOR 2, 0
55.     PRINT "Generating Tone B"
56.     SOUND2 S3, R, P_DONTWAIT
57.     COLOR 3, 0
58.     PRINT "Generating Tone C"
59.     SOUND2 S4, R, P_WAIT
60.     COLOR 4, 0
61.     PRINT "Generating Tone D"
62.     SOUND2 S5, R, P_DONTWAIT
63.     COLOR 5, 0
64.     PRINT "Generating Tone E"
65.     SOUND2 S6, R, P_WAIT
66.     COLOR 6, 0
67.     PRINT "Generating Tone F"
68.     SOUND2 S7, R, P_DONTWAIT
69.     COLOR 7, 0
70.     PRINT "Generating Tone G"
71.     SOUND2 S8, R, P_WAIT
72.     COLOR 8, 0
73.     PRINT "Generating Tone H"
74.  
75. LOOP UNTIL k$ <> ""
76. X = 1
77. IF X = 1 THEN SOUND 0, 0
78. INPUT "Enter Q / q to EXIT, anything else to RESTART: ", I$
79. SELECT CASE I$
80.     CASE "Q"
81.         GOTO 666
82.     CASE "q"
83.         GOTO 666
84. END SELECT
85. CLEAR
86. GOTO 1
87.  
88. 666 END
89.  
90.  
91.  
92.  
93. SUB SOUND2 (frequency AS INTEGER, lenght AS SINGLE, PWait AS INTEGER)
94.     STATIC u
95.     l = lenght / 18
96.     samples = _SNDRATE * l
97.     s = _PI / (_SNDRATE / frequency) * 2
98.  
99.     DO UNTIL plsam >= samples
100.         _SNDRAW SIN(u) * .8, SIN(u) * .8
101.         u = u + s
102.         IF ABS(s) >= _SNDRATE / frequency THEN s = s * -1
103.         plsam = plsam + 1
104.     LOOP
105.     IF PWait THEN DO UNTIL _SNDRAWLEN = 0: LOOP 'comment this row and play in background. BUT, if you call often SNDRAW, is this very memory offensive, therefore is very recomended controlling SNDRAW cache using SNDRAWLEN!
106. END SUB
107.  

[TempodiBasic]

@bplus
nothing is perfect but all is perfectable...

about

OK what about this line:
Code: QB64: [Select]
SOUND 0, 0 ' this statement doesn't work
Why put it in when you know it doesn't work?

it is just to note that for a major backward compatibility to  QBasic this point can be adjusted....
so I imagine that someone with C/C++ knowledge not so dusted like mine must open the box of SOUND and see what it can do...
Do who gives me a SVITOL https://cdn.manomano.com/sbloccante-spray-svitol-P-7201249-13997303_1.jpg or WD40 https://it.rs-online.com/web/p/lubrificanti/1247168?cm_mmc=IT-PLA-DS3A-_-google-_-PLA_IT_IT_Pulizia_e_manutenzione_Whoop-_-(IT:Whoop!)+Lubrificanti-_-1247168&matchtype=&pla-333453465826&gclid=CjwKCAjw5vz2BRAtEiwAbcVIL5-Z65gZPbkrVjPGJbFI4I-ABihHCHsBkFZcPY5E37rduthnX_jNBBoCDWcQAvD_BwE&gclsrc=aw.dsfor my C/C++?

[bplus]

LOL well I know WD40 works great on locks, never knew about C/C++ code.

Since started study of sound in this thread, I tried an app experimenting with spacing sound out, see SOS program here: https://www.qb64.org/forum/index.php?topic=2692.0

As important as frequency and duration is to sound, so is the spacing between SOUNDs, might try making a tool that includes spacing with the 2 given parameters.