Author Topic: Highlight% changes by itself (Read 10229 times)

Jaze · « **on:** April 11, 2022, 01:34:56 pm »

I often make a DO LOOP with an INKEY$ to access the string values of the arrow keys. Out of probably 25 times writing a loop similar to this one, this is the second time I could not use my HaltAndDisplay% bool to stop the flicker.
On line 56, the Highlight% rapidly changes between positive and negative integers of about 3 to 5 digits. From what I can see in the code I've written, Highlight% shouldn't change until
one of the SHARED ArrowKey$ Values has been detected. I'd be grateful to anyone who can't point out my error

Code: QB64: [Select]

 
_TITLE "Time Calculator"
 
CONST TRUE% = 1
CONST FALSE% = -1
DIM SHARED LeftArrowKey$: LeftArrowKey$ = CHR$(0) + "K"
DIM SHARED RightArroeKey$: rightArrowKey$ = CHR$(0) + "M"
DIM SHARED UpArrowKey$: UpArrowKey$ = CHR$(0) + "H"
DIM SHARED DownArrowKey$: DownArrowKey$ = CHR$(0) + "P"
CONST UpArrowHit% = 18432
CONST LeftArrowHit% = 19200
CONST RightArrowHit% = 19712
CONST DownArrowHit% = 20480
' for the highlighted option in the GetTimeAmount SUB
CONST YearsHO% = 1
CONST DaysHO% = 2
CONST HoursHO% = 3
CONST MinutesHO% = 4
CONST SecondsHO% = 5
 
WIDTH 80, 50
_FULLSCREEN
COLOR 14, 1: CLS
 
CALL Menu
 
SUB FromNowUntil
END SUB
 
SUB HowLongSince
END SUB
 
SUB WhatDateAfterElapsedTime
END SUB
 
SUB AddElapsedTimes
END SUB
 
SUB SubtractElapsedTimes
END SUB
 
SUB Multiply
END SUB
 
SUB Divide
END SUB
 
 
SUB Menu
  HaltAndDisplay% = 0: Highlight% = 0: yPos% = 0: UserCommand$ = "": A$ = ""
  xPos% = 0: MaxOption% = 0: SelectedAnOption% = 0
 
  HaltAndDisplay% = TRUE%: Highlight% = 1: yPos% = 13: MaxOption% = 8: SelectedAnOption% = FALSE%
  DO
    UserCommand$ = INKEY$
    LOCATE 45, 1: PRINT S$(Highlight%)
    LOCATE 46, 1: PRINT "|" + UserCommand$ + "|"
    IF HaltAndDisplay% = TRUE% THEN
      COLOR 14, 1: CLS
      A$ = "Time Calculator Menu": xPos% = Center(A$)
      LOCATE yPos%, Center(A$): PRINT A$: LOCATE yPos% + 1, Center(A$)
      PRINT "---- ---------- ----"
 
      A$ = "": A$ = "1.) Find How Long From Now"
      LOCATE yPos% + 3, Center(A$): IF Highlight% = 1 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
      A$ = "": A$ = "Until A Selected Time"
      LOCATE yPos% + 4, Center(A$): IF Highlight% = 1 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      A$ = "": A$ = "2.) Find How Long It Has Been Since"
      LOCATE yPos% + 6, Center(A$): IF highlighedoption% = 2 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
      A$ = "": A$ = "A Selected Time Has Passed"
      LOCATE yPos% + 7, Center(A$): IF Highlight% = 2 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      A$ = "": A$ = "3.) Find The Date And Time It Will Be After"
      LOCATE yPos% + 9, Center(A$): IF Highlight% = 3 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
      A$ = "": A$ = "A Selected Amount Of Time Has Passed"
      LOCATE yPos% + 10, Center(A$): IF Highlight% = 3 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      A$ = "": A$ = "4.) Add Two Elapsed Times"
      LOCATE yPos% + 12, Center(A$): IF Highlight% = 4 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      A$ = "": A$ = "5.) Subtract One Elapsed Time From Another One"
      LOCATE yPos% + 14, Center(A$): IF Highlight% = 5 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      A$ = "": A$ = "6.) Multiply An Elapsed Time By A Constant"
      LOCATE yPos% + 16, Center(A$): IF Highlight% = 6 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      A$ = "": A$ = "7.) Divide An Elapsed Time By A Constant"
      LOCATE yPos% + 18, Center(A$): IF Highlight% = 7 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      A$ = "": A$ = "8.) Exit"
      LOCATE 45, Center(A$): IF Highlight% = 8 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF: PRINT A$
 
      HaltAndDisplay% = FALSE%
    END IF
 
    SELECT CASE UserCommand$
      CASE UpArrowKey$, LeftArrowKey$
        Highlight% = highlightedoption - 1
        IF Highlight% = 0 THEN Highlight% = MaxOption%
        HaltAndDisplay% = TRUE%
      CASE DownArrowKey$, rightarrowkey$
        Highlight% = Highlight% + 1
        IF highlightedoption > maxoption THEN Highlight% = 1
        HaltAndDisplay% = TRUE%
      CASE CHR$(13)
        SelectedAnOption% = TRUE%
      CASE "1", "2", "3", "4", "5", "6", "7"
        Highlight% = VAL(UserCommand$)
        SelectedAnOption% = TRUE%
    END SELECT
    IF SelectedAnOption% = TRUE THEN
      SELECT CASE Highlight%
        CASE 1
          CALL FromNowUntil: SelectedAnOption% = FALSE%
        CASE 2
          CALL HowLongSince: SelectedAnOption% = FALSE%
        CASE 3
          CALL WhatDateAfterElapsedTime: SelectedAnOption% = FALSE%
        CASE 4
          CALL AddElapsedTimes: SelectedAnOption% = FALSE%
        CASE 5
          CALL SubtractElapsedTimes: SelectedAnOption% = FALSE%
        CASE 6
          CALL Multiply: SelectedAnOption% = FALSE%
        CASE 7
          CALL Divide: SelectedAnOption% = FALSE%
      END SELECT
    END IF
  LOOP UNTIL UserCommand$ = CHR$(27) OR UserCommand$ = S$(MaxOption%)
END SUB
 
 
 
 
 
FUNCTION Center% (Text$): Center% = INT((80 - LEN(Text$)) / 2): END FUNCTION
FUNCTION S$ (Number!): S$ = LTRIM$(STR$(Number!)): END FUNCTION
FUNCTION P$: pause$ = INPUT$(1): IF pause$ = CHR$(27) THEN END
P$ = pause$: END FUNCTION
 

bplus · « **Reply #1 on:** April 11, 2022, 01:50:20 pm »

I added _display and _limit to stop flicker.

Once you use _display, then you must say _display every time you want to show something immediatedly. To disable _display use _autodisplay and get default automatic "display". You could put that at the end of the sub before exiting. _display once in you main drawing loop is best.

Code: QB64: [Select]

 
_Title "Time Calculator"
 
Const TRUE% = 1
Const FALSE% = -1
Dim Shared LeftArrowKey$: LeftArrowKey$ = Chr$(0) + "K"
Dim Shared RightArroeKey$: rightArrowKey$ = Chr$(0) + "M"
Dim Shared UpArrowKey$: UpArrowKey$ = Chr$(0) + "H"
Dim Shared DownArrowKey$: DownArrowKey$ = Chr$(0) + "P"
Const UpArrowHit% = 18432
Const LeftArrowHit% = 19200
Const RightArrowHit% = 19712
Const DownArrowHit% = 20480
' for the highlighted option in the GetTimeAmount SUB
Const YearsHO% = 1
Const DaysHO% = 2
Const HoursHO% = 3
Const MinutesHO% = 4
Const SecondsHO% = 5
 
Width 80, 50
_FullScreen
Color 14, 1: Cls
 
Call Menu
 
Sub FromNowUntil
End Sub
 
Sub HowLongSince
End Sub
 
Sub WhatDateAfterElapsedTime
End Sub
 
Sub AddElapsedTimes
End Sub
 
Sub SubtractElapsedTimes
End Sub
 
Sub Multiply
End Sub
 
Sub Divide
End Sub
 
 
Sub Menu
    HaltAndDisplay% = 0: Highlight% = 0: yPos% = 0: UserCommand$ = "": A$ = ""
    xPos% = 0: MaxOption% = 0: SelectedAnOption% = 0
 
    HaltAndDisplay% = TRUE%: Highlight% = 1: yPos% = 13: MaxOption% = 8: SelectedAnOption% = FALSE%
    Do
        UserCommand$ = InKey$
        Locate 45, 1: Print S$(Highlight%)
        Locate 46, 1: Print "|" + UserCommand$ + "|"
        If HaltAndDisplay% = TRUE% Then
            Color 14, 1: Cls
            A$ = "Time Calculator Menu": xPos% = Center(A$)
            Locate yPos%, Center(A$): Print A$: Locate yPos% + 1, Center(A$)
            Print "---- ---------- ----"
 
            A$ = "": A$ = "1.) Find How Long From Now"
            Locate yPos% + 3, Center(A$): If Highlight% = 1 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
            A$ = "": A$ = "Until A Selected Time"
            Locate yPos% + 4, Center(A$): If Highlight% = 1 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            A$ = "": A$ = "2.) Find How Long It Has Been Since"
            Locate yPos% + 6, Center(A$): If highlighedoption% = 2 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
            A$ = "": A$ = "A Selected Time Has Passed"
            Locate yPos% + 7, Center(A$): If Highlight% = 2 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            A$ = "": A$ = "3.) Find The Date And Time It Will Be After"
            Locate yPos% + 9, Center(A$): If Highlight% = 3 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
            A$ = "": A$ = "A Selected Amount Of Time Has Passed"
            Locate yPos% + 10, Center(A$): If Highlight% = 3 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            A$ = "": A$ = "4.) Add Two Elapsed Times"
            Locate yPos% + 12, Center(A$): If Highlight% = 4 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            A$ = "": A$ = "5.) Subtract One Elapsed Time From Another One"
            Locate yPos% + 14, Center(A$): If Highlight% = 5 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            A$ = "": A$ = "6.) Multiply An Elapsed Time By A Constant"
            Locate yPos% + 16, Center(A$): If Highlight% = 6 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            A$ = "": A$ = "7.) Divide An Elapsed Time By A Constant"
            Locate yPos% + 18, Center(A$): If Highlight% = 7 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            A$ = "": A$ = "8.) Exit"
            Locate 45, Center(A$): If Highlight% = 8 Then
            Color 10, 0: Else Color 14, 1: End If: Print A$
 
            HaltAndDisplay% = FALSE%
        End If
 
        Select Case UserCommand$
            Case UpArrowKey$, LeftArrowKey$
                Highlight% = highlightedoption - 1
                If Highlight% = 0 Then Highlight% = MaxOption%
                HaltAndDisplay% = TRUE%
            Case DownArrowKey$, rightarrowkey$
                Highlight% = Highlight% + 1
                If highlightedoption > maxoption Then Highlight% = 1
                HaltAndDisplay% = TRUE%
            Case Chr$(13)
                SelectedAnOption% = TRUE%
            Case "1", "2", "3", "4", "5", "6", "7"
                Highlight% = Val(UserCommand$)
                SelectedAnOption% = TRUE%
        End Select
        If SelectedAnOption% = TRUE Then
            Select Case Highlight%
                Case 1
                    Call FromNowUntil: SelectedAnOption% = FALSE%
                Case 2
                    Call HowLongSince: SelectedAnOption% = FALSE%
                Case 3
                    Call WhatDateAfterElapsedTime: SelectedAnOption% = FALSE%
                Case 4
                    Call AddElapsedTimes: SelectedAnOption% = FALSE%
                Case 5
                    Call SubtractElapsedTimes: SelectedAnOption% = FALSE%
                Case 6
                    Call Multiply: SelectedAnOption% = FALSE%
                Case 7
                    Call Divide: SelectedAnOption% = FALSE%
            End Select
        End If
        _Display ' <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< added this and next
        _Limit 30
    Loop Until UserCommand$ = Chr$(27) Or UserCommand$ = S$(MaxOption%)
End Sub
 
 
 
 
 
Function Center% (Text$): Center% = Int((80 - Len(Text$)) / 2): End Function
Function S$ (Number!): S$ = LTrim$(Str$(Number!)): End Function
Function P$: pause$ = Input$(1): If pause$ = Chr$(27) Then End
P$ = pause$: End Function
 
 
 

bplus · « **Reply #2 on:** April 11, 2022, 01:57:05 pm »

Oh you are trying to highlite something, ehhh

deja vu again today:

Didn't I suggest False% = 0 ???

An If is going to see both -1 and 1 as True and take the THEN path.

Jaze · « **Reply #3 on:** April 11, 2022, 02:10:17 pm »

changing the false constant to zero made no difference. besides I like the -1, 1 so I can flip them by multiplying by -1

bplus · « **Reply #4 on:** April 11, 2022, 02:19:33 pm »

Ah, I use "toggle"
toggle = 1 - toggle 0,1,0,1,....

True, False a little misleading, but everyone has their styles and preferences....

You are attempting to highlight line ready to go on Enter maybe after arrow presses, I assume.

Jaze · « **Reply #5 on:** April 11, 2022, 02:20:56 pm »

I added _DISPLAY and _LIMIT as suggest which does fix the flicker but dose not allow an option to be highlighted and selected with the arrow keys

bplus · « **Reply #6 on:** April 11, 2022, 02:27:22 pm »

Yeah working on highlights.. looks like just _limit 30 is enough to stop flicker.

Jaze · « **Reply #7 on:** April 11, 2022, 02:30:36 pm »

This code does what it is supposed to without the flicker and allows the use of the arrow keys. I didn't think the options were clear enough so I rewrote it. I don't see any difference in this style of the Menu compared to the other. Apart from the text their nearly identical but this one works... just a pain in the ass reordering the menu options but I apparently have no choice

Code: QB64: [Select]

SUB Menu
  DIM highlightedOption, haltAndDisplay, xPos, maxOption, yPos AS INTEGER
  DIM userCommand$
 
  highlightedOption = 1
  haltAndDisplay = TRUE
  maxOption = 8
  yPos = 14
  DO
    userCommand$ = INKEY$
    IF haltAndDisplay = TRUE THEN
      COLOR 14, 1: CLS
      a$ = "Time Calculator": xPos = Center(a$): LOCATE yPos, xPos: PRINT a$
      LOCATE yPos + 1, xPos - 1: PRINT "-----------------"
      a$ = "1.) Add 2 Time Amounts": LOCATE yPos + 5, Center(a$)
      IF highlightedOption = 1 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "2.) Add 1 Time Amount To A Date and Time": LOCATE yPos + 7, Center(a$)
      IF highlightedOption = 2 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "3.) Subtract 1 Time Amount From Another": LOCATE yPos + 9, Center(a$)
      IF highlightedOption = 3 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "4.) Find Date And Time Before Another Date And Time": LOCATE yPos + 11, Center(a$)
      IF highlightedOption = 4 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "5.) Multiply 1 Time Amount By A Constant": LOCATE yPos + 13, Center(a$)
      IF highlightedOption = 5 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "6.) Divide 1 Time Amount By A Constant": LOCATE yPos + 15, Center(a$)
      IF highlightedOption = 6 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "7.) Find The Time From Now Until": LOCATE yPos + 17, Center(a$)
      IF highlightedOption = 7 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "A Selected Date And Time": LOCATE yPos + 18, Center(a$)
      IF highlightedOption = 7 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      a$ = "8.) End": LOCATE yPos + 25, Center(a$)
      IF highlightedOption = 8 THEN
      COLOR 10, 0: ELSE COLOR 14, 1: END IF
      PRINT a$
      haltAndDisplay = FALSE
    END IF
    SELECT CASE userCommand$
      CASE LeftArrowKey$, UpArrowKey$
        highlightedOption = highlightedOption - 1
        IF highlightedOption = 0 THEN highlightedOption = maxOption
        haltAndDisplay = TRUE
      CASE RightArrowKey$, DownArrowKey$
        highlightedOption = highlightedOption + 1
        IF highlightedOption > maxOption THEN highlightedOption = 1
        haltAndDisplay = TRUE
      CASE CHR$(13), CHR$(32)
        SELECT CASE highlightedOption
          CASE 1
            CALL AddTwoTimeAmounts
          CASE 2
            CALL AddTimeToDate
          CASE 3
            CALL SubtractTimeAmounts
          CASE 4
            CALL FindDateBefore
          CASE 5
            CALL MultiplyTimeByConstant
          CASE 6
            CALL DivideTimeByConstant
          CASE 7
            CALL FindTimeUntil
        END SELECT
        haltAndDisplay = TRUE
      CASE "1", "2", "3", "4", "5", "6", "7"
        highlightedOption = VAL(userCommand$)
        SELECT CASE highlightedOption
          CASE 1
            CALL AddTwoTimeAmounts
          CASE 2
            CALL AddTimeToDate
          CASE 3
            CALL SubtractTimeAmounts
          CASE 4
            CALL FindDateBefore
          CASE 5
            CALL MultiplyTimeByConstant
          CASE 6
            CALL DivideTimeByConstant
          CASE 7
            CALL FindTimeUntil
        END SELECT
        haltAndDisplay = TRUE
    END SELECT
  LOOP UNTIL userCommand$ = CHR$(27) OR userCommand$ = "8"
END SUB

Jaze · « **Reply #8 on:** April 11, 2022, 02:39:45 pm »

I had an earlier version of the Time Calculator in desperate need of an overhaul. Hence I came up with the second menu. I commented out the Menu in the older version, cut and pasted the newer menu (the first one I posted) into the program needing the overhaul and it worked fine. Doing the same in reverse, putting the older menu into the newer version of the program and commented out the newer menu. And it flickered. So I have identical code in two different windows behaving differently

bplus · « **Reply #9 on:** April 11, 2022, 02:49:09 pm »

Type-O!

Code: QB64: [Select]

Dim Shared RightArroeKey$: rightArrowKey$ = Chr$(0) + "M"
 

need w in arrow where e is!

I found it by watching highlight continuously increasing even when keys not pressed.

bplus · « **Reply #10 on:** April 11, 2022, 03:07:48 pm »

Line 110 should be this:

Code: QB64: [Select]

 Highlight% = Highlight% - 1    
 

because the up arrow was not changing the highlight number.

bplus · « **Reply #11 on:** April 11, 2022, 03:10:55 pm »

add this in around line 115:

Code: QB64: [Select]

If Highlight% > 8 Then Highlight% = 1   
 

So highlight won't exceed 8

Now I think it will work as intended.

bplus · « **Reply #12 on:** April 11, 2022, 03:27:11 pm »

Added this in to check running the subs for time:

Code: QB64: [Select]

 If SelectedAnOption% = TRUE% Then 
' debug check the selection code section
            Cls
            Print "You selected "; Highlight%
            _Delay 2
            SelectedAnOption% = FALSE%
            HaltAndDisplay% = TRUE%
 
' commented out next section, as not ready
            'Select Case Highlight%
            '    Case 1
            '        Call FromNowUntil: SelectedAnOption% = FALSE%
            '    Case 2
 

News:

Author Topic: Highlight% changes by itself (Read 10229 times)

Jaze

Highlight% changes by itself

bplus

Re: Highlight% changes by itself

bplus

Re: Highlight% changes by itself

Jaze

Re: Highlight% changes by itself

bplus

Re: Highlight% changes by itself

Jaze

Re: Highlight% changes by itself

bplus

Re: Highlight% changes by itself

Jaze

Re: Highlight% changes by itself

Jaze

Re: Highlight% changes by itself

bplus

Re: Highlight% changes by itself

bplus

Re: Highlight% changes by itself

bplus

Re: Highlight% changes by itself

bplus

Re: Highlight% changes by itself