Need Help converting program from old qbasic to qb64

[steinguy]

tlup:
OPEN "com1:1200,n,8,1" FOR RANDOM AS #1

PRINT #1, "D1973D1973D1973BBBBBBBBBB";
t = 3: GOSUB 3000
WHILE LOC(1) > 0
    jj$ = INPUT$(LOC(1), 1)
    GOSUB 3000
WEND
PRINT "Monitor mode initialized..."

PRINT "Waiting 3 minutes for warm up..."
tm = TIMER
WHILE TIMER - tm < 180
    IF INKEY$ <> "" THEN GOTO skip
WEND
skip:
PRINT "3 minutes has expired..."
FOR k = 1 TO 4
    FOR j = 1 TO 4
        SOUND 2000, 1
        FOR i = 1 TO 1000: NEXT i
    NEXT j
    FOR i = 1 TO 2000: NEXT i
NEXT k
PRINT "Remove RF jumper then..."
PRINT "Set LM723 output to 5.000V...": GOSUB 1000
PRINT "Set ADC reference voltage to 1.0900V...": GOSUB 1000
PRINT "Set RF voltage to -2.150 (this depends on probe)...": GOSUB 1000
PRINT "-> replace rf jumper"
PRINT "ADC test:  use hands to make diode voltage change..."
PRINT "--> hit key when through"
PRINT "Diode", "T0", "T1", "T2", "Zero"
GOSUB 2000
PRINT "Testing Balance Relay..."
PRINT "    Does it BUZZZZ?????"
PRINT "--> hit a key when ready to continue"
WHILE INKEY$ <> "": WEND
WHILE INKEY$ = ""
    PRINT #1, "89";
WEND
PRINT "Waiting for buffer to empty..."
PRINT #1, "I";
INPUT #1, a$
PRINT #1, "D";
PRINT "DAC test in progress": GOSUB 1000
klup: PRINT "Keyboard test: hit 0 1 2 3 4 5 6 7 8 9 MODE PRINT and GO keys"
PRINT #1, "G"
PRINT #1, "H";
INPUT #1, a$
IF a$ = "0123456789-." THEN PRINT "Keyboard OK": GOTO kok
SOUND 440, 2
PRINT "Keyboard test failed-- retry(Y/N)?"
klup2: a$ = INKEY$
IF a$ = "Y" THEN GOTO klup
IF a$ = "y" THEN GOTO klup
IF a$ = "n" THEN GOTO kok
IF a$ = "N" THEN GOTO kok
GOTO klup2
kok:
PRINT "Testing Aux Module..."
OPEN "i", #2, "c:\sb900\auxlog"
PRINT #1, "ADFBFB";
WHILE NOT EOF(2)
    INPUT #2, b$
    tm = TIMER
    WHILE (TIMER - tm < 3) AND (LOC(1) < 1): WEND
    IF LOC(1) > 0 THEN INPUT #1, a$
    IF a$ <> b$ THEN GOTO mbad
WEND
t = 3: GOSUB 3000
IF LOC(1) > 0 THEN PRINT "Too Many entries": GOTO mbad
GOTO mok
mbad:
PRINT "############## Error in reading Aux Module!!!"
SOUND 880, 2
mok: PRINT "Aux Module test complete"
PRINT "Serial port handshaking check"
PRINT #1, "ADFBFB";
CLOSE
PRINT "-> Listing on LCD be 'frozen'"
PRINT "-> Unplug Aux Module"
PRINT "-> Unplug serial port and listing should finish"
PRINT
PRINT "-> Finish by doing the 'twist test'"
PRINT
PRINT "?? test another?? (Y/N)??"
dlup: a$ = INKEY$
IF a$ = "Y" THEN GOTO tlup
IF a$ = "y" THEN GOTO tlup
IF a$ = "n" THEN GOTO done
IF a$ = "N" THEN GOTO done
GOTO dlup
done:
END
1000 PRINT "--> Hit a key when ready to continue..."
WHILE INKEY$ <> "": WEND
WHILE INKEY$ = "": WEND
RETURN
2000 REM monitor diode voltage
WHILE INKEY$ <> "": WEND
posn = CSRLIN
PRINT #1, "R0";
WHILE INKEY$ = ""
    PRINT #1, "R0";
    INPUT #1, v0
    PRINT #1, "BR1";
    INPUT #1, v1
    PRINT #1, "BR2";
    INPUT #1, v2
    PRINT #1, "BR3";
    INPUT #1, v3
    PRINT #1, "BR4";
    INPUT #1, v4
    PRINT #1, "B";
    IF v0 > 50000 THEN v0 = v0 - 100000
    IF v1 > 50000 THEN v1 = v1 - 100000
    IF v2 > 50000 THEN v2 = v2 - 100000
    IF v3 > 50000 THEN v3 = v3 - 100000
    IF v4 > 50000 THEN v4 = v4 - 100000

    LOCATE posn, 1
    PRINT v0, v1, v2, v3, v4; "        ";
WEND
PRINT #1, "B";
PRINT
RETURN

3000 REM routine to wait t seconds
tm = TIMER
WHILE TIMER - tm < t: WEND
RETURN

[SpriggsySpriggs]

Just for readability, enclosing it in a code block:

Code: QB64: [Select]

1. tlup:
2. OPEN "com1:1200,n,8,1" FOR RANDOM AS #1
3.  
4. PRINT #1, "D1973D1973D1973BBBBBBBBBB";
5. t = 3: GOSUB 3000
6. WHILE LOC(1) > 0
7.     jj$ = INPUT$(LOC(1), 1)
8.     GOSUB 3000
9. WEND
10. PRINT "Monitor mode initialized..."
11.  
12. PRINT "Waiting 3 minutes for warm up..."
13. tm = TIMER
14. WHILE TIMER - tm < 180
15.     IF INKEY$ <> "" THEN GOTO skip
16. WEND
17. skip:
18. PRINT "3 minutes has expired..."
19. FOR k = 1 TO 4
20.     FOR j = 1 TO 4
21.         SOUND 2000, 1
22.         FOR i = 1 TO 1000: NEXT i
23.     NEXT j
24.     FOR i = 1 TO 2000: NEXT i
25. NEXT k
26. PRINT "Remove RF jumper then..."
27. PRINT "Set LM723 output to 5.000V...": GOSUB 1000
28. PRINT "Set ADC reference voltage to 1.0900V...": GOSUB 1000
29. PRINT "Set RF voltage to -2.150 (this depends on probe)...": GOSUB 1000
30. PRINT "-> replace rf jumper"
31. PRINT "ADC test:  use hands to make diode voltage change..."
32. PRINT "--> hit key when through"
33. PRINT "Diode", "T0", "T1", "T2", "Zero"
34. GOSUB 2000
35. PRINT "Testing Balance Relay..."
36. PRINT "    Does it BUZZZZ?????"
37. PRINT "--> hit a key when ready to continue"
38. WHILE INKEY$ <> "": WEND
39. WHILE INKEY$ = ""
40.     PRINT #1, "89";
41. WEND
42. PRINT "Waiting for buffer to empty..."
43. PRINT #1, "I";
44. INPUT #1, a$
45. PRINT #1, "D";
46. PRINT "DAC test in progress": GOSUB 1000
47. klup: PRINT "Keyboard test: hit 0 1 2 3 4 5 6 7 8 9 MODE PRINT and GO keys"
48. PRINT #1, "G"
49. PRINT #1, "H";
50. INPUT #1, a$
51. IF a$ = "0123456789-." THEN PRINT "Keyboard OK": GOTO kok
52. SOUND 440, 2
53. PRINT "Keyboard test failed-- retry(Y/N)?"
54. klup2: a$ = INKEY$
55. IF a$ = "Y" THEN GOTO klup
56. IF a$ = "y" THEN GOTO klup
57. IF a$ = "n" THEN GOTO kok
58. IF a$ = "N" THEN GOTO kok
59. GOTO klup2
60. kok:
61. PRINT "Testing Aux Module..."
62. OPEN "i", #2, "c:\sb900\auxlog"
63. PRINT #1, "ADFBFB";
64. WHILE NOT EOF(2)
65.     INPUT #2, b$
66.     tm = TIMER
67.     WHILE (TIMER - tm < 3) AND (LOC(1) < 1): WEND
68.     IF LOC(1) > 0 THEN INPUT #1, a$
69.     IF a$ <> b$ THEN GOTO mbad
70. WEND
71. t = 3: GOSUB 3000
72. IF LOC(1) > 0 THEN PRINT "Too Many entries": GOTO mbad
73. GOTO mok
74. mbad:
75. PRINT "############## Error in reading Aux Module!!!"
76. SOUND 880, 2
77. mok: PRINT "Aux Module test complete"
78. PRINT "Serial port handshaking check"
79. PRINT #1, "ADFBFB";
80. CLOSE
81. PRINT "-> Listing on LCD be 'frozen'"
82. PRINT "-> Unplug Aux Module"
83. PRINT "-> Unplug serial port and listing should finish"
84. PRINT
85. PRINT "-> Finish by doing the 'twist test'"
86. PRINT
87. PRINT "?? test another?? (Y/N)??"
88. dlup: a$ = INKEY$
89. IF a$ = "Y" THEN GOTO tlup
90. IF a$ = "y" THEN GOTO tlup
91. IF a$ = "n" THEN GOTO done
92. IF a$ = "N" THEN GOTO done
93. GOTO dlup
94. done:
95. END
96. 1000 PRINT "--> Hit a key when ready to continue..."
97. WHILE INKEY$ <> "": WEND
98. WHILE INKEY$ = "": WEND
99. RETURN
100. 2000 REM monitor diode voltage
101. WHILE INKEY$ <> "": WEND
102. posn = CSRLIN
103. PRINT #1, "R0";
104. WHILE INKEY$ = ""
105.     PRINT #1, "R0";
106.     INPUT #1, v0
107.     PRINT #1, "BR1";
108.     INPUT #1, v1
109.     PRINT #1, "BR2";
110.     INPUT #1, v2
111.     PRINT #1, "BR3";
112.     INPUT #1, v3
113.     PRINT #1, "BR4";
114.     INPUT #1, v4
115.     PRINT #1, "B";
116.     IF v0 > 50000 THEN v0 = v0 - 100000
117.     IF v1 > 50000 THEN v1 = v1 - 100000
118.     IF v2 > 50000 THEN v2 = v2 - 100000
119.     IF v3 > 50000 THEN v3 = v3 - 100000
120.     IF v4 > 50000 THEN v4 = v4 - 100000
121.  
122.     LOCATE posn, 1
123.     PRINT v0, v1, v2, v3, v4; "        ";
124. WEND
125. PRINT #1, "B";
126. PRINT
127. RETURN
128.  
129. 3000 REM routine to wait t seconds
130. tm = TIMER
131. WHILE TIMER - tm < t: WEND
132. RETURN

[steinguy]

thanks

[Richard Frost]

Appears that it should work as is, but it may overheat your CPU.

Loops that have no input (INKEY$ doesn't count) should contain a _LIMIT. 
Using FOR/NEXT as a delay will be so fast as to be useless - use _DELAY.

[steinguy]

Richard frost
Not much of a programmer to be honest. The error I'm getting is bad file mode at print# 1,  ,"d1973....." line. Its essentially not send that string to machine via serial port.

[Richard Frost]

I looked for code I used long ago.  There are optional but sometimes necessary
parameters for a serial port.   Like:

OPEN "COM1:1200,n,8,1,CD,CS,DS,RS,RB4096" for random as #1

And rather than relying on handshaking to take care of it for you, don't be sending
so much data at once.   

[MWheatley]

Program runs fine under QuickBasic 4.5 in 64-bit Windows 10, and QuickBasic 4.5 is what it looks like it was written in.

When I say "runs fine", I mean that it gets past the line in question OK, and prints to my laser printer.

Obviously, I don't possess whatever the device is, and so can't check that aspect of things.

Malcolm

[moises1953]

The serial ports must be used  using put and get, char by char, so you must create your own line function, like this to substitute the print command

Code: QB64: [Select]

1. SUB PrintCOM (line$) STATIC
2.   DIM car AS _BYTE 'STRING * 1
3.   FOR i = 1 TO LEN(line$)
4.     car = ASC(line$, i)
5.     PUT #1, , car
6.   NEXT i
7.   car = 13 'Cr: End of line in Windows
8.   PUT #1, , car
9. END FUNCTION
10.  

[steinguy]

@MWheatley ,
Can you possibly point me to a useable download link, I tried two different ones and Im getting an uncompatible error.

Thanks,

Steinguy

[MWheatley]

I think you're asking for a link for QuickBasic 4.5?  You'll also need vDosPlus to run it under.

My recommendation would be prove to yourself it works, and then port it to QB64 using the advice in this thread.  Much simpler than using DOS-era code under a DOS emulator!

I bought my copy of QuickBasic 4.5 back in 1989, but you'll probably find it on an abandonware site -- I'd try Vetusware first.

You can get vDosPlus here: http://vdosplus.org/

That said, I'd click through to the link to Ed Mendelson's download page, and download it from there.

Malcolm

[Bert22306]

Before stumbling onto QB64, I was using QB v7.1, which I got from this site:

https://www.qbasic.net/en/qbasic-downloads/compiler/qbasic-compiler.htm

As you can see, there are also an English and a German version of QB v4.5 available there. I used to run v7.1 over DOSbox, over Windows 7.

https://www.dosbox.com/download.php?main=1

There was a speed hit, but that aside, it worked fine. Also, you could get fonts for DOSbox, to expand the window of the QB IDE to more lines than the old, small default.