Author Topic: simple array question (I forgot) (Read 5821 times)

xra7en · « **on:** December 22, 2021, 08:44:46 pm »

when initializing an array and type vars - do they start with empty strings or integers ?

I'm tinkering with a program but have tons of arrays and type vars, and just realized that I may have to do the famous loop to zero stuff out.
Do I still need to do that?

example

Code: QB64: [Select]

type tRec
var1 as integer
var2 as string
end type
 
type t2ndRec
var1 as integer
var2 as tRec
end type

do these start off as zero for the var1 and empty string for the var2?

FellippeHeitor · « **Reply #1 on:** December 22, 2021, 08:50:51 pm »

Strings start empty (= "") and numbers start at 0.

bplus · « **Reply #2 on:** December 22, 2021, 08:54:46 pm »

I forgot, did we fix having to initialize UDT arrays at 0 or "", to be sure they are that?

FellippeHeitor · « **Reply #3 on:** December 22, 2021, 08:59:10 pm »

Please run some tests when you can, just to be 100% sure for us, but I do believe it's all good.

xra7en · « **Reply #4 on:** December 22, 2021, 09:01:36 pm »

will do, when I finish the init section I'll run it and see if it gives me the required values
I'll post the results here.
but ya, its the UDT I am concerned about.

SMcNeill · « **Reply #5 on:** December 22, 2021, 09:35:48 pm »

If it was vitally important in my code, I wouldn't take chances and would clear them on initialization.

From my memory, we *usually* clear arrays at start, but I seem to remember some edge cases where we don't.

Is it the difference in DIM vs REDIM vs STATIC?

Is it the difference between arrays declared in the main module vs inside SUB/FUNCTION? (They really are quite different, with temporary arrays being allocated on the fly in SUB/FUNCTIONs.)

Is it the difference in fixed length vs variable-length strings? Or UDTs?

Honestly, I don't remember, but my mind is telling me there's some odd combo of those various options that end up with not all arrays being initialized to 0 and "".

If my code relied on null values at start-up, I wouldn't take any chances and would spend the .2 seconds to manually blank my array as necessary.

Richard Frost · « **Reply #6 on:** December 22, 2021, 09:42:08 pm »

Another reason to initialize arrays (or any variables) to zero on your own is
the case of declaring an array in a SUB and later making the SUB static.

SMcNeill · « **Reply #7 on:** December 22, 2021, 09:50:58 pm »

People make SUBs static?? I've needed a few static variables but never a whole sub. What's the use case for something like that?

Richard Frost · « **Reply #8 on:** December 22, 2021, 09:56:00 pm »

I make a SUB static in an effort to cut down on global variables.

If I've got one-time initializations for a SUB, it's either have a global flag
for that sub or a local one that's preserved by making the SUB static. There's
probably a better way that escapes me.

bplus · « **Reply #9 on:** December 22, 2021, 11:48:07 pm »

Wow never knew you could make a whole sub static, for recursion it looks like.

Before this I thought the only reason to make a sub static was to keep the giant squid away:
https://fox2now.com/news/giant-squid-captured-on-video-attacking-submarine/

luke · « **Reply #10 on:** December 23, 2021, 04:56:49 am »

Unfortunately, there is a long-standing bug where an array of user-defined types which contain a variable length string may not have all its fields initialised to ""/0. This only occurs under rare circumstances, and only with variable length strings in user-defined types (fixed length strings, or simple arrays of strings are not affected). I have been unable to reproduce this with any kind of regularity which is why is escapes fixing.

Cobalt · « **Reply #11 on:** December 23, 2021, 10:54:49 am »

I know just normal fixed length string arrays do NOT initialize to "". They tend to hold junk.

Pretty sure however that Fixed Length strings in UDTs do initialize to "". I would go with Luke's experience on the variable length ones though.

xra7en · « **Reply #12 on:** December 25, 2021, 04:22:41 am »

thanks for the replies

You are correct, it is good practice to init all vars, arrays, and udt, however, is a special case for me.
I was so fascinated by the "ON TIMER(x)" feature.
I am in the process of converting a clicker JS game to QB64, and have almost 500 lines of UDT.

Here is what I was able to convert so far - goes pretty smooth. May not be the correct way. but it works

Code: QB64: [Select]

Option _Explicit
 
'-- THESE 2 LINES WILL RUN EVERY SECOND
'-- AND UPDATE THE GAME WITH THE UPKEEP SUB
On Timer(1) UP_KEEP
Timer On
 
Const TRUE = 1
Const FALSE = 0
 
 
'-- GAME RECORDS
'-- INITIATE EVERYTHING HERE.
'--- TODO MAKE AN INI FILE FOR CUSTOM SETTINGS
 
'-- FOOD
Type tCORE
    nname As String * 20
    total As Integer
    increment As Integer
    specialChance As Double
End Type
Dim Shared CORE As tCORE
Dim Shared FOOD As tCORE
FOOD.nname = "food"
FOOD.total = 0
FOOD.increment = 1
FOOD.specialChance = 0.1
 
'-- WOOD
Dim Shared WOOD As tCORE
WOOD.total = 0
WOOD.increment = 1
WOOD.specialChance = 0.1
 
'-- STONE
Dim Shared STONE As tCORE
STONE.total = 0
STONE.increment = 1
STONE.specialChance = 0.1
 
 
'-- SKINS
Dim Shared SKINS As tCORE
SKINS.nname = "skins"
SKINS.total = 0
 
Dim Shared HERBS As tCORE
HERBS.nname = "herbs"
HERBS.total = 0
 
Dim Shared ORE As tCORE
ORE.nname = "ore"
ORE.total = 0
 
Dim Shared LEATHER As tCORE
LEATHER.nname = "leather"
LEATHER.total = 0
 
Dim Shared METAL As tCORE
METAL.nname = "metal"
METAL.total = 0
 
Dim Shared PIETY As tCORE
PIETY.nname = "piety"
PIETY.total = 0
 
Dim Shared GOLD As tCORE
GOLD.nname = "piety"
GOLD.total = 0
 
Dim Shared LAND As Long
LAND = 1000
Dim Shared TOTAL_BUILDINGS As Long
TOTAL_BUILDINGS = 0
 
Type TREQUIRES
    FOOD As Integer
    WOOD As Integer
    STONE As Integer
    SKINS As Integer
    HERBS As Integer
    ORE As Integer
    LEATHER As Integer
    METAL As Integer
    PIETY As Integer
    CORPSES As Integer
End Type
 
Type treqtemplate
    total As Integer
    devotion As Integer
    requires As TREQUIRES
End Type
 
 
Dim Shared TENT As treqtemplate
TENT.requires.WOOD = 2
TENT.requires.SKINS = 2
 
Dim Shared WHUT As treqtemplate
WHUT.requires.WOOD = 20
WHUT.requires.SKINS = 2
 
 
Dim Shared COTTAGE As treqtemplate
COTTAGE.requires.WOOD = 10
COTTAGE.requires.STONE = 30
 
Dim Shared HOUSE As treqtemplate
HOUSE.requires.WOOD = 30
HOUSE.requires.STONE = 70
 
Dim Shared MANSION As treqtemplate
MANSION.requires.WOOD = 200
MANSION.requires.STONE = 200
 
Dim Shared BARN As treqtemplate
BARN.requires.WOOD = 100
 
Dim Shared WOODSTOCK As treqtemplate
WOODSTOCK.requires.WOOD = 100
 
Dim Shared STONESTOCK As treqtemplate
STONESTOCK.requires.WOOD = 100
 
Dim Shared TANNERY As treqtemplate
TANNERY.requires.WOOD = 30
TANNERY.requires.STONE = 70
TANNERY.requires.SKINS = 2
 
Dim Shared SMITHY As treqtemplate
SMITHY.requires.WOOD = 30
SMITHY.requires.STONE = 70
SMITHY.requires.ORE = 2
 
Dim Shared APOTHECARY As treqtemplate
APOTHECARY.requires.WOOD = 30
APOTHECARY.requires.STONE = 70
APOTHECARY.requires.HERBS = 2
 
Dim Shared TEMPLE As treqtemplate
TEMPLE.requires.WOOD = 30
TEMPLE.requires.STONE = 120
TEMPLE.requires.HERBS = 10
 
Dim Shared BARRACKS As treqtemplate
BARRACKS.requires.WOOD = 60
BARRACKS.requires.FOOD = 20
BARRACKS.requires.STONE = 120
 
Dim Shared STABLE As treqtemplate
STABLE.requires.FOOD = 60
STABLE.requires.WOOD = 60
STABLE.requires.STONE = 120
STABLE.requires.LEATHER = 10
 
Dim Shared MILL As treqtemplate
MILL.requires.WOOD = 100
MILL.requires.STONE = 100
 
Dim Shared GRAVEYARD As treqtemplate
GRAVEYARD.requires.WOOD = 50
GRAVEYARD.requires.STONE = 200
GRAVEYARD.requires.HERBS = 50
 
Dim Shared FORTIFICATION As treqtemplate
FORTIFICATION.requires.STONE = 100
 
Dim Shared BATTLEALTAR As treqtemplate
BATTLEALTAR.devotion = 1
BATTLEALTAR.requires.METAL = 50
BATTLEALTAR.requires.PIETY = 200
BATTLEALTAR.requires.STONE = 200
 
Dim Shared FIELDSALTAR As treqtemplate
FIELDSALTAR.devotion = 1
FIELDSALTAR.requires.FOOD = 500
FIELDSALTAR.requires.WOOD = 500
FIELDSALTAR.requires.STONE = 200
FIELDSALTAR.requires.PIETY = 200
 
Dim Shared UNDERWORLDALTER As treqtemplate
UNDERWORLDALTER.devotion = 1
UNDERWORLDALTER.requires.PIETY = 200
UNDERWORLDALTER.requires.STONE = 200
UNDERWORLDALTER.requires.CORPSES = 1
 
Dim Shared CATALTER As treqtemplate
CATALTER.devotion = 1
CATALTER.requires.PIETY = 200
CATALTER.requires.STONE = 200
CATALTER.requires.HERBS = 100
 
Type TWONDER
    TOTAL As Integer
    WOOD As Integer
    FOOD As Integer
    STONE As Integer
    SKINS As Integer
    HERBS As Integer
    ORE As Integer
    LEATHER As Integer
    METAL As Integer
    PIETY As Integer
    NNAME As String * 20
    BUILDING As Integer
    COMPLETED As Integer
    PROGRESS As Integer
End Type
Dim Shared WONDER As TWONDER
 
Type TPOPULATION
    CURRENT As Integer
    CAP As Integer
    CATS As Integer
    CORPSES As Integer
    ZOMBIES As Integer
    GRAVES As Integer
    UNEMPLOYED As Integer
    FARMERS As Integer
    WOODCUTTERS As Integer
    MINERS As Integer
    TANNERS As Integer
    BLACKSMITHS As Integer
    APOTHECARIES As Integer
    CLERICS As Integer
    LABOURERS As Integer
    SOLDIERS As Integer
    SOLDIERSCAS As Integer
    CAVALRY As Integer
    CAVALRYCAS As Integer
    CAVALRYPARTY As Integer
    CAVALRYPARTYCAS As Integer
    SIEGE As Integer
    ESOLDIERS As Integer
    ESOLDIERSCAS As Integer
    EFORTS As Integer
    healthy As Integer
    totalsick As Integer
    healthyas As Integer
    totalSickas As Integer
    unemployedIll As Integer
    farmersIll As Integer
    woodcuttersIll As Integer
    minersIll As Integer
    tannersIll As Integer
    blacksmithsIll As Integer
    apothecariesIll As Integer
    clericsIll As Integer
    labourersIll As Integer
    soldiersIll As Integer
    soldiersCasIll As Integer
    cavalryIll As Integer
    cavalryCasIll As Integer
    wolves As Integer
    wolvesCas As Integer
    bandits As Integer
    banditsCas As Integer
    barbarians As Integer
    barbariansCas As Integer
    esiege As Integer
    enemiesSlain As Integer
    shades As Integer
End Type
Dim Shared POPULATION As TPOPULATION
 
Type Tefficiency
    happiness As Integer
    farmers As Double
    pestBonus As Double
    woodcutters As Double
    miners As Double
    tanners As Double
    blacksmiths As Double
    apothecaries As Double
    clerics As Double
    soldiers As Double
    cavalry As Double
End Type
Dim Shared EFFICIENCY As Tefficiency
EFFICIENCY.happiness = 1
EFFICIENCY.farmers = 0.2
EFFICIENCY.pestBonus = 0
EFFICIENCY.woodcutters = 0.5
EFFICIENCY.miners = 0.2
EFFICIENCY.tanners = 0.5
EFFICIENCY.blacksmiths = 0.5
EFFICIENCY.apothecaries = 0.1
EFFICIENCY.clerics = 0.05
EFFICIENCY.soldiers = 0.05
EFFICIENCY.cavalry = 0.08
 
Type TUPGRADES
    domestication As Integer
    ploughshares As Integer
    irrigation As Integer
    skinning As Integer
    harvesting As Integer
    prospecting As Integer
    butchering As Integer
    gardening As Integer
    extraction As Integer
    croprotation As Integer
    selectivebreeding As Integer
    fertilisers As Integer
    masonry As Integer
    construction As Integer
    architecture As Integer
    wheel As Integer
    horseback As Integer
    tenements As Integer
    slums As Integer
    granaries As Integer
    palisade As Integer
    weaponry As Integer
    shields As Integer
    writing As Integer
    administration As Integer
    codeoflaws As Integer
    mathematics As Integer
    aesthetics As Integer
    civilservice As Integer
    feudalism As Integer
    guilds As Integer
    serfs As Integer
    nationalism As Integer
    flensing As Integer
    macerating As Integer
    standard As Integer
    deity As Integer
    deityType As Integer
    lure As Integer
    companion As Integer
    comfort As Integer
    blessing As Integer
    waste As Integer
    stay As Integer
    riddle As Integer
    throne As Integer
    lament As Integer
    book As Integer
    feast As Integer
    secrets As Integer
    trade As Integer
    currency As Integer
    commerce As Integer
End Type
Dim Shared UPGRADES As TUPGRADES
 
Type TDEITY
    nname As String * 20
    ttype As String * 20
    seniority As Integer
    devotion As Integer
    battle As Integer
    fields As Integer
    underworld As Integer
    cats As Integer
End Type
Dim Shared DEITY As TDEITY
DEITY.seniority = 1
 
Type TACHIEVEMENTS
    hamlet As Integer
    village As Integer
    smallTown As Integer
    largeTown As Integer
    smallCity As Integer
    largeCity As Integer
    metropolis As Integer
    smallNation As Integer
    nation As Integer
    largeNation As Integer
    empire As Integer
    raider As Integer
    engineer As Integer
    domination As Integer
    hated As Integer
    loved As Integer
    cat As Integer
    glaring As Integer
    clowder As Integer
    battle As Integer
    cats As Integer
    fields As Integer
    underworld As Integer
    fullHouse As Integer
    plague As Integer
    ghostTown As Integer
    wonder As Integer
    seven As Integer
    merchant As Integer
    rushed As Integer
    neverclick As Integer
End Type
Dim Shared ACHIEVEMENTS As TACHIEVEMENTS
 
Type TTRADER
    MATERIAL As Integer
    REQUESTED As Integer
    TTIMER As Integer
 
End Type
Dim Shared TRADER As TTRADER
 
Type TRAIDING
    ISRAIDING As Integer
    VICTORY As Integer
    ITERATIONS As Integer
    LAST As String * 20
End Type
Dim Shared RAIDING As TRAIDING
RAIDING.ISRAIDING = FALSE
RAIDING.VICTORY = FALSE
 
Dim Shared CIVTYPE As String
Dim Shared TARGETMAX As String
CIVTYPE = "THORP"
TARGETMAX = "THORP"
 
Dim Shared resourceClicks As Integer
Dim Shared logRepeat As Integer
Dim Shared attackCounter As Integer
Dim Shared tradeCounter As Integer
Dim Shared throneCount As Integer
Dim Shared pestTimer As Integer
Dim Shared gloryTimer As Integer
Dim Shared cureCounter As Integer
Dim Shared graceCost As Integer
Dim Shared walkTotal As Integer
Dim Shared autosave As String * 4
Dim Shared autosaveCounter As Integer
Dim Shared customIncrements As Integer
Dim Shared delimiters As Integer
Dim Shared usingWords As Integer
Dim Shared worksafe As Integer
Dim Shared thissize As Integer
 
resourceClicks = 0
logRepeat = 1
attackCounter = 0
tradeCounter = 0
throneCount = 0
pestTimer = 0
gloryTimer = 0
cureCounter = 0
graceCost = 1000
walkTotal = 0
autosave = "on"
autosaveCounter = 1
customIncrements = FALSE
delimiters = TRUE
usingWords = FALSE
worksafe = FALSE
thissize = 1
 

And I believe @Cobalt is correct - UDT fixed strings usually hold junk
Also, anyone have an idea how to use "name" in a UDT that doesnt produce an error?

bplus · « **Reply #13 on:** December 25, 2021, 09:30:53 am »

Name is a keyword in QB64 like Print. Add or subtract a letter or more for variable name.

xra7en · « **Reply #14 on:** December 25, 2021, 11:23:23 am »

Quote from: bplus on December 25, 2021, 09:30:53 am

Name is a keyword in QB64 like Print. Add or subtract a letter or more for variable name.

O ya,, knew that. I tried _name but that didnt work either. so using nname, but I saw in @Cobalt had a good idea, and used "nam" not bad. will prob switch to that

thanks @Cobalt

News:

Author Topic: simple array question (I forgot) (Read 5821 times)

xra7en

simple array question (I forgot)

FellippeHeitor

Re: simple array question (I forgot)

bplus

Re: simple array question (I forgot)

FellippeHeitor

Re: simple array question (I forgot)

xra7en

Re: simple array question (I forgot)

SMcNeill

Re: simple array question (I forgot)

Richard Frost

Re: simple array question (I forgot)

SMcNeill

Re: simple array question (I forgot)

Richard Frost

Re: simple array question (I forgot)

bplus

Re: simple array question (I forgot)

luke

Re: simple array question (I forgot)

Cobalt

Re: simple array question (I forgot)

xra7en

Re: simple array question (I forgot)

bplus

Re: simple array question (I forgot)

xra7en

Re: simple array question (I forgot)