Help with program

[Aeveus]

Hi there, I know this program might look crude but I've almost got it to do what I want. I can't get it to display the everything at the end, it seems to only show the two that are above 80000.

Code: QB64: [Select]

1. CLS
2. GOSUB InitializeVariables
3. GOSUB PrintHeadings
4. GOSUB ProcessDetail
5. END
6. '
7. '****************************InitializeVariables**************************
8. InitializeVariables:
9. T1$ = "     XYZ COMPANY"
10. H1$ = "Salesperson          Earnings"
11. D1$ = "\               \          $$#####"
12. RETURN
13. '
14. '***************************** Print Headings ****************************
15. PrintHeadings:
16. PRINT
17. PRINT T1$
18. PRINT
19. PRINT H1$
20. PRINT
21. PRINT
22. RETURN
23. '**************************** Process Detail *****************************
24. ProcessDetail:
25. GOSUB ReadData
26. DO UNTIL Name$ = "END"
27.     GOSUB CalculateAnswer
28.     GOSUB PrintDetail
29.     GOSUB ReadData
30. LOOP
31. RETURN
32. '************************* Print Detail ******************************
33. PrintDetail:
34. PRINT USING D1$; Name$,Pay
35. '*************************** Read Data *************************************
36. ReadData:
37. READ Name$, Sales
38. DATA JILL JOHNSON,90000
39. DATA DON WILLIAMS,70000
40. DATA DEE JONES,95000
41. DATA AL ENNIS,40000
42. DATA END,0
43. RETURN
44. '************************** Calculate Answer ******************************
45. CalculateAnswer:
46. IF Sales > 80000 THEN
47.     PAY = (SALES * 1.1) + 10500
48.     ELSE
49.     PAY = SALES + 10000
50. END IF
51. RETURN
52.  
53.  

[TempodiBasic]

Hi Aeveus

welcome to the forum of QB64!

I can see that you like make SubProgram by GOSUB: RETURN... so you mustn't pass variables as parameters.

It seems to me that you have missed to type the closing statement for GOSUB at line 34

Code: QB64: [Select]

1. :RETURN

for the subprogram started by label PrintDetail:

try if now also on your pc all run ok!

[Dimster]

Hi Aeveus

Another approach would be to eliminate the GoSub PrintDetail all together and simply replace it in your Do Loop with the Print Using statement

Code: QB64: [Select]

1. DO UNTIL NAME$ = "END"
2.     GOSUB CalculateAnswer
3.     PRINT USING D1$; NAME$,Pay
4.     GOSUB ReadData
5. LOOP

[bplus]

Hi Aeveus, welcome to the forum!

Which is clearer to read yours (fixed by TempodiBasic) or this:

Code: QB64: [Select]

1. '
2. '****************************InitializeVariables**************************
3. T1$ = "     XYZ COMPANY"
4. H1$ = "Salesperson          Earnings"
5. D1$ = "\               \          $$#####"
6. '***************************** Print Headings ****************************
7. PRINT
8. PRINT T1$
9. PRINT
10. PRINT H1$
11. PRINT
12. PRINT
13. DO ' ******************* Process pay
14.  
15.     'ReadData:
16.     READ NAME$, Sales
17.     IF NAME$ = "END" THEN EXIT DO
18.  
19.     'calculateAnswer:
20.     IF Sales > 80000 THEN
21.         Pay = (Sales * 1.1) + 10500
22.     ELSE
23.         Pay = Sales + 10000
24.     END IF
25.  
26.     'PrintDetail:
27.     PRINT USING D1$; NAME$, Pay
28. LOOP
29. END
30.  
31. DATA JILL JOHNSON,90000
32. DATA DON WILLIAMS,70000
33. DATA DEE JONES,95000
34. DATA AL ENNIS,40000
35. DATA END,0
36.  
37.  

The opposite of spaghetti code is "shredded wheat" code from over use of GOSUB. Just advice, I know you are just getting started. :)

BTW XYZ is not going to be in business long paying their employees more than their sales, yikes!

[Aeveus]

Thanks for the help as always! You guys are the best