Problem with _FREEIMAGE

[Juanjogomez]

Hi,

I'm doing a billing program and print the invoices using...

Page & = _NEWIMAGE (PageWidth, PageHeight, 256)
_DEST Page &

... I design the invoice and print the invoice with

    _PRINTIMAGE Page &

... and I release the memory with:

    _FREEIMAGE (Page &)

The problem is that the memory is not released completely and the program grows and grows with successive invoices until it fails.

Making a list of invoices, when it takes more than 50 pages the program already occupies more than 1.5 GB in memory and produces a "handle error"

It might not work well _FREEIMAGE?

Thanks

[SMcNeill]

You may need to move the DEST and SOURCE off the image before freeing it.  My memory is telling me that you can’t free an image that is currently in focus.

[Juanjogomez]

I don't get it to work.

I tried to put

_PRINTIMAGE (Page &)

_FONT 16 'change to the QB64 default font to free it
_FREEFONT FontHandle
_DEST 0
_FREEIMAGE (Page &)

and the program continues to grow until it fails on page 58 because it has already reached 1.5 GB.

I have also tried to create only once the page at the beginning of the program and make

CLS, _RGB (256, 256, 256)

before each invoice, but the same thing happens.

Thanks

[SMcNeill]

Can you share the actual program?  It’s hard to debug without the problem code at hand.

[Juanjogomez]

Can you share the actual program?  It’s hard to debug without the problem code at hand.

Hi,
here I attach the code, which has been simplified as I have taken the access to the database.
What the program does is to print 150 identical invoices (just change the invoice number).

The program keeps getting bigger and from the 35thn invoice (aprox.) it already takes around 1 GB of RAM.

Here I also attach the JPGs which are used.

Code: QB64: [Select]

1. tlincre = 150
2. pag = 0
3. DIM menvases$(18)
4.  
5. FOR facturas% = 1 TO tlincre
6.     pag = pag + 1
7.     COLOR 1, 7
8.     LOCATE 10, 30: PRINT "             "
9.     LOCATE 11, 30: PRINT " IMPRIMIENDO "
10.     LOCATE 12, 30: PRINT USING "   Pag:###   "; pag
11.     LOCATE 13, 30: PRINT "             "
12.     COLOR 7, 0
13.     venta$(0) = "1"
14.     envas$(0) = "0": menv = 0
15.     mfac$ = LTRIM$(STR$(facturas%))
16.     mfac$ = STRING$(6 - LEN(mfac$), "0") + mfac$
17.  
18.     abono = 0: sitfac2 = 0: rappel = 0: trappel = 0
19.     FOR n% = 1 TO 18
20.         menvases$(n%) = ""
21.     NEXT
22.     REDIM SHARED RESULTADO(columns, 1) AS STRING
23.  
24.     op = 1
25.     reimp = 1
26.     tbole = 1: nbole = 1
27.     tipocopia = 2
28.     v = 1: a% = 1
29.     DO
30.         GOSUB 20000
31.         v = v + 24
32.         IF v > a% THEN EXIT DO
33.         nbole = nbole + 1
34.     LOOP
35.  
36. NEXT
37.    
38. END
39.  
40. 20000 '------------------ RUTINA DE  IMPRESION --------------------------------
41. FOR copias = 1 TO 2
42.     IF tipocopia = 2 THEN copias = 2
43.     PageScale = 10
44.     PageHeight = 297 * PageScale 'A4 paper size is 210 X 297 mm
45.     PageWidth = 210 * PageScale
46.     Page& = _NEWIMAGE(PageWidth, PageHeight, 32)
47.     _DEST Page&
48.     CLS , _RGB(256, 256, 256)
49.     source_handle = _LOADIMAGE("logo.jpg", 32)
50.     _PUTIMAGE (0, 0), source_handle, Page&
51.     source_handle = _LOADIMAGE("disenofactura6.jpg", 32)
52.     _PUTIMAGE (0, 261), source_handle, Page&
53.     'CursorPosY = 570
54.     PointSize = 12
55.     IF copias = 2 THEN
56.         _DEST Page&
57.         source_handle = _LOADIMAGE("copia.png", 32)
58.         _PUTIMAGE (0, 1000), source_handle, Page&
59.     END IF
60.  
61.     PointSize = 9
62.     FontHeight = INT(PointSize * 0.3527 * PageScale)
63.     FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
64.     _FONT FontHandle
65.  
66.     CursorPosY = 438: CursorPosX = 42: text$ = "   N. de Factura   ": GOSUB PrintTextGris
67.  
68.     PointSize = 12
69.     FontHeight = INT(PointSize * 0.3527 * PageScale)
70.     FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
71.     _FONT FontHandle
72.  
73.     CursorPosY = 326: CursorPosX = 70: text$ = "18/11/19": GOSUB PrintText
74.     CursorPosY = 326: CursorPosX = 410: text$ = "12:25": GOSUB PrintText
75.     CursorPosY = 475: CursorPosX = 95: text$ = mfac$: GOSUB PrintText
76.     b$ = LTRIM$(STR$(tbole)): b$ = SPACE$(2 - LEN(b$)) + b$
77.     a$ = LTRIM$(STR$(nbole)): a$ = "(" + SPACE$(2 - LEN(a$)) + a$ + "/" + b$ + ")"
78.     CursorPosY = 475: CursorPosX = 400: text$ = a$: GOSUB PrintText
79.  
80.     CursorPosY = 330: CursorPosX = 680: text$ = "CLIENTE DE PRUEBA": GOSUB PrintText
81.     CursorPosY = 330: CursorPosX = 1895: text$ = "0125": GOSUB PrintText
82.     CursorPosY = 379: CursorPosX = 680: text$ = "C/la que sea, 2": GOSUB PrintText
83.     CursorPosY = 426: CursorPosX = 680: text$ = "Sevilla": GOSUB PrintText
84.     CursorPosY = 476: CursorPosX = 680: text$ = "Telefono: 902555555": GOSUB PrintText
85.     CursorPosY = 660
86.  
87.     FOR n% = v TO v + 23
88.         IF n% > a% THEN EXIT FOR
89.         '--- Bultos
90.         CursorPosX = 240: a$ = "2": CALL converprin(a$, 10): text$ = a$: GOSUB PrintTextNum
91.         '--- Articulos
92.         CursorPosX = 255: text$ = "PATATAS": GOSUB PrintText
93.         '--- Trazabilidad
94.         CursorPosX = 780: text$ = "1023589547": GOSUB PrintText
95.         '--- K Bruto
96.         CursorPosX = 1206: a$ = "10.25": CALL converprin(a$, 10): text$ = a$: GOSUB PrintTextNum
97.         '--- K Tara
98.         CursorPosX = 1413: a$ = "2": CALL converprin(a$, 9): text$ = a$: GOSUB PrintTextNum
99.         '--- K Neto
100.         CursorPosX = 1622: a$ = "8.25": CALL converprin(a$, 10): text$ = a$: GOSUB PrintTextNum
101.         '--- Precio
102.         CursorPosX = 1804: a$ = "1.3": CALL converprin(a$, 8): text$ = a$: GOSUB PrintTextNum
103.         '--- Total
104.         a = INT(8.25 * 1.3 * 100 + .5) / 100: a$ = LTRIM$(STR$(a))
105.         CursorPosX = 2020: CALL converprin(a$, 10): text$ = a$: GOSUB PrintTextNum
106.         CursorPosY = CursorPosY + 48
107.     NEXT
108.     CursorPosY = 1948: CursorPosX = 388: a$ = "10.73": CALL converprin(a$, 13): text$ = a$: GOSUB PrintTextNum
109.     CursorPosY = 1995: CursorPosX = 388: a$ = "0": CALL converprin(a$, 13): text$ = a$: GOSUB PrintTextNum
110.     CursorPosY = 2045: CursorPosX = 388: a$ = "0": CALL converprin(a$, 13): text$ = a$: GOSUB PrintTextNum
111.     CursorPosY = 1948: CursorPosX = 560: a$ = "4": CALL converprin(a$, 5): text$ = a$: GOSUB PrintTextNum
112.     CursorPosY = 1995: CursorPosX = 560: a$ = "12": CALL converprin(a$, 5): text$ = a$: GOSUB PrintTextNum
113.     CursorPosY = 2045: CursorPosX = 560: a$ = "21": CALL converprin(a$, 5): text$ = a$: GOSUB PrintTextNum
114.     CursorPosY = 1948: CursorPosX = 800: a$ = "0.43": CALL converprin(a$, 12): text$ = a$: GOSUB PrintTextNum
115.     CursorPosY = 1995: CursorPosX = 800: a$ = "0": CALL converprin(a$, 12): text$ = a$: GOSUB PrintTextNum
116.     CursorPosY = 2045: CursorPosX = 800: a$ = "0": CALL converprin(a$, 12): text$ = a$: GOSUB PrintTextNum
117.     CursorPosY = 1948: CursorPosX = 970: a$ = "0.5": CALL converprin(a$, 5): text$ = a$: GOSUB PrintTextNum
118.     CursorPosY = 1995: CursorPosX = 970: a$ = "1.4": CALL converprin(a$, 5): text$ = a$: GOSUB PrintTextNum
119.     CursorPosY = 2045: CursorPosX = 970: a$ = "5.3": CALL converprin(a$, 5): text$ = a$: GOSUB PrintTextNum
120.     CursorPosY = 1948: CursorPosX = 1212: a$ = "0.05": CALL converprin(a$, 12): text$ = a$: GOSUB PrintTextNum
121.     CursorPosY = 1995: CursorPosX = 1212: a$ = "0": CALL converprin(a$, 12): text$ = a$: GOSUB PrintTextNum
122.     CursorPosY = 2045: CursorPosX = 1212: a$ = "0": CALL converprin(a$, 12): text$ = a$: GOSUB PrintTextNum
123.     CursorPosY = 1948: CursorPosX = 1380: a$ = "0": CALL converprin(a$, 5): text$ = a$: GOSUB PrintTextNumGris
124.     CursorPosY = 1948: CursorPosX = 1585: a$ = "0": CALL converprin(a$, 10): text$ = a$: GOSUB PrintTextNumGris
125.     CursorPosY = 2045: CursorPosX = 1340: text$ = " ": GOSUB PrintText
126.  
127.     PointSize = 15
128.     FontHeight = INT(PointSize * 0.3527 * PageScale)
129.     FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
130.     _FONT FontHandle
131.     a$ = "11.21": CALL converprin(a$, 13): text$ = a$ + " EU"
132.  
133.     CursorPosY = 1992: CursorPosX = 2019: GOSUB PrintTextNum
134.  
135.     PointSize = 12
136.     FontHeight = INT(PointSize * 0.3527 * PageScale)
137.     FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
138.     _FONT FontHandle
139.     menvases$(1) = "1"
140.  
141.     IF menvases$(1) <> "" THEN
142.         source_handle = _LOADIMAGE("envases.jpg", 32)
143.         _PUTIMAGE (0, 2250), source_handle, Page&
144.         CursorPosY = 2295: CursorPosX = 230
145.         text$ = "18/11/19": GOSUB PrintText
146.         CursorPosY = 2350: CursorPosX = 230: text$ = mfac$: GOSUB PrintText
147.         CursorPosY = 2405: CursorPosX = 230: text$ = "0125": GOSUB PrintText
148.         CursorPosY = 2460: CursorPosX = 230: text$ = "CLIENTE DE PRUEBA": GOSUB PrintText
149.  
150.         PointSize = 15
151.         FontHeight = INT(PointSize * 0.3527 * PageScale)
152.         FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
153.         _FONT FontHandle
154.         a$ = "11.21": CALL converprin(a$, 13): text$ = a$ + " EU"
155.         CursorPosY = 2535: CursorPosX = 1230: GOSUB PrintTextNumGris
156.         CursorPosY = 2535: CursorPosX = 1229: GOSUB PrintTextNumGris
157.         CursorPosY = 2535: CursorPosX = 1231: GOSUB PrintTextNumGris
158.  
159.         PointSize = 12
160.         FontHeight = INT(PointSize * 0.3527 * PageScale)
161.         FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
162.         _FONT FontHandle
163.  
164.         CursorPosY = 2310
165.         CursorPosX = 1486: a$ = "2": CALL converprin(a$, 8): a$ = LEFT$(a$, 5): text$ = a$: GOSUB PrintTextNum
166.         CursorPosX = 1504: text$ = "BATEA": GOSUB PrintText
167.         CursorPosX = 2010: a$ = "0": CALL converprin(a$, 8): text$ = a$: GOSUB PrintTextNum
168.     ELSE
169.         CursorPosX = 1380: text$ = "-----": GOSUB PrintText
170.         CursorPosX = 1590: text$ = "----------": GOSUB PrintText
171.         CursorPosX = 1870: text$ = "--------": GOSUB PrintText
172.     END IF
173.     CursorPosY = CursorPosY + 45
174.  
175.     CursorPosY = 2850: CursorPosX = 50
176.     text$ = "   Fecha: 18/11/19  N.F.:" + nbol$ + " Cli.:0125 Imp.:"
177.     a$ = LTRIM$(STR$(11.21)): CALL converprin(a$, 13): text$ = text$ + a$
178.     GOSUB PrintText
179.  
180.     _PRINTIMAGE Page&
181.     _FONT 16 'change to the QB64 default font to free it
182.     _FREEFONT FontHandle
183.     _DEST 0
184.  
185.     _FREEIMAGE Page&
186.  
187. NEXT copias
188.  
189.  
190. SLEEP 1
191.  
192. 20520 RETURN
193.  
194.  
195. PrintText:
196. COLOR _RGB(0, 0, 0), _RGBA(255, 255, 255, 255) 'RED text on clear black background
197. 'COLOR 0, 15
198. _PRINTSTRING (CursorPosX, CursorPosY), text$
199. CursorPosX = CursorPosX + _PRINTWIDTH(text$)
200. 'CursorPosY = CursorPosY + FontHeight 'adjust print position down
201. RETURN
202.  
203. PrintTextNum:
204. COLOR _RGB(0, 0, 0), _RGBA(255, 255, 255, 255) 'RED text on clear black background
205. 'COLOR 0, 15
206. _PRINTSTRING (CursorPosX - _PRINTWIDTH(text$), CursorPosY), text$
207. CursorPosX = CursorPosX + 2 * _PRINTWIDTH(text$)
208. 'CursorPosY = CursorPosY + FontHeight 'adjust print position down
209. RETURN
210.  
211. PrintTextNumGris:
212. 'COLOR _RGB(210, 210, 210), _RGBA(256, 256, 256, 256) 'texto gris con fondo blanco
213. 'fondo$ = STRING$(LEN(text$), CHR$(219))
214. '_PRINTSTRING (CursorPosX - _PRINTWIDTH(fondo$), CursorPosY), fondo$
215. COLOR _RGB(0, 0, 0), _RGBA(210, 210, 210, 0) 'texto negro con fondo gris transparente
216. _PRINTSTRING (CursorPosX - _PRINTWIDTH(text$), CursorPosY), text$
217. 'CursorPosX = CursorPosX + 2 * _PRINTWIDTH(text$)
218. 'CursorPosY = CursorPosY + FontHeight 'adjust print position down
219. RETURN
220.  
221. PrintTextGris:
222. COLOR _RGB(0, 0, 0), _RGBA(210, 210, 210, 0) 'texto negro con fondo gris transparente
223. _PRINTSTRING (CursorPosX, CursorPosY), text$
224. CursorPosX = CursorPosX + _PRINTWIDTH(text$)
225. 'CursorPosY = CursorPosY + FontHeight 'adjust print position down
226. RETURN
227.  
228. '-----------------------------------------------------------------------------------------------------------------------------
229. '----------------------------------------------------------- RUTINAS ---------------------------------------------------------
230. '-----------------------------------------------------------------------------------------------------------------------------
231.  
232.  
233. SUB converprin (a$, b)
234.     '----------------------------------------- CONVERTIR NUMERO CON SEPARADORES DE MILES  Y 2 DECIMALES -----------------------
235.     IF VAL(a$) <> 0 THEN
236.         c# = VAL(a$)
237.         d# = c# * 100 + .5
238.         a# = INT(d#)
239.         a$ = LTRIM$(STR$(a#))
240.         IF LEN(a$) = 1 THEN
241.             a$ = "0.0" + a$
242.         ELSEIF LEN(a$) = 2 THEN
243.             IF VAL(a$) < 0 THEN
244.                 a$ = "-0.0" + RIGHT$(a$, 1)
245.             ELSE
246.                 a$ = "0." + a$
247.             END IF
248.         ELSEIF LEN(a$) = 3 AND VAL(a$) < 0 THEN
249.             a$ = "-0." + RIGHT$(a$, 2)
250.         ELSE
251.             a$ = LEFT$(a$, LEN(a$) - 2) + "." + RIGHT$(a$, 2)
252.         END IF
253.     ELSE
254.         a$ = "0.00"
255.     END IF
256.     a = b - LEN(a$)
257.     IF a > 0 THEN
258.         a$ = SPACE$(a) + a$
259.     END IF
260.     IF LEN(a$) - 6 > 0 THEN
261.         IF MID$(a$, LEN(a$) - 6, 1) <> " " AND MID$(a$, LEN(a$) - 6, 1) <> "-" THEN
262.             a$ = LEFT$(a$, LEN(a$) - 6) + "," + MID$(a$, LEN(a$) - 5)
263.             a$ = MID$(a$, 2): '--para quitar caracter que se ha generado por meter la coma
264.         END IF
265.     END IF
266.     IF LEN(a$) - 10 > 0 THEN
267.         IF MID$(a$, LEN(a$) - 10, 1) <> " " AND MID$(a$, LEN(a$) - 10, 1) <> "-" THEN
268.             a$ = LEFT$(a$, LEN(a$) - 10) + "," + MID$(a$, LEN(a$) - 9)
269.             a$ = MID$(a$, 2): '--para quitar caracter que se ha generado por meter la coma
270.         END IF
271.     END IF
272.     IF LEN(a$) - 14 > 0 THEN
273.         IF MID$(a$, LEN(a$) - 14, 1) <> " " AND MID$(a$, LEN(a$) - 14, 1) <> "-" THEN
274.             a$ = LEFT$(a$, LEN(a$) - 14) + "," + MID$(a$, LEN(a$) - 13)
275.             a$ = MID$(a$, 2): '--para quitar caracter que se ha generado por meter la coma
276.         END IF
277.     END IF
278. END SUB
279.  
280.  

[SMcNeill]

Just looking at the start of the code, I can see the issue already.  Let me highlight a few problems:

Code: [Select]

    source_handle = _LOADIMAGE("logo.jpg", 32)
    _PUTIMAGE (0, 0), source_handle, Page&
    source_handle = _LOADIMAGE("disenofactura6.jpg", 32)
    _PUTIMAGE (0, 261), source_handle, Page&
    'CursorPosY = 570
    PointSize = 12
    IF copias = 2 THEN
        _DEST Page&
        source_handle = _LOADIMAGE("copia.png", 32)
How many times are you loading images here?

How many times are you freeing them?

When you do call _FREEIMAGE later, how is it supposed to free all those images whose handle you overwrote??


    source_handle = _LOADIMAGE("logo.jpg", 32)
    _PUTIMAGE (0, 0), source_handle, Page&
    _FREEIMAGE source_handle
    source_handle = _LOADIMAGE("disenofactura6.jpg", 32)
    _PUTIMAGE (0, 261), source_handle, Page&
    _FREEIMAGE source_handle
    'CursorPosY = 570
    PointSize = 12
    IF copias = 2 THEN
        _DEST Page&
        source_handle = _LOADIMAGE("copia.png", 32)


Just because you're repurposing the variable you used to store your image handle, that doesn't mean you freed that image.  Tell me what this would do:

Code: [Select]

source_handle = _LOADIMAGE("logo.jpg", 32)
source_handle = source_handle + 1
_FREEIMAGE source_handle
Our image handle might've been -10, but we changed our variable to make it -9, so either we just freed the wrong image, or else we simply did nothing as there was no image number -9 to free...

You have to free those images before you repurpose your variable, or else you're going to see that massive memory leak which you're describing in your code.

[Juanjogomez]

Thanks for your time.
I didn't know you had to free the memory after loading an image.
I have put a "_FREEIMAGE source_handle" after loading each of the images but the memory continues to increase with each invoice.
It will also have to be placed after each change of font type?

[SMcNeill]

Aye.  It’s the same issues here:

Code: [Select]

    FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
    _FONT FontHandle
 
    CursorPosY = 438: CursorPosX = 42: text$ = "   N. de Factura   ": GOSUB PrintTextGris
 
    PointSize = 12
    FontHeight = INT(PointSize * 0.3527 * PageScale)
    FontHandle = _LOADFONT("c:\windows\fonts\times.ttf", FontHeight)
    _FONT FontHandle
Once again, you’re loading fonts without freeing them, and this generates a memory leak for your program.  Be certain to free those fonts before repurposing that handle for a different one.

[Juanjogomez]

Thank you so much for everything.
What I have done is to load the images and the fonts at the beginning of the program, and then use the handle when I need them.

[SMcNeill]

Thank you so much for everything.
What I have done is to load the images and the fonts at the beginning of the program, and then use the handle when I need them.

That's generally the best bet.  Unless you're going to allow the user to choose the font size, or have a wild variety of images which need to be swapped on and off the map repeatedly, it's usually a good idea to just load them once and then have them available whenever you need them in your program.  It reduces disk reads, prevents the occurrences of accidental memory leaks like you were experiencing, and improves performance time overall.

Unless my program is running into some sort of memory barrier, or doing something really odd with loading/swapping a ton of resources, I tend to just do as you say you're doing now: Load it once and then forget about it.  ;)