memory leak and question

[badger]

Hello

That is ok i figured as much i had to recheck that spot to make sure it was ok being in side the if statement. I understate how they work just not use to using them i have done so visual stuff in vb and vc but quick basic is my choice. I am so glade it has been ported to the 64 bit platform. I just need to see how what you are talking about works.

Badger

[badger]

Hello

i posted i thought i dont think i hit post ugg.

NO problems on the mistake it made me look at that spot to make sure that return should be in that if statement.

I know how subs and functions work i do a little work in vb and vc but my first love is qb 4.5. I am really glad you all ported qb to 64 bit.

badger

[SMcNeill]

A very quick demo of a customer input routine:

Code: QB64: [Select]

1. DIM SHARED n(3) AS STRING
2.  
3.  
4. CLS
5. GetRecord
6. CLS
7. PRINT "This is the record you entered:"
8. PRINT "Customer Name: "; n(1)
9. PRINT "Customer Age :"; n(2)
10. PRINT "Customer Sex :"; n(3)
11.  
12.  
13.  
14.  
15.  
16. SUB GetRecord
17.     'A simple three field record:  name, age, sex
18.     'I could use a TYPE with these, but there's not much point in that.  At least not for just a simple demo
19.     'Instead, I'm just going to use a simple 3 element array, which I dimmed and shared in the main module
20.     DIM c(3) AS STRING * 1 ' And this is just a simple array to hold a cursor so we know where we're entering data at
21.     EntryOn = 1 'Start with the first field by default
22.  
23.     DO
24.         IF EntryOn < 1 THEN EntryOn = 3 'same basic error checking to loop around our fields
25.         IF EntryOn > 3 THEN EntryOn = 1 'same as above
26.         CLS
27.         FOR i = 1 TO 3: c(i) = " ": NEXT 'clear all cursors
28.         c(EntryOn) = CHR$(219)
29.         PRINT "Customer Name: "; n(1); c(1)
30.         PRINT "Customer Age : "; n(2); c(2)
31.         PRINT "Customer Sex : "; n(3); c(3)
32.         PRINT
33.         PRINT "<CTRL-ENTER> to finish."
34.  
35.         k = _KEYHIT
36.         SELECT CASE k
37.             CASE 18432 'up arrow
38.                 EntryOn = EntryOn - 1
39.             CASE 20480, 9 'down arrow, TAB
40.                 EntryOn = EntryOn + 1
41.             CASE 8 'backspace
42.                 n(EntryOn) = LEFT$(n(EntryOn), LEN(n(EntryOn)) - 1)
43.             CASE 65 TO 90, 97 TO 122, 32, 48 TO 57 'A to Z, a TO z, SPACE, 0 to 9
44.                 n(EntryOn) = n(EntryOn) + CHR$(k)
45.             CASE 13
46.                 IF _KEYDOWN(100306) OR _KEYDOWN(100305) THEN 'CTRL is down when we hit enter
47.                     EXIT SUB
48.                 ELSE 'CTRL isn't down.  It's just an ENTER by itself.  Move to the next line
49.                     EntryOn = EntryOn + 1
50.                 END IF
51.         END SELECT
52.         _LIMIT 30
53.     LOOP
54. END SUB
55.  

One short SUB, which is completely self contained in this case, does all the work for us, and it makes it quite easy to navigate and work with our fields.  I'm thinking this is the style input routine which bplus was talking about above, for use.  :)

[bplus]

Yeah I just finished my 50 liner, I turned it into a FUNCTION in case user wants to cancel or quit an edit so it would return 0, otherwise an accepted edit returns -1

Code: QB64: [Select]

1. TYPE customer
2.     id AS LONG
3.     first AS STRING * 25
4.     last AS STRING * 25
5.     address AS STRING * 30
6.     city AS STRING * 25
7.     state AS STRING * 2
8.     zip AS STRING * 5
9.     phone AS STRING * 10
10. END TYPE
11.  
12. DIM SHARED nRecs ' for when you get a file going
13.  
14. DIM myRec AS customer 'edit this record over and over for testing
15. DO
16.     edit = EditCustomer(myRec, 1) ' assign to first record 1 if not Cancelled
17.     CLS
18.     IF edit THEN
19.         PRINT "Record #:"; myRec.id
20.         PRINT "   First:"; myRec.first
21.         PRINT "    Last:"; myRec.last
22.         PRINT " Address:"; myRec.address
23.         PRINT "    City:"; myRec.city
24.         PRINT "   State:"; myRec.state
25.         PRINT "   Phone:"; myRec.phone
26.     ELSE
27.         PRINT "user cancelled edit"
28.     END IF
29.     PRINT "(SLEEPing) press any to continue..."
30.     SLEEP
31.     CLS
32. LOOP
33. 'if edit then fileRec myRec, 1
34.  
35. 'return 0 if user cancelled, -1 if record edit was accepted
36. FUNCTION EditCustomer% (customerRec AS customer, recNumber AS LONG) ' use for new Customer or edit Customer
37.     DIM rec(1 TO 7, 0 TO 1) AS STRING
38.     rec(1, 0) = "First Name"
39.     rec(2, 0) = "Last Name"
40.     rec(3, 0) = "Address"
41.     rec(4, 0) = "City"
42.     rec(5, 0) = "State (abbrev:2)"
43.     rec(6, 0) = "Zip (5)"
44.     rec(7, 0) = "Phone" ' might split to Home and Mobile
45.     IF customerRec.first <> "" THEN rec(1, 1) = customerRec.first
46.     IF customerRec.last <> "" THEN rec(2, 1) = customerRec.last
47.     IF customerRec.address <> "" THEN rec(3, 1) = customerRec.address
48.     IF customerRec.city <> "" THEN rec(4, 1) = customerRec.city
49.     IF customerRec.state <> "" THEN rec(5, 1) = customerRec.state
50.     IF customerRec.zip <> "" THEN rec(6, 1) = customerRec.zip
51.     IF customerRec.phone <> "" THEN rec(7, 1) = customerRec.phone
52.     doAgain:
53.     CLS
54.     FOR i = 1 TO 7 'show what we have
55.         PRINT i, rec(i, 0); " = "; rec(i, 1)
56.     NEXT
57.     PRINT: PRINT "Press a to Accept, n for New, a digit to edit field, or escape to Cancel."
58.     choice$ = getChar$("aAnN1234567" + CHR$(27))
59.     IF ASC(choice$) = 27 THEN ' maybe this should be a function
60.         EditCustomer% = 0: EXIT FUNCTION 'cancelled  EDIT to 0
61.     ELSEIF UCASE$(choice$) = "A" THEN
62.         customerRec.id = recNumber 'assign the record
63.         customerRec.first = rec(1, 1)
64.         customerRec.last = rec(2, 1)
65.         customerRec.address = rec(3, 1)
66.         customerRec.city = rec(4, 1)
67.         customerRec.state = rec(5, 1)
68.         customerRec.zip = rec(6, 1)
69.         customerRec.phone = rec(7, 1)
70.         EditCustomer% = -1: EXIT FUNCTION 'done
71.     ELSEIF UCASE$(choice$) = "N" THEN
72.         CLS
73.         FOR i = 1 TO 7
74.             PRINT rec(i, 0); " > ";
75.             INPUT ""; rec(i, 1)
76.         NEXT
77.         GOTO doAgain
78.     ELSEIF INSTR("1234567", choice$) THEN
79.         CLS
80.         PRINT rec(VAL(choice$), 0); " > ";
81.         INPUT ""; rec(VAL(choice$), 1)
82.         GOTO doAgain
83.     END IF
84. END SUB
85.  
86. FUNCTION getChar$ (fromStr$) ' get a char$ usually for a menu
87.     DIM OK AS INTEGER, k$
88.     WHILE OK = 0
89.         k$ = INKEY$
90.         IF LEN(k$) THEN
91.             IF INSTR(fromStr$, k$) <> 0 THEN OK = -1
92.         END IF
93.         _LIMIT 200
94.     WEND
95.     _KEYCLEAR
96.     getChar$ = k$
97. END SUB
98.  
99.  

EDIT: a last minute change set the cancel to -1, supposed to be 0, fixed.
Updated the record description returned to main code.
Edit2: Got first and last name switched when showing record returned from Function, fixed.

Typically blundering my way to better code ;-))

[TempodiBasic]

so we can say from a large main with so much GOSUB/RETURN (in the place of GOTO labels) we get a shrink SUB of Steve!

just to let be more readable for my eyes that code I have toggled few things

Code: QB64: [Select]

1. CONST cName = 1, cAge = 2, cSex = 3
2. OPTION BASE 1
3. DIM SHARED n(3) AS STRING
4.  
5.  
6. CLS
7. GetRecord
8. CLS
9. PRINT "This is the record you entered:"
10. PRINT "Customer Name: "; n(cName)
11. PRINT "Customer Age :"; n(cAge)
12. PRINT "Customer Sex :"; n(cSex)
13.  
14.  
15.  
16.  
17.  
18. SUB GetRecord
19.     'A simple three field record:  name, age, sex
20.     'I could use a TYPE with these, but there's not much point in that.  At least not for just a simple demo
21.     'Instead, I'm just going to use a simple 3 element array, which I dimmed and shared in the main module
22.     DIM c(3) AS STRING * 1 ' And this is just a simple array to hold a cursor so we know where we're entering data at
23.     EntryOn = 1 'Start with the first field by default
24.  
25.     DO
26.         IF EntryOn < cName THEN EntryOn = cSex 'same basic error checking to loop around our fields
27.         IF EntryOn > cSex THEN EntryOn = cName 'same as above
28.         CLS
29.         FOR i = 1 TO 3: c(i) = " ": NEXT 'clear all cursors
30.         c(EntryOn) = CHR$(219)
31.         PRINT "Customer Name: "; n(cName); c(cName)
32.         PRINT "Customer Age : "; n(cAge); c(cAge)
33.         PRINT "Customer Sex : "; n(cSex); c(cSex)
34.         PRINT
35.         PRINT "<CTRL-ENTER> to finish."
36.  
37.         k = _KEYHIT
38.         SELECT CASE k
39.             CASE 18432 'up arrow
40.                 EntryOn = EntryOn - 1
41.             CASE 20480, 9 'down arrow, TAB
42.                 EntryOn = EntryOn + 1
43.             CASE 8 'backspace
44.                 n(EntryOn) = LEFT$(n(EntryOn), LEN(n(EntryOn)) - 1)
45.             CASE 65 TO 90, 97 TO 122, 32, 48 TO 57 'A to Z, a TO z, SPACE, 0 to 9
46.                 n(EntryOn) = n(EntryOn) + CHR$(k)
47.             CASE 13
48.                 IF _KEYDOWN(100306) OR _KEYDOWN(100305) THEN 'CTRL is down when we hit enter
49.                     EXIT SUB
50.                 ELSE 'CTRL isn't down.  It's just an ENTER by itself.  Move to the next line
51.                     EntryOn = EntryOn + 1
52.                 END IF
53.         END SELECT
54.         _LIMIT 30
55.     LOOP
56. END SUB
57.  
58.  
59.  

[TempodiBasic]

So why I must waste only Steve's work, it is also your turn:
in a gray office program it is beautiful to see more colors...
TA-DA!

Code: QB64: [Select]

1. TYPE customer
2.     id AS LONG
3.     first AS STRING * 25
4.     last AS STRING * 25
5.     address AS STRING * 30
6.     city AS STRING * 25
7.     state AS STRING * 2
8.     zip AS STRING * 5
9.     phone AS STRING * 10
10. END TYPE
11.  
12. DIM SHARED nRecs ' for when you get a file going
13.  
14. DIM myRec AS customer 'edit this record over and over for testing
15. DO
16.     edit = EditCustomer(myRec, 1) ' assign to first record 1 if not Cancelled
17.     CLS
18.     IF edit THEN
19.         PRINT "Record #:"; myRec.id
20.         PRINT "   First:"; myRec.first
21.         PRINT "    Last:"; myRec.last
22.         PRINT " Address:"; myRec.address
23.         PRINT "    City:"; myRec.city
24.         PRINT "   State:"; myRec.state
25.         PRINT "   Phone:"; myRec.phone
26.     ELSE
27.         PRINT "user cancelled edit"
28.     END IF
29.     PRINT "(SLEEPing) press any to continue..."
30.     SLEEP
31.     CLS
32. LOOP
33. 'if edit then fileRec myRec, 1
34.  
35. 'return 0 if user cancelled, -1 if record edit was accepted
36. FUNCTION EditCustomer% (customerRec AS customer, recNumber AS LONG) ' use for new Customer or edit Customer
37.     DIM rec(1 TO 7, 0 TO 1) AS STRING
38.     rec(1, 0) = "First Name"
39.     rec(2, 0) = "Last Name"
40.     rec(3, 0) = "Address"
41.     rec(4, 0) = "City"
42.     rec(5, 0) = "State (abbrev:2)"
43.     rec(6, 0) = "Zip (5)"
44.     rec(7, 0) = "Phone" ' might split to Home and Mobile
45.     IF customerRec.first <> "" THEN rec(1, 1) = customerRec.first
46.     IF customerRec.last <> "" THEN rec(2, 1) = customerRec.last
47.     IF customerRec.address <> "" THEN rec(3, 1) = customerRec.address
48.     IF customerRec.city <> "" THEN rec(4, 1) = customerRec.city
49.     IF customerRec.state <> "" THEN rec(5, 1) = customerRec.state
50.     IF customerRec.zip <> "" THEN rec(6, 1) = customerRec.zip
51.     IF customerRec.phone <> "" THEN rec(7, 1) = customerRec.phone
52.     doAgain:
53.     CLS
54.     FOR i = 1 TO 7 'show what we have
55.         COLOR i: PRINT i, rec(i, 0); " = "; rec(i, 1)
56.     NEXT
57.  
58.     PRINT: PRINT "Press ";: COLOR 2: PRINT "a";: COLOR 7: PRINT " to Accept, ";
59.     COLOR 3: PRINT "n";: COLOR 7: PRINT " for New, a ";
60.     COLOR 4: PRINT "digit";: COLOR 7: PRINT " to edit field, or ";
61.     COLOR 5: PRINT "escape";: COLOR 7: PRINT " to Cancel."
62.     choice$ = getChar$("aAnN1234567" + CHR$(27))
63.     IF ASC(choice$) = 27 THEN ' maybe this should be a function
64.         EditCustomer% = 0: EXIT FUNCTION 'cancelled  EDIT to 0
65.     ELSEIF UCASE$(choice$) = "A" THEN
66.         customerRec.id = recNumber 'assign the record
67.         customerRec.first = rec(1, 1)
68.         customerRec.last = rec(2, 1)
69.         customerRec.address = rec(3, 1)
70.         customerRec.city = rec(4, 1)
71.         customerRec.state = rec(5, 1)
72.         customerRec.zip = rec(6, 1)
73.         customerRec.phone = rec(7, 1)
74.         EditCustomer% = -1: EXIT FUNCTION 'done
75.     ELSEIF UCASE$(choice$) = "N" THEN
76.         CLS
77.         FOR i = 1 TO 7
78.             PRINT rec(i, 0); " > ";
79.             INPUT ""; rec(i, 1)
80.         NEXT
81.         GOTO doAgain
82.     ELSEIF INSTR("1234567", choice$) THEN
83.         CLS
84.         PRINT rec(VAL(choice$), 0); " > ";
85.         INPUT ""; rec(VAL(choice$), 1)
86.         GOTO doAgain
87.     END IF
88. END SUB
89.  
90. FUNCTION getChar$ (fromStr$) ' get a char$ usually for a menu
91.     DIM OK AS INTEGER, k$
92.     WHILE OK = 0
93.         k$ = INKEY$
94.         IF LEN(k$) THEN
95.             IF INSTR(fromStr$, k$) <> 0 THEN OK = -1
96.         END IF
97.         _LIMIT 200
98.     WEND
99.     _KEYCLEAR
100.     getChar$ = k$
101. END SUB
102.  
103.  
104.  

[TempodiBasic]

just to follow my friend enemy of GOTO
here an alternative way of GOTO into FUNCTION

Code: QB64: [Select]

1. TYPE customer
2.     id AS LONG
3.     first AS STRING * 25
4.     last AS STRING * 25
5.     address AS STRING * 30
6.     city AS STRING * 25
7.     state AS STRING * 2
8.     zip AS STRING * 5
9.     phone AS STRING * 10
10. END TYPE
11.  
12. DIM SHARED nRecs ' for when you get a file going
13.  
14. DIM myRec AS customer 'edit this record over and over for testing
15. DO
16.     edit = EditCustomer(myRec, 1) ' assign to first record 1 if not Cancelled
17.     CLS
18.     IF edit THEN
19.         PRINT "Record #:"; myRec.id
20.         PRINT "   First:"; myRec.first
21.         PRINT "    Last:"; myRec.last
22.         PRINT " Address:"; myRec.address
23.         PRINT "    City:"; myRec.city
24.         PRINT "   State:"; myRec.state
25.         PRINT "   Phone:"; myRec.phone
26.     ELSE
27.         PRINT "user cancelled edit"
28.     END IF
29.     PRINT "(SLEEPing) press any to continue..."
30.     SLEEP
31.     CLS
32. LOOP
33. 'if edit then fileRec myRec, 1
34.  
35. 'return 0 if user cancelled, -1 if record edit was accepted
36. FUNCTION EditCustomer% (customerRec AS customer, recNumber AS LONG) ' use for new Customer or edit Customer
37.     DIM rec(1 TO 7, 0 TO 1) AS STRING
38.     rec(1, 0) = "First Name"
39.     rec(2, 0) = "Last Name"
40.     rec(3, 0) = "Address"
41.     rec(4, 0) = "City"
42.     rec(5, 0) = "State (abbrev:2)"
43.     rec(6, 0) = "Zip (5)"
44.     rec(7, 0) = "Phone" ' might split to Home and Mobile
45.     IF customerRec.first <> "" THEN rec(1, 1) = customerRec.first
46.     IF customerRec.last <> "" THEN rec(2, 1) = customerRec.last
47.     IF customerRec.address <> "" THEN rec(3, 1) = customerRec.address
48.     IF customerRec.city <> "" THEN rec(4, 1) = customerRec.city
49.     IF customerRec.state <> "" THEN rec(5, 1) = customerRec.state
50.     IF customerRec.zip <> "" THEN rec(6, 1) = customerRec.zip
51.     IF customerRec.phone <> "" THEN rec(7, 1) = customerRec.phone
52.     doAgain = -1
53.     DO WHILE doAgain
54.         CLS
55.         FOR i = 1 TO 7 'show what we have
56.             COLOR i: PRINT i, rec(i, 0); " = "; rec(i, 1)
57.         NEXT
58.  
59.         PRINT: PRINT "Press ";: COLOR 2: PRINT "a";: COLOR 7: PRINT " to Accept, ";
60.         COLOR 3: PRINT "n";: COLOR 7: PRINT " for New, a ";
61.         COLOR 4: PRINT "digit";: COLOR 7: PRINT " to edit field, or ";
62.         COLOR 5: PRINT "escape";: COLOR 7: PRINT " to Cancel."
63.         choice$ = getChar$("aAnN1234567" + CHR$(27))
64.         IF ASC(choice$) = 27 THEN ' maybe this should be a function
65.             EditCustomer% = 0: EXIT FUNCTION 'cancelled  EDIT to 0
66.         ELSEIF UCASE$(choice$) = "A" THEN
67.             customerRec.id = recNumber 'assign the record
68.             customerRec.first = rec(1, 1)
69.             customerRec.last = rec(2, 1)
70.             customerRec.address = rec(3, 1)
71.             customerRec.city = rec(4, 1)
72.             customerRec.state = rec(5, 1)
73.             customerRec.zip = rec(6, 1)
74.             customerRec.phone = rec(7, 1)
75.             doAgain = 0
76.             EditCustomer% = -1: EXIT FUNCTION 'done
77.         ELSEIF UCASE$(choice$) = "N" THEN
78.             CLS
79.             FOR i = 1 TO 7
80.                 PRINT rec(i, 0); " > ";
81.                 INPUT ""; rec(i, 1)
82.             NEXT
83.             doAgain = -1
84.         ELSEIF INSTR("1234567", choice$) THEN
85.             CLS
86.             PRINT rec(VAL(choice$), 0); " > ";
87.             INPUT ""; rec(VAL(choice$), 1)
88.             doAgain = -1
89.         END IF
90.     LOOP
91. END SUB
92.  
93. FUNCTION getChar$ (fromStr$) ' get a char$ usually for a menu
94.     DIM OK AS INTEGER, k$
95.     WHILE OK = 0
96.         k$ = INKEY$
97.         IF LEN(k$) THEN
98.             IF INSTR(fromStr$, k$) <> 0 THEN OK = -1
99.         END IF
100.         _LIMIT 200
101.     WEND
102.     _KEYCLEAR
103.     getChar$ = k$
104. END SUB
105.