« previous next »
Pages: [1]   Go Down

Author Topic: Too different Tilt Ellipse fills  (Read 4201 times)

0 Members and 1 Guest are viewing this topic.

Offline bplus

  • Global Moderator
  • Forum Resident
  • Posts: 8053
  • b = b + ...
    • View Profile
Too different Tilt Ellipse fills
« on: December 15, 2019, 09:13:50 pm »
I don't get it, in the following app demo of the Toolbox TiltedEllipseFill routine, it works beautifully and the fTiltEllipse routine I came up with today stinks! The Toolbox code can handle very subtle and many layers of transparency but not mine, that needs to start way way more opaque just to be seen and can't do nearly as many layers. Probably something about backgrounds??
Code: QB64: [Select]
  2. _TITLE "Tilted Ellipse app" ' B+ 2019-02-12  add fTiltEllipse routine for comparison
  3.  
  4. CONST xmx = 640
  5. CONST ymx = 640
  6. SCREEN _NEWIMAGE(xmx, ymx, 32)
  7. _SCREENMOVE 340, 40
  8. DIM k AS _UNSIGNED LONG, c, r, stepper, offset, a, x, y
  9. c = xmx / 2
  11. FOR r = 210 TO 0 STEP -30
  12.     stepper = stepper + 30
  13.     offset = offset - _PI(2 / 24)
  14.     FOR a = 0 TO 2 * _PI - .001 STEP _PI(2 / 12)
  15.         x = c + r * COS(a + offset)
  16.         y = c + r * SIN(a + offset)
  17.         k = _RGBA32(0, 0, 200, 15)
  18.         'TiltedEllipseFill 0, x, y, 250 - stepper, stepper, a + offset, k
  19.         fTiltEllipse 0, x, y, 250 - stepper, stepper, a + offset, &H67000090
  20.         _LIMIT 12
  21.     NEXT
  24.  
  25. SUB TiltedEllipseFill (destHandle&, x0, y0, a, b, ang, c AS _UNSIGNED LONG)
  26.     DIM max AS INTEGER, mx2 AS INTEGER, i AS INTEGER, j AS INTEGER, lasti, lastj
  27.     DIM prc AS _UNSIGNED LONG, tef&, k
  28.     prc = _RGB32(255, 255, 255, 255)
  29.     IF a > b THEN max = a + 1 ELSE max = b + 1
  30.     mx2 = max + max
  31.     tef& = _NEWIMAGE(mx2, mx2)
  32.     _DEST tef&
  33.     _SOURCE tef& 'point wont read without this!
  34.     FOR k = 0 TO 6.2832 + .05 STEP .1
  35.         i = max + a * COS(k) * COS(ang) + b * SIN(k) * SIN(ang)
  36.         j = max + a * COS(k) * SIN(ang) - b * SIN(k) * COS(ang)
  37.         IF k <> 0 THEN
  38.             LINE (lasti, lastj)-(i, j), prc
  39.         ELSE
  40.             PSET (i, j), prc
  41.         END IF
  42.         lasti = i: lastj = j
  43.     NEXT
  44.     DIM xleft(mx2) AS INTEGER, xright(mx2) AS INTEGER, x AS INTEGER, y AS INTEGER
  45.     FOR y = 0 TO mx2
  46.         x = 0
  47.         WHILE POINT(x, y) <> prc AND x < mx2
  48.             x = x + 1
  49.         WEND
  50.         xleft(y) = x
  51.         WHILE POINT(x, y) = prc AND x < mx2
  52.             x = x + 1
  53.         WEND
  54.         WHILE POINT(x, y) <> prc AND x < mx2
  55.             x = x + 1
  56.         WEND
  57.         IF x = mx2 THEN xright(y) = xleft(y) ELSE xright(y) = x
  58.     NEXT
  59.     _DEST destHandle&
  60.     FOR y = 0 TO mx2
  61.         IF xleft(y) <> mx2 THEN LINE (xleft(y) + x0 - max, y + y0 - max)-(xright(y) + x0 - max, y + y0 - max), c, BF
  62.     NEXT
  63.     _FREEIMAGE tef&
  65.  
  66.  
  67. 'replace broken toolbox code
  68. 'this needs RotoZoom3 to rotate image BUT it can now scale it also!
  69. SUB fTiltEllipse (destH AS LONG, ox AS INTEGER, oy AS INTEGER, majorRadius AS INTEGER, minorRadius AS INTEGER, radianAngle AS SINGLE, c AS _UNSIGNED LONG)
  70.     'setup isolated area, draw fFlatEllipse and then RotoZoom the image into destination
  71.     'ox, oy is center of ellipse
  72.     'majorRadius is 1/2 the lonest axis
  73.     'minorRadius is 1/2 the short axis
  74.     'radianAngle is the Radian Angle of Tilt
  75.     'c is of course color
  76.     DIM sd&, temp&
  77.     sd& = _DEST
  78.     temp& = _NEWIMAGE(2 * majorRadius, 2 * minorRadius, 32)
  79.     _DEST temp&
  80.     fEllipse majorRadius, minorRadius, majorRadius, minorRadius, c
  81.     _DEST destH
  82.     RotoZoom3 ox, oy, temp&, 1, 1, radianAngle
  83.     _FREEIMAGE temp&
  84.     _DEST sd&
  86.  
  87. 'modified 2019-12-15 _seamless added, rotation convert to radians
  88. SUB RotoZoom3 (X AS LONG, Y AS LONG, Image AS LONG, xScale AS SINGLE, yScale AS SINGLE, radianRotation AS SINGLE) ' 0 at end means no scaling of x or y
  89.     DIM px(3) AS SINGLE: DIM py(3) AS SINGLE
  90.     DIM W&, H&, sinr!, cosr!, i&, x2&, y2&
  91.     W& = _WIDTH(Image&): H& = _HEIGHT(Image&)
  92.     px(0) = -W& / 2: py(0) = -H& / 2: px(1) = -W& / 2: py(1) = H& / 2
  93.     px(2) = W& / 2: py(2) = H& / 2: px(3) = W& / 2: py(3) = -H& / 2
  94.     sinr! = SIN(-radianRotation): cosr! = COS(-radianRotation)
  95.     FOR i& = 0 TO 3
  96.         x2& = (px(i&) * cosr! + sinr! * py(i&)) + X * xScale: y2& = (py(i&) * cosr! - px(i&) * sinr!) + Y * yScale
  97.         px(i&) = x2&: py(i&) = y2&
  98.     NEXT
  99.     _MAPTRIANGLE _SEAMLESS(0, 0)-(0, H& - 1)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(1), py(1))-(px(2), py(2))
  100.     _MAPTRIANGLE _SEAMLESS(0, 0)-(W& - 1, 0)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(3), py(3))-(px(2), py(2))
  102.  
  103. 'this seems to work as well as any
  104. SUB fEllipse (CX AS LONG, CY AS LONG, xRadius AS LONG, yRadius AS LONG, c AS _UNSIGNED LONG)
  105.     DIM scale AS SINGLE, x AS LONG, y AS LONG
  106.     scale = yRadius / xRadius
  107.     LINE (CX, CY - yRadius)-(CX, CY + yRadius), c, BF
  108.     FOR x = 1 TO xRadius
  109.         y = scale * SQR(xRadius * xRadius - x * x)
  110.         LINE (CX + x, CY - y)-(CX + x, CY + y), c, BF
  111.         LINE (CX - x, CY - y)-(CX - x, CY + y), c, BF
  112.     NEXT
  114.  
  115.  


But in the recent megaphone drawing app, the toolbox code leaves a striping of horizontal lines often, using transparencies or not, whereas my fTiltEllipse routine of today does fine filling with a nice smooth layer:

Code: QB64: [Select]
  1. _TITLE "fTiltEllipse tests" 'b+ 2019-12-15
  2. 'test code from "Draw megaphone Test, click 4 points in clockwise direction first pair is one opening and 2nd is 2nd." 'B+ 2019-12-15
  3.  
  4. CONST xmax = 800, ymax = 600
  5. SCREEN _NEWIMAGE(xmax, ymax, 32)
  6. _SCREENMOVE 300, 40
  7.  
  9.     CLS
  10.     WHILE pi < 4 'get 4 mouse clicks
  11.         _PRINTSTRING (5, 5), SPACE$(20)
  12.         _PRINTSTRING (5, 5), "Need 4 clicks, have" + STR$(pi)
  13.         WHILE _MOUSEINPUT: WEND
  14.         IF _MOUSEBUTTON(1) AND oldMouse = 0 THEN 'new mouse down
  15.             pi = pi + 1
  16.             mx(pi) = _MOUSEX: my(pi) = _MOUSEY
  17.             CIRCLE (mx(pi), my(pi)), 2
  18.         END IF
  19.         oldMouse = _MOUSEBUTTON(1)
  20.         _DISPLAY
  21.         _LIMIT 60
  22.     WEND
  23.     LINE (mx(2), my(2))-(mx(3), my(3))
  24.     LINE (mx(4), my(4))-(mx(1), my(1))
  25.     ang1 = _ATAN2(my(2) - my(1), mx(2) - mx(1))
  26.     maj1 = (_HYPOT(mx(1) - mx(2), my(1) - my(2))) / 2
  27.     min1 = .1 * maj1
  28.     cx1 = (mx(1) + mx(2)) / 2
  29.     cy1 = (my(1) + my(2)) / 2
  30.     EllipseTilt cx1, cy1, maj1, min1, ang1, &HFFFFFFFF
  31.     ang2 = _ATAN2(my(3) - my(4), mx(3) - mx(4))
  32.     maj2 = (_HYPOT(mx(3) - mx(4), my(3) - my(4))) / 2
  33.     min2 = .1 * maj2
  34.     cx2 = (mx(3) + mx(4)) / 2
  35.     cy2 = (my(3) + my(4)) / 2
  36.     EllipseTilt cx2, cy2, maj2, min2, ang2, &HFFFFFFFF
  37.     _DISPLAY
  38.     _DELAY 3
  39.     CLS
  40.     _PRINTSTRING (5, 5), "Sleeping, wake with click or keypress..."
  41.     'fTiltEllipse 0, cx2, cy2, maj2, min2, ang2, &H880000FF 'check trnasparency
  42.     TiltedEllipseFill 0, cx2, cy2, maj2, min2, ang2, &HFF0000FF 'check trnasparency <<< Toolbox fill
  43.     fquad mx(1), my(1), mx(2), my(2), mx(3), my(3), mx(4), my(4), &H880000FF
  44.     'fTiltEllipse 0, cx1, cy1, maj1, min1, ang1, &H88FFFF00
  45.     TiltedEllipseFill 0, cx1, cy1, maj1, min1, ang1, &HFFFFFF00 '<<<<<<<<<<<<<<<<<<<<<<< Toolbox fill
  46.     _DISPLAY
  47.     cSleep 45
  48.  
  49.     pi = 0 'point index
  51.  
  52. 'thanks STxAxTIC from Toolbox
  53. SUB EllipseTilt (CX, CY, a, b, ang, C AS _UNSIGNED LONG)
  54.     DIM k, i, j
  55.     '  CX = center x coordinate
  56.     '  CY = center y coordinate
  57.     '   a = semimajor axis  major radius
  58.     '   b = semiminor axis  minor radius
  59.     ' ang = clockwise orientation of semimajor axis in radians (0 default)
  60.     '   C = fill color
  61.     FOR k = 0 TO 6.283185307179586 + .025 STEP .025
  62.         i = a * COS(k) * COS(ang) + b * SIN(k) * SIN(ang)
  63.         j = -a * COS(k) * SIN(ang) + b * SIN(k) * COS(ang)
  64.         i = i + CX
  65.         j = -j + CY
  66.         IF k <> 0 THEN
  67.             LINE -(i, j), C
  68.         ELSE
  69.             PSET (i, j), C
  70.         END IF
  71.     NEXT
  73.  
  74. 'relace broken toolbax code
  75. 'this needs RotoZoom3 to rotate image BUT it can now scale it also!
  76. SUB fTiltEllipse (destH AS LONG, ox AS INTEGER, oy AS INTEGER, majorRadius AS INTEGER, minorRadius AS INTEGER, radianAngle AS SINGLE, c AS _UNSIGNED LONG)
  77.     'setup isolated area, draw fFlatEllipse and then RotoZoom the image into destination
  78.     'ox, oy is center of ellipse
  79.     'majorRadius is 1/2 the lonest axis
  80.     'minorRadius is 1/2 the short axis
  81.     'radianAngle is the Radian Angle of Tilt
  82.     'c is of course color
  83.     sd& = _DEST
  84.     temp& = _NEWIMAGE(2 * majorRadius, 2 * minorRadius, 32)
  85.     _DEST temp&
  86.     fEllipse majorRadius, minorRadius, majorRadius, minorRadius, c
  87.     _DEST destH
  88.     RotoZoom3 ox, oy, temp&, 1, 1, radianAngle
  89.     _FREEIMAGE temp&
  90.     _DEST sd&
  92.  
  93. 'modified 2019-12-15 _seamless added, rotation convert to radians
  94. SUB RotoZoom3 (X AS LONG, Y AS LONG, Image AS LONG, xScale AS SINGLE, yScale AS SINGLE, radianRotation AS SINGLE) ' 0 at end means no scaling of x or y
  95.     DIM px(3) AS SINGLE: DIM py(3) AS SINGLE
  96.     W& = _WIDTH(Image&): H& = _HEIGHT(Image&)
  97.     px(0) = -W& / 2: py(0) = -H& / 2: px(1) = -W& / 2: py(1) = H& / 2
  98.     px(2) = W& / 2: py(2) = H& / 2: px(3) = W& / 2: py(3) = -H& / 2
  99.     sinr! = SIN(-radianRotation): cosr! = COS(-radianRotation)
  100.     FOR i& = 0 TO 3
  101.         x2& = (px(i&) * cosr! + sinr! * py(i&)) + X * xScale: y2& = (py(i&) * cosr! - px(i&) * sinr!) + Y * yScale
  102.         px(i&) = x2&: py(i&) = y2&
  103.     NEXT
  104.     _MAPTRIANGLE _SEAMLESS(0, 0)-(0, H& - 1)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(1), py(1))-(px(2), py(2))
  105.     _MAPTRIANGLE _SEAMLESS(0, 0)-(W& - 1, 0)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(3), py(3))-(px(2), py(2))
  107.  
  108. 'this seems to work as well as any
  109. SUB fEllipse (CX AS LONG, CY AS LONG, xRadius AS LONG, yRadius AS LONG, c AS _UNSIGNED LONG)
  110.     DIM scale AS SINGLE, x AS LONG, y AS LONG
  111.     scale = yRadius / xRadius
  112.     LINE (CX, CY - yRadius)-(CX, CY + yRadius), c, BF
  113.     FOR x = 1 TO xRadius
  114.         y = scale * SQR(xRadius * xRadius - x * x)
  115.         LINE (CX + x, CY - y)-(CX + x, CY + y), c, BF
  116.         LINE (CX - x, CY - y)-(CX - x, CY + y), c, BF
  117.     NEXT
  119.  
  120. ' found at [abandoned, outdated and now likely malicious qb64 dot net website - don’t go there]:    http://www.[abandoned, outdated and now likely malicious qb64 dot net website - don’t go there]/forum/index.php?topic=14425.0
  121. SUB ftri (x1, y1, x2, y2, x3, y3, K AS _UNSIGNED LONG)
  122.     DIM D AS LONG
  123.     D = _DEST
  124.     a& = _NEWIMAGE(1, 1, 32)
  125.     _DEST a&
  126.     PSET (0, 0), K
  127.     _DEST D
  128.     _MAPTRIANGLE _SEAMLESS(0, 0)-(0, 0)-(0, 0), a& TO(x1, y1)-(x2, y2)-(x3, y3)
  129.     _FREEIMAGE a& '<<< this is important!
  131.  
  132. '2019-11-20 Steve saves some time with STATIC and saves and restores last dest
  133. SUB ftri1 (x1, y1, x2, y2, x3, y3, K AS _UNSIGNED LONG)
  134.     DIM D AS LONG
  135.     STATIC a&
  136.     D = _DEST
  137.     IF a& = 0 THEN a& = _NEWIMAGE(1, 1, 32)
  138.     _DEST a&
  139.     PSET (0, 0), K
  140.     _DEST D
  141.     _MAPTRIANGLE _SEAMLESS(0, 0)-(0, 0)-(0, 0), a& TO(x1, y1)-(x2, y2)-(x3, y3)
  143.  
  144. 'need 4 non linear points (not all on 1 line) list them clockwise so x2, y2 is opposite of x4, y4
  145. SUB fquad (x1, y1, x2, y2, x3, y3, x4, y4, K AS _UNSIGNED LONG)
  146.     ftri x1, y1, x2, y2, x4, y4, K
  147.     ftri x3, y3, x2, y2, x4, y4, K
  149.  
  150. SUB cSleep (secsWait AS DOUBLE) 'wait for keypress or mouseclick, solves midnight problem nicely I think
  151.     DIM wayt AS INTEGER, oldMouse AS INTEGER, k AS LONG, startTime AS DOUBLE
  152.  
  153.     startTime = TIMER
  154.     wayt = 1
  155.     _KEYCLEAR
  156.     WHILE wayt
  157.         WHILE _MOUSEINPUT: WEND
  158.         IF _MOUSEBUTTON(1) AND oldMouse = 0 THEN wayt = 0
  159.         oldMouse = _MOUSEBUTTON(1) ' <<< this is Steve's cool way to get clear of mouse click
  160.         k = _KEYHIT: IF k > 0 THEN _KEYCLEAR: wayt = 0
  161.         IF TIMER - startTime < 0 THEN 'past midnight
  162.             IF TIMER + 24 * 60 * 60 - startTime > secsWait THEN wayt = 0
  163.         ELSE
  164.             IF TIMER - startTime >= secsWait THEN wayt = 0
  165.         END IF
  166.         _LIMIT 30
  167.     WEND
  169.  
  170. SUB TiltedEllipseFill (destHandle&, x0, y0, a, b, ang, c AS _UNSIGNED LONG)
  171.     DIM max AS INTEGER, mx2 AS INTEGER, i AS INTEGER, j AS INTEGER, lasti, lastj
  172.     DIM prc AS _UNSIGNED LONG, tef&, k
  173.     prc = _RGB32(255, 255, 255, 255)
  174.     IF a > b THEN max = a + 1 ELSE max = b + 1
  175.     mx2 = max + max
  176.     tef& = _NEWIMAGE(mx2, mx2)
  177.     _DEST tef&
  178.     _SOURCE tef& 'point wont read without this!
  179.     FOR k = 0 TO 6.2832 + .05 STEP .1
  180.         i = max + a * COS(k) * COS(ang) + b * SIN(k) * SIN(ang)
  181.         j = max + a * COS(k) * SIN(ang) - b * SIN(k) * COS(ang)
  182.         IF k <> 0 THEN
  183.             LINE (lasti, lastj)-(i, j), prc
  184.         ELSE
  185.             PSET (i, j), prc
  186.         END IF
  187.         lasti = i: lastj = j
  188.     NEXT
  189.     DIM xleft(mx2) AS INTEGER, xright(mx2) AS INTEGER, x AS INTEGER, y AS INTEGER
  190.     FOR y = 0 TO mx2
  191.         x = 0
  192.         WHILE POINT(x, y) <> prc AND x < mx2
  193.             x = x + 1
  194.         WEND
  195.         xleft(y) = x
  196.         WHILE POINT(x, y) = prc AND x < mx2
  197.             x = x + 1
  198.         WEND
  199.         WHILE POINT(x, y) <> prc AND x < mx2
  200.             x = x + 1
  201.         WEND
  202.         IF x = mx2 THEN xright(y) = xleft(y) ELSE xright(y) = x
  203.     NEXT
  204.     _DEST destHandle&
  205.     FOR y = 0 TO mx2
  206.         IF xleft(y) <> mx2 THEN LINE (xleft(y) + x0 - max, y + y0 - max)-(xright(y) + x0 - max, y + y0 - max), c, BF
  207.     NEXT
  208.     _FREEIMAGE tef&
  210.  
  211.  
  212.  

Why such radically different results?
« Last Edit: December 15, 2019, 09:20:26 pm by bplus »
Logged

Offline bplus

  • Global Moderator
  • Forum Resident
  • Posts: 8053
  • b = b + ...
    • View Profile
Re: Too different Tilt Ellipse fills
« Reply #1 on: December 16, 2019, 04:50:53 pm »
OK the _DONTBLEND / _BLEND trick worked to fix my stinky fTiltEllipse in the first code app so both versions work equally well in display quality. Not even sure I need _BLEND in that sub since I throw away the handle for a different size ellipse if needed.
Code: QB64: [Select]
  2. _TITLE "Tilted Ellipse app" ' B+ 2019-02-12  add fTiltEllipse routine for comparison
  3.  
  4. CONST xmx = 640
  5. CONST ymx = 640
  6. SCREEN _NEWIMAGE(xmx, ymx, 32)
  7. _SCREENMOVE 340, 40
  8. DIM k AS _UNSIGNED LONG, c, r, stepper, offset, a, x, y, start!
  9. c = xmx / 2
  11. start! = TIMER(.001)
  12. FOR r = 210 TO 0 STEP -30
  13.     stepper = stepper + 30
  14.     offset = offset - _PI(2 / 24)
  15.     FOR a = 0 TO 2 * _PI - .001 STEP _PI(2 / 12)
  16.         x = c + r * COS(a + offset)
  17.         y = c + r * SIN(a + offset)
  18.         k = _RGBA32(0, 0, 200, 15)
  19.         TiltedEllipseFill 0, x, y, 250 - stepper, stepper, a + offset, k
  20.         'fTiltEllipse 0, x, y, 250 - stepper, stepper, a + offset, k
  21.         '_LIMIT 12
  22.     NEXT
  24. PRINT INT((TIMER(.001) - start!) * 100) / 100; "secs"
  26.  
  27. SUB TiltedEllipseFill (destHandle&, x0, y0, a, b, ang, c AS _UNSIGNED LONG)
  28.     DIM max AS INTEGER, mx2 AS INTEGER, i AS INTEGER, j AS INTEGER, lasti, lastj
  29.     DIM prc AS _UNSIGNED LONG, tef&, k
  30.     prc = _RGB32(255, 255, 255, 255)
  31.     IF a > b THEN max = a + 1 ELSE max = b + 1
  32.     mx2 = max + max
  33.     tef& = _NEWIMAGE(mx2, mx2)
  34.     _DEST tef&
  35.     _SOURCE tef& 'point wont read without this!
  36.     FOR k = 0 TO 6.2832 + .05 STEP .1
  37.         i = max + a * COS(k) * COS(ang) + b * SIN(k) * SIN(ang)
  38.         j = max + a * COS(k) * SIN(ang) - b * SIN(k) * COS(ang)
  39.         IF k <> 0 THEN
  40.             LINE (lasti, lastj)-(i, j), prc
  41.         ELSE
  42.             PSET (i, j), prc
  43.         END IF
  44.         lasti = i: lastj = j
  45.     NEXT
  46.     DIM xleft(mx2) AS INTEGER, xright(mx2) AS INTEGER, x AS INTEGER, y AS INTEGER
  47.     FOR y = 0 TO mx2
  48.         x = 0
  49.         WHILE POINT(x, y) <> prc AND x < mx2
  50.             x = x + 1
  51.         WEND
  52.         xleft(y) = x
  53.         WHILE POINT(x, y) = prc AND x < mx2
  54.             x = x + 1
  55.         WEND
  56.         WHILE POINT(x, y) <> prc AND x < mx2
  57.             x = x + 1
  58.         WEND
  59.         IF x = mx2 THEN xright(y) = xleft(y) ELSE xright(y) = x
  60.     NEXT
  61.     _DEST destHandle&
  62.     FOR y = 0 TO mx2
  63.         IF xleft(y) <> mx2 THEN LINE (xleft(y) + x0 - max, y + y0 - max)-(xright(y) + x0 - max, y + y0 - max), c, BF
  64.     NEXT
  65.     _FREEIMAGE tef&
  67.  
  68.  
  69. 'relace broken toolbox code
  70. 'this needs RotoZoom3 to rotate image and fEllipse to make an image BUT it can now scale it also!
  71. SUB fTiltEllipse (destH AS LONG, ox AS INTEGER, oy AS INTEGER, majorRadius AS INTEGER, minorRadius AS INTEGER, radianAngle AS SINGLE, c AS _UNSIGNED LONG)
  72.     'setup isolated area, draw fFlatEllipse and then RotoZoom the image into destination
  73.     'ox, oy is center of ellipse
  74.     'majorRadius is 1/2 the lonest axis
  75.     'minorRadius is 1/2 the short axis
  76.     'radianAngle is the Radian Angle of Tilt
  77.     'c is of course color
  78.     DIM sd&, temp&
  79.     sd& = _DEST
  80.     temp& = _NEWIMAGE(2 * majorRadius, 2 * minorRadius, 32)
  81.     _DEST temp&
  82.     _DONTBLEND temp& '<< test 12-16
  83.     fEllipse majorRadius, minorRadius, majorRadius, minorRadius, c
  84.     _BLEND temp& '<< test 12-16
  85.     _DEST destH
  86.     RotoZoom3 ox, oy, temp&, 1, 1, radianAngle
  87.     _FREEIMAGE temp&
  88.     _DEST sd&
  90.  
  91. 'modified 2019-12-15 _seamless added, rotation convert to radians
  92. SUB RotoZoom3 (X AS LONG, Y AS LONG, Image AS LONG, xScale AS SINGLE, yScale AS SINGLE, radianRotation AS SINGLE) ' 0 at end means no scaling of x or y
  93.     DIM px(3) AS SINGLE: DIM py(3) AS SINGLE
  94.     DIM W&, H&, sinr!, cosr!, i&, x2&, y2&
  95.     W& = _WIDTH(Image&): H& = _HEIGHT(Image&)
  96.     px(0) = -W& / 2: py(0) = -H& / 2: px(1) = -W& / 2: py(1) = H& / 2
  97.     px(2) = W& / 2: py(2) = H& / 2: px(3) = W& / 2: py(3) = -H& / 2
  98.     sinr! = SIN(-radianRotation): cosr! = COS(-radianRotation)
  99.     FOR i& = 0 TO 3
  100.         x2& = (px(i&) * cosr! + sinr! * py(i&)) + X * xScale: y2& = (py(i&) * cosr! - px(i&) * sinr!) + Y * yScale
  101.         px(i&) = x2&: py(i&) = y2&
  102.     NEXT
  103.     _MAPTRIANGLE _SEAMLESS(0, 0)-(0, H& - 1)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(1), py(1))-(px(2), py(2))
  104.     _MAPTRIANGLE _SEAMLESS(0, 0)-(W& - 1, 0)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(3), py(3))-(px(2), py(2))
  106.  
  107. 'this seems to work as well as any
  108. SUB fEllipse (CX AS LONG, CY AS LONG, xRadius AS LONG, yRadius AS LONG, c AS _UNSIGNED LONG)
  109.     DIM scale AS SINGLE, x AS LONG, y AS LONG
  110.     scale = yRadius / xRadius
  111.     LINE (CX, CY - yRadius)-(CX, CY + yRadius), c, BF
  112.     FOR x = 1 TO xRadius
  113.         y = scale * SQR(xRadius * xRadius - x * x)
  114.         LINE (CX + x, CY - y)-(CX + x, CY + y), c, BF
  115.         LINE (CX - x, CY - y)-(CX - x, CY + y), c, BF
  116.     NEXT
  118.  
  119.  
  120.  

Oh hell yeah! I need the _BLEND also  LOL

Update: fTiltEllipse is about 3 times faster and has the same or less code lines including 2 subs you can use for other things.
« Last Edit: December 16, 2019, 06:35:44 pm by bplus »
Logged

Offline bplus

  • Global Moderator
  • Forum Resident
  • Posts: 8053
  • b = b + ...
    • View Profile
Re: Too different Tilt Ellipse fills
« Reply #2 on: December 16, 2019, 07:17:10 pm »
Turns out Toolbox code wasn't broken so much as it just needed it's parameter types declared:
Code: QB64: [Select]
  1. 'fixed 2019-12-16 B+
  2. SUB TiltedEllipseFill (destHandle&, x0 AS INTEGER, y0 AS INTEGER, a AS SINGLE, b AS SINGLE, ang AS SINGLE, c AS _UNSIGNED LONG)
  3.     DIM max AS INTEGER, mx2 AS INTEGER, i AS INTEGER, j AS INTEGER, lasti AS INTEGER, lastj AS INTEGER
  4.     DIM prc AS _UNSIGNED LONG, tef&, k AS SINGLE, x AS INTEGER, y AS INTEGER
  5.     prc = _RGB32(255, 255, 255, 255)
  6.     IF a > b THEN max = a + 1 ELSE max = b + 1
  7.     mx2 = max + max
  8.     DIM xleft(mx2) AS INTEGER, xright(mx2) AS INTEGER
  9.     tef& = _NEWIMAGE(mx2, mx2)
  10.     _DEST tef&
  11.     _SOURCE tef& 'point wont read without this!
  12.     FOR k = 0 TO 6.2832 + .05 STEP .05
  13.         i = max + a * COS(k) * COS(ang) + b * SIN(k) * SIN(ang)
  14.         j = max + a * COS(k) * SIN(ang) - b * SIN(k) * COS(ang)
  15.         IF k <> 0 THEN
  16.             LINE (lasti, lastj)-(i, j), prc
  17.         ELSE
  18.             PSET (i, j), prc
  19.         END IF
  20.         lasti = i: lastj = j
  21.     NEXT
  22.     FOR y = 0 TO mx2
  23.         x = 0
  24.         WHILE POINT(x, y) <> prc AND x < mx2
  25.             x = x + 1
  26.         WEND
  27.         xleft(y) = x
  28.         WHILE POINT(x, y) = prc AND x < mx2
  29.             x = x + 1
  30.         WEND
  31.         WHILE POINT(x, y) <> prc AND x < mx2
  32.             x = x + 1
  33.         WEND
  34.         IF x = mx2 THEN xright(y) = xleft(y) ELSE xright(y) = x
  35.     NEXT
  36.     _DEST destHandle&
  37.     FOR y = 0 TO mx2
  38.         IF xleft(y) <> mx2 THEN LINE (xleft(y) + x0 - max, y + y0 - max)-(xright(y) + x0 - max, y + y0 - max), c, BF
  39.     NEXT
  40.     _FREEIMAGE tef&
  42.  

Unfortunately it didn't speed up the code all that much, but overall our fortunes have been improved because if it weren't for sloppy declares of parameters would never have found code that does the same thing 3 times faster, the error I had in fTri since it's inception, the fix for cSleep or Steve's Pause, the improvement in RotoZoom3 and what Steve and all who paid attention found about _DONTBLEND.

How Blunderfull. ;-))
« Last Edit: December 16, 2019, 07:19:55 pm by bplus »
Logged

Offline bplus

  • Global Moderator
  • Forum Resident
  • Posts: 8053
  • b = b + ...
    • View Profile
Re: Too different Tilt Ellipse fills
« Reply #3 on: December 16, 2019, 08:45:41 pm »
I just tracked down the big discussion of Ellipse Fills
https://www.qb64.org/forum/index.php?topic=1044.0
Logged

Offline STxAxTIC

  • Library Staff
  • Forum Resident
  • Posts: 1091
  • he lives
    • View Profile
Re: Too different Tilt Ellipse fills
« Reply #4 on: December 16, 2019, 09:47:20 pm »
(In case it wasn't super obvious, that thread is linked at the top of the Toolbox header for the filled ellipse page.)
Logged
You're not done when it works, you're done when it's right.

Offline bplus

  • Global Moderator
  • Forum Resident
  • Posts: 8053
  • b = b + ...
    • View Profile
Re: Too different Tilt Ellipse fills
« Reply #5 on: December 16, 2019, 09:58:38 pm »
Quote from: STxAxTIC on December 16, 2019, 09:47:20 pm
(In case it wasn't super obvious, that thread is linked at the top of the Toolbox header for the filled ellipse page.)

Yikes! another great reading job by bplus...

OK so just skimmed through 11 pages of ... oh boy more reading...

Anyway, I tried the other code for a Flat EllipseFill and shaved a couple .01's of a second off the time on average for this nice little app for testing TiltedEllipseFills versus fTiltEllipse so now maybe fTiltEllipse is 3-4 times faster than what we came up with in Feb, 2019.
Code: QB64: [Select]
  2. _TITLE "Tilted Ellipse app" ' B+ 2019-02-12  add fTiltEllipse routine for comparison 2019-12-16 plus added
  3. '2 Flat Ellipse Fill routines for the new fTiltEllipse routine looking to be almost 4 times faster now.
  4.  
  5. CONST xmx = 640
  6. CONST ymx = 640
  7. SCREEN _NEWIMAGE(xmx, ymx, 32)
  8. _SCREENMOVE 340, 40
  9. DIM k AS _UNSIGNED LONG, c, r, stepper, offset, a, x, y, start!
  10. c = xmx / 2
  12. start! = TIMER(.001)
  13. FOR r = 210 TO 0 STEP -30
  14.     stepper = stepper + 30
  15.     offset = offset - _PI(2 / 24)
  16.     FOR a = 0 TO 2 * _PI - .001 STEP _PI(2 / 12)
  17.         x = c + r * COS(a + offset)
  18.         y = c + r * SIN(a + offset)
  19.         k = _RGBA32(0, 0, 200, 15)
  20.         'TiltedEllipseFill 0, x, y, 250 - stepper, stepper, a + offset, k
  21.         fTiltEllipse 0, x, y, 250 - stepper, stepper, a + offset, k
  22.         '_LIMIT 12
  23.     NEXT
  25. PRINT INT((TIMER(.001) - start!) * 100) / 100; "secs"
  27.  
  28. 'fixed Toolbox code
  29. SUB TiltedEllipseFill (destHandle&, x0 AS INTEGER, y0 AS INTEGER, a AS SINGLE, b AS SINGLE, ang AS SINGLE, c AS _UNSIGNED LONG)
  30.     DIM max AS INTEGER, mx2 AS INTEGER, i AS INTEGER, j AS INTEGER, lasti AS INTEGER, lastj AS INTEGER
  31.     DIM prc AS _UNSIGNED LONG, tef&, k AS SINGLE, x AS INTEGER, y AS INTEGER
  32.     prc = _RGB32(255, 255, 255, 255)
  33.     IF a > b THEN max = a + 1 ELSE max = b + 1
  34.     mx2 = max + max
  35.     DIM xleft(mx2) AS INTEGER, xright(mx2) AS INTEGER
  36.     tef& = _NEWIMAGE(mx2, mx2)
  37.     _DEST tef&
  38.     _SOURCE tef& 'point wont read without this!
  39.     FOR k = 0 TO 6.2832 + .05 STEP .05
  40.         i = max + a * COS(k) * COS(ang) + b * SIN(k) * SIN(ang)
  41.         j = max + a * COS(k) * SIN(ang) - b * SIN(k) * COS(ang)
  42.         IF k <> 0 THEN
  43.             LINE (lasti, lastj)-(i, j), prc
  44.         ELSE
  45.             PSET (i, j), prc
  46.         END IF
  47.         lasti = i: lastj = j
  48.     NEXT
  49.     FOR y = 0 TO mx2
  50.         x = 0
  51.         WHILE POINT(x, y) <> prc AND x < mx2
  52.             x = x + 1
  53.         WEND
  54.         xleft(y) = x
  55.         WHILE POINT(x, y) = prc AND x < mx2
  56.             x = x + 1
  57.         WEND
  58.         WHILE POINT(x, y) <> prc AND x < mx2
  59.             x = x + 1
  60.         WEND
  61.         IF x = mx2 THEN xright(y) = xleft(y) ELSE xright(y) = x
  62.     NEXT
  63.     _DEST destHandle&
  64.     FOR y = 0 TO mx2
  65.         IF xleft(y) <> mx2 THEN LINE (xleft(y) + x0 - max, y + y0 - max)-(xright(y) + x0 - max, y + y0 - max), c, BF
  66.     NEXT
  67.     _FREEIMAGE tef&
  69.  
  70. 'relace broken toolbox code
  71. 'this needs RotoZoom3 to rotate image and fEllipse to make th eimage BUT it can now scale it also!
  72. SUB fTiltEllipse (destH AS LONG, ox AS INTEGER, oy AS INTEGER, majorRadius AS INTEGER, minorRadius AS INTEGER, radianAngle AS SINGLE, c AS _UNSIGNED LONG)
  73.     'setup isolated area, draw fFlatEllipse and then RotoZoom the image into destination
  74.     'ox, oy is center of ellipse
  75.     'majorRadius is 1/2 the lonest axis
  76.     'minorRadius is 1/2 the short axis
  77.     'radianAngle is the Radian Angle of Tilt
  78.     'c is of course color
  79.     DIM sd&, temp&
  80.     sd& = _DEST
  81.     temp& = _NEWIMAGE(2 * majorRadius, 2 * minorRadius, 32)
  82.     _DEST temp&
  83.     _DONTBLEND temp& '<< test 12-16
  84.     'fEllipse majorRadius, minorRadius, majorRadius, minorRadius, c
  85.     EllipseFill majorRadius, minorRadius, majorRadius, minorRadius, c
  86.     _BLEND temp& '<< test 12-16
  87.     _DEST destH
  88.     RotoZoom3 ox, oy, temp&, 1, 1, radianAngle
  89.     _FREEIMAGE temp&
  90.     _DEST sd&
  92.  
  93. 'modified 2019-12-15 _seamless added, rotation convert to radians
  94. SUB RotoZoom3 (X AS LONG, Y AS LONG, Image AS LONG, xScale AS SINGLE, yScale AS SINGLE, radianRotation AS SINGLE) ' 0 at end means no scaling of x or y
  95.     DIM px(3) AS SINGLE: DIM py(3) AS SINGLE
  96.     DIM W&, H&, sinr!, cosr!, i&, x2&, y2&
  97.     W& = _WIDTH(Image&): H& = _HEIGHT(Image&)
  98.     px(0) = -W& / 2: py(0) = -H& / 2: px(1) = -W& / 2: py(1) = H& / 2
  99.     px(2) = W& / 2: py(2) = H& / 2: px(3) = W& / 2: py(3) = -H& / 2
  100.     sinr! = SIN(-radianRotation): cosr! = COS(-radianRotation)
  101.     FOR i& = 0 TO 3
  102.         x2& = (px(i&) * cosr! + sinr! * py(i&)) + X * xScale: y2& = (py(i&) * cosr! - px(i&) * sinr!) + Y * yScale
  103.         px(i&) = x2&: py(i&) = y2&
  104.     NEXT
  105.     _MAPTRIANGLE _SEAMLESS(0, 0)-(0, H& - 1)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(1), py(1))-(px(2), py(2))
  106.     _MAPTRIANGLE _SEAMLESS(0, 0)-(W& - 1, 0)-(W& - 1, H& - 1), Image& TO(px(0), py(0))-(px(3), py(3))-(px(2), py(2))
  108.  
  109. 'this seems to work as well as any
  110. SUB fEllipse (CX AS LONG, CY AS LONG, xRadius AS LONG, yRadius AS LONG, c AS _UNSIGNED LONG)
  111.     DIM scale AS SINGLE, x AS LONG, y AS LONG
  112.     scale = yRadius / xRadius
  113.     LINE (CX, CY - yRadius)-(CX, CY + yRadius), c, BF
  114.     FOR x = 1 TO xRadius
  115.         y = scale * SQR(xRadius * xRadius - x * x)
  116.         LINE (CX + x, CY - y)-(CX + x, CY + y), c, BF
  117.         LINE (CX - x, CY - y)-(CX - x, CY + y), c, BF
  118.     NEXT
  120.  
  121. SUB EllipseFill (CX AS INTEGER, CY AS INTEGER, a AS INTEGER, b AS INTEGER, C AS _UNSIGNED LONG)
  122.     ' CX = center x coordinate
  123.     ' CY = center y coordinate
  124.     '  a = semimajor axis
  125.     '  b = semiminor axis
  126.     '  C = fill color
  127.     IF a = 0 OR b = 0 THEN EXIT SUB
  128.     DIM h2 AS _INTEGER64
  129.     DIM w2 AS _INTEGER64
  130.     DIM h2w2 AS _INTEGER64
  131.     DIM x AS INTEGER
  132.     DIM y AS INTEGER
  133.     w2 = a * a
  134.     h2 = b * b
  135.     h2w2 = h2 * w2
  136.     LINE (CX - a, CY)-(CX + a, CY), C, BF
  137.     DO WHILE y < b
  138.         y = y + 1
  139.         x = SQR((h2w2 - y * y * w2) \ h2)
  140.         LINE (CX - x, CY + y)-(CX + x, CY + y), C, BF
  141.         LINE (CX - x, CY - y)-(CX + x, CY - y), C, BF
  142.     LOOP
  144.  

We put maybe the most people and time getting that last EllipseFill listed here worked out, should of used it to begin with.
« Last Edit: December 16, 2019, 10:16:24 pm by bplus »
Logged
Pages: [1]   Go Up
« previous next »