I've got a problem...

[Prithak]

Here is my code:

Code: QB64: [Select]

1. SCREEN _NEWIMAGE(500, 600, 32)
2. r = 100
3. g = 200
4. b = 255
5. red& = _LOADIMAGE("music/red.png")
6. blue& = _LOADIMAGE("music/blue.png")
7. orange& = _LOADIMAGE("music/orange.png")
8. green& = _LOADIMAGE("music/green.png")
9. DIM location$(12)
10. DIM type$(12)
11. DIM h&(12)
12. DIM pic&(12)
13. DIM x(12)
14. DIM y(12)
15. OPEN "music.txt" FOR INPUT AS #1
16. FOR i = 1 TO 12
17.     INPUT #1, location$(i)
18.     INPUT #1, type$(i)
19.     IF type$(i) = "pink" THEN pic&(i) = _LOADIMAGE("music/red.png")
20.     IF type$(i) = "orange" THEN pic&(i) = _LOADIMAGE("music/green.png")
21.     IF type$(i) = "loop" THEN pic&(i) = _LOADIMAGE("music/blue.png")
22.     READ x(i), y(i)
23. NEXT i
24. CLOSE #1
25. DO
26.     here:
27.     k$ = UCASE$(INKEY$)
28.     FOR i = 1 TO 12
29.         _PUTIMAGE (x(i), y(i))-(x(i) + 90, y(i) + 90), pic&(i)
30.     NEXT i
31.     maketiles
32.  
33.     IF LEN(k$) THEN
34.         IF k$ = "Q" THEN k = 10: GOTO there
35.         IF k$ = "W" THEN k = 11: GOTO there
36.         IF k$ = "E" THEN k = 12: GOTO there
37.  
38.         k = VAL(k$)
39.         IF k = 7 THEN k = 1: GOTO there
40.         IF k = 8 THEN k = 2: GOTO there
41.         IF k = 9 THEN k = 3: GOTO there
42.         IF k = 1 THEN k = 7
43.         IF k = 2 THEN k = 8
44.         IF k = 3 THEN k = 9
45.         there:
46.         c = k
47.         IF type$(k) = "loop" THEN
48.             IF _SNDPLAYING(l&) = -1 THEN
49.                 _SNDSTOP l&
50.                 _SNDCLOSE l&
51.             END IF
52.             l& = _SNDOPEN(location$(k), "SYNC")
53.             _SNDLOOP l&
54.         ELSEIF type$(k) = "orange" THEN
55.             IF _SNDPLAYING(l&) = -1 THEN _SNDSTOP l&: _SNDCLOSE l&
56.             IF _SNDPLAYING(h&) = -1 THEN _SNDSTOP h&: _SNDCLOSE h&
57.             o& = _SNDOPEN(location$(k), "SYNC")
58.             _SNDPLAY o&
59.         ELSE
60.             IF _SNDPLAYING(h&) = -1 THEN
61.                 _SNDSTOP h&
62.                 _SNDCLOSE h&
63.             END IF
64.             h& = _SNDOPEN(location$(k), "SYNC")
65.             _SNDPLAY h&
66.         END IF
67.     END IF
68.     LOCATE 1, 1: PRINT c
69.     _DISPLAY
70.     CLS
71. LOOP
72.  
73. DATA 100,100,200,100,300,100,100,200,200,200,300,200,100,300,200,300,300,300,100,400,200,400,300,400
74.  
75. SUB maketiles ()
76.     FOR i = 100 TO 300 STEP 100
77.         FOR j = 100 TO 400 STEP 100
78.             LINE (i, j)-(i + 90, j + 90), _RGB32(255, 255, 255), B
79.         NEXT j
80.     NEXT i
81. END SUB
82.  

And I gave the zip file.
Here, once I press a loop tile, and press it again, it keeps on playing it. How can I remove it? (Once the key is hit of the loop bar(blue one), if the music is playing then end it and return back)????
I hope you understand...

BTW, if you wanna play this music try typing this:
7
88 9 8 5 9 88 9 8 5 6 88 9 8 5 9 88 9 8 5 6
33 666 555 999 5555 36 36 36

lol (Only true DBS fans will get this lol)

[Petr]

Hi Prithak, try _SNDSETPOS, if it solve your problem.

[bplus]

Prithak, I see trouble in this code snip:

Code: QB64: [Select]

1. IF LEN(k$) THEN
2.     IF k$ = "Q" THEN k = 10: GOTO there
3.     IF k$ = "W" THEN k = 11: GOTO there
4.     IF k$ = "E" THEN k = 12: GOTO there
5.  
6.     k = VAL(k$)
7.  
8.     IF k = 7 THEN k = 1: GOTO there
9.     IF k = 8 THEN k = 2: GOTO there
10.     IF k = 9 THEN k = 3: GOTO there
11.     IF k = 1 THEN k = 7
12.     IF k = 2 THEN k = 8
13.     IF k = 3 THEN k = 9  
14.  
15.  

Edit: oops, no just a little weird ;-))

[TempodiBasic]

Hi Prithak
yep a QB64 MusicMaker!
fine idea!

my feedbacks

1. Input must be improved because you can run in an overflow of input from keyboard with error by _soundPlaying():_sndstop():_sndclose() in sequence!  I got this issue both with lines 55,56,57 (type$() = "loop") both with lines 62 or 63  (type$()="orange")

2. try to compact the code of the same area in the same place of the code
here I post your code with my suddivision in different function areas

3. I prefer to use a codeblock like a sub or function with parameter instead of goto and global variables
Here your code with comments

'INITIALIZATION AREA
SCREEN _NEWIMAGE(500, 600, 32)
r = 100
g = 200
b = 255
red& = _LOADIMAGE("music/red.png")
blue& = _LOADIMAGE("music/blue.png")
orange& = _LOADIMAGE("music/orange.png")
green& = _LOADIMAGE("music/green.png")
'DECLARATION AREA OF VARIABLES AND CONSTANTS
DIM location$(12)
DIM type$(12)
DIM h&(12)
DIM pic&(12)
DIM x(12)
DIM y(12)
' SECOND INITIALIZATION AREA
OPEN "music.txt" FOR INPUT AS #1
FOR i = 1 TO 12
    INPUT #1, location$(i)
    INPUT #1, type$(i)
    IF type$(i) = "pink" THEN pic&(i) = _LOADIMAGE("music/red.png")
    IF type$(i) = "orange" THEN pic&(i) = _LOADIMAGE("music/green.png")
    IF type$(i) = "loop" THEN pic&(i) = _LOADIMAGE("music/blue.png")
    READ x(i), y(i)
NEXT i
CLOSE #1

'MAIN LOOP
DO
    here: ' NO INSTRUCTIONS JUMPS HERE
    ' INPUT MANAGER
    k$ = UCASE$(INKEY$)

    ' GRAPHIC INTERFACE
    FOR i = 1 TO 12
        _PUTIMAGE (x(i), y(i))-(x(i) + 90, y(i) + 90), pic&(i)
    NEXT i
    maketiles
    ' COMMAND ENGINE
    IF LEN(k$) THEN
        IF k$ = "Q" THEN k = 10: GOTO there
        IF k$ = "W" THEN k = 11: GOTO there
        IF k$ = "E" THEN k = 12: GOTO there

        k = VAL(k$)
        IF k = 7 THEN k = 1: GOTO there
        IF k = 8 THEN k = 2: GOTO there
        IF k = 9 THEN k = 3: GOTO there
        IF k = 1 THEN k = 7
        IF k = 2 THEN k = 8
        IF k = 3 THEN k = 9
        'SOUND MAKER AREA
        there: ' A LABEL WITH MANY GOTO? BETTER A SUB/FUNCTION WITH PARAMETER?
        c = k
        IF type$(k) = "loop" THEN
            IF _SNDPLAYING(l&) = -1 THEN
                _SNDSTOP l&
                _SNDCLOSE l&
            END IF
            l& = _SNDOPEN(location$(k), "SYNC")
            _SNDLOOP l&
        ELSEIF type$(k) = "orange" THEN
            IF _SNDPLAYING(l&) = -1 THEN _SNDSTOP l&: _SNDCLOSE l&
            IF _SNDPLAYING(h&) = -1 THEN _SNDSTOP h&: _SNDCLOSE h&
            o& = _SNDOPEN(location$(k), "SYNC")
            _SNDPLAY o&
        ELSE
            IF _SNDPLAYING(h&) = -1 THEN
                _SNDSTOP h&
                _SNDCLOSE h&
            END IF
            h& = _SNDOPEN(location$(k), "SYNC")
            _SNDPLAY h&
        END IF
    END IF
    ' DEBUG AREA
    LOCATE 1, 1: PRINT c
    ' SECOND GRAPHIC AREA
    _DISPLAY
    CLS 'HOW MUCH TIME IS THERE BETWEEN SHOWING OUTPUT AND ERASE OF SCREEN?
LOOP

' DATA SETTINGS
DATA 100,100,200,100,300,100,100,200,200,200,300,200,100,300,200,300,300,300,100,400,200,400,300,400

'SUB OF GRAPHIC AREA
SUB maketiles ()
    FOR i = 100 TO 300 STEP 100
        FOR j = 100 TO 400 STEP 100
            LINE (i, j)-(i + 90, j + 90), _RGB32(255, 255, 255), B
        NEXT j
    NEXT i
END SUB