I want a simple Ping status up or down program and here is what I came up with.

[Chris80194]

I do not get why there is not a _icmp command in qb64 that would give results to a pinged IP address internally.

So what I have done is shelled to dos and run the ping ip -n 1 and captured it to a file then read that file looking or the results sent = a pass or fail number.
I also create a external config file to get the ip of each machine I a testing for up or down.

So I open he config get 1.1.1.1 and then left until I get the the end of the value and pass that to the command to ping with find the results of sent and received as equalling each other then print the entire line in green it if failed the sent and lost would equal and print in red. Ok good then I return to the topish to get the next ip in the config file and do that again.

That is where the issue appears the code wont do the same thing and will sometimes show failed ips on ips that are up.  So not sure about the type of loop I should have used I ended up with gotos as a last resort which got the program to the point it is now.

The next thing I wanted to do was make it run faster and add a second column for the ips when there are more then X number in the first one but that is when I caught the issue and focused on it instead of the other column.

I added some areas to try to see what is going on and the first run you see the values but the next loop is where things go wonky.

Code: QB64: [Select]

1.  
2. COLOR 3, 1: CLS
3. file1 = FREEFILE
4. Config$ = "Config.ini"
5. file2 = FREEFILE + 1
6. Pingfile$ = "ip1.tmp"
7. IF _FILEEXISTS(Pingfile$) THEN CLOSE: KILL Pingfile$
8. 1
9. locateline = 5
10. LOCATE 2, 33: PRINT "Network up/down"
11. IF _FILEEXISTS(Config$) THEN
12.     LOCATE 3, 24: PRINT "Settings file (" + Config$ + ") found.": GOTO 2
13. END IF
14. 'No Config file create file for user with sample data
15. PRINT "File missing, Creating " + Config$ + ""
16. PRINT "Eg. 192.168.1.1 Router"
17. PRINT "Eg. 192.168.1.2 File Server"
18. PRINT "and so on"
19. OPEN Config$ FOR OUTPUT AS #file1
20. WRITE #file1, "192.168.1.1 Router"
21. WRITE #file1, "192.168.1.254 Wifi Access Point"
22. CLOSE #file1
23. PRINT "File created with data."
24. SYSTEM
25. 'open Config file to get ips to check
26. 2
27. OPEN Config$ FOR INPUT AS #file1
28. 'find ip in config file to send to ping command
29. 3
30. 'S and T just to trouble shoot and see what is going on
31. T = 5
32. S = 12
33. locateline = locateline + 1
34. IF EOF(file1) THEN GOTO 99
35. LINE INPUT #file1, IPvalue$
36. 'locate IPLength part in config file
37. LOCATE S, T: PRINT "*" + IPvalue$ + "* line value of config file"
38. DO UNTIL a$ = " "
39.     IPLength = IPLength + 1
40.     a$ = MID$(IPvalue$, IPLength, 1)
41.     IF MID$(a$, IPLength, 1) = " " THEN EXIT DO
42. LOOP
43. 'Dos Ping
44. 22
45. IPCount = IPCount + 1
46. '*********problem area*********
47. LOCATE S + 1, T: PRINT "*"; IPLength - 1; "* length of ip -1"
48. LOCATE S + 2, T: PRINT "*" + LEFT$(IPvalue$, IPLength - 1) + "* value determined from config file"
49.  
50. Comand$ = "cmd /c ping " + LEFT$(IPvalue$, IPLength - 1) + " -n 1 > " + Pingfile$
51. LOCATE S + 3, T: PRINT "*" + Comand$ + "* command to send shell"
52.  
53. SHELL _HIDE Comand$
54. 'Get Ping status
55. OPEN Pingfile$ FOR INPUT AS #file2
56. DO WHILE NOT EOF(file2)
57.     LINE INPUT #file2, Status$
58.     IF LEFT$(Status$, 32) = "Ping request could not find host" THEN Status$ = "    Packets: Sent = 1, Received = 0, Lost = 1 (100% loss),": EXIT DO
59.     IF LEFT$(Status$, 12) = "    Packets:" THEN EXIT DO
60. LOOP
61. IF _FILEEXISTS(Pingfile$) THEN CLOSE file2: KILL Pingfile$
62. 'Set Up Down Statues
63. Sent = VAL(MID$(Status$, 21, 1))
64. Receive = VAL(MID$(Status$, 35, 1))
65. Lost = VAL(MID$(Status$, 45, 1))
66. 'testing print of values
67. LOCATE S + 4: PRINT "*", Sent, Receive, Lost, "*", "             Sent         Recived         Lost  Values from shell"
68. Colum1 = 5
69. IF Sent = Receive THEN LOCATE locateline, Colum1: COLOR 10, 7: PRINT "UP" + " " + IPvalue$
70. IF Sent = Lost THEN LOCATE locateline, Colum1: COLOR 4, 7: PRINT "DN" + " " + IPvalue$:
71. COLOR 3, 1
72. 'Return to ping start for next value in config
73. INPUT "press enter for next loop", A
74. GOTO 3
75. ' close and startover from the top
76. 99
77. CLOSE
78. GOTO 1
79.  
80.  

A config.ini file would be a txt tile that looks like
1.1.1.1 DNS Server
192.168.1.1 house router
8.8.8.8 DNS Server
google.com google website this would be the next part for me to work on is host names instead of absolute ips.
The program should read over until it finds the space at the end of the ip the rest is the description of what that ip represents.

[FellippeHeitor]

One of your issues is using WRITE to write to the config file. WRITE adds quotation marks around the text you save and when you're reading the lines back, all of them start with CHR$(34), and you're also passing that to the PING command when you SHELL.

Try using PRINT #file1, "192.168.1.1 Router", etc. That won't add the quotation marks and reading back will work as expected.

If you intended to keep using WRITE, then instead of LINE INPUT, just use INPUT to read the values back from the disk, as INPUT will ignore the CHR$(34) character.

[Chris80194]

I actually created the config using notepad......
My config has a lot more then the example file that is created so it was easier that way but thanks for catching that.

Something weird is the first pass through the do loop to get the packets line in the ping results
I can get the ip but each pass after it hold the value in IPlength at 16 if I clear that it messes up and is now 0 ummmm let me make sure I put the clear in the right place above the counting of IPlength=IPlength+1. that would solve that mystery maybe.

[Chris80194]

I think it is literally one line

[FellippeHeitor]

I don't have the config file and your program is creating is using WRITE. Now go back to my first reply and you'll see what I'm talking about.

[Chris80194]

UPDATED
I fixed a few things and cleared out some unneeded things still having issues at do loop line 35

Code: QB64: [Select]

1. COLOR 3, 1: CLS
2. file1 = FREEFILE
3. Config$ = "Config.ini"
4. file2 = FREEFILE + 1
5. Pingfile$ = "ip1.tmp"
6. Colum1 = 5
7. IF _FILEEXISTS(Pingfile$) THEN CLOSE: KILL Pingfile$
8. 1
9. locateline = 5
10. LOCATE 2, 33: PRINT "Network up/down"
11. IF _FILEEXISTS(Config$) THEN
12.     LOCATE 3, 24: PRINT "Settings file (" + Config$ + ") found.": GOTO 2
13. END IF
14. 'No Config file create file for user with sample data
15. PRINT "File missing, Creating " + Config$ + ""
16. PRINT "Eg. 192.168.1.1 Router"
17. PRINT "Eg. 192.168.1.2 File Server"
18. PRINT "and so on"
19. OPEN Config$ FOR OUTPUT AS #file1
20. PRINT #file1, "192.168.1.1 Router"
21. PRINT #file1, "1.1.1.1 DNS Server"
22. PRINT #file1, "192.168.1.254 Wifi Access Point"
23. CLOSE #file1
24. PRINT "File created with data."
25. SYSTEM
26. 'open Config file to get ips to check
27. 2
28. OPEN Config$ FOR INPUT AS #file1
29. 'find ip in config file to send to ping command
30. 3
31. locateline = locateline + 1
32. IF EOF(file1) THEN GOTO 99
33. LINE INPUT #file1, IPvalue$
34. 'locate IPLength part in config file
35. A$ = "*": IPLength = 0
36. DO UNTIL A$ = " "
37.     IPLength = IPLength + 1
38.     A$ = MID$(IPvalue$, IPLength, 1)
39.     IF MID$(A$, IPLength, 1) = " " THEN IPLength = IPLength - 1: EXIT DO
40. LOOP
41. 'Dos Ping
42. 22
43. IPCount = IPCount + 1
44. Comand$ = "cmd /c ping " + LEFT$(IPvalue$, IPLength) + " -n 1 > " + Pingfile$
45. SHELL _HIDE Comand$
46. 'Get Ping status
47. OPEN Pingfile$ FOR INPUT AS #file2
48. DO WHILE NOT EOF(file2)
49.     LINE INPUT #file2, Status$
50.     IF LEFT$(Status$, 32) = "Ping request could not find host" THEN Status$ = "    Packets: Sent = 1, Received = 0, Lost = 1 (100% loss),": EXIT DO
51.     IF LEFT$(Status$, 12) = "    Packets:" THEN EXIT DO
52. LOOP
53. IF _FILEEXISTS(Pingfile$) THEN CLOSE file2: KILL Pingfile$
54. 'Set Up Down Statues
55. Sent = VAL(MID$(Status$, 21, 1))
56. Receive = VAL(MID$(Status$, 35, 1))
57. Lost = VAL(MID$(Status$, 45, 1))
58. 'testing print of values
59. IF Sent = Receive THEN LOCATE locateline, Colum1: COLOR 10, 7: PRINT "UP" + " " + IPvalue$
60. IF Sent = Lost THEN LOCATE locateline, Colum1: COLOR 4, 7: PRINT "DN" + " " + IPvalue$:
61. COLOR 3, 1
62. 'Return to ping start for next value in config file
63. GOTO 3
64. ' close files and startover from the top
65. 99
66. CLOSE
67. GOTO 1
68.  

[Chris80194]

Thanks to FellippeHeitor this project has become much more streamlined and is a shell of its original self.

[Chris80194]

So I got my simple up down monitor thanks to FellippeHeitor for the code snip.
I dressed it up, gave it a splash of color and put in some bits to make it more universal with the code bits he shared and adding things I wanted to beabe to do but could not find a software that did what I wanted, free options for private use are limited Pinger is basic with a bit of logging.  You wont be watching it so nice to know when you had a problem.

Code: QB64: [Select]

1. SCREEN 0: WIDTH 80, 50
2. ConfigFile$ = "config.ini"
3. IF _FILEEXISTS(ConfigFile$) = 0 THEN
4.     OPEN ConfigFile$ FOR OUTPUT AS #1
5.     PRINT #1, "192.168.1.1 Router"
6.     PRINT #1, "1.1.1.1 DNS Server"
7.     PRINT #1, "192.168.1.254 Wifi Access Point"
8.     PRINT #1, "qb64.com QB64.com (doesn't exist)"
9.     PRINT #1, "MUST include Ip, hostname or domain name and a description"
10.     PRINT #1, "Otherwise the program will not be able to ping propely."
11.     CLOSE
12. END IF
13. Readme$ = "read.me.txt"
14. IF _FILEEXISTS(Readme$) = 0 THEN
15.     OPEN Readme$ FOR OUTPUT AS #1
16.     PRINT #1, "Written by Chris Owen Chris.Owen09@gmail.com"
17.     PRINT #1, "Much thanks goes to FellippeHeitor for the starting code, after seeing how my first work was clumsy he pointed me to what this has become."
18.     PRINT #1, "The Config.ini file shall contain all the ips you wish to monitor."
19.     PRINT #1, "The Config.ini file is dynamic so changes can be made without stopping the program, the file is read line by line and not all loaded at one time."
20.     PRINT #1, "This makes changing the file and reading the data in slower but you can monitor while changes are being done using a text editor."
21.     PRINT #1, "The program can ping, IPs, domain names and host names, descriptions are necessary. I used ( cmd Ping 1.1.1.1 -n 1 ) for the results"
22.     PRINT #1, "192.168.1.254 Wifi Access Point will be reported on the main screen as separate items using a UP or DN status."
23.     PRINT #1, "Since the program has to shell out to run the Cmd PING speed is slow so I have added a -n 1 count instead of the usual 3 count."
24.     PRINT #1, "This program will show 44 lines of ips, 45 and above will start a scroll effect and will pick up at the first ip in you list."
25.     PRINT #1, "Downed IPs are logged to a file called ( down????.log ) where ???? is the date it was noticed."
26.     PRINT #1, "In the log, simple details such as the date, time, and ip and if you put in a description are logged."
27.     PRINT #1, "ESC exits the program and holding the ( a ) key acknowledges any visual down notification."
28.     PRINT #1, "The program will self create missing files such as the Config.ini where the IPs are read from, and This read.me.txt file every run."
29.     PRINT #1, "You MUST include Ip, hostname or domain name and a description.  Otherwise the program will not be able to ping properly."
30.     CLOSE
31. END IF
32.  
33. COLOR 3, 1: CLS
34. flag = 0: set = 0: AlertLocation = 68: AlertLocationHigh = 10: ipstartline = 4
35. DO
36.     DownLog$ = "Down" + DATE$ + ".LOG"
37.     IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
38.     IF flag = 1 AND set = 0 THEN
39.         set = 1
40.         COLOR 20, 15
41.         LOCATE AlertLocationHigh, AlertLocation: PRINT "****"
42.         COLOR 4, 15
43.         LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "Hold A to clear"
44.         LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "Log=" + DownLog$
45.     END IF
46.  
47.     IF flag = 0 AND set = 0 THEN
48.         set = 2
49.         COLOR 3, 1
50.         LOCATE AlertLocationHigh, AlertLocation: PRINT "    "
51.         LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "                "
52.         LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "                      "
53.     END IF
54.  
55.     IF INKEY$ = CHR$(27) THEN 999
56.     IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
57.     OPEN ConfigFile$ FOR INPUT AS #1
58.     OPEN DownLog$ FOR APPEND AS #2
59.     COLOR 14, 1
60.     Title1$ = "Network up/down" + "       Press ESC to exit"
61.  
62.     Title3$ = "Settings file (" + ConfigFile$ + ") found."
63.     note$ = "File " + ConfigFile$ + " can be edited while the program runs. IPs scroll."
64.     LOCATE 3, 41 - LEN(Title1$) / 2: PRINT Title1$, Title2$
65.     IF _FILEEXISTS(ConfigFile$) THEN LOCATE 4, 41 - LEN(Title3$) / 2: PRINT Title3$
66.     LOCATE 50, 41 - LEN(note$) / 2: PRINT note$;
67.     DO
68.         IF INKEY$ = CHR$(27) THEN 999
69.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
70.         IF flag = 1 AND set = 0 THEN
71.             set = 1
72.             COLOR 20, 15
73.             LOCATE AlertLocationHigh, AlertLocation: PRINT "****"
74.             COLOR 4, 15
75.             LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "Hold A to clear"
76.         END IF
77.  
78.         IF flag = 0 AND set = 0 THEN
79.             set = 2
80.             COLOR 3, 1
81.             LOCATE AlertLocationHigh, AlertLocation: PRINT "    "
82.             LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "                "
83.             LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "                      "
84.         END IF
85.  
86.         IF EOF(1) THEN CLOSE: EXIT DO
87.         LINE INPUT #1, ipLine$
88.         IF INKEY$ = CHR$(27) THEN 999
89.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
90.         ip$ = LEFT$(ipLine$, INSTR(ipLine$, " ") - 1)
91.         desc$ = RIGHT$(ipLine$, LEN(ipLine$) - LEN(ip$) - 1)
92.         COLOR 2, 1
93.         LOCATE 2, 41 - LEN(DATE$ + " " + LEFT$(TIME$, 5)) / 2: PRINT DATE$ + " " + LEFT$(TIME$, 5)
94.         linelocate = linelocate + 1: IF linelocate = 45 THEN linelocate = 1
95.         lineclear$ = "": FOR lclear = 1 TO 50: lineclear$ = lineclear$ + " ": NEXT
96.         LOCATE linelocate + ipstartline, 1: PRINT lineclear$
97.         LOCATE linelocate + ipstartline, 1: PRINT linelocate; "Ping ("; ip$; ") ("; desc$; ")";
98.         IF INKEY$ = CHR$(27) THEN 999
99.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
100.         COLOR 7, 1: LOCATE , 52: PRINT "**";
101.         result& = _SHELLHIDE("ping " + ip$ + " -n 1")
102.         IF result& = 0 THEN
103.             'success
104.             COLOR 2, 15
105.             LOCATE , 52: PRINT "UP"
106.             COLOR 7, 1
107.         ELSE
108.             COLOR 4, 15
109.             LOCATE , 52: PRINT "DN"
110.             COLOR 7, 1
111.             PRINT #2, DATE$ + " " + TIME$ + " " + "Ping (" + ip$ + ") (" + desc$ + ")" + "   Down": flag = 1: set = 0
112.         END IF
113.         IF INKEY$ = CHR$(27) THEN 999
114.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
115.     LOOP
116.     _LIMIT 1 'once per second
117. LOOP
118. 999
119. PRINT "Shutting down"
120. SYSTEM
121.  

So how is my Frankenstein???
The words that come to my mind are "Its alive Its alive"
Considering where this started from I'm happy so far.

[Chris80194]

So was doing some more tinkering
this runs fast on a system with no over head  Still have some INKEY issues particularly with A L and E functions.
Chr$27 works great.
I am happy with its process and until I can figure out or maybe get a few hints I think this is good right here.
Frankenstein was built with parts so was not a real polished man.

Code: QB64: [Select]

1. SCREEN 0: WIDTH 80, 50
2. DIM SHARED ConfigFile$, ReadMe$
3. ConfigFile$ = "config.ini"
4. ReadMe$ = "read.me.txt"
5. IF _FILEEXISTS(ConfigFile$) = 0 THEN CALL example(ConfigFile%, ReadMe%)
6. IF _FILEEXISTS(ReadMe$) = 0 THEN CALL example(ConfigFile%, ReadMe%)
7. COLOR 3, 1: CLS
8. flag = 0: set = 0: AlertLocation = 68: AlertLocationHigh = 10: ipstartline = 4
9. DO
10.     DownLog$ = "Down" + DATE$ + ".LOG"
11.     IF UCASE$(INKEY$) = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
12.     IF UCASE$(INKEY$) = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
13.     IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
14.     IF flag = 1 AND set = 0 THEN
15.         set = 1
16.         COLOR 20, 15
17.         LOCATE AlertLocationHigh, AlertLocation: PRINT "****"
18.         COLOR 4, 15
19.         LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "Hold A to clear"
20.         LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "Log=" + DownLog$
21.         LOCATE AlertLocationHigh + 4, AlertLocation - 10: PRINT "Press L For Todays Log"
22.     END IF
23.  
24.     IF flag = 0 AND set = 0 THEN
25.         set = 2
26.         COLOR 3, 1
27.         LOCATE AlertLocationHigh, AlertLocation: PRINT "    "
28.         LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "                "
29.         LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "                      "
30.         LOCATE AlertLocationHigh + 4, AlertLocation - 10: PRINT "Press L For Todays Log"
31.         LOCATE AlertLocationHigh + 5, AlertLocation - 11: PRINT "Press E to edit IP list"
32.     END IF
33.  
34.     IF INKEY$ = CHR$(27) THEN 999
35.     IF UCASE$(INKEY$) = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
36.     IF UCASE$(INKEY$) = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
37.     IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
38.     OPEN ConfigFile$ FOR INPUT AS #1
39.     OPEN DownLog$ FOR APPEND AS #2
40.     COLOR 14, 1
41.     Title1$ = "Network up/down" + "       Press ESC to exit"
42.  
43.     Title3$ = "Settings file (" + ConfigFile$ + ") found."
44.     note$ = "File " + ConfigFile$ + " can be edited while the program runs. IPs scroll."
45.     LOCATE 3, 41 - LEN(Title1$) / 2: PRINT Title1$, Title2$: COLOR 4, 15: LOCATE 2, 7: PRINT "Local IP (" + LTRIM$(GetLocalIP$) + ")"
46.     IF _FILEEXISTS(ConfigFile$) THEN COLOR 13, 1: LOCATE 4, 41 - LEN(Title3$) / 2: PRINT Title3$
47.     LOCATE 50, 41 - LEN(note$) / 2: PRINT note$;
48.     DO
49.         IF INKEY$ = CHR$(27) THEN 999
50.         IF UCASE$(INKEY$) = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
51.         IF UCASE$(INKEY$) = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
52.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
53.         IF flag = 1 AND set = 0 THEN
54.             set = 1
55.             COLOR 20, 15
56.             LOCATE AlertLocationHigh, AlertLocation: PRINT "****"
57.             COLOR 4, 15
58.             LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "Hold A to clear"
59.             LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "Log=" + DownLog$
60.             LOCATE AlertLocationHigh + 4, AlertLocation - 10: PRINT "Press L For Todays Log"
61.         END IF
62.  
63.         IF flag = 0 AND set = 0 THEN
64.             set = 2
65.             COLOR 3, 1
66.             LOCATE AlertLocationHigh, AlertLocation: PRINT "    "
67.             LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "                "
68.             LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "                      "
69.             LOCATE AlertLocationHigh + 4, AlertLocation - 10: PRINT "Press L For Todays Log"
70.             LOCATE AlertLocationHigh + 5, AlertLocation - 11: PRINT "Press E to edit IP list"
71.  
72.         END IF
73.  
74.         IF EOF(1) THEN CLOSE: EXIT DO
75.         LINE INPUT #1, ipLine$
76.         IF INKEY$ = CHR$(27) THEN 999
77.         IF UCASE$(INKEY$) = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
78.         IF UCASE$(INKEY$) = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
79.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
80.         ip$ = LEFT$(ipLine$, INSTR(ipLine$, " ") - 1)
81.         desc$ = RIGHT$(ipLine$, LEN(ipLine$) - LEN(ip$) - 1)
82.         COLOR 8, 15: b = 5: c = 2 'b moves IP and description status line over while c moves **/up/down around that line
83.         LOCATE 2, 64 - LEN(DATE$ + " " + LEFT$(TIME$, 5)) / 2: PRINT DATE$ + " " + LEFT$(TIME$, 5)
84.         linelocate = linelocate + 1: IF linelocate = 45 THEN linelocate = 1
85.         lineclear$ = "": FOR lclear = 1 TO 52: lineclear$ = lineclear$ + " ": NEXT
86.         LOCATE linelocate + ipstartline, b: COLOR 3, 1: PRINT lineclear$
87.         IF yesno = 0 THEN COLOR 15, 1 ELSE COLOR 15, 6
88.         LOCATE linelocate + ipstartline, b: PRINT "Ping ("; ip$; ") ("; desc$; ")";
89.         IF INKEY$ = CHR$(27) THEN 999
90.         IF UCASE$(INKEY$) = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
91.         IF UCASE$(INKEY$) = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
92.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
93.         COLOR 7, 1: LOCATE , c: PRINT "**";
94.         result& = _SHELLHIDE("ping " + ip$ + " -n 1")
95.         IF result& = 0 THEN
96.             'success
97.             COLOR 2, 15
98.             LOCATE , c: PRINT "UP"
99.             COLOR 7, 1
100.         ELSE
101.             COLOR 4, 15
102.             LOCATE , c: PRINT "DN"
103.             COLOR 7, 1
104.             PRINT #2, DATE$ + " " + TIME$ + " " + "Ping (" + ip$ + ") (" + desc$ + ")" + "   Down": flag = 1: set = 0
105.         END IF
106.         IF INKEY$ = CHR$(27) THEN 999
107.         IF UCASE$(INKEY$) = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
108.         IF UCASE$(INKEY$) = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
109.         IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0
110.     LOOP
111.     _LIMIT 1 'once per second
112.     IF yesno = 0 THEN yesno = 1 ELSE yesno = 0
113. LOOP
114. 999
115. PRINT "Shutting down"
116. SYSTEM
117.  
118. FUNCTION GetLocalIP$
119.     fill = 3
120.     SHELL _HIDE "cmd /c ipconfig > IPconfig.tmp"
121.     OPEN "IPconfig.tmp" FOR INPUT AS #fill
122.     DO
123.         LINE INPUT #fill, ipline$
124.         IF LEFT$(LTRIM$(ipline$), 2) = "IP" THEN
125.             CLOSE #fill
126.             GetLocalIP$ = MID$(ipline$, INSTR(ipline$, ":") + 1)
127.             IF LEFT$(ipline$, 3) = "169" THEN ipline$ = "Invalid IP" + ipline$
128.             KILL "IPconfig.tmp" 'kill the messenger?
129.             EXIT DO
130.         END IF
131.     LOOP UNTIL EOF(fill)
132. END FUNCTION
133.  
134. SUB example (ConfigFile%, ReadMe%)
135.     IF _FILEEXISTS(ConfigFile$) = 0 THEN
136.         OPEN ConfigFile$ FOR OUTPUT AS #1
137.         PRINT #1, "192.168.1.1 Router"
138.         PRINT #1, "1.1.1.1 DNS Server"
139.         PRINT #1, "192.168.1.254 Wifi Access Point"
140.         PRINT #1, "qb64.com QB64.com (doesn't exist)"
141.         PRINT #1, "MUST include Ip, hostname or domain name and a description"
142.         PRINT #1, "Otherwise the program will not be able to ping properly."
143.         CLOSE
144.     END IF
145.     ReadMe$ = "read.me.txt"
146.     IF _FILEEXISTS(ReadMe$) = 0 THEN
147.         OPEN ReadMe$ FOR OUTPUT AS #1
148.         PRINT #1, "Written by Chris Owen Chris.Owen09@gmail.com"
149.         PRINT #1, "This program came about from a necessity of keeping tabs on servers, switches, a router, a access point, and some printers, other windows pings were not able to accommodate my needs."
150.         PRINT #1, "Much thanks goes to FellippeHeitor for the starting code, after seeing how my first work was clumsy he pointed me to what this has become."
151.         PRINT #1, "The Config.ini file shall contain all the ips you wish to monitor. It is recommended to edit it to your needs."
152.         PRINT #1, "The Config.ini file is dynamic so changes can be made without stopping the program, the file is read line by line and not all loaded at one time."
153.         PRINT #1, "This makes changing the file and reading the data in slower but you can monitor while changes are being done using a text editor."
154.         PRINT #1, "The program can ping, IPs, domain names and host names, descriptions are necessary. I used ( cmd Ping 1.1.1.1 -n 1 ) for the results"
155.         PRINT #1, "192.168.1.254 Wifi Access Point will be reported on the main screen as separate items using a UP or DN status."
156.         PRINT #1, "Since the program has to shell out to run the Cmd PING speed is slow so I have added a -n 1 count instead of the usual 3 count."
157.         PRINT #1, "This program will show 44 lines of ips, 45 and above will start a scroll effect and will pick up at the first ip in you list."
158.         PRINT #1, "Downed IPs are logged to a file called ( down????.log ) where ???? is the date it was noticed."
159.         PRINT #1, "In the log, simple details such as the date, time, and ip and if you put in a description are logged."
160.         PRINT #1, "ESC exits the program and holding the ( a ) key acknowledges any visual down notification."
161.         PRINT #1, "The program will self create missing files such as the Config.ini where the IPs are read from, and This read.me.txt file every run."
162.         PRINT #1, "You MUST include Ip, hostname or domain name and a description.  Otherwise the program will not be able to ping properly."
163.         PRINT #1, "The pinger now changes color each completed loop so you can see its progress.  On a fast computer with little overhead this thing is blazing."
164.         PRINT #1, "In addition to ESC and A to acknowledge I added E to launch notepad to edit the IP config file and L to launch the Log of the day."
165.         PRINT #1, "Tap the buttons a few times to launch The Inkey does not seem to catch even with them spread everywhere in the program."
166.         PRINT #1, "Added a search function for the IP that the machine is running on since I had a few issues with DHCP not working on a DDWRT that caused a headache. "
167.         CLOSE
168.     END IF
169.     SHELL _DONTWAIT "notepad " + ReadMe$
170.     SHELL _DONTWAIT "notepad " + ConfigFile$
171.     SYSTEM
172. END SUB
173.  

And this would be how I catch spelling and keyboard errors.
Reply if anyone has ideas on how to clean this up some
Thanks,

[SMcNeill]

The issue is here:

Log$ = "Down" + DATE$ + ".LOG"
    IF UCASE$(INKEY$) = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
    IF UCASE$(INKEY$) = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
    IF UCASE$(INKEY$) = "A" THEN flag = 0: set = 0

Each call to INKEY$ reads a character from the input buffer.  Type “AA”, and it’ll fail to run as the first inkey$ is “A”, the second inkey$ is “A”, andthe third inkey$ is “”...

Fix is simple:

  Char$ = UCASE$(INKEY$)
  IF Char$ = “E” THEN...
  IF Char$ = “L” THEN ...

[visionmercer]

The times I have needed to know if a host is up or down i have used the _shellhide function, so i didn't need an output to file.

a = _SHELLHIDE("ping " + Networkaddress$ + " -n 1 -w 100")

if a is 0 then the host is up
if a is 1 the host is down

[Chris80194]

To address SMcNeill you are right. It was late when I added the extra INKEY items and was thrilled the program does pretty much what I wanted with out the limitations I had found in the ones I had tried and this morning fresh and clear headed looked at your post I remembered that from when I learned Qbasic and was given a QB compiler package way back in the 90s.  Extra eyes are helpful especially after 10 hours of beating on keys.  Wish I could see code like I used to its coming back with yalls help.  Thanks

visionmercer thanks FellippeHeitor pointed me in that similar direction and I am grateful for yours too I have a few others programs I am working on so ill try this out and see if it runs any faster.

Ping is such a basic command.  I wrote this thinking I would need about 10 devices monitored but the list is about 24 now and testing shows that it can do 24 lines and seems limitless. FellippeHeitor's help with reading in and cypher out the config file made that happen.

Let me see how the suggestion works out.  It almost rivals the professionals speed wise.
Thanks,

[Chris80194]

So its been running great for a while but I made a few tweaks. To highlight down nodes better.

Code: QB64: [Select]

1. SCREEN 0: WIDTH 80, 50
2. DIM SHARED ConfigFile$, ReadMe$
3. ConfigFile$ = "config.ini"
4. ReadMe$ = "read.me.txt"
5. IF _FILEEXISTS(ConfigFile$) = 0 THEN CALL example(ConfigFile%, ReadMe%)
6. IF _FILEEXISTS(ReadMe$) = 0 THEN CALL example(ConfigFile%, ReadMe%)
7. COLOR 3, 1: CLS
8. flag = 0: set = 0: AlertLocation = 68: AlertLocationHigh = 10: ipstartline = 4
9. DO
10.     DownLog$ = "Down" + DATE$ + ".LOG"
11.     IF Char$ = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
12.     IF Char$ = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
13.     IF Char$ = "A" THEN flag = 0: set = 0
14.     IF flag = 1 AND set = 0 THEN
15.         set = 1
16.         COLOR 20, 15
17.         LOCATE AlertLocationHigh, AlertLocation: PRINT "****"
18.         COLOR 4, 15
19.         LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "Hold A to clear"
20.         LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "Log=" + DownLog$
21.         LOCATE AlertLocationHigh + 4, AlertLocation - 10: PRINT "Press L For Todays Log"
22.     END IF
23.  
24.     IF flag = 0 AND set = 0 THEN
25.         set = 2
26.         COLOR 3, 1
27.         LOCATE AlertLocationHigh, AlertLocation: PRINT "    "
28.         LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "                "
29.         LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "                      "
30.     END IF
31.  
32.     Char$ = INKEY$: IF Char$ = CHR$(27) THEN 999
33.     IF Char$ = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
34.     IF Char$ = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
35.     IF Char$ = "A" THEN flag = 0: set = 0
36.     OPEN ConfigFile$ FOR INPUT AS #1
37.     OPEN DownLog$ FOR APPEND AS #2
38.     COLOR 14, 1
39.     Title1$ = "Network up/down"
40.     Title2a$ = "Press ESC to exit"
41.     Title2b$ = "Press L For Todays Log"
42.     Title2c$ = "Press E to edit IP list"
43.     Title3$ = "Settings file (" + ConfigFile$ + ") found."
44.     note$ = "File " + ConfigFile$ + " can be edited while the program runs. IPs scroll."
45.     LOCATE AlertLocationHigh - 1, AlertLocation - 8: PRINT Title2a$
46.     LOCATE AlertLocationHigh + 4, AlertLocation - 10: PRINT Title2b$
47.     LOCATE AlertLocationHigh + 5, AlertLocation - 11: PRINT Title2c$
48.  
49.     LOCATE 3, 41 - LEN(Title1$) / 2: PRINT Title1$: COLOR 4, 15: LOCATE 2, 7: PRINT "Local IP (" + LTRIM$(GetLocalIP$) + ")"
50.     IF _FILEEXISTS(ConfigFile$) THEN COLOR 13, 1: LOCATE 4, 41 - LEN(Title3$) / 2: PRINT Title3$
51.     LOCATE 50, 41 - LEN(note$) / 2: PRINT note$;
52.     DO
53.         Char$ = INKEY$: IF Char$ = CHR$(27) THEN 999
54.         IF Char$ = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
55.         IF Char$ = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
56.         IF Char$ = "A" THEN flag = 0: set = 0
57.         IF flag = 1 AND set = 0 THEN
58.             set = 1
59.             COLOR 20, 15
60.             LOCATE AlertLocationHigh, AlertLocation: PRINT "****"
61.             COLOR 4, 15
62.             LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "Hold A to clear"
63.             LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "Log=" + DownLog$
64.             LOCATE AlertLocationHigh + 4, AlertLocation - 10: PRINT "Press L For Todays Log"
65.         END IF
66.  
67.         IF flag = 0 AND set = 0 THEN
68.             set = 2
69.             COLOR 3, 1
70.             LOCATE AlertLocationHigh, AlertLocation: PRINT "    "
71.             LOCATE AlertLocationHigh + 2, AlertLocation - 6: PRINT "                "
72.             LOCATE AlertLocationHigh + 3, AlertLocation - 10: PRINT "                      "
73.  
74.         END IF
75.  
76.         IF EOF(1) THEN CLOSE: EXIT DO
77.         LINE INPUT #1, ipLine$
78.         Char$ = INKEY$: IF Char$ = CHR$(27) THEN 999
79.         IF Char$ = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
80.         IF Char$ = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
81.         IF Char$ = "A" THEN flag = 0: set = 0
82.         ip$ = LEFT$(ipLine$, INSTR(ipLine$, " ") - 1)
83.         desc$ = RIGHT$(ipLine$, LEN(ipLine$) - LEN(ip$) - 1)
84.         COLOR 8, 15: b = 5: c = 2 'b moves IP and description status line over while c moves **/up/down around that line
85.         LOCATE 2, 64 - LEN(DATE$ + " " + LEFT$(TIME$, 5)) / 2: PRINT DATE$ + " " + LEFT$(TIME$, 5)
86.         linelocate = linelocate + 1: IF linelocate = 45 THEN linelocate = 1
87.         lineclear$ = "": FOR lclear = 1 TO 52: lineclear$ = lineclear$ + " ": NEXT
88.         LOCATE linelocate + ipstartline, b: COLOR 3, 1: PRINT lineclear$
89.         IF yesno = 0 THEN COLOR 15, 1 ELSE COLOR 15, 6
90.         LOCATE linelocate + ipstartline, b: PRINT "Ping ("; ip$; ") ("; desc$; ")";
91.         Char$ = INKEY$: IF Char$ = CHR$(27) THEN 999
92.         IF Char$ = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
93.         IF Char$ = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
94.         IF Char$ = "A" THEN flag = 0: set = 0
95.         COLOR 7, 1: LOCATE , c: PRINT "** ";
96.         ' Shell to ping and get results 0 up 1 down
97.         result& = _SHELLHIDE("ping " + ip$ + " -n 1 -w 100")
98.         IF result& = 0 THEN
99.             'success
100.             COLOR 2, 15
101.             LOCATE , c: PRINT "UP"
102.             COLOR 7, 1
103.         ELSE
104.             COLOR 4, 15
105.             LOCATE , c: PRINT "DN"; " Ping ("; ip$; ") ("; desc$; ")";
106.             COLOR 7, 1
107.             PRINT #2, DATE$ + " " + TIME$ + " " + "Ping (" + ip$ + ") (" + desc$ + ")" + "   Down": flag = 1: set = 0
108.         END IF
109.         Char$ = UCASE$(INKEY$): IF Char$ = CHR$(27) THEN 999
110.         IF Char$ = "E" THEN SHELL _DONTWAIT "notepad " + ConfigFile$
111.         IF Char$ = "L" THEN SHELL _DONTWAIT "notepad " + DownLog$
112.         IF Char$ = "A" THEN flag = 0: set = 0
113.     LOOP
114.     _LIMIT 1 'once per second
115.     IF yesno = 0 THEN yesno = 1 ELSE yesno = 0
116. LOOP
117. 999
118. PRINT "Shutting down"
119. SYSTEM
120.  
121. FUNCTION GetLocalIP$
122.     fill = 3
123.     SHELL _HIDE "cmd /c ipconfig > IPconfig.tmp"
124.     OPEN "IPconfig.tmp" FOR INPUT AS #fill
125.     DO
126.         LINE INPUT #fill, ipline$
127.         IF LEFT$(LTRIM$(ipline$), 2) = "IP" THEN
128.             CLOSE #fill
129.             GetLocalIP$ = MID$(ipline$, INSTR(ipline$, ":") + 1)
130.             IF LEFT$(ipline$, 3) = "169" THEN ipline$ = "Invalid IP" + ipline$
131.             KILL "IPconfig.tmp" 'kill the messenger?
132.             EXIT DO
133.         END IF
134.     LOOP UNTIL EOF(fill)
135. END FUNCTION
136.  
137. SUB example (ConfigFile%, ReadMe%)
138.     IF _FILEEXISTS(ConfigFile$) = 0 THEN
139.         OPEN ConfigFile$ FOR OUTPUT AS #1
140.         PRINT #1, "192.168.1.1 Router"
141.         PRINT #1, "1.1.1.1 DNS Server"
142.         PRINT #1, "192.168.1.254 Wifi Access Point"
143.         PRINT #1, "qb64.com QB64.com (doesn't exist)"
144.         PRINT #1, "MUST include Ip, hostname or domain name and a description"
145.         PRINT #1, "Otherwise the program will not be able to ping properly."
146.         CLOSE
147.     END IF
148.     ReadMe$ = "read.me.txt"
149.     IF _FILEEXISTS(ReadMe$) = 0 THEN
150.         OPEN ReadMe$ FOR OUTPUT AS #1
151.         PRINT #1, "Written by Chris Owen Chris.Owen09@gmail.com"
152.         PRINT #1, "This program came about from a necessity of keeping tabs on servers, switches, a router, a access point, and some printers, other windows pings were not able to accommodate my needs."
153.         PRINT #1, "Much thanks goes to FellippeHeitor for the starting code, after seeing how my first work was clumsy he pointed me to what this has become."
154.         PRINT #1, "visionmercer pointed out another ping parameter that I added as a tweak  looking to make this fast as it can be."
155.         PRINT #1, "SMcNeill pointed out a flaw staring me in the face.  In the interest of reduction of variables I knew I wanted to check INKEY values but by that I created a problem where a simpler approach was needed. Thanks"
156.         PRINT #1, "The Config.ini file shall contain all the ips you wish to monitor. It is recommended to edit it to your needs."
157.         PRINT #1, "The Config.ini file is dynamic so changes can be made without stopping the program, the file is read line by line and not all loaded at one time."
158.         PRINT #1, "This makes changing the file and reading the data in slower but you can monitor while changes are being done using a text editor."
159.         PRINT #1, "The program can ping, IPs, domain names and host names, descriptions are necessary. I used ( cmd Ping 1.1.1.1 -n 1 ) for the results"
160.         PRINT #1, "192.168.1.254 Wifi Access Point will be reported on the main screen as separate items using a UP or DN status."
161.         PRINT #1, "Since the program has to shell out to run the Cmd PING speed is slow so I have added a -n 1 count instead of the usual 3 count."
162.         PRINT #1, "This program will show 44 lines of ips, 45 and above will start a scroll effect and will pick up at the first ip in you list."
163.         PRINT #1, "Downed IPs are logged to a file called ( down????.log ) where ???? is the date it was noticed."
164.         PRINT #1, "In the log, simple details such as the date, time, and ip and if you put in a description are logged."
165.         PRINT #1, "ESC exits the program and holding the ( a ) key acknowledges any visual down notification."
166.         PRINT #1, "The program will self create missing files such as the Config.ini where the IPs are read from, and This read.me.txt file every run."
167.         PRINT #1, "You MUST include Ip, hostname or domain name and a description.  Otherwise the program will not be able to ping properly."
168.         PRINT #1, "The pinger now changes color each completed loop so you can see its progress.  On a fast computer with little overhead this thing is blazing."
169.         PRINT #1, "In addition to ESC and A to acknowledge I added E to launch notepad to edit the IP config file and L to launch the Log of the day."
170.         PRINT #1, "Tap the buttons a few times to launch The Inkey does not seem to catch even with them spread everywhere in the program."
171.         PRINT #1, "Added a search function for the IP that the machine is running on since I had a few issues with DHCP not working on a DDWRT that caused a headache. "
172.         CLOSE
173.     END IF
174.     SHELL _DONTWAIT "notepad " + ReadMe$
175.     SHELL _DONTWAIT "notepad " + ConfigFile$
176.     SYSTEM
177. END SUB
178.  
179.