QB64.org Forum

Active Forums => Programs => Topic started by: bplus on October 16, 2018, 11:49:36 pm

Title: Pig
Post by: bplus on October 16, 2018, 11:49:36 pm

Yeah, Pig, I found it at Rosetta, I was curious if it was an interesting game.
You get to keep rolling a die and accumulating a score unless you roll a 1 then the accumulated score is lost.
If you don't roll a 1 you have option of holding or rolling again. First to 100 wins.

I have AI programmed to roll 4 times here:

Code: QB64: [Select]

1. RANDOMIZE TIMER
2. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
3.     turn = (turn + 1) MOD 2
4.     di = INT(RND * 6) + 1
5.     PRINT: PRINT "Player:"; player; "  AI:"; AI
6.     accum = 0 '<<<<<<<<<<<<<<<<< EDIT  one line instead of two
7.     IF turn THEN 'player
8.         DO
9.             IF di = 1 THEN
10.                 INPUT "Player you rolled a 1, your turn is over, press enter..."; wate$
11.                 EXIT DO
12.             ELSE
13.                 accum = accum + di
14.                 PRINT "Player you rolled a "; di; "your accumulated total is now "; accum
15.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h > "; choice$
16.                 IF choice$ = "r" THEN
17.                     di = INT(RND * 6) + 1
18.                 ELSE
19.                     player = player + accum
20.                     EXIT DO
21.                 END IF
22.             END IF
23.         LOOP
24.     ELSE
25.         FOR i = 1 TO 5
26.             IF di = 1 THEN
27.                 INPUT "AI rolled a 1, it's turn is over, press enter..."; wate$
28.                 EXIT FOR
29.             ELSE
30.                 accum = accum + di
31.                 PRINT "AI rolled a "; di; "it's total accumulated now is"; accum
32.                 IF i < 4 AND accum + AI < 100 THEN  '<<<<<<<<<<<<<<<<<<<<<<<<<EDIT
33.                     PRINT "AI is rolling again."
34.                     INPUT "press enter..."; wate$
35.                     di = INT(RND * 6) + 1
36.                 ELSE
37.                     PRINT "AI is holding with"; accum; "added to it's score."
38.                     INPUT "press enter..."; wate$
39.                     AI = AI + accum
40.                     EXIT FOR
41.                 END IF
42.             END IF
43.         NEXT
44.     END IF
45. WEND
46. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"
47. END
48.  

Oh, I see I should tell the AI not to roll again if it's got 100 points with accum.

I've only played with this for about 45 mins. anyone have ideas for improvements?

Title: Re: Pig
Post by: bplus on October 17, 2018, 08:11:58 pm

38 lines now (fits completely in IDE window), not a single :

Code: QB64: [Select]

1. _TITLE "Pig 1 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     turn = (turn + 1) MOD 2
5.     IF turn THEN Who$ = "Player" ELSE Who$ = "AI"
6.     PRINT "Player =" + STR$(player) + "  AI =" + STR$(AI) + CHR$(10)
7.     accum = 0
8.     FOR i = 1 TO 100
9.         di = INT(RND * 6) + 1
10.         IF di = 1 THEN
11.             PRINT Who$ + " rolled a 1, the turn is over, press enter...";
12.             INPUT "", wate$
13.             EXIT FOR
14.         ELSE
15.             accum = accum + di
16.             PRINT Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum)
17.             IF turn THEN
18.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
19.                 IF choice$ <> "r" THEN player = player + accum
20.                 IF choice$ <> "r" THEN EXIT FOR
21.             ELSE
22.                 IF i < 3 AND accum + AI < 100 THEN
23.                     PRINT "AI is rolling again,";
24.                     INPUT " press enter...", wate$
25.                 ELSE
26.                     PRINT "AI is holding with"; accum; "added to it's score,";
27.                     INPUT " press enter...", wate$
28.                     AI = AI + accum
29.                     EXIT FOR
30.                 END IF
31.             END IF
32.         END IF
33.         PRINT
34.     NEXT
35.     PRINT
36. WEND
37. PRINT "Player =" + STR$(player) + "  AI =" + STR$(AI)
38. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"
39.  

;-)) Yes, I used a FOR loop to save from having to use an i = i+1 line!

EDIT 2x's found 2 more lines to cut.

Title: Re: Pig
Post by: bplus on October 18, 2018, 08:23:18 pm

Update 35 lines now.

Title: Re: Pig
Post by: SMcNeill on October 18, 2018, 08:33:04 pm

Quote from: bplus on October 18, 2018, 08:23:18 pm

Update 35 lines now.

Line Count reduction -- from:

PRINT "AI is rolling again,";
                    INPUT " press enter...", wate$

to:

INPUT "AI is rolling again, press enter...", wate$

Title: Re: Pig
Post by: bplus on October 18, 2018, 08:48:29 pm

Hi Steve,

I think you are looking at the code in OP, with your suggestion.

I removed duplicate code sections with who$ variable.

I wish I could use INPUT like PRINT with variable(s) in prompt. I could cut more lines.

Here is update at 35 lines to check ideas out.

Code: QB64: [Select]

1. _TITLE "Pig 2 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     turn = (turn + 1) MOD 2
5.     IF turn THEN Who$ = "Player" ELSE Who$ = "AI"
6.     accum = 0
7.     FOR i = 1 TO 100
8.         di = INT(RND * 6) + 1
9.         IF di = 1 THEN
10.             PRINT CHR$(10) + Who$ + " rolled a 1, the turn is over, press enter...";
11.             INPUT "", wate$
12.             EXIT FOR
13.         ELSE
14.             accum = accum + di
15.             PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum)
16.             IF turn THEN
17.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
18.                 IF choice$ <> "r" THEN player = player + accum
19.                 IF choice$ <> "r" THEN EXIT FOR
20.             ELSE
21.                 IF i < 3 AND accum + AI < 100 THEN
22.                     PRINT "AI is rolling again,";
23.                     INPUT " press enter... ", wate$
24.                 ELSE
25.                     AI = AI + accum
26.                     PRINT "AI is holding with"; accum; "added to it's score,";
27.                     INPUT " press enter...", wate$
28.                     EXIT FOR
29.                 END IF
30.             END IF
31.         END IF
32.     NEXT
33.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
34. WEND
35. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"
36.  

I am eyeing _Title and Randomize, nah... not desparate yet, maybe if I get to 20's.

It is not a bad game, I am liking it better than 21!

Oh hey just got an idea!

Title: Re: Pig
Post by: bplus on October 18, 2018, 09:01:54 pm

34 lines:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN
9.             PRINT CHR$(10) + Who$ + " rolled a 1, the turn is over, press enter...";
10.             INPUT "", wate$
11.             EXIT FOR
12.         ELSE
13.             accum = accum + di
14.             PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum)
15.             IF Who$ = "Player" THEN
16.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
17.                 IF choice$ <> "r" THEN player = player + accum
18.                 IF choice$ <> "r" THEN EXIT FOR
19.             ELSE
20.                 IF i < 3 AND accum + AI < 100 THEN
21.                     PRINT "AI is rolling again,";
22.                     INPUT " press enter... ", wate$
23.                 ELSE
24.                     AI = AI + accum
25.                     PRINT "AI is holding with"; accum; "added to it's score,";
26.                     INPUT " press enter...", wate$
27.                     EXIT FOR
28.                 END IF
29.             END IF
30.         END IF
31.     NEXT
32.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
33. WEND
34. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

Title: Re: Pig
Post by: bplus on October 18, 2018, 09:05:30 pm

Oh I see it now! Sorry Steve you are right!
33 lines:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN
9.             PRINT CHR$(10) + Who$ + " rolled a 1, the turn is over, press enter...";
10.             INPUT "", wate$
11.             EXIT FOR
12.         ELSE
13.             accum = accum + di
14.             PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum)
15.             IF Who$ = "Player" THEN
16.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
17.                 IF choice$ <> "r" THEN player = player + accum
18.                 IF choice$ <> "r" THEN EXIT FOR
19.             ELSE
20.                 IF i < 3 AND accum + AI < 100 THEN
21.                     INPUT "AI is rolling again, press enter... ", wate$
22.                 ELSE
23.                     AI = AI + accum
24.                     PRINT "AI is holding with"; accum; "added to it's score,";
25.                     INPUT " press enter...", wate$
26.                     EXIT FOR
27.                 END IF
28.             END IF
29.         END IF
30.     NEXT
31.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
32. WEND
33. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"
34.  

EDIT: sorry I pasted wrong update.

Thanks Steve!!!

Title: Re: Pig
Post by: bplus on October 18, 2018, 09:39:29 pm

Oh heck, do it again in next block, there is no real loss of information reporting:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN
9.             PRINT CHR$(10) + Who$ + " rolled a 1, the turn is over, press enter...";
10.             INPUT "", wate$
11.             EXIT FOR
12.         ELSE
13.             accum = accum + di
14.             PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum)
15.             IF Who$ = "Player" THEN
16.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
17.                 IF choice$ <> "r" THEN player = player + accum
18.                 IF choice$ <> "r" THEN EXIT FOR
19.             ELSE
20.                 IF i < 3 AND accum + AI < 100 THEN
21.                     INPUT "AI is rolling again, press enter... ", wate$
22.                 ELSE
23.                     AI = AI + accum
24.                     INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
25.                     EXIT FOR
26.                 END IF
27.             END IF
28.         END IF
29.     NEXT
30.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
31. WEND
32. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"
33.  

32 lines, thanks again Steve.

Title: Re: Pig
Post by: SMcNeill on October 18, 2018, 09:59:52 pm

Let's reverse those numbers -- 23 Lines:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a 1, the turn is over, press enter...";
9.         IF di = 1 THEN INPUT "", wate$
10.         IF di = 1 THEN EXIT FOR
11.         accum = accum + di
12.         PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum)
13.         IF Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
14.         IF Who$ = "Player" THEN IF choice$ <> "r" THEN player = player + accum
15.         IF Who$ = "Player" THEN IF choice$ <> "r" THEN EXIT FOR
16.         IF Who$ <> "Player" AND i < 3 AND accum + AI < 100 THEN INPUT "AI is rolling again, press enter... ", wate$
17.         IF Who$ <> "Player" AND i >= 3 OR accum + AI >= 100 THEN AI = AI + accum
18.         IF Who$ <> "Player" AND i >= 3 OR accum + AI >= 100 THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
19.         IF Who$ <> "Player" AND i >= 3 OR accum + AI >= 100 THEN EXIT FOR
20.     NEXT
21.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
22. WEND
23. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

Title: Re: Pig
Post by: bplus on October 18, 2018, 10:15:19 pm

That is amazing but I've noticed a bug while player is rolling suddenly the AI is holding ...???

and now this!!! ? (Dang! I thought I had a 2nd shot of buggy code giving all points racked up by Player to AI.)

Title: Re: Pig
Post by: SMcNeill on October 18, 2018, 10:20:44 pm

Give me a sec and I'll see what I missed with the IF statements...  :P

Title: Re: Pig
Post by: bplus on October 18, 2018, 10:22:57 pm

I am sure there is big savings here!

Title: Re: Pig
Post by: SMcNeill on October 18, 2018, 10:28:29 pm

Try this:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a 1, the turn is over, press enter...";
9.         IF di = 1 THEN INPUT "", wate$
10.         IF di = 1 THEN EXIT FOR
11.         accum = accum + di
12.         PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum)
13.         IF Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
14.         IF Who$ = "Player" THEN IF choice$ <> "r" THEN player = player + accum
15.         IF Who$ = "Player" THEN IF choice$ <> "r" THEN EXIT FOR
16.         IF Who$ <> "Player" AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
17.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
18.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
19.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN EXIT FOR
20.     NEXT
21.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
22. WEND
23. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

I'm thinking the glitch was with the binary operators...
IF this AND that OR otherthing THEN....  Anytime otherthing was valid, it made the statement valid...

Whereas:
IF this AND (that OR otherthing) THEN...  Now one of the secondary options have to be valid, while the primary option is valid as well.  It's not just saying "IF the third choice is good, then we're good."  Now it's "IF the first choice is good AND (either the second or third choice are good) THEN...

Title: Re: Pig
Post by: bplus on October 18, 2018, 10:43:24 pm

Looking good! Nice job tracking down bug!

Title: Re: Pig
Post by: SMcNeill on October 18, 2018, 10:50:10 pm

And a little reworking of the PRINT statements and INPUT, reduces one more line:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN accum = 0 ELSE accum = accum + di
9.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
10.         IF di = 1 THEN INPUT "The turn is over, press enter...", wate$
11.         IF di = 1 THEN EXIT FOR
12.         IF Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
13.         IF Who$ = "Player" AND choice$ <> "r" THEN player = player + accum
14.         IF Who$ = "Player" AND choice$ <> "r" THEN EXIT FOR
15.         IF Who$ <> "Player" AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
16.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
17.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
18.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN EXIT FOR
19.     NEXT
20.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
21. WEND
22. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

And, I don't think I see anything else which I can chip away, to reduce line count any further.  22 Lines is where I say, "That's it for Steve!'  ;D

Title: Re: Pig
Post by: bplus on October 18, 2018, 11:08:36 pm

Wow that is nice! Not a single statement is double parked! :) 22 lines.

Thanks!

Well, down in low 20's could loose title and make it legal 21. ;)

Code: QB64: [Select]

1. RANDOMIZE TIMER 'pig from Rosetta v4  B+ started 2018-10-16, Steve McNeill finished 2018-10-18
2. WHILE player < 100 AND AI < 100
3.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
4.     accum = 0
5.     FOR i = 1 TO 100
6.         di = INT(RND * 6) + 1
7.         IF di = 1 THEN accum = 0 ELSE accum = accum + di
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
9.         IF di = 1 THEN INPUT "The turn is over, press enter...", wate$
10.         IF di = 1 THEN EXIT FOR
11.         IF Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
12.         IF Who$ = "Player" AND choice$ <> "r" THEN player = player + accum
13.         IF Who$ = "Player" AND choice$ <> "r" THEN EXIT FOR
14.         IF Who$ <> "Player" AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
15.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
16.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
17.         IF Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN EXIT FOR
18.     NEXT
19.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
20. WEND
21. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"
22.  

I am finding the AI pretty easy to beat, so I will see if I can find a more competitive strategy for AI.

Title: Re: Pig
Post by: SMcNeill on October 18, 2018, 11:33:26 pm

I lied...   After going to bed, a thought hit me, so I hopped back up and made a few other small changes:

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         di = INT(RND * 6) + 1
8.         IF di = 1 THEN accum = 0 ELSE accum = accum + di
9.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
10.         IF di = 1 THEN INPUT "The turn is over, press enter...", wate$
11.         IF di > 1 AND Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
12.         IF di > 1 AND Who$ = "Player" AND choice$ <> "r" THEN player = player + accum
13.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
14.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
15.         IF (Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
16.     NEXT
17.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
18. WEND
19. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

19 lines...  It now works for the 20-line challenge, so I think this is *IT* for me.  :D

Title: Re: Pig
Post by: SMcNeill on October 18, 2018, 11:48:02 pm

OK, so I managed to drop one more line -- though the logic here is becoming so obtuse that I'm afraid it'll obfuscate the code beyond any sort of readability for folks in the future...

Code: QB64: [Select]

1. _TITLE "Pig 3 (Rosetta task)" ' attempt to pare down (no :'s) first version B+ started 2018-10-17
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     FOR i = 1 TO 100
6.         di = INT(RND * 6) + 1
7.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
9.         IF di = 1 THEN INPUT "The turn is over, press enter...", wate$
10.         IF di > 1 AND Who$ = "Player" THEN INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "AI is rolling again, press enter... ", wate$
11.         IF di > 1 AND Who$ = "Player" AND choice$ <> "r" THEN player = player + accum
12.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
13.         IF di > 1 AND Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
14.         IF (Who$ <> "Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
15.     NEXT
16.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
17. WEND
18. IF player > AI THEN PRINT "Player wins!" ELSE PRINT "AI wins!"

How's this beauty for a singular statement, that's almost impossible to look at and figure out what the heck it's doing:

        IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di

All that to get rid of the simple command which reset the value of accum for us each loop...  accum = 0

BUT... 

18 lines!

Title: Re: Pig
Post by: bplus on October 19, 2018, 12:07:43 am

Well that accum = 0 line was sticking out like a sore thumb anyway! ;D

Man, unbelievable, amazing, .... wow!

So 17 now? because I dropped the _TITLE and settled for a comment after Randomize Timer.
Now. I don't know if necessary.

Title: Re: Pig
Post by: SMcNeill on October 19, 2018, 12:19:56 am

You could get 17 if you merged the lines with the PRINT statements, though it'd give the user redundant information with the overall total more often.  Otherwise, I really don't see anything else much which we can cut out easily or compress.

Title: Re: Pig
Post by: bplus on October 19, 2018, 12:25:13 am

I like the title, there was some poor wording I changed and I got everything off the edge of the screen, maybe even more margin would be nice.

Code: QB64: [Select]

1. _TITLE "Pig 5 (Rosetta task)" ' B+ started 2018-10-17 Steve McNeill finished 2018-10-19
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100
4.     IF Who$ <> "   Player" THEN Who$ = "   Player" ELSE Who$ = "   AI"
5.     FOR i = 1 TO 100
6.         di = INT(RND * 6) + 1
7.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
8.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
9.         IF di = 1 THEN INPUT "   The turn is over, press enter...", wate$
10.         IF di > 1 AND Who$ = "   Player" THEN INPUT "   Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "   AI is rolling again, press enter... ", wate$
11.         IF di > 1 AND Who$ = "   Player" AND choice$ <> "r" THEN player = player + accum
12.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
13.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT "   AI is holding so accumulated amount is scored, press enter", wate$
14.         IF (Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "   Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
15.     NEXT
16.     PRINT CHR$(10) + "   Player =" + STR$(player) + "  AI =" + STR$(AI)
17. WEND
18. IF player > AI THEN PRINT "   Player wins!" ELSE PRINT " AI wins!"
19.  

EDIT: Yeah more margin and fix a space before a comma.

Title: Re: Pig
Post by: SMcNeill on October 19, 2018, 12:36:29 am

If you don't mind the player getting a free, static, roll on the very first turn, you could also change:

IF di = 1 THEN INPUT " The turn is over, press enter...", wate$

To:

IF di = 1 THEN INPUT " The turn is over, press enter...", wate$ ELSE RANDOMIZE TIMER

The first roll would be predictable when the game starts, but since it's not going to be 1, you'd randomize timer to make all the rolls afterwards difficult to predict.

Can drop 1 more line that way, as well.

Title: Re: Pig
Post by: bplus on October 19, 2018, 12:52:41 am

Yeah, OK 17! that's less than half the IDE screen.

I started a little out-dentation to signal the end of a turn:

Code: QB64: [Select]

1. _TITLE "Pig 5 (Rosetta task)" ' B+ started 2018-10-17 Steve McNeill finished 2018-10-19
2. WHILE player < 100 AND AI < 100
3.     IF Who$ <> "   Player" THEN Who$ = "   Player" ELSE Who$ = "   AI"
4.     FOR i = 1 TO 100
5.         di = INT(RND * 6) + 1
6.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
7.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
8.         IF di = 1 THEN INPUT " The turn is over, press enter...", wate$ ELSE RANDOMIZE TIMER
9.         IF di > 1 AND Who$ = "   Player" THEN INPUT "   Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "   AI is rolling again, press enter... ", wate$
10.         IF di > 1 AND Who$ = "   Player" AND choice$ <> "r" THEN player = player + accum
11.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
12.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT " AI is holding so accumulated amount is scored, press enter", wate$
13.         IF (Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "   Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
14.     NEXT
15.     PRINT CHR$(10) + "   Player =" + STR$(player) + "  AI =" + STR$(AI)
16. WEND
17. IF player > AI THEN PRINT " Player wins!" ELSE PRINT " AI wins!"
18.  
19.  

EDIT: change a spacing on last line.

Title: Re: Pig
Post by: SMcNeill on October 19, 2018, 01:01:04 am

Question:

Can't the last line just be:  PRINT Who$; " wins!"

Is the IF necessary there?  (I'm in bed, on the iPad, so can't test it ATM.  :P )

Title: Re: Pig
Post by: bplus on October 19, 2018, 01:06:41 am

Also good!

Code: QB64: [Select]

1. _TITLE "Pig 5 (Rosetta task)" ' B+ started 2018-10-17 Steve McNeill finished 2018-10-19
2. WHILE player < 100 AND AI < 100
3.     IF Who$ <> "   Player" THEN Who$ = "   Player" ELSE Who$ = "   AI"
4.     FOR i = 1 TO 100
5.         di = INT(RND * 6) + 1
6.         IF i = 1 AND di = 1 THEN accum = 0 ELSE IF i = 1 THEN accum = di ELSE IF di = 1 THEN accum = 0 ELSE accum = accum + di
7.         IF di = 1 THEN PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + CHR$(10) ELSE PRINT CHR$(10) + Who$ + " rolled a" + RTRIM$(STR$(di)) + ", the accumulated total is" + STR$(accum) + CHR$(10);
8.         IF di = 1 THEN INPUT " The turn is over, press enter...", wate$ ELSE RANDOMIZE TIMER
9.         IF di > 1 AND Who$ = "   Player" THEN INPUT "   Do you want to (r)oll again or (h)old, Enter r or h"; choice$ ELSE IF di > 1 AND (i < 3 AND accum + AI < 100) THEN INPUT "   AI is rolling again, press enter... ", wate$
10.         IF di > 1 AND Who$ = "   Player" AND choice$ <> "r" THEN player = player + accum
11.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN AI = AI + accum
12.         IF di > 1 AND Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100) THEN INPUT " AI is holding so accumulated amount is scored, press enter", wate$
13.         IF (Who$ <> "   Player" AND (i >= 3 OR accum + AI >= 100)) OR (Who$ = "   Player" AND choice$ <> "r") OR di = 1 THEN EXIT FOR
14.     NEXT
15.     PRINT CHR$(10) + "   Player =" + STR$(player) + "  AI =" + STR$(AI)
16. WEND
17. PRINT Who$; " wins!"
18.  

Nice touch at end. :)

I am calling it a night, very fun night! Thanks

Title: Re: Pig
Post by: johnno56 on October 19, 2018, 03:20:46 am

I have converted, albeit crudely, an old TRS80 (1980) game called Groan.

It's similar to Pig but uses a pair of dice against AI. Select a score total; Roll dice; Pass and accumulate; Roll again. If a one is rolled, the total for that 'hand,' is lost. If a pair of one's are rolled then all of the roller's score is lost and reset to zero. First to total wins. It is spaghetti and has line numbers.

If anyone is interested I will post the listing. If not, no big deal... Just thought I would mention it...

J

Title: Re: Pig
Post by: bplus on October 19, 2018, 09:40:47 am

Yeah, Johnno, I was reading the Wiki for Pig Game: https://en.wikipedia.org/wiki/Pig_(dice_game)
and I wouldn't mind exploring variations of the game.

So if you need help removing spaghetti, I will butcher your pig. ;)

I was thinking of hamming it up with a variation to the multi-di game where you choose in advance the amount of dice, but 1 Ace you score nothing, 2 Ace's you loose your whole score 3 Ace's and your game is over! What do you think?

Title: Re: Pig
Post by: johnno56 on October 19, 2018, 06:20:27 pm

bplus,

As per your request.

Code: QB64: [Select]

1. '                   GROAN
2. '   (c) 1979 by Phil Feldman and Tom Rugg
3. '
4. 120 RANDOMIZE TIMER: DEFINT W: DIM SHARED Z
5. 140 B$ = CHR$(219): C$ = CHR$(254): L$ = CHR$(220): M$ = "="
6. 150 U$ = CHR$(223): N$ = " ": F3$ = B$ + STRING$(40, "=") + B$
7. 160 D1$ = B$ + STRING$(7, 223) + B$: D2$ = B$ + STRING$(7, 32) + B$
8. 170 D3$ = B$ + STRING$(7, 220) + B$: E1$ = STRING$(4, 32) + L$ + M$ + L$ + STRING$(4, 32)
9. 180 E2$ = N$ + L$ + M$ + U$ + N$ + N$ + N$ + U$ + M$ + L$ + N$: E3$ = U$ + M$ + L$ + STRING$(5, 32) + L$ + M$ + U$
10. 185 E4$ = N$ + N$ + N$ + U$ + M$ + L$ + M$ + U$ + N$ + N$ + N$
11. 190 F1$ = B$ + STRING$(40, 223) + B$: F2$ = B$ + STRING$(40, 220) + B$
12. 200 CLS: PRINT TAB(25); "G R O A N"
13. 210 PRINT "HOW MUCH NEEDED TO WIN"
14. 220 INPUT "(BETWEEN 50-100 IS BEST) "; W: IF W <= 0 THEN GOTO 200
15. 230 PRINT: PRINT "LET'S TOSS FOR FIRST ROLL": GOSUB 830
16. 240 PRINT: PRINT "THE COIN IS IN THE AIR AND"
17. 250 Q$ = "YOU": Q = INT(RND * 2) + 1: IF Q = 2 THEN Q$ = "I"
18. 260 PRINT TAB(8);: FOR J = 1 TO 5: PRINT ". ";: GOSUB 830: NEXT
19.  
20.  
21. 270 PRINT Q$; " GET FIRST ROLL": GOSUB 840: T = 0: IF Q = 2 THEN GOTO 400
22. 300 P$ = " YOU": CLS: PRINT TAB(25); "YOU'RE ROLLING": GOSUB 830: GOSUB 500
23. 310 T = T + R1 + R2: IF F > 0 THEN T = 0
24. 320 IF F = 2 THEN H = 0
25. 330 GOSUB 850: IF F > 0 THEN PRINT "DICE PASS TO ME": GOSUB 840: GOTO 400
26. 340 PRINT "(P=PASS DICE - R=ROLL AGAIN)": PRINT "YOUR CHOICE (P OR R) ?"
27. 350 Q$ = INKEY$: Q$ = UCASE$(Q$): IF Q$ = "" THEN GOTO 350
28. 360 IF Q$ = "R" THEN GOTO 300
29. 370 IF Q$ <> "P" THEN GOTO 350
30. 380 PRINT: H = H + T: IF H >= W THEN GOTO 970
31. 390 T = 0: F = 1: CLS: GOTO 330
32. 400 T = 0: P$ = "I"
33. 410 CLS: PRINT TAB(26); "I'M ROLLING": GOSUB 830: GOSUB 500
34. 420 T = T + R1 + R2: IF F > 0 THEN T = 0
35. 430 IF F = 2 THEN P = 0
36. 440 GOSUB 850: IF F > 0 THEN PRINT "DICE PASS TO YOU": GOSUB 840: T = 0: GOTO 300
37. 450 GOSUB 1000: IF X = 1 THEN PRINT "I'LL ROLL AGAIN": GOSUB 840: GOTO 410
38. 460 PRINT "I'LL STOP WITH THIS": GOSUB 830: P = P + T: IF P >= W THEN GOTO 970
39. 470 PRINT: PRINT "DICE PASS TO YOU": T = 0: GOSUB 840: GOTO 300
40. 500 D = 266: R1 = INT(RND * 6) + 1: R2 = INT(RND * 6) + 1: GOTO 540
41. 530 C = D + K: GOSUB 650: C = C + 384: GOSUB 650: GOSUB 600: CLS
42. 535 GOSUB 660: C = C - 384: GOSUB 660: GOSUB 600: CLS
43. 540 C = D + 48: GOSUB 650: C = C + 384: GOSUB 650
44. 550 C = D + 48: R = R1: GOSUB 700
45. 560 C = C + 384: R = R2: GOSUB 700: F = 0: IF R1 = 1 THEN F = 1: GOSUB 800
46. 570 IF R2 = 1 THEN F = F + 1: GOSUB 810
47. 580 IF F = 2 THEN GOSUB 820: GOSUB 830
48. 590 RETURN
49. 600 FOR J = 1 TO DL: NEXT: RETURN
50. 650 PRINTAT C - 136: PRINT D1$: PRINTAT C - 72: PRINT D2$: PRINTAT C - 8: PRINT D3$: RETURN
51. 660 PRINTAT C - 192: PRINT E1$: PRINTAT C - 133: PRINT E2$: PRINTAT C - 69: PRINT E3$
52. 670 PRINTAT C - 5: PRINT E4$: RETURN
53. 700 ON R GOSUB 710, 730, 740, 750, 760, 770: RETURN
54. 710 PRINTAT C - 134: PRINT C$;: PRINTAT C - 130: PRINT C$;: PRINTAT C - 68: PRINT "(";: PRINTAT C - 6: PRINT "/";
55.  
56. 720 FOR Q = 3 TO 5: PRINTAT C - Q: PRINT C$;: NEXT: PRINTAT C - 2: PRINT "\";: RETURN
57. 730 PRINTAT C - 134: PRINT C$;: PRINTAT C - 2: PRINT C$;: RETURN
58. 740 PRINTAT C - 68: PRINT "=";: GOSUB 730: RETURN
59. 750 PRINTAT C - 130: PRINT C$;: PRINTAT C - 6: PRINT C$: GOSUB 730: RETURN
60. 760 GOSUB 740: GOSUB 750: RETURN
61. 770 PRINTAT C - 70: PRINT "=";: PRINTAT C - 66: PRINT "=";: GOSUB 750: RETURN
62. 800 PRINTAT 52: PRINT "GROAN";: RETURN
63. 810 PRINTAT 820: PRINT "GROAN";: RETURN
64. 820 PRINTAT 434: PRINT "-DESPAIR-";: RETURN
65. 830 _DELAY 2: RETURN
66. 840 _DELAY 3: RETURN
67. 850 PRINTAT 64: PRINT F1$;: G = 128: GOSUB 960: PRINTAT 135: PRINT "- - S C O R E B O A R D - -";
68. 860 PRINTAT 192: PRINT F3$;: G = 256: GOSUB 960: PRINTAT 264: PRINT W; "POINTS NEEDED TO WIN";
69. 870 PRINTAT 320: PRINT F3$;: G = 384: GOSUB 960
70. 880 PRINTAT 386: PRINT "   POINTS SCORED         YOU     ME";: G = 448
71. 890 GOSUB 960: PRINTAT 450: PRINT "BEFORE THIS SERIES";: PRINTAT 475: PRINT H;
72. 900 PRINTAT 482: PRINT P;: PRINTAT 512: PRINT F3$;: G = 576: GOSUB 960
73. 910 PRINTAT 582: PRINT P$; " HAVE"; T; "POINTS THIS SERIES";
74. 920 PRINTAT 640: PRINT F2$;: PRINTAT 768: PRINT "";: RETURN
75. 960 PRINTAT G: PRINT B$;: PRINTAT G + 41: PRINT B$;: RETURN
76. 970 T = 0: CLS: GOSUB 850: IF P >= W THEN PRINTAT 768: PRINT "SKILL WINS AGAIN"
77. 980 IF H >= W THEN PRINTAT 768: PRINT "YOU WIN - IT WAS SHEER LUCK!"
78. 990 END
79. 1000 V = P + T: IF V >= W THEN GOTO 1100
80. 1010 IF (W - H) < 10 THEN GOTO 1110
81. 1020 IF P >= H THEN L = T / 25: GOTO 1050
82. 1030 IF V < H THEN L = T / 35: GOTO 1050
83. 1040 L = T / 30
84. 1050 IF RND > L THEN GOTO 1110
85. 1100 X = 0: RETURN
86. 1110 X = 1: RETURN
87.  
88. SUB PRINTAT (Z)
89.     LOCATE INT(Z / 64) + 1, (Z MOD 64 + 1)
90. END SUB
91.  

As you are probably aware, TRS80 uses 'print@ x' to position the text on the screen, so I have added a subroutine to simulate the command. The graphics are ugly because I cannot duplicate the TRS80 character set. If you can 'de-spaghetti' the listing that would be great. Demonstrating how you do that would be even better. That way, eventually, I will not have to pester you (or others) to do it for me... Nudge. Nudge. Wink. Wink. Say no more...

Happy butchering... lol

ps:  I have a PDF copy of the book this program came from. If you are interested, let me know, and I will post it...

Title: Re: Pig
Post by: bplus on October 19, 2018, 07:30:44 pm

Hi Johnno,

Oh so you want me to fix this thing? Are those two things on the right suppose to be dice?

I think this code is purposely designed to demonstrate the worst of spaghetti. I mean who would in their right mind would call a gosub to do one freakin line of code?

Code: QB64: [Select]

1. 1100 X = 0: RETURN
2. 1110 X = 1: RETURN

The quickest way to fix this code is to scrap it and start over using variables and subs that are descriptive.

Johnno break this game down into steps. Get the essence of the game working and then refine adding bells and whistles.
 
OK here is 2 dice Pig game:

Code: QB64: [Select]

1. _TITLE "Pig with 2 Dice" 'get Johnno setup with 2 di version of Pig B+ started 2018-10-19
2. RANDOMIZE TIMER
3. WHILE player < 100 AND AI < 100 'pig from Rosetta  B+ started 2018-10-16
4.     IF Who$ <> "Player" THEN Who$ = "Player" ELSE Who$ = "AI"
5.     accum = 0
6.     FOR i = 1 TO 100
7.         d1 = INT(RND * 6) + 1: d2 = INT(RND * 6) + 1
8.         PRINT CHR$(10) + "The dice are:"; d1; "and"; d2
9.         IF d1 = 1 OR d2 = 1 THEN
10.             PRINT Who$ + " rolled a 1, the turn is over, press enter...";
11.             INPUT "", wate$
12.             EXIT FOR
13.         ELSE
14.             accum = accum + d1 + d2
15.             PRINT Who$ + " accumulated total is" + STR$(accum)
16.             IF Who$ = "Player" THEN
17.                 INPUT "Do you want to (r)oll again or (h)old, Enter r or h"; choice$
18.                 IF choice$ <> "r" THEN player = player + accum
19.                 IF choice$ <> "r" THEN EXIT FOR
20.             ELSE
21.                 IF i < 3 AND accum + AI < 100 THEN
22.                     INPUT "AI is rolling again, press enter... ", wate$
23.                 ELSE
24.                     AI = AI + accum
25.                     INPUT "AI is holding so accumulated amount added it's score, press enter", wate$
26.                     EXIT FOR
27.                 END IF
28.             END IF
29.         END IF
30.     NEXT
31.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
32. WEND
33. PRINT Who$; " wins!"
34.  

If you want to see dice and nice scoreboard be my guest! :)

Title: Re: Pig
Post by: johnno56 on October 19, 2018, 09:04:58 pm

I am not 'expecting' you to fix it... lol  A refresher: I 'did' use the conditional statement, "IF you can..."  The choice is yours... I can, and prefer to use, subs or functions but as I have stated in the past, I struggle with 'gotos' particularly when jumping out of "if...then's"

I have a 'list' of 'main routines' (as laid out in the book) and will try my best to convert. You are correct when it comes to refining the 'working' of the game 'before' adding the 'bells and whistles'.

The "right mind" gosub incorporates line numbers 1000-1110 and is only called when the computer rolls in line number 450.

Yep. "Those two things" are indeed meant to be dice... TRS80 'graphics', as you are probably familiar with, are 2 by 3 'blocks'. The current dice conversion are made by using the closest extended character set as possible (in my opinion...) and hence the "ugly". I know there are better ways but will leave that until I have finished my attempt at converting... (in the book... the dice roll is animated across an empty screen - the option to omit the roll is included in the book... Maybe it will be added in the updated version? (fingers crossed)...)

I am SO used to 'line numbers' (and that kind of thinking) that I find it difficult to convert it to something more structured like QB64, Naalaa and SDLBasic... So I don't 'normally' opt for converting unless there are no goto's... lol  (old dogs: new tricks) That doesn't mean I'm not keen to change... For me change is not so easy... but I try...

I will break it down as you suggest and go from there... Do not hold your breath waiting... lol

Thanks for the advise.

J

Title: Re: Pig
Post by: bplus on October 19, 2018, 10:54:03 pm

Hi Johnno,

I am wondering if the two dice game is working as expected for 2 dice ie following the rules of play correctly.
The code you posted did not work properly (It would jump suddenly from player rolling to AI without player seeing what they rolled probably had a 1 in it which caused the switch of play??? need a pause right there so player can see what is going on.) so I could not tell from that.

Where my Pig 2 Dice game code says:
PRINT CHR$(10) + "The dice are:"; d1; "and"; d2
Here is where you would call the sub to do whatever thing you want, to show off dice.

And at least everywhere there is an INPUT, there, you would call a sub to display a pretty score board and wait for a keypress to exit sub and continue play.

I would say those 2 things are main difference of my Pig 2 dice game and the spaghetti western one. :)

Title: Re: Pig
Post by: johnno56 on October 20, 2018, 12:02:22 am

I cannot attest to the accuracy of the game-play, as I did not write the program. All I did was to copy the book listing into the QB64 IDE and modify the graphics where needed. But I did say, from the beginning, that they (Pig and Groan) were similar.

The switching of players is pretty much automatic as soon as a one or double one is rolled. There should be a brief delay, so as to see either a single or double groan message, before the next roller has a turn... in theory that is... lol

I have transposed this game, on more than one occasion, into several types of basic and have not experienced any 'game flow' difficulties. But, that being said, the basics I used were quite old and slow. The poor things probably couldn't switch players fast enough, even if they could... lol

If you need to check the program, https://www.dropbox.com/s/wtumork8p6otiq2/TRS-80%20Programs%20%281980%29%28Tom%20Rugg%29%28pdf%29.pdf?dl=0, from page 119 onwards

Title: Re: Pig
Post by: bplus on October 20, 2018, 09:16:07 am

Hmm,,,, Johnno, I am getting impression this not a game you want to pursue development wise. You were just offering as example of 2 Dice Game like Pig and unfortunately I could not learn anything useful from that version because in my view it doesn't work well enough to learn how the play of the game goes. And the spaghetti code would be hell to try and fix! So, so much for that, ha! ;-))

I am interested in developing a version as mentioned before of each player choosing how many dice for a one roll turn, where again one 1 will gain no points, two 1's will loose your score and three 1's and game over.

New: FOUR 1's and you are automatic winner! So high risk offers high reward!

This game, since it is a QB64 forum variation, I would like to develop with sound and graphics, perhaps an Oink! for every dice chosen above one or 2 and of course we have to work in some appropriate pig images for winners and losers and AI's pig and human's pig avatar... Dice rolling sound, dice images rolling, I bet people have versions of that?

Anybody feel free to offer ideas, sounds and or pig images, I or we could be free to use.

Potential names:
Hog Heaven
Bringing Home the Bacon
Porkers

Also since there seems an advantage to who rolls first, who rolls first will be decided randomly by a farmer referee possibly?
(Come to think of it, I got that idea partially form Johnno's code but also from Rosetta Challenge that offers bragging rights bonus for analyzing different AI strategies and then they mentioned an advantage to the first roller also.)

Oh opening screen sound: the farmer calling his pigs home. ;-))

Title: Re: Pig
Post by: bplus on October 22, 2018, 09:41:23 am

Reading over this thread, I see I forgot to handle the condition of rolling 2 ones in the 2 Dice version of Pig, what Johnno is calling Groan.

Here I added that and also splendidly colorized game. :D

Code: QB64: [Select]

1. _TITLE "Pig with 2 Dice" 'get Johnno setup with 2 di version of Pig B+ started 2018-10-19
2. '2018-10-22 fixed handling of rolling two 1's when score should be reset to 0 and colorized
3.  
4. RANDOMIZE TIMER
5. WHILE player < 100 AND AI < 100
6.     IF Who$ <> "Player" THEN Who$ = "Player": COLOR 11: ELSE Who$ = "AI": COLOR 9
7.     accum = 0
8.     FOR i = 1 TO 100
9.         d1 = INT(RND * 6) + 1: d2 = INT(RND * 6) + 1
10.         PRINT CHR$(10) + Who$; " dice are:"; d1; "and"; d2
11.         IF d1 = 1 AND d2 = 1 THEN
12.             INPUT "Two 1's rolled, so that score is reset to 0, press enter...", wate$
13.             IF Who$ = "AI" THEN AI = 0 ELSE player = 0
14.             EXIT FOR
15.         ELSEIF d1 = 1 OR d2 = 1 THEN
16.             INPUT "A 1 was rolled, the turn is over, press enter..."; wate$
17.             EXIT FOR
18.         ELSE
19.             accum = accum + d1 + d2
20.             PRINT Who$ + " accumulated total is" + STR$(accum)
21.             IF Who$ = "Player" THEN
22.                 COLOR 14
23.                 INPUT "Do you want to (r)oll again or hold? Enter r or just enter to hold"; choice$
24.                 COLOR 11
25.                 IF choice$ <> "r" THEN player = player + accum
26.                 IF choice$ <> "r" THEN EXIT FOR
27.             ELSE
28.                 IF i < 3 AND accum + AI < 100 THEN
29.                     INPUT "AI is rolling again, press enter... ", wate$
30.                 ELSE
31.                     AI = AI + accum
32.                     INPUT "AI is holding so accumulated amount is added to it's score, press enter...", wate$
33.                     EXIT FOR
34.                 END IF
35.             END IF
36.         END IF
37.     NEXT
38.     COLOR 2
39.     PRINT CHR$(10) + "Player =" + STR$(player) + "  AI =" + STR$(AI)
40. WEND
41. PRINT Who$; " wins!"
42.  
43.  

Title: Re: Pig
Post by: johnno56 on October 22, 2018, 04:46:27 pm

Cool... and I even like the colours...

Side note. A potential name for the game... 'Rashers' staring: Chris P. Bacon  lol

Title: Re: Pig
Post by: bplus on October 23, 2018, 08:57:00 am

I had never heard of Rashers, Albert Einswine advises Hamlet.

Boink works for me.

Title: Re: Pig
Post by: bplus on October 23, 2018, 01:58:14 pm

Prize Pig (so far) fattest code yet!

Code: QB64: [Select]

1. _TITLE "Boink" ' for QB64 B+ started a version of Pig when/where the number of di is declared and rolled
2.  
3.  
4. ' Boink rules:
5. ' Start round by flipping coin who goes first
6. ' Each player chooses number of dice to roll to start their round
7. ' Dice rolled
8. ' If 1 di is 1 then no points that turn,
9. ' If 2 di are 1 then no points and the score is reset to 0,
10. ' If 3 di are 1 then gameover that player lost,
11. ' If 4 di are 1 then player wins game automatically,
12. ' Otherwise the player gets the total of di added to their score.
13.  
14.  
15. RANDOMIZE TIMER
16. CONST wholeHog = 7
17. Sooie = 1
18. WHILE Sooie
19.     IF RND < .5 THEN
20.         GOSUB FarmerRound
21.         IF Sooie THEN GOSUB HALRound
22.     ELSE
23.         GOSUB HALRound
24.         IF Sooie THEN GOSUB FarmerRound
25.     END IF
26. WEND
27. END
28.  
29. FarmerRound:
30. COLOR 11
31. Who$ = "Farmer"
32. COLOR 14
33. cp "Farmer, Enter how many dice to roll."
34. LOCATE , 38: INPUT ; hogHerd
35. COLOR 11
36. GOSUB RollEmRollEM
37. RETURN
38.  
39. HALRound:
40. COLOR 9
41. Who$ = "HAL"
42. hogHerd = INT(wholeHog * (100 - HAL) / 100 + .5)
43. IF hogHerd = 0 THEN hogHerd = 1
44. GOSUB RollEmRollEM
45. RETURN
46.  
47. RollEmRollEM:
48. pigsEye = 0: bacon = 0
49. s$ = Who$ + "'s, dice roll is:"
50. FOR pigglet = 1 TO hogHerd
51.     Babe = INT(RND * 6) + 1
52.     IF Babe = 1 THEN pigsEye = pigsEye + 1
53.     bacon = bacon + Babe
54.     s$ = s$ + " " + STR$(Babe)
55. NEXT
56. cp s$
57. SELECT CASE pigsEye
58.     CASE 0
59.         IF Who$ = "Farmer" THEN Farmer = Farmer + bacon ELSE HAL = HAL + bacon
60.         cp Who$ + "," + STR$(bacon) + " has been added to your score."
61.         IF Farmer >= 100 OR HAL >= 100 THEN Sooie = 0: cp Who$ + " wins!"
62.     CASE 1
63.         cp Who$ + " rolled a 1, so your score remains the same."
64.     CASE 2
65.         IF Who$ = "Farmer" THEN Farmer = 0 ELSE HAL = 0
66.         cp Who$ + " rolled two 1's, so your score is reset to 0."
67.     CASE 3
68.         cp Who$ + ", sorry three 1's means you lost the game."
69.         Sooie = 0
70.     CASE ELSE
71.         cp Who$ + " more than three 1's makes you the winner!"
72.         Sooie = 0
73. END SELECT
74. cp "Press any..."
75. IF Sooie THEN
76.     k$ = INKEY$
77.     WHILE LEN(k$) = 0: k$ = INKEY$: _LIMIT 100: WEND
78.     COLOR _RGB(255, 150, 170)
79.     PRINT
80.     cp "Boink Score Board:  Farmer =" + STR$(Farmer) + "  HAL =" + STR$(HAL)
81.     PRINT
82. END IF
83. RETURN
84.  
85. SUB cp (s$)
86.     LOCATE , (80 - LEN(s$)) / 2: PRINT s$
87. END SUB
88.  
89.  

Title: Re: Pig
Post by: johnno56 on October 23, 2018, 03:27:46 pm

Nice variation... Cool.  I see you have located, and used, some of the original 1945 options... (I looked up 'Pig'...) - However, and I am in no way asking you to make changes, one of the options of selecting the number of dice (die) is that the number 6 is treated like a number 1. But only when choosing the number of dice greater than two...

By the way... Playing your last version (with double ones) seemed to take forever. The number of times a double one came up was almost frustrating... Got to 86 points and Pow! Double one... Not just my rolls either... Played several times, but the 'loosing streak', did not occur again... Whew!

If ever you want to use graphics I have made two sets of dice. Red and White. The number one 'dot' now has a pig's face.

Title: Re: Pig
Post by: bplus on October 23, 2018, 04:19:25 pm

Hi Johnno,

Great! Thanks, there goes Screen 0, sorry Pete. ;(

Now these sounds do work on your Linux, correct?

Also, wasn't it you that had some dice rolling code? Maybe SdlBasic style or even Naalaa? That would be easily converted to QB64.

PS RE: 6 too?
I am awaiting codeguy's analysis of 1 frequency for n amount of di, in meantime one is enough. :D

Title: Re: Pig
Post by: johnno56 on October 23, 2018, 05:09:01 pm

In regards to the sounds... Yes they do. If this is not the case for you, I can convert them to whichever format you desire.

Screen 0? Oh. you were going for 'Text Only'? Not a problem. Will not be offended if you decide not to use them. Hang on to them for another project.

Dice rolling code? I will check but I have my doubts. I personally use the method int(rnd*6)+1 (rnd(6)).  I mentioned that 'Groan' had an animation sequence for the dice roll, but for your program, a better one is needed. The TRS80 version is too 'chunky'. I will research some code. Question: Do you want the dice to roll at the same time or one after the other (the latter can slightly add to the 'suspense'... lol)

Title: Re: Pig
Post by: johnno56 on October 23, 2018, 05:19:34 pm

Update: Dice.

Back in August of 2014, I posted an image of a 'dice' spinner, from the 1943 UK version of Monopoly. It is only for two dice. Other than that, I am still looking...

J

Title: Re: Pig
Post by: bplus on October 23, 2018, 05:26:07 pm

Hey Johnno,

(You posted while I was composing this reply, Oh I remember that! like a Roulette Wheel!)

Screen 0  is like tinkering around on the piano until you find a nice little melody, then writing the score for the full orchestra. Isn't that how Flappy Bird started?

I ask about sound because with Battleship you provided great stuff but after mods the sound did not work as I recall. I find such very disappointing because it was you who provided the sound.

Don't worry about what kind of code for the dice rolling you find, it will probably be modified anyway...

Just want to get this pig to fly! ;-))

Title: Re: Pig
Post by: SMcNeill on October 23, 2018, 05:31:31 pm

Try these for dice: https://notendur.hi.is/~ade3/Backgammon/images/dice2.png

That's a nice enough sheet, you could animate a good rolling animation.

Title: Re: Pig
Post by: bplus on October 23, 2018, 05:37:26 pm

Oh that sheet looks good!

Title: Re: Pig
Post by: SMcNeill on October 23, 2018, 05:49:33 pm

Quote from: bplus on October 23, 2018, 05:37:26 pm

Oh that sheet looks good!

You know, I'd even change my randomization routine to fit it.  Instead of just Dice = RND * 6 + 1, I'd set up a method to randomly choose up/down/left/right and then loop it until the user hits a key.  The random would choose which part of the sheet to show, making it the number we end up with.

At a decent display speed, it'd be hard for the user to "cheat" and force a value, but it'd look dang nice while rolling.   Add a little rattle, rattle, and you've got a work of art there.  :)

Title: Re: Pig
Post by: johnno56 on October 23, 2018, 06:19:35 pm

Nice sheet!  That's going to make a serious animation... I'll start on it right away.  Does it come in red? lol Kidding...

Thank you.

J

Title: Re: Pig
Post by: johnno56 on October 24, 2018, 04:56:19 am

Ok. I found a free animated dice gif and extracted each frame. Made a simple roller. It's not efficient but it works. It's just to see if something like this can be used for Pig. No user input. Rolls and gives a number.

J

Title: Re: Pig
Post by: bplus on October 24, 2018, 09:31:29 am

Johnno, a most excellent start!

I am currently knee deep in a Word Search Editor so if you don't mind continuing or maybe I can talk you through.

First you can optimize the file loads by creating the file names programatically (@Spell Checker = SC what? not a word? sheez)
sub loadManyImages(baseName, numOfFiles)
for i = 1 to numOfFiles
   filename$(i) = baseName + ltrim$(str$(i))+ ".png"
   dice&(i) = _LoadImage( filename$(i)) '<<<<<<<<<<<<<< DIM SHARED dice&(1 to numOfFiles) at code start
next
end sub
something like that, load 100's of images same 4 lines or so of code.

The one, two, three.. dice I would rename something like show1, show2, show3... show 6 and use same technique for loading.

Then setup a di Type for handling up to ... 18-100 di ( @SC, I like di sorry) in array of that Type.
track x, y, dx, dy, frame, directionRotation?< to decide next frame...
maybe a targetFrame too to stop dice spinning when on the ground with that frame up.

then dig up some old code with bouncing balls and plug-in dice images use same collision code use radius something between 1/2 di width/height and 1/2 the diagonal.

Oh it might be helpful to track the di frame with the face number(s) showing and associate that with the file name for loading.
3 faces at most would show list those in file from mainly to hardly showing 365 (if that is possible? hmm the only impossible is a face opposite)...  eh might be getting carried away... ;-)) but that is getting into a numbers sort thing, where is codeguy?

Actually I was wondering if Terry wanted to give his library a workout? perhaps a demo for setting up and using this di rolling thing.

Title: Re: Pig
Post by: bplus on October 24, 2018, 03:05:09 pm

Dang start talking about it and next thing you know you have some mods:

Title: Re: Pig
Post by: johnno56 on October 24, 2018, 03:30:59 pm

Optimising the 'load' worked like a treat... Excellent. I tried to do that earlier but had no idea that I had to use 'ltrim$()'... To quote the late, great, Maxwell Smart... "Missed it by THAT much..."

I spent at least an hour on extracting the dice images from the 'sheet' that Steve provided. I duplicated the red dice roller... The red dice roller used 15 images... Steve's black dice uses 114... So, no prizes for guessing, how THAT was coded. Your optimisation will GREATLY reduce the size of THAT listing...

As to the rest of it... You obviously have a greater belief in my abilities than I do...  I have had little to no experience with 'Type'. In fact, I have avoided it in the past, because of that... I know. Quite sad... I had thought of 'dynamic' dice (bounce and roll across the screen) but had no idea how to do that. The best I could hope for was rotating dice, in one spot, but could not figure out how to rotate so I resorted to multiple images.

The program, for want of a better word, that I provided was intended as a 'proof of concept' and took me ages just to figure it out... I am not a programmer. I enjoy tinkering with code and graphics. I have to use tutorials because it takes too long to have conversations. One of the downsides of living 'down under'. What I produce is based on what I know. I do not know anywhere near as much as you guys. Targetframe; Bouncing; Collision; Tracking and now the possibility of external libraries... This is too much to handle. This stuff may 'come easy' for you guys, but for me, not so much... This is all my fault for suggesting graphics... I should have been satisfied with 'Screen 0'...

Title: Re: Pig
Post by: bplus on October 24, 2018, 10:57:21 pm

Hi Johnno,

You sound overwhelmed, relax I don't think Terry is going to get involved with external libraries but aren't you the one who keeps asking for tutorials? Terry would be great.

Target frame is only the show # image we want to display at the end of the dice roll, the face number for the roll.

Collision and bounce we've not done yet but it's the same as any particle code, you've been there before. You even posted great collision code for rectangles that I saved for future reference.

TYPE is no mystery, instead of ballX() ballY() ballColor() 3 arrays for each character of ball, such that ballX(10), ballY(10) ballColor(10) describe ball 10.

With Type you can do a setup like this:

Type ballType
  x as integer
  y as integer
  kolor as _unsigned long '< best type for colors
end type

Dim ball(nBalls) as BallType 

This sets up an array that includes all the type definitions for one object, instead of 3 separate but related arrays, you have this one that groups them together.

Now ball 10 looks like this:
ball(10).x
ball(10).y
ball(10).kolor

Type just adds a .thing and embeds a () for the index number of the array. It is just the same as ballX(10) ballY(10) ballKolor(10), instead of needing 3 arrays you just use one to cover all the ball characteristics

In QB64, everything has a type (well in any PL everything has a type but some PL's leave it under the hood (SmallBASIC, SdlBasic..) more than others Naalaa and QB64 gives like 16 options for type of one variable.)

Here is my cheat sheet for Types, don't leave home without it:

Append: This is better and more complete of course but not quite at your fingertips (I typed my Type sheet out on Printer).
http://qb64.org/wiki/Variable_Types

I left out Memory stuff and forgot to mention fixed string types on my cheat sheet.

So in summary, all the variables have a Type and a TYPE definition groups several variables of different types (or the same) into an object or record. These can be dimensioned singly or in arrays like other variable types.

Lecture over, quiz on Friday. ;)

PS For a crash course on learning type, put OPTION _EXPLICIT at the top of your code then you will learn your number one bug is getting a variable DIM 'd but it will save you from those pesky less easy to find bugs caused by misspelling. It will also be quizzing you automatically about what type you want or at least have you thinking what type you really need.

Title: Re: Pig
Post by: bplus on October 25, 2018, 05:06:57 pm

Boink update, Graphic Boink has dice rolling and bouncing and no more sliding around after settling on the floor and all this is incorporated into the game:

Plenty left to do, like leaving a score board up all the time.

Text Only | Text with Attachments