Text Only | Text with Attachments

QB64.org Forum

Active Forums => QB64 Discussion => Topic started by: Cobalt on August 30, 2018, 11:48:03 am

Title: Invalid Syntax for ELSE error
Post by: Cobalt on August 30, 2018, 11:48:03 am
I swear I've had to deal with this error before and it has nothing to do with the ELSE itself. Probably on the .NET forum.
here is the sub generating the error.

Code: QB64: [Select]
  1. SUB DrawSprite(Lx%, Ly%, Mx~%%, MY~%%, Scale%%)
  2.   'get the end map displayed based on scale
  3.  Fx~%% = Mx~%% + (29 \ Scale%%)
  4.  Fy~%% = My~%% + (21 \ Scale%%)
  5.  
  6.  SELECT CASE Unit(0).Movement.IDmark 'Unit(0) sprite layout
  7.   CASE Peasant, Peon, Grunt, Archer, Spearman, Knight, Cleric, Necrolyte, Conjurer, Warlock
  8.    SELECT CASE Unit(0).Movement.Direction 'get base sprite offsets
  9.     CASE North
  10.      SpriteX1% = 0
  11.      SpriteY1% = 0
  12.      SpriteX2% = 31
  13.      SpriteY2% = 31
  14.     CASE NorthEast
  15.      SpriteX1% = 32
  16.      SpriteY1% = 0
  17.      SpriteX2% = 63
  18.      SpriteY2% = 31
  19.     CASE East
  20.      SpriteX1% = 64
  21.      SpriteY1% = 0
  22.      SpriteX2% = 95
  23.      SpriteY2% = 31
  24.     CASE SouthEast
  25.      SpriteX1% = 96
  26.      SpriteY1% = 0
  27.      SpriteX2% = 127
  28.      SpriteY2% = 31
  29.     CASE South
  30.      SpriteX1% = 128
  31.      SpriteY1% = 0
  32.      SpriteX2% = 159
  33.      SpriteY2% = 31
  34.     CASE SouthWest
  35.      SpriteX1% = 127
  36.      SpriteY1% = 0
  37.      SpriteX2% = 96
  38.      SpriteY2% = 31
  39.     CASE West
  40.      SpriteX1% = 95
  41.      SpriteY1% = 0
  42.      SpriteX2% = 64
  43.      SpriteY2% = 31
  44.     CASE NorthWest
  45.      SpriteX1% = 63
  46.      SpriteY1% = 0
  47.      SpriteX2% = 32
  48.      SpriteY2% = 31
  49.    END SELECT
  50.    SELECT CASE Unit(0).Act 'adjust based on unit action
  51.     CASE Still '      unit is not performing an action
  52.     CASE Moving '     unit is walking
  53.      SpriteX1% = SpriteX1%
  54.      SpriteY1% = SpriteY1% + 32 * Anima(0, Unit(0).Movement.Frame)
  55.      SpriteX2% = SpriteX2%
  56.      SpriteY2% = SpriteY2% + 32 * Anima(0, Unit(0).Movement.Frame)
  57.      Unit(0).Movement.Frame = Unit(0).Movement.Frame + 1
  58.      IF Unit(0).Movement.Frame = 8 THEN Unit(0).Movement.Frame = 0
  59.     CASE Mining '     unit is in mine and hidden  Peasant+Peon only
  60.     CASE LumberJack ' unit is chopping wood   Peasant+Peon only
  61.      SpriteX1% = SpriteX1% + 160
  62.      SpriteY1% = SpriteY1% + 32 * Anima(Unit(0).Movement.IDmark, Unit(0).Movement.Frame)
  63.      SpriteX2% = SpriteX2% + 160
  64.      SpriteY2% = SpriteY2% + 32 * Anima(Unit(0).Movement.IDmark, Unit(0).Movement.Frame)
  65.      Unit(0).Movement.Frame = Unit(0).Movement.Frame + 1
  66.      IF Unit(0).Movement.Frame = 8 THEN Unit(0).Movement.Frame = 0
  67.     CASE CarryGold '  unit is carrying bag of gold  Peasant+Peon only
  68.      SpriteX1% = SpriteX1%
  69.      SpriteY1% = SpriteY1% + 320 + 32 * Anima(0, Unit(0).Movement.Frame)
  70.      SpriteX2% = SpriteX2%
  71.      SpriteY2% = SpriteY2% + 320 + 32 * Anima(0, Unit(0).Movement.Frame)
  72.      Unit(0).Movement.Frame = Unit(0).Movement.Frame + 1
  73.      IF Unit(0).Movement.Frame = 8 THEN Unit(0).Movement.Frame = 0
  74.     CASE CarryWood '  unit is carrying a stack of wood  Peasant+Peon only
  75.      SpriteX1% = SpriteX1%
  76.      SpriteY1% = SpriteY1% + 160 + 32 * Anima(0, Unit(0).Movement.Frame)
  77.      SpriteX2% = SpriteX2%
  78.      SpriteY2% = SpriteY2% + 160 + 32 * Anima(0, Unit(0).Movement.Frame)
  79.      Unit(0).Movement.Frame = Unit(0).Movement.Frame + 1
  80.      IF Unit(0).Movement.Frame = 8 THEN Unit(0).Movement.Frame = 0
  81.     CASE Attacking '  unit is attacking
  82.     CASE Shooting '   unit is shooting a projectile
  83.     CASE Casting '    unit is casting a spell
  84.     CASE Decomposing 'unit is dead
  85.    END SELECT
  86.   CASE Footman, Raider
  87.    SELECT CASE Unit(0).Movement.Direction
  88.     CASE North
  89.      SpriteX1% = 0
  90.      SpriteY1% = 0
  91.      SpriteX2% = 47
  92.      SpriteY2% = 47
  93.     CASE NorthEast
  94.      SpriteX1% = 48
  95.      SpriteY1% = 0
  96.      SpriteX2% = 95
  97.      SpriteY2% = 47
  98.     CASE East
  99.      SpriteX1% = 96
  100.      SpriteY1% = 0
  101.      SpriteX2% = 143
  102.      SpriteY2% = 47
  103.     CASE SouthEast
  104.      SpriteX1% = 144
  105.      SpriteY1% = 0
  106.      SpriteX2% = 191
  107.      SpriteY2% = 47
  108.     CASE South
  109.      SpriteX1% = 192
  110.      SpriteY1% = 0
  111.      SpriteX2% = 239
  112.      SpriteY2% = 47
  113.     CASE SouthWest
  114.      SpriteX1% = 191
  115.      SpriteY1% = 0
  116.      SpriteX2% = 144
  117.      SpriteY2% = 47
  118.     CASE West
  119.      SpriteX1% = 143
  120.      SpriteY1% = 0
  121.      SpriteX2% = 96
  122.      SpriteY2% = 47
  123.     CASE NorthWest
  124.      SpriteX1% = 95
  125.      SpriteY1% = 0
  126.      SpriteX2% = 48
  127.      SpriteY2% = 47
  128.    END SELECT
  130.  
  131.  if Unit(0).Movement.MapX < Mx~%% or Unit(0).Movement.MapX > Fx~%% or Unit(0).Movement.MapY < My~%% or Unit(0).Movement.MapY > Fy~%% then
  132.          'unit is not in view
  133.         else
  134.   L%% = Unit(0).Movement.IDmark
  135.  
  136.   UXpos%=Lx%+ ( (Unit(0).Movement.MapX - Mx~%%) * (16*Scale%%) )
  137.   UYpos%=Ly%+ ( (Unit(0).Movement.MapY - My~%%) * (16*Scale%%) )
  138.  
  139.   _PUTIMAGE (UXpos%, UYpos%), Layer(L%%), _DISPLAY, (SpriteX1%, SpriteY1%)-(SpriteX2%, SpriteY2%)
  141.  
  143.  

its the ELSE down by the bottom of the code, now if you notice the else seems monstrously spaced in. It is not as per the IDE or my text editor. Which actually jogs my memory and realize that is the error, for some reason every so often the IDE or my text editor will pop a tab where I space indent things and the IDE freaks out over it. and its very hard to find cause that TAB is hidden on everything on my end, but for some reason it showed up when I pasted it here. and the comment just above also appears to have a hidden TAB in it as well.

BUT that still makes me wonder why the IDE does not like TAB before an ELSE statement?
Title: Re: Invalid Syntax for ELSE error
Post by: SMcNeill on August 30, 2018, 03:51:05 pm
It's also NOT been syntax checked, as we can tell from previous lines:

Code: QB64: [Select]
  1. if Unit(0).Movement.MapX < Mx~%% or


If the syntax checker had done its thing, these lines would be capitalized, which makes it seem to me as if there's a syntax error, or some such, which should be noticeable in your program before it gets to this point.


For instance, if I define the types so that the syntax checker will complete its run and not error out for me, the code snippet I end up with is this one, instead of your original layout:


Code: QB64: [Select]
  1.  TYPE innerjunk
  2.     IDmark AS INTEGER
  3.     direction AS INTEGER
  4.     frame AS INTEGER
  5.     mapx AS INTEGER
  6.     mapy AS INTEGER
  8.  
  9. TYPE junk
  10.     movement AS innerjunk
  11.     act AS INTEGER
  13.  
  14.  
  15. DIM SHARED unit(10) AS junk
  16.  
  17. SUB DrawSprite (Lx%, Ly%, Mx~%%, MY~%%, Scale%%)
  18.     'get the end map displayed based on scale
  19.     Fx~%% = Mx~%% + (29 \ Scale%%)
  20.     Fy~%% = MY~%% + (21 \ Scale%%)
  21.  
  22.     SELECT CASE unit(0).movement.IDmark 'Unit(0) sprite layout
  23.         CASE Peasant, Peon, Grunt, Archer, Spearman, Knight, Cleric, Necrolyte, Conjurer, Warlock
  24.             SELECT CASE unit(0).movement.direction 'get base sprite offsets
  25.                 CASE North
  26.                     SpriteX1% = 0
  27.                     SpriteY1% = 0
  28.                     SpriteX2% = 31
  29.                     SpriteY2% = 31
  30.                 CASE NorthEast
  31.                     SpriteX1% = 32
  32.                     SpriteY1% = 0
  33.                     SpriteX2% = 63
  34.                     SpriteY2% = 31
  35.                 CASE East
  36.                     SpriteX1% = 64
  37.                     SpriteY1% = 0
  38.                     SpriteX2% = 95
  39.                     SpriteY2% = 31
  40.                 CASE SouthEast
  41.                     SpriteX1% = 96
  42.                     SpriteY1% = 0
  43.                     SpriteX2% = 127
  44.                     SpriteY2% = 31
  45.                 CASE South
  46.                     SpriteX1% = 128
  47.                     SpriteY1% = 0
  48.                     SpriteX2% = 159
  49.                     SpriteY2% = 31
  50.                 CASE SouthWest
  51.                     SpriteX1% = 127
  52.                     SpriteY1% = 0
  53.                     SpriteX2% = 96
  54.                     SpriteY2% = 31
  55.                 CASE West
  56.                     SpriteX1% = 95
  57.                     SpriteY1% = 0
  58.                     SpriteX2% = 64
  59.                     SpriteY2% = 31
  60.                 CASE NorthWest
  61.                     SpriteX1% = 63
  62.                     SpriteY1% = 0
  63.                     SpriteX2% = 32
  64.                     SpriteY2% = 31
  65.             END SELECT
  66.             SELECT CASE unit(0).act 'adjust based on unit action
  67.                 CASE Still '      unit is not performing an action
  68.                 CASE Moving '     unit is walking
  69.                     SpriteX1% = SpriteX1%
  70.                     SpriteY1% = SpriteY1% + 32 * Anima(0, unit(0).movement.frame)
  71.                     SpriteX2% = SpriteX2%
  72.                     SpriteY2% = SpriteY2% + 32 * Anima(0, unit(0).movement.frame)
  73.                     unit(0).movement.frame = unit(0).movement.frame + 1
  74.                     IF unit(0).movement.frame = 8 THEN unit(0).movement.frame = 0
  75.                 CASE Mining '     unit is in mine and hidden  Peasant+Peon only
  76.                 CASE LumberJack ' unit is chopping wood   Peasant+Peon only
  77.                     SpriteX1% = SpriteX1% + 160
  78.                     SpriteY1% = SpriteY1% + 32 * Anima(unit(0).movement.IDmark, unit(0).movement.frame)
  79.                     SpriteX2% = SpriteX2% + 160
  80.                     SpriteY2% = SpriteY2% + 32 * Anima(unit(0).movement.IDmark, unit(0).movement.frame)
  81.                     unit(0).movement.frame = unit(0).movement.frame + 1
  82.                     IF unit(0).movement.frame = 8 THEN unit(0).movement.frame = 0
  83.                 CASE CarryGold '  unit is carrying bag of gold  Peasant+Peon only
  84.                     SpriteX1% = SpriteX1%
  85.                     SpriteY1% = SpriteY1% + 320 + 32 * Anima(0, unit(0).movement.frame)
  86.                     SpriteX2% = SpriteX2%
  87.                     SpriteY2% = SpriteY2% + 320 + 32 * Anima(0, unit(0).movement.frame)
  88.                     unit(0).movement.frame = unit(0).movement.frame + 1
  89.                     IF unit(0).movement.frame = 8 THEN unit(0).movement.frame = 0
  90.                 CASE CarryWood '  unit is carrying a stack of wood  Peasant+Peon only
  91.                     SpriteX1% = SpriteX1%
  92.                     SpriteY1% = SpriteY1% + 160 + 32 * Anima(0, unit(0).movement.frame)
  93.                     SpriteX2% = SpriteX2%
  94.                     SpriteY2% = SpriteY2% + 160 + 32 * Anima(0, unit(0).movement.frame)
  95.                     unit(0).movement.frame = unit(0).movement.frame + 1
  96.                     IF unit(0).movement.frame = 8 THEN unit(0).movement.frame = 0
  97.                 CASE Attacking '  unit is attacking
  98.                 CASE Shooting '   unit is shooting a projectile
  99.                 CASE Casting '    unit is casting a spell
  100.                 CASE Decomposing 'unit is dead
  101.             END SELECT
  102.         CASE Footman, Raider
  103.             SELECT CASE unit(0).movement.direction
  104.                 CASE North
  105.                     SpriteX1% = 0
  106.                     SpriteY1% = 0
  107.                     SpriteX2% = 47
  108.                     SpriteY2% = 47
  109.                 CASE NorthEast
  110.                     SpriteX1% = 48
  111.                     SpriteY1% = 0
  112.                     SpriteX2% = 95
  113.                     SpriteY2% = 47
  114.                 CASE East
  115.                     SpriteX1% = 96
  116.                     SpriteY1% = 0
  117.                     SpriteX2% = 143
  118.                     SpriteY2% = 47
  119.                 CASE SouthEast
  120.                     SpriteX1% = 144
  121.                     SpriteY1% = 0
  122.                     SpriteX2% = 191
  123.                     SpriteY2% = 47
  124.                 CASE South
  125.                     SpriteX1% = 192
  126.                     SpriteY1% = 0
  127.                     SpriteX2% = 239
  128.                     SpriteY2% = 47
  129.                 CASE SouthWest
  130.                     SpriteX1% = 191
  131.                     SpriteY1% = 0
  132.                     SpriteX2% = 144
  133.                     SpriteY2% = 47
  134.                 CASE West
  135.                     SpriteX1% = 143
  136.                     SpriteY1% = 0
  137.                     SpriteX2% = 96
  138.                     SpriteY2% = 47
  139.                 CASE NorthWest
  140.                     SpriteX1% = 95
  141.                     SpriteY1% = 0
  142.                     SpriteX2% = 48
  143.                     SpriteY2% = 47
  144.             END SELECT
  145.     END SELECT
  146.  
  147.     IF unit(0).movement.mapx < Mx~%% OR unit(0).movement.mapx > Fx~%% OR unit(0).movement.mapy < MY~%% OR unit(0).movement.mapy > Fy~%% THEN
  148.         'unit is not in view
  149.     ELSE
  150.         L%% = unit(0).movement.IDmark
  151.  
  152.         UXpos% = Lx% + ((unit(0).movement.mapx - Mx~%%) * (16 * Scale%%))
  153.         UYpos% = Ly% + ((unit(0).movement.mapy - MY~%%) * (16 * Scale%%))
  154.  
  155.         _PUTIMAGE (UXpos%, UYpos%), Layer(L%%), _DISPLAY, (SpriteX1%, SpriteY1%)-(SpriteX2%, SpriteY2%)
  156.     END IF
  157.  
  159.  


Title: Re: Invalid Syntax for ELSE error
Post by: FellippeHeitor on August 30, 2018, 04:26:03 pm
I don't get it. Both if I load a file with hard TAB characters or if I paste a snippet with hard TAB characters these will be converted by the IDE into spaces. What is your method here?

This attachment contains indentation made with TAB in Windows' Notepad:   [ This attachment cannot be displayed inline in 'Print Page' view ]  

Does it not load properly in your IDE? What other steps must be taken to reproduce the issue?
Title: Re: Invalid Syntax for ELSE error
Post by: FellippeHeitor on August 30, 2018, 04:32:20 pm
PS: Command-line compiling it with qb64 -c tabElse.txt also works here, so the compiler is fine with it too.

PS2: What version of QB64?
Title: Re: Invalid Syntax for ELSE error
Post by: Cobalt on August 30, 2018, 09:03:45 pm
okay,
Quote from: SMcNeill on August 30, 2018, 03:51:05 pm
It's also NOT been syntax checked, as we can tell from previous lines:

Code: QB64: [Select]
  1. if Unit(0).Movement.MapX < Mx~%% or

If the syntax checker had done its thing, these lines would be capitalized, which makes it seem to me as if there's a syntax error, or some such, which should be noticeable in your program before it gets to this point.

That is because this section of code was added after I turned this sub into an include file, that IF-THEN section was typed in my Hex editor. Once I get a SUB or FUNCTION working I pull it from the main code and turn it into an include, freeing up the IDE space. from time to time I change something in the main code that requires some changes to the included subs and for that I use the Hex editor. this time the issue was caused by that editor. but that is why the If then section wasn't syntax checked while the rest is.

Felli, I am including the code necessary to make the error show up, I started this project with Build 20171116/82 and will probably finish it with that version, then the move to a more recent release for the next project. though I am pretty sure this happened on an even earlier version too but cant remember just when it happened last time.(I'll test it with the current DB just to be thorough but I doubt this issue has been addressed as I doubt it comes up that often. will add response once done.)
I also included a snap shot of what my editor shows me when I copied the original posted code and pasted it back into my editor, and thats why this is so hard for me to catch right off cause it shows everything spaced just how I wanted it and I never use the tab key.

Hey if you want to check out some of the test animation change 'DrawSpriteerror.bi' to 'DrawSprite.bi' and watch the peasant follow his path around the trees! its still pretty rough but the pathfinding and animation are working together!
Title: Re: Invalid Syntax for ELSE error
Post by: FellippeHeitor on August 30, 2018, 09:13:22 pm
WarCraft64.bas compiled just fine from the command line; It was loading it inside the IDE that showed the error you report, which indicates it's when parsing an INCLUDE that TABs get in the way. That makes it clearer now, thanks.

Workarounds for your workflow to be able to move forward:
1- When the faulty included file is indicated by the IDE, double-clicking it launches a second instance of QB64 with the faulty file loaded and the faulty line highlighted. Ctrl+S or File->Save and the issue is gone.

2- none of this would have showed up if you were compiling via command line; since you use an external edit tool, you can probably set it up to trigger qb64 -x yourprogram.bas without having to leave it; that can be useful especially since the compiler doesn't have an issue with TAB before else any longer; that's just the IDE that'll need fixing.
Title: Re: Invalid Syntax for ELSE error
Post by: Cobalt on August 30, 2018, 09:38:57 pm
Quote from: FellippeHeitor on August 30, 2018, 09:13:22 pm
WarCraft64.bas compiled just fine from the command line; It was loading it inside the IDE that showed the error you report, which indicates it's when parsing an INCLUDE that TABs get in the way. That makes it clearer now, thanks.

Workarounds for your workflow to be able to move forward:
1- When the faulty included file is indicated by the IDE, double-clicking it launches a second instance of QB64 with the faulty file loaded and the faulty line highlighted. Ctrl+S or File->Save and the issue is gone.

2- none of this would have showed up if you were compiling via command line; since you use an external edit tool, you can probably set it up to trigger qb64 -x yourprogram.bas without having to leave it; that can be useful especially since the compiler doesn't have an issue with TAB before else any longer; that's just the IDE that'll need fixing.

1- yeah fix is easy, but still doesn't show up in the IDE window that opened for me and  my machine doesn't like it slows down a bit, usually cant have two IDEs open with anything else going, shes just old and gettin clunky., but not an issue to fix, simple backspace and new space the the tab is gone.

2- Yeah, no my editor is 25 years old. doesn't have anything like that but it does allow me to have multiple files open at the same time and display in both text and HEX so I still use it(not to mention it was paid for back then). and I'm still developing the main body of code within the IDE the only things I mess with in the editor is the subs I've turned into includes, and as for double clicking within the ide see number 1.

any idea as to why the IDE would throw a fit about it though?
Title: Re: Invalid Syntax for ELSE error
Post by: FellippeHeitor on August 30, 2018, 10:07:05 pm
Quote from: Cobalt on August 30, 2018, 09:38:57 pm
any idea as to why the IDE would throw a fit about it though?

It'd have to manually account for that corner case and ignore it. I made the compiler ignore it a while back, but that hadn't popped like this in the IDE for me before. A future release may bring it fixed, hopefully.
Text Only | Text with Attachments