QB64.org Forum

Active Forums => QB64 Discussion => Topic started by: QB64Curious on January 30, 2022, 07:12:05 pm

Title: Illegal string-number conversion on line 37
Post by: QB64Curious on January 30, 2022, 07:12:05 pm

Hi,

I'm in the process of converting a sort of grid text-mode menu system, to one with a single row that will scroll & display more items than the width of the screen will fit.

The menu array is working fine.  This is MenuItem().

But the array for the messages associated with each menu item, is a problem.  This array is called MenuMessage(), and is defined the same way as MenuItem().

I'm running this in the QB64 ide right now, but will also test it in the 4.5 ide later.

The error is

     Illegal string-number conversion on line 37

The line 37 in question is

Code: QB64: [Select]

1. MenuMessage(1) = "Message for Choice 1"

Is it possible that I'm running up against the limit of the name of an array?  'MenuMessage' is 11 characters.

The full code is here

Code: QB64: [Select]

1. 'horzmenu.bas, originally menucol.bas by Ray Thomas      January 2002
2.  
3. Option Base 1
4. Screen 0
5. Const BLUE = 1
6. Const WHITE = 7
7. Const MENUROW = 1
8. Const MAXIMUMITEMLENGTH = 10
9.  
10. Dim MenuItem(12) As String * 25 'Define the menu item array
11. Dim MenuMessages(12) As String * 50 'Define the menu message array
12. Dim ChooseItem As Integer 'Currently chosen menu item
13. Dim XMenuPosn As Integer 'Controls the menu item X positions
14. Dim YMenuPosn As Integer 'Controls the menu item Y positions
15. Dim CurrentYMenuPosition As Integer
16. Dim CurrentXMenuPosition As Integer
17.  
18. Dim Count As Integer 'Array counter
19. Dim NumberOfColumns As Integer 'Number of menu items per line
20. Dim Temp As String 'Used to centre text in the space
21. Dim FullItemNameRow As Integer 'Row where the full name of the item is displayed
22. Dim MessageRow 'Row where a message corresponding to the Menu Item is displayed
23.  
24. MenuItem(1) = "Choice 1"
25. MenuItem(2) = "Choice 2"
26. MenuItem(3) = "Choice 3"
27. MenuItem(4) = "Choice 4"
28. MenuItem(5) = "Longer Choice 5"
29. MenuItem(6) = "Choice 6"
30. MenuItem(7) = "Choice 7"
31. MenuItem(8) = "Choice 8"
32. MenuItem(9) = "Choice 9"
33. MenuItem(10) = "Another Longer Choice 10"
34. MenuItem(11) = "Choice 11"
35. MenuItem(12) = "Choice 12"
36.  
37. MenuMessage(1) = "Message for Choice 1"
38. MenuMessage(2) = "Message for Choice 2"
39. MenuMessage(3) = "Message for Choice 3"
40. MenuMessage(4) = "Message for Choice 4"
41. MenuMessage(5) = "Message for Longer Choice 5"
42. MenuMessage(6) = "Message for Choice 6"
43. MenuMessage(7) = "Message for Choice 7"
44. MenuMessage(8) = "Message for Choice 8"
45. MenuMessage(9) = "Message for Choice 9"
46. MenuMessage(10) = "Message for Another Longer Choice 10"
47. MenuMessage(11) = "Message for Choice 11"
48. MenuMessage(12) = "Message for Choice 12"
49.  
50. ChooseItem = 1 'Starting point of highlighted menu item
51. XMenuPosn = 1 'X starting point of menu
52. YMenuPosn = 1 'Y starting point of menu
53. NumberOfColumns = 12 'Number of columns in the menu
54. FullItemNameRow = 4
55. MessageRow = 5
56.  
57.  
58. Cls
59.  
60. Color WHITE, BLUE
61. GoSub DrawMenu
62.  
63. '*** get cursor key movements and redraw menu ***
64. Do
65.     Cmmnd$ = InKey$
66.  
67.     'Check for Esc key
68.     If Cmmnd$ = Chr$(27) Then
69.         End
70.     End If
71.     If Len(Cmmnd$) = 2 Then Cmmnd$ = Right$(Cmmnd$, 1)
72.  
73.     If Cmmnd$ = "8" Or Cmmnd$ = Chr$(72) Then GoSub MoveUp
74.     If Cmmnd$ = "2" Or Cmmnd$ = Chr$(80) Then GoSub MoveDown
75.     If Cmmnd$ = "4" Or Cmmnd$ = Chr$(75) Then GoSub Moveleft
76.     If Cmmnd$ = "6" Or Cmmnd$ = Chr$(77) Then GoSub MoveRight
77.     If Cmmnd$ = "9" Or Cmmnd$ = Chr$(73) Then GoSub TopCol
78.     If Cmmnd$ = "3" Or Cmmnd$ = Chr$(81) Then GoSub BottomCol
79.     If Cmmnd$ = "7" Or Cmmnd$ = Chr$(71) Then ChooseItem = 1
80.     If Cmmnd$ = "1" Or Cmmnd$ = Chr$(79) Then ChooseItem = UBound(MenuItem$)
81.  
82.  
83.     GoSub DrawMenu
84.  
85. Loop Until Cmmnd$ = Chr$(13)
86.  
87. Print
88. Color 7, 1
89. Print "Item chosen = "; RTrim$(MenuItem(ChooseItem))
90.  
91. End:
92.  
93. DrawMenu:
94. 'Draw the menu
95. Locate YMenuPosn, XMenuPosn
96. For Count = 1 To UBound(MenuItem$)
97.     If Count = ChooseItem Then Color BLUE, WHITE Else Color WHITE, BLUE
98.     Print RTrim$(Mid$(MenuItem$(Count), 1, MAXIMUMITEMLENGTH)) + " ";
99.  
100.  
101.  
102.  
103.  
104.     If Count = ChooseItem Then
105.         CurrentYMenuPosition = CsrLin
106.         CurrentXMenuPosition = Pos(0)
107.  
108.         Locate MessageRow, 1
109.         Print Space$(50)
110.         Locate MessageRow, 1
111.         Print RTrim$(MenuMessages(Count));
112.         Locate FullItemNameRow, 1
113.         Print Space$(25)
114.         Locate FullItemNameRow, 1
115.         Print RTrim$(MenuItem$(Count))
116.         Locate CurrentYMenuPosition, CurrentXMenuPosition
117.     End If
118.  
119.     '/*
120.     ' Locate FullItemNameRow, 1
121.     ' Print Space$(50)
122.     ' Locate FullItemNameRow, 1
123.     ' Print MenuItem$(Count)
124.     ' Locate CurrentYMenuPosition, CurrentXMenuPosition
125.     '*/
126.  
127.     If Count Mod NumberOfColumns = 0 Then
128.         Print
129.         Locate CsrLin, XMenuPosn
130.     End If
131. Next Count
132.  
133. Return
134.  
135.  
136.  
137. MoveUp:
138. If ChooseItem <= NumberOfColumns Then
139.     ChooseItem = UBound(MenuItem$) - (MenuItem Mod NumberOfColumns)
140. Else
141.     ChooseItem = ChooseItem - NumberOfColumns
142. End If
143. Return
144.  
145. MoveDown:
146. If ChooseItem > UBound(MenuItem$) - MenuLine Then
147.     ChooseItem = ChooseItem Mod MenuLine
148. Else
149.     ChooseItem = ChooseItem + MenuLine
150. End If
151. If ChooseItem = 0 Then ChooseItem = MenuLine
152. Return
153.  
154. Moveleft:
155. ChooseItem = ChooseItem - 1
156. If ChooseItem = 0 Then ChooseItem = UBound(MenuItem$)
157. Return
158.  
159. MoveRight:
160. ChooseItem = ChooseItem + 1
161. If ChooseItem = UBound(MenuItem$) + 1 Then ChooseItem = 1
162. Return
163.  
164. TopCol:
165. ChooseItem = ChooseItem Mod MenuLine
166. If ChooseItem = 0 Then ChooseItem = MenuLine
167. Return
168.  
169. BottomCol:
170. ChooseItem = UBound(MenuItem$) - (MenuLine - (ChooseItem Mod MenuLine))
171. If MenuLine - (ChooseItem Mod MenuLine) = MenuLine Then ChooseItem = UBound(MenuItem$)
172. Return
173.  

Title: Re: Illegal string-number conversion on line 37
Post by: SMcNeill on January 30, 2022, 07:25:00 pm

Variable name mismatch.

DIM MenuMessages...

MenuMessage(... = ....

Notice the missing S at the end of your variable name?

Title: Re: Illegal string-number conversion on line 37
Post by: QB64Curious on January 30, 2022, 07:34:02 pm

Yep I see it, thanks McNeil.

Quote from: SMcNeill on January 30, 2022, 07:25:00 pm

Variable name mismatch.

DIM MenuMessages...

MenuMessage(... = ....

Notice the missing S at the end of your variable name?

Title: Re: Illegal string-number conversion on line 37
Post by: bplus on January 30, 2022, 07:34:29 pm

Looks like a job for Option _Explicit, that way if you have a typo it will show up as not dimensioned yet.

Title: Re: Illegal string-number conversion on line 37
Post by: QB64Curious on January 31, 2022, 02:59:30 am

Yes, absolutely.  I use it in VBScript all the time.  It didn't occur to me that QB had it as well.

Text Only | Text with Attachments