Text Only | Text with Attachments

QB64.org Forum

Active Forums => QB64 Discussion => Topic started by: johannhowitzer on October 20, 2021, 12:41:11 am

Title: Mouse input lag
Post by: johannhowitzer on October 20, 2021, 12:41:11 am
Is there a way in a _limit 60 loop to have the mouse input data keep current?

Code: QB64: [Select]
  3. color 0, 15
  4.  
  5. const true = -1
  6. const false = 0
  7.  
  8. dim shared dev_keyboard as byte ' Store device index, to be re-checked whenever inputs are involved
  9. dim shared dev_gamepad  as byte
  10. dim shared dev_mouse    as byte
  11. const keyboard = 1
  12. const gamepad  = 2
  13. const mouse    = 3
  14.  
  15. dim shared mouse_press(3)     as byte
  16. dim shared mouse_hold(3)      as byte
  17. dim shared mouse_press_x(3)   as integer ' Records where mouse button press started
  18. dim shared mouse_press_y(3)   as integer
  19. dim shared mouse_release_x(3) as integer ' Records where mouse button was released
  20. dim shared mouse_release_y(3) as integer
  21.  
  22. call update_inputs
  23.  
  25.    limit 60
  26.    cls , 15
  27.  
  28.    r = 15
  29.    for b = 1 to 3
  30.       locate b: print mouse_press_x(b); mouse_press_y(b), , mouse_release_x(b); mouse_release_y(b)
  31.       print mousex, mousey
  32.       h = (b * 2) + 7
  33.  
  34.       x1 = mouse_press_x(b)
  35.       y1 = mouse_press_y(b)
  36.  
  37.       x2 = mouse_release_x(b)
  38.       y2 = mouse_release_y(b)
  39.  
  40.       circle(x1, y1), r, h
  41.       if mouse_press(b) = false and mouse_hold(b) = true then paint(x1, y1), 0, h
  42.  
  43.       circle(x2, y2), r, h + 1
  44.       if mouse_press(b) = false and mouse_hold(b) = true then paint(x2, y2), 0, h + 1
  45.    next b
  46.    display
  47.  
  48.    call update_inputs
  50.  
  51.  
  52. sub detect_devices
  53.  
  54. dev_keyboard = false
  55. dev_gamepad  = false
  56. dev_mouse    = false
  57.  
  58. d = devices
  59. for n = d to 1 step -1
  60.    if left$(device$(n), 10) = "[KEYBOARD]"   then dev_keyboard = n
  61.    if left$(device$(n), 12) = "[CONTROLLER]" then dev_gamepad  = n
  62.    if left$(device$(n),  7) = "[MOUSE]"      then dev_mouse    = n
  64.  
  66.  
  67.  
  68. sub update_inputs
  69.  
  70. call detect_devices
  71.  
  72. if dev_mouse <> false then
  73.    z = mouseinput
  74. '   z = deviceinput(dev_mouse)
  75.  
  76.    for b = 1 to 3
  77.       if b > lastbutton(dev_mouse) then exit for
  78.  
  79.       mouse_hold(b)  = mouse_press(b)
  80.       mouse_press(b) = mousebutton(b)
  81.  
  82.       ' Wait for mouse position read to catch up
  83.       x1 = mousex
  84.       y1 = mousey
  85.       do
  86. '         z = mouseinput
  87.          x2 = x1
  88.          y2 = y1
  89.          x1 = mousex
  90.          y1 = mousey
  91.       loop until x1 = x2 and y1 = y2
  92.  
  93.       if     mouse_press(b) = true and mouse_hold(b) = false then
  94.          mouse_press_x(b) = mousex
  95.          mouse_press_y(b) = mousey
  96.       elseif mouse_press(b) = false and mouse_hold(b) = true then
  97.          mouse_release_x(b) = mousex
  98.          mouse_release_y(b) = mousey
  99.       end if
  100.    next b
  102.  
  104.  

Running this, as you move the mouse around, you can see the numbers on row 4 lag way behind what the mouse is actually doing.  If I increase the limit to 30000, it stays current as far as user perception, but it will still be way behind for the same number of loops, it's just running too fast to see this.  It seems like data from mousex and mousey is just lagging behind for some reason, not actually returning the mouse's current position, but rather pulling the oldest value from a stack of position values.

In update_inputs, you can see I tried to counter this by waiting until the position information from subsequent calls was the same.  This does nothing without the z = mouseinput, if you uncomment that line, you can see it improves the speed dramatically, it still lags behind a bit, but catches up much faster.

Do you know of a way to make mousex and mousey be current on every frame, in a limit 60 loop?
Title: Re: Mouse input lag
Post by: luke on October 20, 2021, 01:01:42 am
I have a long-winded discussion of things at https://www.qb64.org/forum/index.php?topic=2377.0 but I think you might be okay with the naive solution:
Code: [Select]
Sub update_inputs

    Call detect_devices

    If dev_mouse <> false Then
        ' Wait for mouse position read to catch up
        Do: Loop While MouseInput

        For b = 1 To 3
            If b > LastButton(dev_mouse) Then Exit For

            mouse_hold(b) = mouse_press(b)
            mouse_press(b) = MouseButton(b)

            If mouse_press(b) = true And mouse_hold(b) = false Then
                mouse_press_x(b) = MouseX
                mouse_press_y(b) = MouseY
            ElseIf mouse_press(b) = false And mouse_hold(b) = true Then
                mouse_release_x(b) = MouseX
                mouse_release_y(b) = MouseY
            End If
        Next b
    End If

End Sub
If you do have issues with missed clicks you'll likely need the "more advanced method" linked above.
Title: Re: Mouse input lag
Post by: Pete on October 20, 2021, 03:28:17 am
Similar to luke's solution...

Code: QB64: [Select]
  3. COLOR 0, 15
  4.  
  5. CONST true = -1
  6. CONST false = 0
  7.  
  8. DIM SHARED dev_keyboard AS BYTE ' Store device index, to be re-checked whenever inputs are involved
  9. DIM SHARED dev_gamepad AS BYTE
  10. DIM SHARED dev_mouse AS BYTE
  11. CONST keyboard = 1
  12. CONST gamepad = 2
  13. CONST mouse = 3
  14.  
  15. DIM SHARED mouse_press(3) AS BYTE
  16. DIM SHARED mouse_hold(3) AS BYTE
  17. DIM SHARED mouse_press_x(3) AS INTEGER ' Records where mouse button press started
  18. DIM SHARED mouse_press_y(3) AS INTEGER
  19. DIM SHARED mouse_release_x(3) AS INTEGER ' Records where mouse button was released
  20. DIM SHARED mouse_release_y(3) AS INTEGER
  21.  
  22. CALL update_inputs
  23.  
  25.     LIMIT 60
  26.     CLS , 15
  27.  
  28.     r = 15
  29.     FOR b = 1 TO 3
  30.         LOCATE b: PRINT mouse_press_x(b); mouse_press_y(b), , mouse_release_x(b); mouse_release_y(b)
  31.         PRINT MOUSEX, MOUSEY
  32.         h = (b * 2) + 7
  33.  
  34.         x1 = mouse_press_x(b)
  35.         y1 = mouse_press_y(b)
  36.  
  37.         x2 = mouse_release_x(b)
  38.         y2 = mouse_release_y(b)
  39.  
  40.         CIRCLE (x1, y1), r, h
  41.         IF mouse_press(b) = false AND mouse_hold(b) = true THEN PAINT (x1, y1), 0, h
  42.  
  43.         CIRCLE (x2, y2), r, h + 1
  44.         IF mouse_press(b) = false AND mouse_hold(b) = true THEN PAINT (x2, y2), 0, h + 1
  45.     NEXT b
  46.     DISPLAY
  47.  
  48.     CALL update_inputs
  50.  
  51.  
  52. SUB detect_devices
  53.  
  54.     dev_keyboard = false
  55.     dev_gamepad = false
  56.     dev_mouse = false
  57.  
  58.     d = DEVICES
  59.     FOR n = d TO 1 STEP -1
  60.         IF LEFT$(DEVICE$(n), 10) = "[KEYBOARD]" THEN dev_keyboard = n
  61.         IF LEFT$(DEVICE$(n), 12) = "[CONTROLLER]" THEN dev_gamepad = n
  62.         IF LEFT$(DEVICE$(n), 7) = "[MOUSE]" THEN dev_mouse = n
  63.     NEXT n
  64.  
  66.  
  67.  
  68. SUB update_inputs
  69.  
  70.     CALL detect_devices
  71.  
  72.     IF dev_mouse <> false THEN
  73.         '''z = MOUSEINPUT
  74.         '   z = deviceinput(dev_mouse)
  75.  
  76.         FOR b = 1 TO 3
  77.             IF b > LASTBUTTON(dev_mouse) THEN EXIT FOR
  78.  
  79.             mouse_hold(b) = mouse_press(b)
  80.             mouse_press(b) = MOUSEBUTTON(b)
  81.  
  82.             ' Wait for mouse position read to catch up
  83.             x1 = MOUSEX
  84.             y1 = MOUSEY
  85.             '''DO
  86.             WHILE MOUSEINPUT: WEND
  87.             '         '''z = mouseinput
  88.             x2 = x1
  89.             y2 = y1
  90.             x1 = MOUSEX
  91.             y1 = MOUSEY
  92.             ''''LOOP UNTIL x1 = x2 AND y1 = y2
  93.  
  94.             IF mouse_press(b) = true AND mouse_hold(b) = false THEN
  95.                 mouse_press_x(b) = MOUSEX
  96.                 mouse_press_y(b) = MOUSEY
  97.             ELSEIF mouse_press(b) = false AND mouse_hold(b) = true THEN
  98.                 mouse_release_x(b) = MOUSEX
  99.                 mouse_release_y(b) = MOUSEY
  100.             END IF
  101.         NEXT b
  102.     END IF
  103.  
  105.  

See the added WHILE MOUSEINPUT: WEND and the removed code with ''' remark signs.

Pete
Title: Re: Mouse input lag
Post by: johannhowitzer on October 20, 2021, 04:06:45 am
Thanks, that's exactly what I was looking for.  My solution probably didn't work perfectly because due to rounding, there would be some back to back identical coordinate pairs in the stream of mouse data.  I read the more in-depth stuff, and I'll add in the button state change catch too.

First time using mouse in anything qbasic related!  In the past I've only ever cared about keyboard and gamepad, but I'm trying to make a manual-input tracker for a game, and clicking is way more user-friendly for that.
Title: Re: Mouse input lag
Post by: Pete on October 20, 2021, 10:57:38 am
Mouse and Keyboard Library

If it helps, this is something I cooked up awhile ago and I use it with most of my programs. It does not detect gaming devices, as I don't really do game applications, but is does handle all mouse usage, including left, right, and middle button down and release status, mouse wheel up and down, left double click, left drag, etc. It also handles key press identification for INKEY$ and returns values for Alt, Ctrl, and Shift keys when held down.

I made this particular using TYPE declared variables, but as you already know, that could be changed to standard variable use. I like TYPE usage for a library use, because it is easy to pass the variables as a TYPE rather than long list of parameters or using DIM SHARED to pass them.

Code: QB64: [Select]
  1. mydemo% = -1
  2. DIM UI AS UserInput
  3.  
  4. TYPE UserInput
  5.     KeyPress AS STRING
  6.     KeyCombos AS INTEGER
  7.     MbStatus AS INTEGER
  8.     MbEnvoked AS INTEGER
  9.     drag AS INTEGER
  10.     DoubleClick AS INTEGER
  11.     MbLeftx AS INTEGER
  12.     MbLefty AS INTEGER
  13.     mx AS INTEGER
  14.     oldmx AS INTEGER
  15.     my AS INTEGER
  16.     oldmy AS INTEGER
  18.  
  19. PRINT "Press keys or use mouse for demo.";
  21.     CALL keyboard_mouse(UI, mydemo%)
  22.     IF UI.MbStatus < 0 AND UI.MbEnvoked = 0 THEN
  23.         SOUND 1000, .3: UI.MbEnvoked = -1
  24.     END IF
  25.     IF UI.KeyPress = CHR$(13) THEN BEEP: EXIT DO
  27.  
  29.     CALL keyboard_mouse(UI, mydemo%)
  30.     IF UI.MbStatus > 0 AND UI.MbEnvoked = 0 THEN
  31.         SOUND 300, .3: UI.MbEnvoked = 1
  32.     END IF
  34.  
  36.  
  37. SUB keyboard_mouse (UI AS UserInput, mydemo%)
  38.     STATIC z1, lclick
  39.  
  40.     _LIMIT 30
  41.  
  42.     DEF SEG = 0
  43.     IF PEEK(1047) MOD 16 = 1 OR PEEK(1047) MOD 16 = 2 THEN
  44.         UI.KeyCombos = 1 ' Shift  % = -1 ELSE shift% = 0
  45.     ELSEIF PEEK(1047) MOD 16 = 3 OR PEEK(1047) MOD 16 = 4 THEN
  46.         UI.KeyCombos = 2 ' Ctrl  % = -1 ELSE ctrl% = 0
  47.     ELSEIF PEEK(1047) MOD 16 = 7 OR PEEK(1047) MOD 16 = 8 THEN
  48.         UI.KeyCombos = 3 ' Alt  % = -1
  49.     ELSEIF PEEK(1047) MOD 16 = 5 OR PEEK(1047) MOD 16 = 6 THEN
  50.         UI.KeyCombos = 4 ' Ctrl+Shift  % = -1 ELSE ctrlshift% = 0
  51.     ELSE
  52.         UI.KeyCombos = 0
  53.     END IF
  54.     DEF SEG
  55.  
  56.     IF mydemo% THEN GOSUB check_UI.KeyCombos
  57.  
  58.     UI.KeyPress = INKEY$
  59.     IF LEN(UI.KeyPress) THEN ' A key was pressed.
  60.         UI.MbEnvoked = 0: UI.MbLeftx = 0
  61.         SELECT CASE LEN(UI.KeyPress)
  62.             CASE 1 ' 1-byte key A-Z, etc.
  63.                 IF mydemo% THEN mydemo% = 1: GOSUB mydemo
  64.                 SELECT CASE UI.KeyPress
  65.                     ' Place key selection routine here...
  66.                     CASE CHR$(27): SYSTEM
  67.                 END SELECT
  68.             CASE 2 '2-byte key F1-F12, etc.
  69.                 IF mydemo% THEN mydemo% = 2: GOSUB mydemo
  70.                 SELECT CASE RIGHT$(UI.KeyPress, 1)
  71.                     ' Place key selection routine here...
  72.                 END SELECT
  73.         END SELECT
  74.     ELSE ' Check for mouse input since no keyboard input was detected.
  75.  
  76.         IF lclick THEN ' Check timer for double-clicks.
  77.             IF TIMER < z1 THEN z1 = z1 - 86400 ' Midnight adjustment.
  78.             IF TIMER - z1 > .33 THEN lclick = 0 ' Too much time ellapsed for a double click.
  79.         END IF
  80.  
  81.         WHILE _MOUSEINPUT
  82.             mw = mw + _MOUSEWHEEL ' Check for mouse wheel use.
  83.         WEND
  84.  
  85.         ' Get mouse status.
  86.         UI.mx = _MOUSEX
  87.         UI.my = _MOUSEY
  88.         lb = _MOUSEBUTTON(1)
  89.         rb = _MOUSEBUTTON(2)
  90.         mb = _MOUSEBUTTON(3)
  91.  
  92.         SELECT CASE UI.MbEnvoked
  93.             CASE 0
  94.                 IF lb OR rb OR mb THEN
  95.  
  96.                 END IF
  97.             CASE 1
  98.                 IF lb OR rb OR mb THEN UI.MbEnvoked = 0
  99.             CASE -1
  100.                 IF lb = 0 AND rb = 0 AND mb = 0 THEN UI.MbEnvoked = 0
  101.         END SELECT
  102.  
  103.         ' Check for mouse movement.
  104.         IF UI.mx <> UI.oldmx OR UI.my <> UI.oldmy THEN
  105.             oldcsrlin = CSRLIN: oldpos = POS(0)
  106.             LOCATE 3, 1: PRINT "Mouse row/col ="; UI.my; UI.mx; "     ";: LOCATE oldcsrlin, oldpos
  107.         END IF
  108.  
  109.         IF UI.MbStatus < 0 THEN ' Mouse button pressed. UI.MbStatus identity is by number. -1=left, -2=right, -3=middle.
  110.             SELECT CASE UI.MbStatus
  111.                 CASE -1 ' Left button was pressed.
  112.                     IF lb = 0 THEN ' Left button released.
  113.                         SELECT CASE lclick ' Single or double click analysis.
  114.                             CASE 0
  115.                                 IF mydemo% THEN mydemo% = 3: GOSUB mydemo
  116.                                 lclick = lclick + 1
  117.                             CASE ELSE ' Double click. Completed upon 2nd left button release.
  118.                                 IF mydemo% THEN mydemo% = 11: GOSUB mydemo
  119.                                 UI.DoubleClick = -1
  120.                                 lclick = 0
  121.                         END SELECT
  122.                         UI.MbStatus = 1
  123.  
  124.                         IF UI.MbLeftx THEN
  125.                             IF UI.mx <> UI.MbLeftx OR UI.my <> UI.MbLefty THEN UI.MbStatus = 0: lclick = 0
  126.                             UI.MbLeftx = 0: UI.MbLefty = 0
  127.                         END IF
  128.  
  129.                         IF UI.drag THEN UI.drag = 0
  130.                     ELSE ' Left button is being held down. Check for UI.drag.
  131.                         IF UI.mx <> UI.oldmx OR UI.my <> UI.oldmy THEN ' Mouse cursor has moved. UI.drag.
  132.                             IF mydemo% THEN mydemo% = 12: GOSUB mydemo
  133.                             UI.drag = -1
  134.                         END IF
  135.                     END IF
  136.                 CASE -2 ' Right button was pressed.
  137.                     IF rb = 0 THEN ' Right button was relased.
  138.                         IF mydemo% THEN mydemo% = 4: GOSUB mydemo
  139.                         UI.MbStatus = 2
  140.                     END IF
  141.                 CASE -3 ' Middle button was pressed
  142.                     IF mb = 0 THEN ' Middle button was released.
  143.                         IF mydemo% THEN mydemo% = 5: GOSUB mydemo
  144.                         UI.MbStatus = 3
  145.                     END IF
  146.             END SELECT
  147.         ELSE
  148.             IF lb THEN ' Left button just pressed.
  149.                 IF mydemo% THEN mydemo% = 6: GOSUB mydemo
  150.                 UI.MbStatus = -1
  151.                 IF UI.MbLeftx = 0 THEN UI.MbLeftx = UI.mx: UI.MbLefty = UI.my
  152.                 z1 = TIMER
  153.             ELSEIF rb THEN ' Right button just pressed.
  154.                 IF mydemo% THEN mydemo% = 7: GOSUB mydemo
  155.                 IF UI.MbLeftx = 0 THEN UI.MbLeftx = UI.mx: UI.MbLefty = UI.my
  156.                 UI.MbStatus = -2
  157.             ELSEIF mb THEN ' Middle button just pressed.
  158.                 IF mydemo% THEN mydemo% = 8: GOSUB mydemo
  159.                 IF UI.MbLeftx = 0 THEN UI.MbLeftx = UI.mx: UI.MbLefty = UI.my
  160.                 UI.MbStatus = -3
  161.             ELSEIF mw THEN ' Mouse wheel just moved.
  162.                 SELECT CASE mw
  163.                     CASE IS > 0 ' Scroll down.
  164.                         IF mydemo% THEN mydemo% = 9: GOSUB mydemo
  165.                     CASE IS < 0 ' Scroll up.
  166.                         IF mydemo% THEN mydemo% = 10: GOSUB mydemo
  167.                 END SELECT
  168.             END IF
  169.         END IF
  170.  
  171.         UI.oldmx = UI.mx: UI.oldmy = UI.my: mw = 0 ' Mouse position past and present.
  172.     END IF
  173.     EXIT SUB
  174.  
  175.     mydemo:
  176.     LOCATE 1, 1: PRINT "Last User Status:                                    ";
  177.     LOCATE , 19
  178.     SELECT CASE mydemo%
  179.         CASE 1
  180.             PRINT "1-byte Key = "; UI.KeyPress
  181.         CASE 2
  182.             PRINT "2-byte Key = "; UI.KeyPress
  183.         CASE 3
  184.             PRINT "Left button released."
  185.         CASE 4
  186.             PRINT "Right button released."
  187.         CASE 5
  188.             PRINT "Middle button released."
  189.         CASE 6
  190.             PRINT "Left button down."
  191.         CASE 7
  192.             PRINT "Right button down."
  193.         CASE 8
  194.             PRINT "Middle button down."
  195.         CASE 9
  196.             PRINT "Wheel scroll down."
  197.         CASE 10
  198.             PRINT "Wheel scroll up."
  199.         CASE 11
  200.             PRINT "Left button double click."
  201.         CASE 12
  202.             PRINT "Drag..."
  203.     END SELECT
  204.     mydemo% = -1
  205.     RETURN
  206.  
  207.     check_UI.KeyCombos:
  208.     IF UI.KeyCombos THEN
  209.         LOCATE 1, 50
  210.         SELECT CASE UI.KeyCombos
  211.             CASE 1
  212.                 PRINT "Shift key down.        ";
  213.             CASE 2
  214.                 PRINT "Ctrl key down.         ";
  215.             CASE 3
  216.                 PRINT "Alt key down.          ";
  217.             CASE 4
  218.                 PRINT "Ctrl + Shift key down. ";
  219.         END SELECT
  220.     ELSE
  221.         LOCATE 1, 50: PRINT SPACE$(29);
  222.     END IF
  223.     RETURN
  225.  
Title: Re: Mouse input lag
Post by: Dimster on October 20, 2021, 03:35:44 pm
@Pete - Back in Jan of 2020, you had a routine which had the mouse highlighting menu items which were the various States. In that routine you use a _limit 60 but I don't think you used a While MouseInput:Wend line in your code and yet there was no lag that I could see in the selection of any of the items on the menu. I would be interested in knowing what the difference (in terms of Lag/No Lag) between your coding results and what Johannhowitzer is experiencing. I have looked at both codes (myopic as I am) and can't see where the While MouseInput:wend would be inserted tp correct the lag or how your code didn't need that line of code?
Title: Re: Mouse input lag
Post by: Pete on October 20, 2021, 04:06:30 pm
@Dimster Actually, that one from Jan 2020 did have the WHILE _MOUSEINPUT: WEND in the code.

https://www.tapatalk.com/groups/qbasic/a-library-to-make-mouse-selections-from-row-and-co-t39567.html#p213107

What appeared to be slowing up johann's routine was a DO/LOOP

Code: QB64: [Select]
  2. ' Wait for mouse position read to catch up
  3.       x1 = mousex
  4.       y1 = mousey
  6.          x2 = x1
  7.          y2 = y1
  8.          x1 = mousex
  9.          y1 = mousey
  10. loop until x1 = x2 and y1 = y2
  11.  

Now if you could move at lightning speed, like Steve does when dinner is ready, x1 might be at 5 and y1 at 20. All of a sudden, you move the mouse as you enter the loop, so X1 is now 6 and y1 is 21, but x2 will always be 5 in the loop and y2 will always be 5. So you won't be exiting that loop until you mouse around back to 5, 20 again!

Always remember when it comes to mousing around...

WHILE: WEND is your best friend.

Pete
Title: Re: Mouse input lag
Post by: Dimster on October 20, 2021, 05:06:40 pm
Thanks Pete
Title: Re: Mouse input lag
Post by: SMcNeill on October 20, 2021, 06:27:56 pm
IF you guys want to see why mouseinput lags up, here's a quick example for you explaining the situation:

Code: QB64: [Select]
  1. $Let ONLYCHANGES = TRUE
  2.  
  3. f = _LoadFont("courbd.ttf", 36, "monospace")
  7. MX = _MouseX: MY = _MouseY
  8. Dim mx(1000), my(1000)
  11.         $If ONLYCHANGES = TRUE Then
  12.             If MX <> _MouseX Or MY <> _MouseY Then
  13.                 count = count + 1
  14.                 mx(count) = _MouseX: my(count) = _MouseY
  15.                 MX = _MouseX: MY = _MouseY
  16.                 runtimer = -1
  17.             End If
  18.         $Else
  19.             If MX <> _MouseX Or MY <> _MouseY Then runtimer = -1
  20.             If runtimer Then
  21.             count = count + 1
  22.             mx(count) = _MouseX: my(count) = _MouseY
  23.             End If
  24.         $End If
  25.     Wend
  26.     If runtimer = -1 And StartTimer = 0 Then StartTimer = Timer + 1
  27.     If Timer > StartTimer And StartTimer <> 0 Then Exit Do
  29.  
  30. Print count; "mouse events in one second."
  31.  
  32.  

Run the program, drag the mouse around...  See how many mouse x/y change events you generate in a single second.  On my laptop, with the trackpad, I get close to 100 updates per second.

Now, change the $LET to false.  You are now tracking ALL mouse reports in a single second and not just the change events that I marked before.  With my laptop, with the trackpad, I'm getting close to 600 updates per second.

Now, toss that in a program that runs with a _LIMIT of 60 times per second, and it's going to take you one and  a half seconds to just read and react to the change states, and about 10 seconds if you try to process each and every mouse update in that second!

There's no two ways about it, in a situation like that, you end up generating lag with each user input!  It takes 1.5 seconds to process 1 second of mouse activity (at _LIMIT 60... _LIMIT 30, would of course, take twice as long, whereas a _LIMIT 120 may not have noticeable lag at all, as long as the program and PC allows you to run at such a high number of loops per second.)

The way we fix this issue is to simply clear the buffer and only deal with the state when we need it.

DO
    WHILE _MOUSEINPUT:WEND
    x = _mousex: y = _mousey
    LOCATE 1,1: PRINT x, y
    _LIMIT 30
LOOP UNTIL _MOUSEBUTTON(1)

With the above, we clear the mouse buffer with the while-wend statements, and only deal with the mouse state 30 times a second, when our loop processes.  Why would we give a crap where our mouse was located at in the microseconds before we read it??

At 0.000 microseconds the mouse was at 100,100
At 0.010 microseconds the mouse was at 101,100
At 0.020 microseconds the mouse was at 101,101
At 0.030 microseconds the mouse was at 102,101
At 0.040 microseconds the mouse was at 102,102  >-- We read it here.
At 0.050 microseconds the mouse was at 103,102
At 0.060 microseconds the mouse was at 103,103 >-- We read it here.

Every 0.033 seconds we make a loop (30 times a second).  Why do we care where the mouse was at 0.01 seconds?  At 0.02 seconds?  We can toss those X/Y coordinates out as we can't process them without generating a backlog of activity.  Our program is running a loop ever 0.033 seconds, so we only need to know the X/Y coordinates during the refresh of each run cycle.

While-wend the buffer away to only deal with updates when your main loop cycles back around. 

The ONLY thing that you should ever have inside those while-wend loops is a mousewheel checker, if you're using it in your program.  Everything else is just doing it wrong.

WHILE _MOUSEINPUT
    MouseScroll = MouseScroll + _MouseWheel
WEND

Title: Re: Mouse input lag
Post by: Dimster on October 21, 2021, 08:20:36 am
And the light bulb goes off...thanks Steve.
Title: Re: Mouse input lag
Post by: Cobalt on October 21, 2021, 11:05:14 am
A simple:

 DO: nul%% = _MOUSEINPUT: LOOP WHILE nul%%

at the end of my main loop tends to do it for me.
Title: Re: Mouse input lag
Post by: bplus on October 21, 2021, 12:07:56 pm
Quote from: Dimster on October 21, 2021, 08:20:36 am
And the light bulb goes off...thanks Steve.

Doesn't he mean On? But he does call himself the Dimster ;-))
Title: Re: Mouse input lag
Post by: bplus on October 21, 2021, 12:12:16 pm
Quote from: Cobalt on October 21, 2021, 11:05:14 am
A simple:

 DO: nul%% = _MOUSEINPUT: LOOP WHILE nul%%

at the end of my main loop tends to do it for me.

This is the same thing with less fuss:

While _MouseInput: Wend

But then again, Cobalt is still shouting keywords at himself. (And I am still underlining.)  ;-))
Title: Re: Mouse input lag
Post by: Pete on October 21, 2021, 12:40:03 pm
It could have been worse...

DO: INT(nul%%) = _MOUSEINPUT: LOOP UNTIL INT(nul%%) > -1 and INT(nul%%) <  1

But it takes FreeBASIC for that!

Pete
Title: Re: Mouse input lag
Post by: Cobalt on October 21, 2021, 01:46:34 pm
Quote from: bplus on October 21, 2021, 12:12:16 pm
But then again, Cobalt is still shouting keywords at himself. (And I am still underlining.)  ;-))

Can I help it that I speak with authority? Not like some little whelp.

I have tried it as

DO:LOOP WHILE _MOUSEINPUT

But that tended to cause issues. Can't remember just what it did now though.
Title: Re: Mouse input lag
Post by: Pete on October 21, 2021, 03:10:29 pm
Quote from: Cobalt on October 21, 2021, 01:46:34 pm
Can I help it that I speak with authority? Not like some little whelp.

I have tried it as

DO:LOOP WHILE _MOUSEINPUT

But that tended to cause issues. Can't remember just what it did now though.

I vaguely remember issues with either that, or some other similar method. These days, I just stick to using WHILE:WEND.

Pete

DO: LOOP UNTIL SCREEN_0
Title: Re: Mouse input lag
Post by: johannhowitzer on October 22, 2021, 05:09:41 am
Code: QB64: [Select]
  1. sub update_inputs
  2.  
  3. call detect_devices
  4.  
  5. if dev_mouse = false then exit sub
  6.  
  7. dim mb(3)
  8. for b = 1 to 3
  9.    mb(b) = mouse_press(b)
  11.  
  12. mouse_change = false
  13. do while mouseinput <> false and mouse_change = false
  14.    mx = mousex
  15.    my = mousey
  16.    for b = 1 to 3
  17.       mb(b) = mousebutton(b)
  18.       if mb(b) <> mouse_press(b) then mouse_change = true
  19.    next b
  21.  
  22. for b = 1 to 3
  23.    mouse_hold(b) = mouse_press(b)
  24.    mouse_press(b) = mb(b)
  25.  
  26.    if mouse_press(b) = true and mouse_hold(b) = false then
  27.       mouse_press_x(b) = mx ' Store position mouse button was pressed
  28.       mouse_press_y(b) = my
  29.    elseif mouse_press(b) = false and mouse_hold(b) = true then
  30.       mouse_release_x(b) = mx ' Store position mouse button was released
  31.       mouse_release_y(b) = my
  32.    end if
  34.  
  36.  

After reading up on all this, here's the changes I made to the routine.  As I drain mouseinput, I stop it short whenever there's a change in one of the three button states, this way it keeps up, even in limit 60, but it also doesn't miss any clicks - which I read was a concern.  This appears to have no issues at all.
Title: Re: Mouse input lag
Post by: SMcNeill on October 22, 2021, 05:43:02 am
The only clicks you really have to worry about missing are your scroll wheel events.  They update and clear almost instantly, so you need to track them inside your WHILE:WEND loop, but regular left/right mouse input should never be an issue for you.  ;)
Title: Re: Mouse input lag
Post by: luke on October 22, 2021, 07:05:06 am
To demonstrate precisely why a simple Do: Loop While _Mouseinput is insufficient in some cases, consider the following two programs:
Code: [Select]
'Program A
$noprefix
Do
    Do: Loop While MouseInput
    If MouseButton(1) Then
        i = i + 1
        Print "Click"; i; "processing...";
        Delay 0.5
        Print "Done"
    End If
    Limit 30
Loop
Code: [Select]
'Program B
$noprefix
Do
    If MouseInput Then
        If MouseButton(1) = mouse_down Then 'Is the button still in the same position?
            Do While MouseInput
                If MouseButton(1) <> mouse_down Then Exit Do 'Process through the queue until the button changes state
            Loop
        End If
        mouse_down = MouseButton(1)
        'Do mouse processing here
        If mouse_down Then
            i = i + 1
            Print "Click"; i; "processing...";
            Delay 0.5
            Print "Done"
        End If
    End If
    Limit 30
Loop

In both cases, the intention is to capture each mouse click and perform some "processing" on it. Here our "processing" is just a delay to simulate some actual code. Run each program and do some clicks. You should see a new message printed for each click. Now try a double click (two clicks in rapid succession). Assuming you're reasonably quick, you'll notice that program A will only register the first click - any clicks done during the "processing" time are ignored. Program B avoids this by scanning through the input buffer to see if there were any click events that need to be processed.
Title: Re: Mouse input lag
Post by: Pete on October 22, 2021, 11:20:51 am
@luke makes a good point about more advanced mouse usage such as double-clicks, and I'll add drag in that mix. @johannhowitzer  Personally, I strive for flow through code, so all my routines are free of _DELAY statements and continuously cycle back to the main. In the code I posted, you will notice the effects like double-click and drag are obtained by tracking time and mouse button states (pressed and released.) Frankly, I'd wish you'd change your code to the WHILE:WEND model, as it would be easier to help you implement these other features, including _MOUSEWHEEL, as @SMcNeill posted. Of course if you have all that you will ever need for this and other routines cooked into the code you posted, that's fine. I rank creativity over dogma most of the time.

Pete
Title: Re: Mouse input lag
Post by: johannhowitzer on October 22, 2021, 03:23:56 pm
I didn't put double click tracking in there yet, but my code does support dragging, as it not only tracks press and release, but where each happened.  This is partly so I can make sure both happened over the same hotspot - so if you click a button, hold, then release the mouse while not over the button, it won't activate it.
Title: Re: Mouse input lag
Post by: Dimster on October 27, 2021, 10:15:08 am
I'm thinking this thread may have come to an end as interesting and helpful as it was.... but felt I needed to defend myself (ie @bplus .. on/off). Mark is correct, typically a light goes ON but the interchangeable use of ON/OFF is rampant in the English language .. ie "the gun when off" doesn't mean it was turned off and inactive, it means it was turned on and very active... same with the horse races "..and their off" doesn't mean the horses are off the track, it does mean they are very much on the race track and running.

And here's one which is very confusing but logical "..and the Dimster is Off, ON another of his rants."
Title: Re: Mouse input lag
Post by: bplus on October 27, 2021, 10:56:01 am
Quote from: Dimster on October 27, 2021, 10:15:08 am
I'm thinking this thread may have come to an end as interesting and helpful as it was.... but felt I needed to defend myself (ie @bplus .. on/off). Mark is correct, typically a light goes ON but the interchangeable use of ON/OFF is rampant in the English language .. ie "the gun when off" doesn't mean it was turned off and inactive, it means it was turned on and very active... same with the horse races "..and their off" doesn't mean the horses are off the track, it does mean they are very much on the race track and running.

And here's one which is very confusing but logical "..and the Dimster is Off, ON another of his rants."

Always nice to get a peek into how another thinks, very nice logical explanation, thankyou I am smiling.
Title: Re: Mouse input lag
Post by: Pete on October 27, 2021, 04:35:20 pm
I find this conversation to be on the whole, OFF topic.

The
Quote from: Dimster on October 27, 2021, 10:15:08 am
.. ie "the gun when off" doesn't mean it was turned off and inactive, it means it was turned on and very active... same with the horse races "..and their off" doesn't mean the horses are off the track, it does mean they are very much on the race track and running.

 "the gun when off" Huh? How can the gun go off "when" the gun is off? Oh well, maybe a better question for that idiot actor, Alex Baldwin.

Pete

In Soviet Russia, to stay on top, you have to stay off bottom of things.
Title: Re: Mouse input lag
Post by: Cobalt on October 27, 2021, 07:29:35 pm
Quote from: Dimster on October 27, 2021, 10:15:08 am
Mark is correct, typically a light goes ON but the interchangeable use of ON/OFF is rampant in the English language .. ie "the gun when off" doesn't mean it was turned off and inactive, it means it was turned on and very active... same with the horse races "..and their off" doesn't mean the horses are off the track, it does mean they are very much on the race track and running.

And here's one which is very confusing but logical "..and the Dimster is Off, ON another of his rants."

side note:
 When a gun discharges it is off, because it is safe at that point. Once a new round is chambered the gun is now "charged" or ON and is again very dangerous. as with a light bulb, when the line is unloaded(off[aka no power]) it is safe to change, how ever when the line is loaded(ON [aka has power]) you can fry yourself!

I would like to think of it as "Dimster is Off, ON another journey seeking enlightenment!"
Title: Re: Mouse input lag
Post by: Dimster on October 28, 2021, 10:24:08 am
You're right @Pete, that should have read "went off" and not " when". Not sure how I missed that typo. Off my game I guess.
And @Cobalt, when it comes to the On and Off of light switches, I'm starting to hear the phrase "open/closed" with electricians, rather than On/Off. But I do agree with you, @blus called me on that use of On/Off for the proverbial enlightening light bulb.
Title: Re: Mouse input lag
Post by: Dimster on October 28, 2021, 11:14:06 am
@Cobalt ... just to elaborate on that light switch "open/closed". I recently had an electrician install a water pump for me. Because there would be more people switching that switch I asked him to label the on/off positions. He labelled "pump on/ pump off". I suggested he could have just labelled on/off. He said a switch is like a circuit breaker which opens and closes but the object at the end of the line of the power will be either on or off. That phase "switched on" should in fact be "switched open"..
Title: Re: Mouse input lag
Post by: bplus on October 28, 2021, 12:19:43 pm
Quote from: Dimster on October 28, 2021, 10:24:08 am
You're right @Pete, that should have read "went off" and not " when". Not sure how I missed that typo. Off my game I guess.
And @Cobalt, when it comes to the On and Off of light switches, I'm starting to hear the phrase "open/closed" with electricians, rather than On/Off. But I do agree with you, @blus called me on that use of On/Off for the proverbial enlightening light bulb.

Oh ha! I am blus now, I like it! I type that allot, @Dimster I guess you are On your game now by being Off a bit ;-))
Title: Re: Mouse input lag
Post by: Dimster on October 28, 2021, 12:56:19 pm
Freudian slip ... always felt it should be Aplus.
Text Only | Text with Attachments