Post by: NOVARSEG on February 03, 2021, 09:25:35 pm
Does not use _LOADIMAGE. To use the program, enter the name of the BMP file you want to look at.
Code: QB64: [Select]
Post by: SMcNeill on February 03, 2021, 09:36:04 pm
And the only difference with 32-bit images is you just get 4 bytes instead of 3 and adding CHR$(255).
Post by: SpriggsySpriggs on February 03, 2021, 09:37:27 pm
Post by: NOVARSEG on February 03, 2021, 09:51:51 pm
Yep adding that 4th byte is important with 24 bit per pixel BMPs
Post by: NOVARSEG on February 03, 2021, 10:12:52 pm
Code: QB64: [Select]
Post by: NOVARSEG on February 04, 2021, 02:38:54 am
used the FILELIST function to display BMP files in a folder
just click with mouse to display BMP
Code: QB64: [Select]
- _TITLE "Demo of FILELIST$ Function by Ted Weissgerber 2010 (modified)"
- SCREEN dst&
- 'LOCATE 33, 10: PRINT "Do you want file display in a new window? (Y/N)"
- 'DO
- 'SLEEP
- 'yesno$ = UCASE$(INKEY$)
- 'LOOP UNTIL yesno$ <> ""
- 'IF yesno$ = "Y" THEN x% = 0: y% = 0 ELSE x% = 8: y% = 16 'set parameters
- x% = 8: y% = 16
- ' INPUT "Enter a File Type extension(*.BMP, *.TXT, etc): ", spec$
- 'spec$ = UCASE$(spec$)
- ''IF INSTR(spec$, "*.") = 0 THEN spec$ = "*." + spec$
- spec$ = "*.bmp"
- '<<<<<<< If x% and y% parameters are 0, the display is in separate window.>>>>>>
- filename = FILELIST$(spec$, x%, y%) '<<<<<<<< added display position parameters
- 'SLEEP
- 'END
- 'INPUT " Enter name of BMP file "; i$
- PRINT "Offset to picture data"; OF
- PRINT "Header size "; L
- PRINT "image width "; W
- PRINT "image height "; H
- PRINT "bits per pixel "; I
- N = N + 4
- NEXT C
- NEXT R
- f% = FREEFILE
- CLOSE #f%
- DL$ = "DIR": BS$ = "\" 'directory searches only
- ' Get Specific file information if available
- Head$ = " Short Name Long Name Last Modified "
- tmp$ = " \ \ \ \ \ \ \ \"
- setcode% = 0: filecode% = 0
- Sst% = 40: Lst% = 53: Dst% = 26: format% = 1 ' XP
- cnt% = cnt% + 1
- DIR$(cnt%) = D1R$: Paths$(cnt%) = Path$
- Spec$ = SHFN$(cnt%) + BS$: FILELIST$ = Spec$: LFN$ = LGFN$(cnt%) + BS$
- ELSE 'first page = 0
- _DEST FList&
- _TITLE current$ '<<<<<<<<<<<<<<<<<<<<<<<<<<< TITLE optional
- GOSUB NewScreen '<<<< update function's screen with Putimage(see notes)
- GOSUB pickfile
- page% = page% + 1: cnt% = 0
- CLOSE #f%
- last = 1: total% = cnt% + (page% * 25)
- pickfile:
- _DEST FList&
- GOSUB NewDisplay
- R% = Trow% - 2
- GOSUB NewDisplay
- P% = R%
- Spec$ = SHFN$(R%)
- GOSUB NewDisplay
- Spec$ = Spec$ + BS$: FILELIST$ = Spec$: Path$ = Paths$(R%)
- FILELIST$ = "": Spec$ = "": LFN$ = ""
- KILLdata:
- _AUTODISPLAY 'reset default settings
- NewScreen: 'clear screen and set display format
- GOSUB NewDisplay
- NewDisplay: 'show program or window displays
- _DEST FList&
Post by: bplus on February 04, 2021, 02:06:59 pm
OK you fixed the first error on title but I am still getting path not found line 39
Code: QB64: [Select]
- spec$ = "*.*"
- '<<<<<<< If x% and y% parameters are 0, the display is in separate window.>>>>>>
- filename = FILELIST$(spec$, x%, y%) '<<<<<<<< added display position parameters
so filename is missing, so maybe it's the spec$, changed to "*.*" takes care of that error (when no .bmp file is found) and what a lovely display Ted W! from 2010 but then I want to try another directory for bmp files I click where it says to change directory error again. I click current folder to change that and another error.
Not fun... :(
There is a tool to get Folders and Files that works cross platform from which you could work out file select or Folder change Best Answer here: https://www.qb64.org/forum/index.php?topic=1511.msg107143#msg107143
You would build your own filter for BMP files and the code for displaying the Directory Lists and File Lists, it's good exercise and you explain your code better to others and fix errors. There are also tools for displaying lists and selecting also probably harder to do than getting Folder and File lists.
Just trying to help, I don't save BMP's in this format but you are attempting a very common and useful task browsing for filename to load. It is important.
Post by: NOVARSEG on February 04, 2021, 06:37:15 pm
The code is buggy
When I paste a single bmp into a folder or no BMP in folder it crashes
When I paste 2 bmp into a folder it works.
Post by: bplus on February 04, 2021, 07:28:53 pm
I still recommend using someone else filename retriever, not Ted W from 2010. Someone here and now at forum that can help with code they wrote if you get stuck while using.
Steve has good filename retriever, Spriggsy, Dav... not just me to choose more current code from.
Post by: NOVARSEG on February 04, 2021, 07:40:31 pm
Followed that link https://www.qb64.org/forum/index.php?topic=1511.msg107143#msg107143 and found the code with library functions. I have also done the same thing with the DOS interrupts.
Post by: bplus on February 04, 2021, 07:49:23 pm
The code is a demo used with BMP viewer.
Followed that link https://www.qb64.org/forum/index.php?topic=1511.msg107143#msg107143 and found the code with library functions. I have also done the same thing with the DOS interrupts.
The advantage of using code from that link is that it is cross platform not Windows dependent so build a filename retriever from that and it can be used in Linux and Mac (so I hear). And reused for any app that needs to get a filename.
But maybe those other OS don't use that form of BMP. :)
Post by: NOVARSEG on February 04, 2021, 09:45:47 pm
Im trying to work with win API. I'm trying to download fileapi.h not much luck so far.
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/
Are you actually clicking the file name with mouse?
Microsoft recommends C++ when coding with WINAPI
https://docs.microsoft.com/en-us/windows/win32/learnwin32/learn-to-program-for-windows
Can we do the same with QB64?
Post by: bplus on February 04, 2021, 10:24:16 pm
The BMP format is cross platform. It's disadvantage is size of file.
Im trying to work with win API. I'm trying to download fileapi.h not much luck so far.
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/
Are you actually clicking the file name with mouse?
Microsoft recommends C++ when coding with WINAPI
https://docs.microsoft.com/en-us/windows/win32/learnwin32/learn-to-program-for-windows
Can we do the same with QB64?
Windows API isn't going to help you in Linux.
Here is Tiny Navigator for File Retrieval, you need direntry.h in the same folder as QB64.exe.
Tiny Navigator for File Retrieval the left side is directories, the right is a sample of files from the directory highlighted. When on the directory you want to select a file from press f then another scrollable window comes up on right for file selection.
You can scroll, arrow, pageup and down by clicking green bars home end for start of array and end, you can also select directories and files by typing the number then enter.
Code: QB64: [Select]
- ' B+ started 2019-08-22 restart 2020-06-24
- ' 2019-08-22 orig post at https://www.qb64.org/forum/index.php?topic=1646.msg108682#msg108682
- ' 2019-08-23_13-25 try fix (to nav all directories) with one place for tmpFile, theory can't write files in some dir's
- ' For some reason Windows won't write to a fully pathed file in my user folder???from a SHELL command
- ' Try testing if dir exists "C:\temp" exists and making one if not, yes! and I can write my temp files there
- ' and now I can chDir anywhere!!!!
- ' 2019-08-23_14-25 Take Steve's Advice to use users tmp directory for temp files
- ' 2019-08-23_23+ Have files window working for file selection
- ' 2020-06-24 restart using DirEntry.h, wow looks like Steve's fix helped ALLOT! Thanks SMcNeill
- ' I am hitting glitches where Windows wont let me access I think. So I am offering a c enter option
- ' to restart at the root but this might not work cross platform.
- ' 2020-06-26 another fix to DirEntry.h usage add CHR$(0) to string when calling a C program. This fixed a snag
- ' between marka and next folder up when heading to root with .. calls.
- ' 2020-07-04 Use this to Kill some pesky .ogg files
- ' direntry.h needs to be in QB64 folder ' <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< IMPORTANT
- _TITLE "Tiny Navigator File Name Retriever: press f to start File Selection List of current directory"
- ' for GetFileName$()
- DO 'test our new function
- scnState 0
- myFile$ = GetFileName$
- scnState -1
- PRINT "You selected: "; myFile$
- INPUT "Test another File Selection (y for yes) "; again$
- 'you might try srnState before and after calling this function to restore conditions
- ' uses: SUB GetLists (SearchDirectory AS STRING, DirList() AS STRING, FileList() AS STRING) for getting dirs a nd files
- ' uses: FUNCTION getArrayItemNumber& (locateRow, locateColumn, boxWidth, boxHeight, arr() AS STRING) for display large arrays and selecting
- ' share these with Main Code section:
- ' 'for GetFileName$() and GetLists
- 'DIM SHARED selectedFile AS STRING
- 'REDIM SHARED DIRs(0) AS STRING, FILs(0) AS STRING
- _TITLE "Tiny Navigator File Name Retriever: press f to start File Selection List of current directory"
- mySelection& = getArrayItemNumber&(5, 5, 50, 30, DIRs())
- GetFileName$ = selectedFile: done$ = "y"
- GetFileName$ = "": done$ = "y" ' cancelled or error
- selectedFile = ""
- _LIMIT 60
- 'put this block in main code section of your program close to top
- '' direntry.h needs to be in QB64 folder
- 'DECLARE CUSTOMTYPE LIBRARY ".\direntry"
- ' FUNCTION load_dir& (s AS STRING)
- ' FUNCTION has_next_entry& ()
- ' SUB close_dir ()
- ' SUB get_next_entry (s AS STRING, flags AS LONG, file_size AS LONG)
- 'END DECLARE
- DIM nam$
- DirCount = 0: FileCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- 'close_dir 'move to after end if might correct the multi calls problem
- close_dir 'this might correct the multi calls problem
- ' "Escape or Red X box returns -1719 to allow a Cancel function and signal no slection."
- 'Notes: locateRow, locateColumn for top right corner of selection box on screen in characters for LOCATE.
- 'boxWidth and boxHeight are in character units, again for locate and print at correct places.
- 'All displaying is restricted to inside the box, which has PgUP and PgDn as top and bottom lines in the display.
- 'save old settings to restore at end ofsub
- curRow = CSRLIN
- fg = _DEFAULTCOLOR
- bg = _BACKGROUNDCOLOR
- maxWidth = boxWidth ' number of characters in box
- maxHeight = boxHeight - 2 ' number of lines displayed of array at one time = 1 page
- page = 0
- hlite = 0 ' line in display ready for selection by spacebar or if no number is started, enter
- GOSUB update ' show the beginning of the array items for selection
- 'signal cancel selection process, exit sub with this unlikely index to signal canel
- choice = -1719 'primes 7 and 8, not likely to be a select index of an array
- DO 'until get a selection or demand exit
- 'handle the key stuff
- kh& = _KEYHIT
- 'REDIM FILs(0) AS STRING 'hopefully this is already ready
- 'loadFiles FILs()
- selNum& = getArrayItemNumber&(5, 60, 60, 30, FILs())
- CLS 'need to signal out of file selection
- 'back to directory select
- ELSE 'clear b$ to show some response to enter
- choice = hlite + page * maxHeight + lba 'must mean to select the highlighted item
- 'handle the mouse stuff
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- choice = my + page * maxHeight + lba - 1 'select item clicked
- ELSE 'PgUp bar clicked
- ELSE ' mouse over highlighting, only if mouse has moved!
- hlite = my - 1
- lastMX = mx: lastMY = my
- GOSUB update
- _LIMIT 200
- getArrayItemNumber& = choice
- COLOR fg, bg
- 'clear key presses
- LOCATE curRow, curCol
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- update: '--------------- display of array sections and controls on screen
- 'fix hlite if it has dropped below last array item
- hlite = hlite - 1
- 'main display of array items at page * maxHeight (lines high)
- index = row + page * maxHeight + lba
- 'make page up and down bars to click, print PgUp / PgDn if available
- 'make exit sign for mouse click
- PRINT " X "
- 'if a number selection has been started show it's build = b$
- PRINT b$;
- _LIMIT 100
- ' for saving and restoring screen settins
- _FONT Font
- COLOR DefaultColor, BackGroundColor
- _DEST Dest
- _SOURCE Source
- LOCATE row, col
- _LIMIT 100
You will have to test the selected file for the proper extension.
Post by: NOVARSEG on February 05, 2021, 02:49:04 am
Here is the source code BAS file
Code: QB64: [Select]
- _TITLE "BMP slide show. Press ESC to exit"
- length = has_next_entry
- '_FULLSCREEN
- PRINT "NO more files to process"
- get_next_entry NAM, flags, file_size
- Fcount = Fcount + 1
- F(Fcount) = NAM
- Fmax = Fcount
- close_dir '
- Fcount = 0
- N = 0
- Fcount = Fcount + 1
- 'PRINT "Offset to picture data"; OF
- ' PRINT "Header size "; L
- ' PRINT "image width "; W
- 'PRINT "image height "; H
- ' PRINT "bits per pixel "; I
- 'PRINT
- N = N + 4
- NEXT C
- NEXT R
- _MEMFREE a
- LL1:
- t1 = TIMER
- _LIMIT 100
- t2 = TIMER
- i$ = INKEY$
OK there is the pics hmm not much use for the program if you can see the pics ????
Post by: Dav on February 05, 2021, 11:54:05 am
- Dav
Post by: bplus on February 05, 2021, 01:21:18 pm
Wow nice job re-interpreting the library for files/folders and using direntry.h !
And those 3 photos are gorgeous!
Thanks for providing files to test, now working, I made some mods you might like for slide show app:
Code: QB64: [Select]
- length = has_next_entry
- get_next_entry NAM, flags, file_size
- Fcount = Fcount + 1
- F(Fcount) = NAM
- Fmax = Fcount
- close_dir '
- _DELAY .25
- Fcount = 0
- Fcount = Fcount + 1
- image& = loadBMP24&(F(Fcount))
- _FREEIMAGE image&
- N = N + 4
- NEXT C
- NEXT R
- loadBMP24& = dh
- _MEMFREE a
My main purpose was to get that FUNCTION working so we can explore the whole hard disk with Tiny Navigator File Retriever and maybe other image displaying routines or file management things.
EDIT: Oh I am going to need a check last 4 chars = BMP in that function because I won't be screening for that first as you had. Fixed.
Post by: SMcNeill on February 05, 2021, 01:45:54 pm
Code: QB64: [Select]
And if you want to know more about decoding them from there, let me know. ;)
That first I you’re getting is for number of planes; second I is for bits per pixel.
Post by: bplus on February 05, 2021, 01:50:42 pm
Almost have Navigator ready to see if I have any more of these special BMP's on my Hard Drive, I suspect JB images might be?
Post by: SMcNeill on February 05, 2021, 02:04:17 pm
Bitmaps are strict on how many bits they store per row, and they need to be multiples of 4. If your image doesnt fit that criteria, you add padding to it.
Say a 4 pixel wide image would be stored as RGBRGBRGBRGB. 12 bytes per row, no padding is needed.
But a 3 pixel wide image is RGBRGBRGB — or only 9 bytes. You tack 3 bytes of padding onto the end of it.
From what I can tell, it doesn’t seem like there’s any adjusting for the padding in the code? Will what you’re doing work with non-size-4 images?
EDIT:
IF ((BMP.PWidth * 3) MOD 4) <> 0 THEN '’need padding pixels
Padding$ = SPACE$((4 - ((BMP.PWidth * 3) MOD 4)))
END IF
EDIT 2:
You should get the padding at line 86.5 in your code, at least, that’s my initial thoughts on it.
Post by: bplus on February 05, 2021, 02:18:55 pm
Code: QB64: [Select]
- ' B+ started 2019-08-22 restart 2020-06-24
- ' 2020-06-24 restart using DirEntry.h, wow looks like Steve's fix helped ALLOT! Thanks SMcNeill
- ' I am hitting glitches where Windows wont let me access I think.
- ' 2020-06-26 another fix to DirEntry.h usage add CHR$(0) to string when calling a C program.
- ' 2020-07-04 Use this to Kill some pesky .ogg files
- ' 2021-02-05 Use this to Display BMP24 files
- ' direntry.h needs to be in QB64 folder ' <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< IMPORTANT
- ' for GetFileName$()
- _TITLE "Tiny Navigator File Name Retriever for Displaying BMP24 files: press f for File Selection of current directory"
- _DELAY .25
- DIM myFile$, image&
- DO 'test our new function
- scnState 0
- myFile$ = GetFileName$
- scnState -1 ' <<<<<<<<<<<<<<<<<<<<<<<<<<< this is supposed to restore back color
- image& = loadBMP24&(myFile$)
- _FREEIMAGE image&
- N = N + 4
- NEXT C
- NEXT R
- loadBMP24& = dh
- _MEMFREE a
- 'you might try srnState before and after calling this function to restore conditions
- ' uses: SUB GetLists (SearchDirectory AS STRING, DirList() AS STRING, FileList() AS STRING) for getting dirs a nd files
- ' uses: FUNCTION getArrayItemNumber& (locateRow, locateColumn, boxWidth, boxHeight, arr() AS STRING) for display large arrays and selecting
- ' share these with Main Code section:
- ' 'for GetFileName$() and GetLists
- 'DIM SHARED selectedFile AS STRING
- 'REDIM SHARED DIRs(0) AS STRING, FILs(0) AS STRING
- _TITLE "Tiny Navigator File Name Retriever: press f to start File Selection List of current directory"
- mySelection& = getArrayItemNumber&(5, 5, 50, 30, DIRs())
- GetFileName$ = selectedFile: done$ = "y"
- GetFileName$ = "": done$ = "y" ' cancelled or error
- selectedFile = ""
- _LIMIT 60
- 'put this block in main code section of your program close to top
- '' direntry.h needs to be in QB64 folder
- 'DECLARE CUSTOMTYPE LIBRARY ".\direntry"
- ' FUNCTION load_dir& (s AS STRING)
- ' FUNCTION has_next_entry& ()
- ' SUB close_dir ()
- ' SUB get_next_entry (s AS STRING, flags AS LONG, file_size AS LONG)
- 'END DECLARE
- DIM nam$
- DirCount = 0: FileCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- 'close_dir 'move to after end if might correct the multi calls problem
- close_dir 'this might correct the multi calls problem
- ' "Escape or Red X box returns -1719 to allow a Cancel function and signal no slection."
- 'Notes: locateRow, locateColumn for top right corner of selection box on screen in characters for LOCATE.
- 'boxWidth and boxHeight are in character units, again for locate and print at correct places.
- 'All displaying is restricted to inside the box, which has PgUP and PgDn as top and bottom lines in the display.
- 'save old settings to restore at end ofsub
- curRow = CSRLIN
- fg = _DEFAULTCOLOR
- bg = _BACKGROUNDCOLOR
- maxWidth = boxWidth ' number of characters in box
- maxHeight = boxHeight - 2 ' number of lines displayed of array at one time = 1 page
- page = 0
- hlite = 0 ' line in display ready for selection by spacebar or if no number is started, enter
- GOSUB update ' show the beginning of the array items for selection
- 'signal cancel selection process, exit sub with this unlikely index to signal canel
- choice = -1719 'primes 7 and 8, not likely to be a select index of an array
- DO 'until get a selection or demand exit
- 'handle the key stuff
- kh& = _KEYHIT
- 'REDIM FILs(0) AS STRING 'hopefully this is already ready
- 'loadFiles FILs()
- selNum& = getArrayItemNumber&(5, 60, 60, 30, FILs())
- CLS 'need to signal out of file selection
- 'back to directory select
- ELSE 'clear b$ to show some response to enter
- choice = hlite + page * maxHeight + lba 'must mean to select the highlighted item
- 'handle the mouse stuff
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- choice = my + page * maxHeight + lba - 1 'select item clicked
- ELSE 'PgUp bar clicked
- ELSE ' mouse over highlighting, only if mouse has moved!
- hlite = my - 1
- lastMX = mx: lastMY = my
- GOSUB update
- _LIMIT 200
- getArrayItemNumber& = choice
- COLOR fg, bg
- 'clear key presses
- LOCATE curRow, curCol
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- update: '--------------- display of array sections and controls on screen
- 'fix hlite if it has dropped below last array item
- hlite = hlite - 1
- 'main display of array items at page * maxHeight (lines high)
- index = row + page * maxHeight + lba
- 'make page up and down bars to click, print PgUp / PgDn if available
- 'make exit sign for mouse click
- PRINT " X "
- 'if a number selection has been started show it's build = b$
- PRINT b$;
- _LIMIT 100
- ' for saving and restoring screen settins
- _FONT Font
- COLOR DefaultColor, BackGroundColor
- _DEST Dest
- _SOURCE Source
- LOCATE row, col
- _LIMIT 100
Post by: SMcNeill on February 05, 2021, 02:21:58 pm
Post by: bplus on February 05, 2021, 02:31:03 pm
Just read my edit above. I believe you may run into issues with padding. ;)
I did read and he's using the 4 size only.
Do you have an image to demonstrate and test code and code fixes?
Post by: SMcNeill on February 05, 2021, 03:14:27 pm
I did read and he's using the 4 size only.
Do you have an image to demonstrate and test code and code fixes?
Grab the file below and give it a run. It's only 638 pixels wide (non-4), so it requires end of line padding.
Here's a quick set of example code for you to study as well:
Code: QB64: [Select]
Run it and you'll see the image distorted as heck.
Unremark out the lines I've got remarked and run it. (Also remark out the current GET line of GET #1, R * W * 3 + C + OF, t , as we're replacing it with the one I have remarked.)
You should be able to easily see the difference.
Here's an image of what the program you have now displays, vs the original:
Post by: bplus on February 05, 2021, 03:39:36 pm
Here is the FUNCTION I used with the modifications
Code: QB64: [Select]
Post by: SMcNeill on February 05, 2021, 04:03:46 pm
One was the SEEK.... I forgot to add 1 since binary files start at byte 1 and not 0.
SEEK #1, OF + 1
Second is the face that it seems BMP files are stored bottom up, not top-down. Just one of those many things I used to know, that I have to run into a little BLIP to remind myself of.
Change the SEEK like above, and run it. You'll see your image reversed. :P
The change the MEMPUT to where you put the data in from the end to the beginning, and you're good to go:
_MEMPUT a, a.OFFSET + a.SIZE - N - 4, tt
And I think that'll account for your padding, start the color at the proper pixel to read the RGB right, and draw it in the proper order.
Post by: SMcNeill on February 05, 2021, 04:31:00 pm
w& = _WIDTH(image&)
DO
y = y - 1: x = x1% - 1
DO
x = x + 1
_MEMGET m, m.OFFSET + (w& * y + x) * 4, temp
y starts at the bottom of the screen, and moves up.
x starts at the left of the screen, and moves right.
I'm thinking what I posted above might mirror the image for you, accidently. (Not that you'd notice in single color rows...)
Here's what I'm thinking you actually need to do this properly:
Code: QB64: [Select]
Post by: NOVARSEG on February 05, 2021, 04:49:02 pm
bplus
Quote
GET #1, , I
GET #1, , I 'get I twice ???
The first I read 2 bytes (DIM I AS INTEGER) which is biPlanes and I did not need that info, so skipped it
Quote
biPlanes 2 Must be 1
biBitCount 2 Bits per pixel - 1, 4, 8, 16, 24, or 32
The second I is bits per pixel and the viewer works only with 24 bits per pixel.
****
Another thing, in my source code, my comment looks to be wrong as I tried the code in the root of drive C and it worked. In the past I was able to detect whether code was run in the root or not and I will have to dig up some old code to see how that was done.
Quote
IF load_dir("." + CHR$(0)) = -1 THEN 'found "." this is a folder not a root drive****
Steve
In my viewer code I did not run into a padding issue. If there was padding at the end of a row (scan line) then for sure my code would not work. from http://www.dragonwins.com/domains/getteched/bmp/bmpfileformat.htm Look at subheading "Pixel Data" I'm really not sure if that is correct.
Will look into this "padding thing"
The only "padding" I did was adding that 4th byte at the end of a 24 bit pixel because
Quote
handle = _NEWIMAGE(W, H, 32)
expects a 32 bit pixel
****
Dav
Glad it worked on your computer!!!
Post by: NOVARSEG on February 05, 2021, 06:20:33 pm
from https://homepages.inf.ed.ac.uk/rbf/BOOKS/PHILLIPS/cips2ed.pdf
Quote
The BMP color table has four bytes in each color table entry. The bytes
are for the blue, green, and red color values. The fourth byte is padding and
is always zero. For a 256 gray shade image, the color table is 4x256 bytes
long. The blue, green, and red values equal one another.
The final part of the BMP file is the image data. The data is stored row
by row with padding on the end of each row. The padding ensures the image
rows are multiples of four. The four, just like in the color table, makes it
easier to read blocks and keep track of addresses.
Now I'm really confused. You could have any number of bytes per scan line as long as they are a multiple of 3 (24 bit BMP). I don't see the reason for padding in a 24 bit BMP???
If there was in fact padding at the end of a 24 bit BMP scan line, then my viewer code would not work.
As the above quote says
Quote
makes it easier to read blocks and keep track of addresses.
HUH? file pointers have BYTE resolution
Addresses WHAT , all we need to know is the offset from start of file to pixel data.
Post by: SMcNeill on February 05, 2021, 06:26:53 pm
You do one row at a time, starting at bottom left, to bottom right.
At the end of that row, you have padding to make it a length divisible by 4.
Then you go up to the line above it and repeat, until you reach the top.
You don’t need to worry about the color table reference, as that’s for other color modes.
Post by: NOVARSEG on February 05, 2021, 06:30:31 pm
In a, say, 1024 * 768 24 bit BMP there are exactly 1024 * 3 bytes per scan line. That is what my code is saying. If there was actually padding bytes at the end of a scan line then surely I would have found them.
Post by: NOVARSEG on February 05, 2021, 07:14:53 pm
1024 * 3 /4 = 768 = no padding
1072 * 3 /4 = 804 = no padding
imagine that
update coming
Post by: SMcNeill on February 05, 2021, 07:18:09 pm
Ya but I did not have to adjust for "padding" in my code . If there are padding bytes at the end of a scan line then the padding byte don't contain pixel data. The file pointer (GET, point, . . .) is supposed to point to pixel data only
In a, say, 1024 * 768 24 bit BMP there are exactly 1024 * 3 bytes per scan line. That is what my code is saying. If there was actually padding bytes at the end of a scan line then surely I would have found them.
As I mentioned, the padding is only there in images whose width is not evenly divisible by four.
Most full screen images have no padding: 320, 480, 640, 720, 1024 are all evenly divisible by 4. Where you normally see the padding is when folks take a screenshot of a potion of the screen. (Say from 0,0 to 638, 372 — that 638 isn’t evenly divisible by 4 and thus has padding at the end of the line.)
Post by: NOVARSEG on February 05, 2021, 07:19:26 pm
code update coming
Post by: STxAxTIC on February 05, 2021, 07:28:04 pm
Steve, you're my only hope. Drag them in.
Post by: bplus on February 05, 2021, 07:52:47 pm
You guys are using this thread like a chatroom. Not illegal, but you realize Discord would be much more efficient?
Steve, you're my only hope. Drag them in.
Somebody forgot definition of a forum.
Post by: STxAxTIC on February 05, 2021, 07:54:29 pm
Post by: SMcNeill on February 05, 2021, 08:21:12 pm
Here's the complete version of what you guys want:
Code: QB64: [Select]
I posted the changes needed above, but didn't actually plug it into the whole thing until now. Sorry. Today's my mom's 81st birthday, and I was enjoying the evening with her and the rest of the family for a change.
One thing which I think is also important to change here:
Why copy the image over to another image of the exact same size, then return the handle to that image, without ever freeing the first image? You guys have a rather serious memory leak in your code here, and it's much simpler to just pass the handle on directly, without worrying about the middleman dh. See the changes down at the last few lines in the routine, before you exit.
Post by: NOVARSEG on February 05, 2021, 08:52:06 pm
There is a lot in this thread to go over. So I converted one of my 1024 pixel wide pics to 1023 pixels wide and my code crashed. Sorry about that.
Post by: bplus on February 05, 2021, 09:07:39 pm
Quote
Why copy the image over to another image of the exact same size, then return the handle to that image, without ever freeing the first image? You guys have a rather serious memory leak in your code here, and it's much simpler to just pass the handle on directly, without worrying about the middleman dh. See the changes down at the last few lines in the routine, before you exit.
Yeah that was me, just trying to get the thing to work as a Function returning a handle of a loaded image.
If this were a chat room I'd ask if that was a cobweb hanging off the bottom of the Starship model and I'd say congrats to Steve's mother and mention I took my 89 year old mother for COVID vaccination today and maybe mention nothing sticks in her memory so I have the same set of questions over and over... but if this were a chatroom you wouldn't have the image to check and say, "No, I think that is just a plain old hair."
I had that dang code working, went to clean up with the new Dim As _Unsigned Long all those variables into one line take out commented out code and when I was done, a blank screen.
So thanks Steve for writing up the revised sub because my cleanup refused to work right and it's even better without the extra handle and memory leaking code!
Post by: NOVARSEG on February 06, 2021, 03:38:58 am
3 more pictures and an EXE to download
Fixed the padding bug.
Code: QB64: [Select]
- _TITLE "BMP slide show. Press ESC to exit"
- 'To view BMP pictures in the root drive or a particular folder (example)
- 'IF load_dir("C:" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'IF load_dir("C:\QB64" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'To view BMP pictures in the directory (folder) from where the EXE is run (current)
- 'To view BMP pictures in the parent directory (folder) from where the EXE is run (current)
- 'IF load_dir(".." + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- length = has_next_entry
- '_FULLSCREEN
- PRINT "NO more files to process"
- get_next_entry NAM, flags, file_size
- Fcount = Fcount + 1
- F(Fcount) = NAM
- Fmax = Fcount
- close_dir
- Fcount = 0
- N = 0
- Fcount = Fcount + 1
- 'PRINT "Offset to picture data"; OF
- ' PRINT "Header size "; L
- ' PRINT "image width "; W
- 'PRINT "image height "; H
- PRINT Fcount
- N = N + 4
- NEXT C
- NEXT R
- _MEMFREE a
- t1 = TIMER
- _LIMIT 100
- t2 = TIMER
- i$ = INKEY$
- LL1:
Post by: NOVARSEG on February 06, 2021, 08:24:07 pm
Quote
pad = 4 - (W * 3) MOD 4
IF pad = 4 THEN pad = 0 'pad = multiple of 4
FOR R = H - 1 TO 0 STEP -1
FOR C = 1 TO W * 3 STEP 3
GET #1, R * (W * 3 + pad) + C + OF, t
tt = t + CHR$(255)
_MEMPUT a, a.OFFSET + N, tt
N = N + 4
NEXT C
NEXT R
FOR R = H - 1 TO 0 STEP -1
if say H = 768 then R is from 767 to 0 or 768 rows.
row 0 final
row 1
row 2
. . .
row 767 start
The key thing here is the final row value R = 0 so
when R = 0
0 * (W * 3 + pad) + C + OF = C + OF = the correct offset into row 0
There are (W * 3 + pad ) bytes per row. so when R = 1 then
(W * 3 + pad) + C + OF = the correct offset into row 1
with (W * 3 + pad) being the bytes in the preceding row 0
when R = 2 then
2 * (W * 3 + pad) + C + OF = the correct offset into row 2
with 2 * (W * 3 + pad) = the total bytes of row 0 + row 1
and so on.
in reality the code down counts but the offset will still work out the same
Post by: NOVARSEG on February 07, 2021, 12:01:47 am
from https://stackoverflow.com/questions/9296059/read-pixel-value-in-bmp-file
Quote
Some bitmaps can be written with a negative height, so when you try to allocate your image data buffer, your code will crash with std::bad_alloc. Bitmaps with negative height means that the image data is stored top to bottom instead of the traditional bottom to top. Therefore, a slightly better version of the top level answer is (still not including portability for systems with different endianness and size of bytes):
Post by: NOVARSEG on February 07, 2021, 02:55:13 am
Works with negative height BMPs too.
EXE attached.
Code: QB64: [Select]
- _TITLE "BMP slide show. Press ESC to exit"
- 'To view BMP pictures in the root drive or a particular folder (example)
- 'IF load_dir("C:" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'IF load_dir("C:\QB64" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'To view BMP pictures in the directory (folder) from where the EXE is run (current)
- 'To view BMP pictures in the parent directory (folder) from where the EXE is run (current)
- 'IF load_dir(".." + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- length = has_next_entry
- PRINT "No more files to process"
- get_next_entry NAM, flags, file_size
- Fcount = Fcount + 1
- F(Fcount) = NAM
- Fmax = Fcount
- close_dir
- Fcount = 0
- N = 0
- Fcount = Fcount + 1
- 'PRINT "Offset to picture data"; OF
- 'PRINT "Header size "; L
- 'PRINT "image width "; W
- 'PRINT "image height "; H
- PRINT Fcount
- GOTO LL1
- N = N + 4
- NEXT C
- NEXT R
- N = N + 4
- NEXT C
- NEXT R
- _MEMFREE a
- t1 = TIMER
- _LIMIT 100
- t2 = TIMER
- i$ = INKEY$
- LL1:
Post by: _vince on February 07, 2021, 06:47:13 am
http://www.petesqbsite.com/sections/tutorials/zines/qbcm/12-bmps.html (http://www.petesqbsite.com/sections/tutorials/zines/qbcm/12-bmps.html)
Hey, Steve, are you fairly active on discord? Anyone know?
Post by: SMcNeill on February 07, 2021, 07:19:12 am
Hey, Steve, are you fairly active on discord? Anyone know?
I go and come a lot. The last week or so, I've been in fairly often, but for the next week or so, I probably won't be. It's time for me to go get mom and take care of her again for a bit to give my sister a break. ;)
Post by: NOVARSEG on February 07, 2021, 02:49:16 pm
RLE compression. Another update
Steve
you were right about the padding. I should have listened.
Post by: _vince on February 07, 2021, 06:56:01 pm
I go and come a lot. The last week or so, I've been in fairly often, but for the next week or so, I probably won't be. It's time for me to go get mom and take care of her again for a bit to give my sister a break. ;)
Nice, good to know! I'm going to make a discord account tonight and join in, see you soon ;-)
Post by: bplus on February 09, 2021, 09:43:34 pm
start this at bottom of code:
Code: QB64: [Select]
- Function LoadBmp24&(Filename$) 'loadBMP24& returns handle to image for display code from main code section.
- >>>>>>>>>>>>>>>> Insert Chuck Here
- LoadBMP24& = handle
Code: QB64: [Select]
- _TITLE "BMP slide show. Press ESC to exit"
- 'To view BMP pictures in the root drive or a particular folder (example)
- 'IF load_dir("C:" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'IF load_dir("C:\QB64" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'To view BMP pictures in the directory (folder) from where the EXE is run (current)
- 'To view BMP pictures in the parent directory (folder) from where the EXE is run (current)
- 'IF load_dir(".." + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- length = has_next_entry
- PRINT "No more files to process"
- get_next_entry NAM, flags, file_size
- Fcount = Fcount + 1
- F(Fcount) = NAM
- Fmax = Fcount
- close_dir
- Fcount = 0
- N = 0
- Fcount = Fcount + 1
- '========================================================= start code chuck
- 'PRINT "Offset to picture data"; OF
- 'PRINT "Header size "; L
- 'PRINT "image width "; W
- 'PRINT "image height "; H
- PRINT Fcount
- GOTO LL1
- N = N + 4
- NEXT C
- NEXT R
- N = N + 4
- NEXT C
- NEXT R
- '===================================================== end of code chunk
- _MEMFREE a
- t1 = TIMER
- _LIMIT 100
- t2 = TIMER
- i$ = INKEY$
- LL1:
Then move all DIM 's Variable in main that got moved to Function into Function at top
Post by: NOVARSEG on February 09, 2021, 10:11:19 pm
Code: QB64: [Select]
Post by: bplus on February 09, 2021, 10:48:23 pm
I don't see the need to pass anything but the handle for the image to display in the main.
Do you have to change something when displaying for h < 0? Couldn't the adjustment be made before the sub or function passes the handle to main for display.
Remember to _FeeImage handles to avoid memory leaks.
Post by: NOVARSEG on February 09, 2021, 11:05:11 pm
Quote
I don't see the need to pass anything but the handle for the image to display in the main.
In the main this code displays
SCREEN _NEWIMAGE(W, (ABS(H)), 32)
_PUTIMAGE (0, 0), HANDLE
_MEMFREE a
which requires W and H. The SUB returns W, H and handle. Notice the ABS(H) because the Sub will return either -H or H depending on the BMP
Also if there is an error (not a 24BMP) the sub will return W = 0
Maybe only a HANDLE is needed but at least there is the optional W and H returned
That is one of the problems with SUBs - what data do we think does not have to be returned
***
Quote
Do you have to change something when displaying for h < 0? Couldn't the adjustment be made before the sub or function passes the handle (height?) to main for display.
Inside the sub there could be an H = ABS(H) but what if your code in the main wanted to know if the BMP had -H or +h height?
****
Quote
Remember to _FreeImage handles to avoid memory leaks.
how is _FreeImage used?
Post by: NOVARSEG on February 09, 2021, 11:43:45 pm
Code: QB64: [Select]
- _TITLE "BMP slide show. Press ESC to exit"
- 'To view BMP pictures in the root drive or a particular folder (example)
- 'IF load_dir("C:" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'IF load_dir("C:\QB64" + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- 'To view BMP pictures in the directory (folder) from where the EXE is run (current)
- 'To view BMP pictures in the parent directory (folder) from where the EXE is run (current)
- 'IF load_dir(".." + CHR$(0)) <> -1 THEN _FULLSCREEN: PRINT: PRINT "Path name does not exist": SLEEP: END
- length = has_next_entry
- PRINT "No more files to process"
- get_next_entry NAM, flags, file_size
- Fcount = Fcount + 1
- F(Fcount) = NAM
- Fmax = Fcount
- close_dir
- Fcount = 0
- Fcount = Fcount + 1
- loadBMP24 F(Fcount), W, H, HANDLE
- PRINT W; H
- GOTO LL1
- _MEMFREE a
- LL1:
- t1 = TIMER
- _LIMIT 100
- t2 = TIMER
- i$ = INKEY$
- 'SUB loadBMP24
- 'input filename
- 'returns W image width (if = 0 then error)
- 'returns H image height (negative or positive value)
- 'returns HANDLE
- N = 0
- N = N + 4
- NEXT C
- NEXT R
- N = N + 4
- NEXT C
- NEXT R
- LL1:
Post by: bplus on February 10, 2021, 12:20:33 am
Navigate your hard disk for BMP24's to display:
Code: QB64: [Select]
- ' Thanks to Spriggsy, Zak, for convincing me pipecom is better!
- ' Using Steve's fixed BMP24 loader
- ' Also thanks to Dav for 1 window for file and folder selection idea
- ' Also thanks to NOVARSEG who got me going on this for a better filename$ retriever
- ' 2021-02-10 update with LoadBMP24 Sub
- _Delay .25
- ReDim myFile$
- Do 'test our new function
- ScnState 0
- col = 16: row = 3: charW = 128: charH = 40
- myFile$ = GetFileName$(row, col, charW, charH)
- ScnState -1 ' <<<<<<<<<<<<<<<<<<<<<<<<<<< this is supposed to restore back color
- 'image& = loadBMP24&(myFile$)
- loadBMP24 myFile$, W, H, image
- _FreeImage image&
- 'NOVARSEG's fixed loadBLP24 Sub 2021-02-10 AAAAM https://www.qb64.org/forum/index.php?topic=3602.msg129753#msg129753
- N = 0
- N = N + 4
- Next C
- Next R
- N = N + 4
- Next C
- Next R
- LL1:
- Dim padding$
- Print Filename$
- Next c
- Next r
- loadBMP24& = handle
- _MemFree a
- 'This Funtion needs:
- ' pipecom.h in same folder as QB64.exe
- ' This in main code section near top:
- ' Declare Library "pipecom"
- ' Function pipecom$ (cmd As String)
- ' End Declare
- ' sub Split source$, delimiter$, arr$()
- ' function GetArrayItem$(x, y, w, h, arr$())
- Getfolder:
- d = pipecom("dir /n /o:gend") '/n files on right (40) /o = order g for group dirs first, e extension, name, date
- s = GetArrayItem$(LocateR, LocateC, CharWide, CharHigh, dir())
- ChDir dr
- GoTo Getfolder
- arrpos = arrpos + 1
- curpos = dpos + LD
- ' Help: all this I hope is intuitive so Help window is provided
- ' "Mouse, mouse wheel, and arrow keys should work as expected for item selection."
- ' "Press spacebar to select a highlighted item or just click it."
- ' "Use number(s) + enter to select an array item by it's index number,"
- ' "backspace will remove last number pressed, delete will clear a number started.
- ' "Numbers started are shown in bottom right PgDn bar."
- ' "Enter will also select the highlighted item, if no number has been started."
- ' "Home starts you at lowest array index, End highlights then highest index."
- ' "Use PgUp and PgDn keys to flip through pages of array items."
- '
- ' Escape to Cancel Return "" else Return the selected string from the array
- 'Notes: locateRow, locateColumn for top right corner of selection box on screen in characters for LOCATE.
- 'boxWidth and boxHeight are in character units, again for locate and print at correct places.
- 'All displaying is restricted to inside the box, which has PgUP and PgDn as top and bottom lines in the display.
- 'ScnState 0 ' use out side this function before and after
- locateRow = LocateRoww + 1 'fix a miscalc in coding
- maxWidth = BoxWidth ' number of characters in box
- maxHeight = BoxHeight - 2 ' number of lines displayed of array at one time = 1 page
- page = 0
- hlite = 0 ' line in display ready for selection by spacebar or if no number is started, enter
- GoSub update ' show the beginning of the array items for selection
- choice = -1719
- Do 'until get a selection or demand exit
- 'handle the key stuff
- kh& = _KeyHit
- Else 'clear b$ to show some response to enter
- choice = hlite + page * maxHeight + lba 'must mean to select the highlighted item
- choice = hlite + page * maxHeight + lba 'best way to choose highlighted selection
- 'handle the mouse stuff
- 'clear mouse clicks
- While mb 'OK!
- _Limit 100
- choice = my + page * maxHeight + lba - 1 'select item clicked
- Else 'PgUp bar clicked
- Else ' mouse over highlighting, only if mouse has moved!
- hlite = my - 1
- lastMX = mx: lastMY = my
- GoSub update
- _Limit 200
- 'ScnState -1 'restore
- 'display of array sections and controls on screen ====================================================
- update:
- 'fix hlite if it has dropped below last array item
- hlite = hlite - 1
- 'main display of array items at page * maxHeight (lines high)
- index = row + page * maxHeight + lba
- 'make page up and down bars to click, print PgUp / PgDn if available
- 'make exit sign for mouse click
- Print " X ";
- 'if a number selection has been started show it's build = b$
- Print b$;
- _Limit 100
- _Font font
- Color defaultColor, backGroundColor
- _Dest dest
- _Source source
- _Limit 100
- _FreeImage snap
- Locate row, col
- _Limit 100
Need this in your QB64.exe Folder
Post by: NOVARSEG on February 10, 2021, 12:40:17 am
Do I need the latest ver of QB64 to see this?
Glad it worked even on -h too ?
i see you used _FreeImage image&
Ok prob works better than _MEMFREE a
Post by: bplus on February 10, 2021, 10:53:54 am
That is the first sub I have written in years!
Do I need the latest ver of QB64 to see this?
Glad it worked even on -h too ?
i see you used _FreeImage image&
Ok prob works better than _MEMFREE a
For your version QB64, you might have to change the REDIM statements that declare Types in groups like:
ReDim As Long x, y, z
Just make:
Redim x as long, y as long, z as long
Or get the 1.5 dev version ;)
I used _FreeImage because what was stored in Handle was an image.
_MEMFREE a should have been in LoadBMP24 Sub because that is where the variable, a, resides.
I don't know with _Mem stuff if a is automatically cleared like a regular variable as soon as you exit the sub. We know images wont.