Text Only | Text with Attachments

QB64.org Forum

Active Forums => QB64 Discussion => Topic started by: Ed Davis on January 28, 2021, 12:54:13 pm

Title: Small syntax bug
Post by: Ed Davis on January 28, 2021, 12:54:13 pm
This code is intended to be used as a function, but I mistakenly used "exit sub", and "end sub" - and the QB64 compiler didn't catch it.
It compiles and runs, and even seems to work, and passes my unit tests (this function is from a much larger program).

Code: QB64: [Select]
  2. DIM SHARED pgm(1000) AS STRING
  3. ' finds target, using current sym
  4. FUNCTION get_target&
  5.     IF symtype = tynum THEN
  6.         get_target = expression#
  7.     ELSE
  8.         DIM i AS INTEGER, lbl AS STRING
  9.         lbl = sym
  10.         IF RIGHT$(lbl, 1) <> ":" THEN lbl = lbl + ":"
  11.         FOR i = 1 TO pgmsize
  12.             IF LCASE$(MID$(LTRIM$(pgm(i)), 1, LEN(lbl))) = lbl THEN
  13.                 get_target& = i
  14.                 EXIT SUB ' should be exit function
  15.             END IF
  16.         NEXT
  17.         PRINT at_line$; "Target of goto not found:"; sym: errors = true
  18.         get_target& = 0
  19.     END IF
  20. END SUB ' should be end function
  21.  
Title: Re: Small syntax bug
Post by: FellippeHeitor on January 28, 2021, 12:55:46 pm
Yeah, QB64 intentionally ignores the difference between END FUNCTION/END SUB, EXIT FUNCTION/EXIT SUB. Both have the same purpose and it's one less error.

Notice that QB4.5 would change it for you - we just let you be.

Also, internally both translate to a mere "}", that's why it doesn't really matter.
Title: Re: Small syntax bug
Post by: Pete on January 28, 2021, 12:59:13 pm
I don't want to make you guys extra work, but why not change it to...

EXIT WHATEVER

Okay, I was kidding. I do want to make you guys extra work!

Pete
Text Only | Text with Attachments