Text Only | Text with Attachments

QB64.org Forum

Active Forums => Programs => Topic started by: bplus on November 08, 2020, 12:47:24 pm

Title: Guess the Animal
Post by: bplus on November 08, 2020, 12:47:24 pm
This is an interesting program and might be good exercise to convert it to more modern ways with QB64.

In 70 lines or so this little program starts learning.

Define the problem: wouldn't it be nice to save it's learning so you don't have to start over the next time you run the program? wouldn't it be nice if your answers didn't have to be in all capital letters? wouldn't it be nice to get a little practice using an array? Wouldn't it be nice to lose all the line numbers?

Here, I've taken TempodiBasic's find and divided the program into 4 or 5 sections with spaces to start making sense of what it is doing and how.

Code: QB64: [Select]
  1. 10 PRINT TAB(32); "ANIMAL"
  2. 20 PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  4. 40 PRINT "PLAY 'GUESS THE ANIMAL'"
  6. 50 PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  8. 70 DIM A$(200)
  9. 80 FOR I = 0 TO 3
  10.    90 READ A$(I)
  11. 100 NEXT I
  12. 110 N = VAL(A$(0))
  13.  
  14. 120 REM          MAIN CONTROL SECTION
  15. 130 INPUT "ARE YOU THINKING OF AN ANIMAL"; A$
  16. 140 IF A$ = "LIST" THEN 600
  17. 150 IF LEFT$(A$, 1) <> "Y" THEN 120
  18. 160 K = 1
  19. 170 GOSUB 390
  20. 180 IF LEN(A$(K)) = 0 THEN 999
  21. 190 IF LEFT$(A$(K), 2) = "\Q" THEN 170
  22. 200 PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  23. 210 INPUT A$
  24. 220 A$ = LEFT$(A$, 1)
  25. 230 IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": GOTO 120
  26. 240 INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  27. 250 PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  28. 260 PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  29. 270 INPUT X$
  30. 280 PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  31. 290 INPUT A$
  32. 300 A$ = LEFT$(A$, 1): IF A$ <> "Y" AND A$ <> "N" THEN 280
  33. 310 IF A$ = "Y" THEN B$ = "N"
  34. 320 IF A$ = "N" THEN B$ = "Y"
  35. 330 Z1 = VAL(A$(0))
  36. 340 A$(0) = STR$(Z1 + 2)
  37. 350 A$(Z1) = A$(K)
  38. 360 A$(Z1 + 1) = "\A" + V$
  39. 370 A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  40. 380 GOTO 120
  41.  
  42.  
  43. 390 REM     SUBROUTINE TO PRINT QUESTIONS
  44. 400 Q$ = A$(K)
  45. 410 FOR Z = 3 TO LEN(Q$)
  46.    415 IF MID$(Q$, Z, 1) <> "\" THEN PRINT MID$(Q$, Z, 1);
  47. 417 NEXT Z
  48. 420 INPUT C$
  49. 430 C$ = LEFT$(C$, 1)
  50. 440 IF C$ <> "Y" AND C$ <> "N" THEN 410
  51. 450 T$ = "\" + C$
  52. 455 FOR X = 3 TO LEN(Q$) - 1
  53.    460 IF MID$(Q$, X, 2) = T$ THEN 480
  54. 470 NEXT X
  55. 475 STOP
  56. 480 FOR Y = X + 1 TO LEN(Q$)
  57.    490 IF MID$(Q$, Y, 1) = "\" THEN 510
  58. 500 NEXT Y
  59. 505 STOP
  60. 510 K = VAL(MID$(Q$, X + 2, Y - X - 2))
  61. 520 RETURN
  62.  
  63.  
  64.  
  65. 530 DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  66.  
  67.  
  68. 600 PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  69. 605 X = 0
  70. 610 FOR I = 1 TO 200
  71.    620 IF LEFT$(A$(I), 2) <> "\A" THEN 650
  72.    624 PRINT TAB(15 * X);
  73.    630 FOR Z = 3 TO LEN(A$(I))
  74.        640 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  75.    642 NEXT Z
  76.    645 X = X + 1: IF X = 4 THEN X = 0: PRINT
  77. 650 NEXT I
  78. 660 PRINT
  79. 670 PRINT
  80. 680 GOTO 120
  81. 999 END
  82.  
  83.  
  84.  

Divide and conquer!
Title: Re: Guess the Animal
Post by: Kiara87 on November 08, 2020, 05:17:17 pm
Quote from: bplus on November 08, 2020, 12:47:24 pm
This is an interesting program and might be good exercise to convert it to more modern ways with QB64.

In 70 lines or so this little program starts learning.

Define the problem: wouldn't it be nice to save it's learning so you don't have to start over the next time you run the program? wouldn't it be nice if your answers didn't have to be in all capital letters? wouldn't it be nice to get a little practice using an array? Wouldn't it be nice to lose all the line numbers?

Here, I've taken TempodiBasic's find and divided the program into 4 or 5 sections with spaces to start making sense of what it is doing and how.

Code: QB64: [Select]
  1. 10 PRINT TAB(32); "ANIMAL"
  2. 20 PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  4. 40 PRINT "PLAY 'GUESS THE ANIMAL'"
  6. 50 PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  8. 70 DIM A$(200)
  9. 80 FOR I = 0 TO 3
  10.    90 READ A$(I)
  11. 100 NEXT I
  12. 110 N = VAL(A$(0))
  13.  
  14. 120 REM          MAIN CONTROL SECTION
  15. 130 INPUT "ARE YOU THINKING OF AN ANIMAL"; A$
  16. 140 IF A$ = "LIST" THEN 600
  17. 150 IF LEFT$(A$, 1) <> "Y" THEN 120
  18. 160 K = 1
  19. 170 GOSUB 390
  20. 180 IF LEN(A$(K)) = 0 THEN 999
  21. 190 IF LEFT$(A$(K), 2) = "\Q" THEN 170
  22. 200 PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  23. 210 INPUT A$
  24. 220 A$ = LEFT$(A$, 1)
  25. 230 IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": GOTO 120
  26. 240 INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  27. 250 PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  28. 260 PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  29. 270 INPUT X$
  30. 280 PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  31. 290 INPUT A$
  32. 300 A$ = LEFT$(A$, 1): IF A$ <> "Y" AND A$ <> "N" THEN 280
  33. 310 IF A$ = "Y" THEN B$ = "N"
  34. 320 IF A$ = "N" THEN B$ = "Y"
  35. 330 Z1 = VAL(A$(0))
  36. 340 A$(0) = STR$(Z1 + 2)
  37. 350 A$(Z1) = A$(K)
  38. 360 A$(Z1 + 1) = "\A" + V$
  39. 370 A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  40. 380 GOTO 120
  41.  
  42.  
  43. 390 REM     SUBROUTINE TO PRINT QUESTIONS
  44. 400 Q$ = A$(K)
  45. 410 FOR Z = 3 TO LEN(Q$)
  46.    415 IF MID$(Q$, Z, 1) <> "\" THEN PRINT MID$(Q$, Z, 1);
  47. 417 NEXT Z
  48. 420 INPUT C$
  49. 430 C$ = LEFT$(C$, 1)
  50. 440 IF C$ <> "Y" AND C$ <> "N" THEN 410
  51. 450 T$ = "\" + C$
  52. 455 FOR X = 3 TO LEN(Q$) - 1
  53.    460 IF MID$(Q$, X, 2) = T$ THEN 480
  54. 470 NEXT X
  55. 475 STOP
  56. 480 FOR Y = X + 1 TO LEN(Q$)
  57.    490 IF MID$(Q$, Y, 1) = "\" THEN 510
  58. 500 NEXT Y
  59. 505 STOP
  60. 510 K = VAL(MID$(Q$, X + 2, Y - X - 2))
  61. 520 RETURN
  62.  
  63.  
  64.  
  65. 530 DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  66.  
  67.  
  68. 600 PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  69. 605 X = 0
  70. 610 FOR I = 1 TO 200
  71.    620 IF LEFT$(A$(I), 2) <> "\A" THEN 650
  72.    624 PRINT TAB(15 * X);
  73.    630 FOR Z = 3 TO LEN(A$(I))
  74.        640 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  75.    642 NEXT Z
  76.    645 X = X + 1: IF X = 4 THEN X = 0: PRINT
  77. 650 NEXT I
  78. 660 PRINT
  79. 670 PRINT
  80. 680 GOTO 120
  81. 999 END
  82.  
  83.  
  84.  

Divide and conquer!

these sources as an exercise I downloaded them

https://www.mediafire.com/file/psy37gm7dadtobb/Basic_Computer_Games_SourceCode.7z/file

so the solution to learn and translate a program from one code to another?

will help learning?

is this what you mean?
from basic code to QB64
OR other language to QB64?
Title: Re: Guess the Animal
Post by: TempodiBasic on November 08, 2020, 05:42:40 pm
Hi kiara87
I suppose that Bplus drives you to learning translating a source code to another structure so:
1. you must read Wiki to understand what does each keyword that you have to manage
2. you can see a general structure in the code
3. you can choose a more readable structure
4. you can change the structure  adding or modifying its way of working
It takes times but it is a good and hard way to learn
Good luck

Ciao kiara87
Io suppongo che Bplus ti guidi ad apprendere  traducendo un codice sorgente in un'altra struttura di codice così facendo:
1. tu sei costretta a leggere laWIKI per capire coda fa ogni parola che tu devi gestire
2. tu puoi vedere una struttura generale nel codice
3. tu puoi scegliere una struttura più leggibile
4. tu puoi cambiare la struttura aggiungendo o modificando il suo modo di funzionare
Richiede del tempo ma è un modo buono e duro di apprendere
Buona fortuna
Title: Re: Guess the Animal
Post by: Kiara87 on November 08, 2020, 05:59:28 pm
Quote from: TempodiBasic on November 08, 2020, 05:42:40 pm
Hi kiara87
I suppose that Bplus drives you to learning translating a source code to another structure so:
1. you must read Wiki to understand what does each keyword that you have to manage
2. you can see a general structure in the code
3. you can choose a more readable structure
4. you can change the structure  adding or modifying its way of working
It takes times but it is a good and hard way to learn
Good luck

Ciao kiara87
Io suppongo che Bplus ti guidi ad apprendere  traducendo un codice sorgente in un'altra struttura di codice così facendo:
1. tu sei costretta a leggere laWIKI per capire coda fa ogni parola che tu devi gestire
2. tu puoi vedere una struttura generale nel codice
3. tu puoi scegliere una struttura più leggibile
4. tu puoi cambiare la struttura aggiungendo o modificando il suo modo di funzionare
Richiede del tempo ma è un modo buono e duro di apprendere
Buona fortuna

ciao @TempodiBasic 
allora avevo capito bene devo tradurre  il programma dal codice basic a QB64
però hai detto che ci vuole del tempo per apprendere con questo metodo
allora io mi chiedo se cè un metodo più veloce per imparare a programmare
questo magari e il metodo migliore tradurre un programma in altro linguaggio?
oppure non esiste un metodo migliore?
non sia per la fretta per imparare ma è quasi 1 anno che ci giro è cercando scorciatoie magari un metodo più veloce esiste
comunque farò anche come consigliato da bplus perche credo che lui abbia imparato cosi a programmare
grazie anche alla tua attenzione e tutti i tuoi suggerimenti e un tuo commento vale tanto con la tua traduzione in italiano
Title: Re: Guess the Animal
Post by: bplus on November 08, 2020, 06:29:48 pm
Oh man! this is harder than I thought. I tried this afternoon putting it in more modern form and picked up errors. Might be easier to rewrite this from scratch, for me anyway ;-))

Title: Re: Guess the Animal
Post by: Kiara87 on November 08, 2020, 06:37:06 pm
Quote from: bplus on November 08, 2020, 06:29:48 pm
Oh man! this is harder than I thought. I tried this afternoon putting it in more modern form and picked up errors. Might be easier to rewrite this from scratch, for me anyway ;-))

you can post the work here to verify the changes made so to learn how you transformed the code
thanks
Title: Re: Guess the Animal
Post by: Dav on November 08, 2020, 06:54:08 pm
I once had a Basic code tool that converted old basic source (that needed line numbers), into prettier Qbasic source code.  It removed all line numbers that were not called on (like GOTO 110), and it cleaned up code in other ways too.  I used it often to translate old code into more modern code and it worked good.  It was called B2Q I think.  I'm going to look for it.  Could come in handy again....

- Dav.
Title: Re: Guess the Animal
Post by: bplus on November 08, 2020, 06:59:56 pm
Yeah Dav that was first thing I did. Then plugged in the list maker right in where it was called. Something happens with Question gosub when trying to redo the goto's inside it. It would help if I fully understand how it worked :)

Oh heck it might have been just a case of not being UCASE$() ;-))

Not use to seeing naked INPUT C$

OK removed non essential line numbers, moved the list of animals into main loop putting data at the end of program and capitalized all the INPUTs.

Looks like the original program is not parsing the A$() questions correctly either.

progress?
Code: QB64: [Select]
  1. PRINT TAB(32); "ANIMAL"
  2. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  4. PRINT "PLAY 'GUESS THE ANIMAL'"
  6. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  8. DIM A$(200)
  9. FOR I = 0 TO 3
  10.     READ A$(I)
  12. N = VAL(A$(0))
  13. 120 REM          MAIN CONTROL SECTION
  14. INPUT "ARE YOU THINKING OF AN ANIMAL"; A$
  15. A$ = UCASE$(A$)
  16. IF A$ = "LIST" THEN
  17.     PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  18.     X = 0
  19.     FOR I = 1 TO 200
  20.         IF LEFT$(A$(I), 2) <> "\A" THEN _CONTINUE
  21.         PRINT TAB(15 * X);
  22.         FOR Z = 3 TO LEN(A$(I))
  23.             IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  24.         NEXT Z
  25.         X = X + 1: IF X = 4 THEN X = 0: PRINT
  26.     NEXT I
  27.     PRINT
  28.     PRINT
  29.     GOTO 120
  31. IF LEFT$(A$, 1) <> "Y" THEN 120
  32. K = 1
  33. 170 GOSUB 390
  34. IF LEN(A$(K)) = 0 THEN END
  35. IF LEFT$(A$(K), 2) = "\Q" THEN 170
  36. PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  38. A$ = UCASE$(LEFT$(A$, 1))
  39. IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": GOTO 120
  40. INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  41. V$ = UCASE$(V$)
  42. PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  43. PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  45. X$ = UCASE$(X$)
  46. 280 PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  48. A$ = UCASE$(A$)
  49. A$ = LEFT$(A$, 1): IF A$ <> "Y" AND A$ <> "N" THEN 280
  50. IF A$ = "Y" THEN B$ = "N"
  51. IF A$ = "N" THEN B$ = "Y"
  52. Z1 = VAL(A$(0))
  53. A$(0) = STR$(Z1 + 2)
  54. A$(Z1) = A$(K)
  55. A$(Z1 + 1) = "\A" + V$
  56. A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  57. GOTO 120
  58. 390 REM     SUBROUTINE TO PRINT QUESTIONS
  59. Q$ = A$(K)
  60. 410 FOR Z = 3 TO LEN(Q$)
  61.     IF MID$(Q$, Z, 1) <> "\" THEN PRINT MID$(Q$, Z, 1);
  64. C$ = UCASE$(LEFT$(C$, 1))
  65. IF C$ <> "Y" AND C$ <> "N" THEN 410
  66. T$ = "\" + C$
  67. FOR X = 3 TO LEN(Q$) - 1
  68.     IF MID$(Q$, X, 2) = T$ THEN 480
  71. 480 FOR Y = X + 1 TO LEN(Q$)
  72.     IF MID$(Q$, Y, 1) = "\" THEN 510
  75. 510 K = VAL(MID$(Q$, X + 2, Y - X - 2))
  77. DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  78.  

Looks like will have to trim$ STR$(numbers) also.
Title: Re: Guess the Animal
Post by: Dav on November 08, 2020, 07:13:42 pm
 I ran the code through the remline  (https://www.qb64.org/wiki/Line_number)tool in the wiki, and here's that output. A wee bit better I guess...

- Dav

Code: QB64: [Select]
  1. PRINT TAB(32); "ANIMAL"
  2. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  4. PRINT "PLAY 'GUESS THE ANIMAL'"
  6. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  8. DIM A$(200)
  9. FOR I = 0 TO 3
  10.   90 READ A$(I)
  12. N = VAL(A$(0))
  13.  
  14. 120 REM          MAIN CONTROL SECTION
  15. INPUT "ARE YOU THINKING OF AN ANIMAL"; A$
  16. IF A$ = "LIST" THEN 600
  17. IF LEFT$(A$, 1) <> "Y" THEN 120
  18. K = 1
  19. 170 GOSUB 390
  20. IF LEN(A$(K)) = 0 THEN 999
  21. IF LEFT$(A$(K), 2) = "\Q" THEN 170
  22. PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  24. A$ = LEFT$(A$, 1)
  25. IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": GOTO 120
  26. INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  27. PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  28. PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  30. 280 PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  32. A$ = LEFT$(A$, 1): IF A$ <> "Y" AND A$ <> "N" THEN 280
  33. IF A$ = "Y" THEN B$ = "N"
  34. IF A$ = "N" THEN B$ = "Y"
  35. Z1 = VAL(A$(0))
  36. A$(0) = STR$(Z1 + 2)
  37. A$(Z1) = A$(K)
  38. A$(Z1 + 1) = "\A" + V$
  39. A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  40. GOTO 120
  41.  
  42.  
  43. 390 REM     SUBROUTINE TO PRINT QUESTIONS
  44. Q$ = A$(K)
  45. 410 FOR Z = 3 TO LEN(Q$)
  46.   415 IF MID$(Q$, Z, 1) <> "\" THEN PRINT MID$(Q$, Z, 1);
  49. C$ = LEFT$(C$, 1)
  50. IF C$ <> "Y" AND C$ <> "N" THEN 410
  51. T$ = "\" + C$
  52. FOR X = 3 TO LEN(Q$) - 1
  53.   460 IF MID$(Q$, X, 2) = T$ THEN 480
  56. 480 FOR Y = X + 1 TO LEN(Q$)
  57.   490 IF MID$(Q$, Y, 1) = "\" THEN 510
  60. 510 K = VAL(MID$(Q$, X + 2, Y - X - 2))
  62.  
  63.  
  64.  
  65. DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  66.  
  67.  
  68. 600 PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  69. X = 0
  70. FOR I = 1 TO 200
  71.   620 IF LEFT$(A$(I), 2) <> "\A" THEN 650
  72.   624 PRINT TAB(15 * X);
  73.   630 FOR Z = 3 TO LEN(A$(I))
  74.       640 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  75.   642 NEXT Z
  76.   645 X = X + 1: IF X = 4 THEN X = 0: PRINT
  77. 650 NEXT I
  80. GOTO 120
  81. 999 END
  82.  
Title: Re: Guess the Animal
Post by: Kiara87 on November 08, 2020, 07:40:14 pm
Quote from: Dav on November 08, 2020, 07:13:42 pm
I ran the code through the remline  (https://www.qb64.org/wiki/Line_number)tool in the wiki, and here's that output. A wee bit better I guess...

- Dav

Code: QB64: [Select]
  1. PRINT TAB(32); "ANIMAL"
  2. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  4. PRINT "PLAY 'GUESS THE ANIMAL'"
  6. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  8. DIM A$(200)
  9. FOR I = 0 TO 3
  10.   90 READ A$(I)
  12. N = VAL(A$(0))
  13.  
  14. 120 REM          MAIN CONTROL SECTION
  15. INPUT "ARE YOU THINKING OF AN ANIMAL"; A$
  16. IF A$ = "LIST" THEN 600
  17. IF LEFT$(A$, 1) <> "Y" THEN 120
  18. K = 1
  19. 170 GOSUB 390
  20. IF LEN(A$(K)) = 0 THEN 999
  21. IF LEFT$(A$(K), 2) = "\Q" THEN 170
  22. PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  24. A$ = LEFT$(A$, 1)
  25. IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": GOTO 120
  26. INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  27. PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  28. PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  30. 280 PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  32. A$ = LEFT$(A$, 1): IF A$ <> "Y" AND A$ <> "N" THEN 280
  33. IF A$ = "Y" THEN B$ = "N"
  34. IF A$ = "N" THEN B$ = "Y"
  35. Z1 = VAL(A$(0))
  36. A$(0) = STR$(Z1 + 2)
  37. A$(Z1) = A$(K)
  38. A$(Z1 + 1) = "\A" + V$
  39. A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  40. GOTO 120
  41.  
  42.  
  43. 390 REM     SUBROUTINE TO PRINT QUESTIONS
  44. Q$ = A$(K)
  45. 410 FOR Z = 3 TO LEN(Q$)
  46.   415 IF MID$(Q$, Z, 1) <> "\" THEN PRINT MID$(Q$, Z, 1);
  49. C$ = LEFT$(C$, 1)
  50. IF C$ <> "Y" AND C$ <> "N" THEN 410
  51. T$ = "\" + C$
  52. FOR X = 3 TO LEN(Q$) - 1
  53.   460 IF MID$(Q$, X, 2) = T$ THEN 480
  56. 480 FOR Y = X + 1 TO LEN(Q$)
  57.   490 IF MID$(Q$, Y, 1) = "\" THEN 510
  60. 510 K = VAL(MID$(Q$, X + 2, Y - X - 2))
  62.  
  63.  
  64.  
  65. DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  66.  
  67.  
  68. 600 PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  69. X = 0
  70. FOR I = 1 TO 200
  71.   620 IF LEFT$(A$(I), 2) <> "\A" THEN 650
  72.   624 PRINT TAB(15 * X);
  73.   630 FOR Z = 3 TO LEN(A$(I))
  74.       640 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  75.   642 NEXT Z
  76.   645 X = X + 1: IF X = 4 THEN X = 0: PRINT
  77. 650 NEXT I
  80. GOTO 120
  81. 999 END
  82.  

as I see the code is always the same
Title: Re: Guess the Animal
Post by: Dav on November 08, 2020, 07:47:06 pm
Quote from: Kiara87 on November 08, 2020, 07:40:14 pm
as I see the code is always the same

Yes, you are correct.  However, with the unused lines numbers removed, it may now be visually easier to start modernizing the code (I would find it easier).

- Dav
Title: Re: Guess the Animal
Post by: bplus on November 08, 2020, 07:52:12 pm
Quote from: Kiara87 on November 08, 2020, 07:40:14 pm
as I see the code is always the same

I don't see line numbers on every line.

But I see REMline leaves allot more line numbers in than I did?
Title: Re: Guess the Animal
Post by: bplus on November 08, 2020, 07:53:36 pm
Dav did you pick up on the parsing problem of the original code, look at the ends of the questions?

 
Title: Re: Guess the Animal
Post by: Dav on November 08, 2020, 07:56:03 pm
Quote from: bplus on November 08, 2020, 07:53:36 pm
Dav did you pick up on the parsing problem of the original code, look at the ends of the questions?

No I didn't - but I'll take a closer look at it....

- Dav
Title: Re: Guess the Animal
Post by: Kiara87 on November 08, 2020, 08:22:57 pm
Quote from: bplus on November 08, 2020, 07:52:12 pm
I don't see line numbers on every line.

But I see REMline leaves allot more line numbers in than I did?

REMline   i don't know this instruction i was looking in the wiki but i can't understand what it is for 
Title: Re: Guess the Animal
Post by: bplus on November 08, 2020, 08:28:01 pm
Quote from: Kiara87 on November 08, 2020, 08:22:57 pm
REMline   i don't know this instruction i was looking in the wiki but i can't understand what it is for 

Found it searching Wiki: https://www.qb64.org/wiki/Line_number

First I searched remline, nothing, then remline.bas and hit!
Title: Re: Guess the Animal
Post by: Kiara87 on November 08, 2020, 08:33:22 pm
Quote from: bplus on November 08, 2020, 08:28:01 pm
Found it searching Wiki: https://www.qb64.org/wiki/Line_number

First I searched remline, nothing, then remline.bas and hit!

only gives me error?
https://imgur.com/yXPNoeg
Title: Re: Guess the Animal
Post by: bplus on November 08, 2020, 09:30:02 pm
Quote
only gives me error?

REMline is a .bas program that needs the program name for the .BAS Source file to remove the line numbers from.

Store the remline.bas program in same folder where your .bas file is that you want to remove line numbers from.
RUN the program to compile it. (Make sure the Save EXE in same folder as Source is bulleted in the RUN menu of IDE)
Run the program again and input the name of the bas file to remove the numbers from (looks like it does quotes too.)

What I do is look for every GOTO and GOSUB and comment those line numbers then I remove all line numbers not commented then I remove comments to line numbers and make sure the program still works correctly.

Title: Re: Guess the Animal
Post by: MidnightOwl on November 09, 2020, 03:24:06 am
here is the program converted to QB64 code. I have done things like this so much that it was a piece of cake.
Code: QB64: [Select]
  1. [DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  2.  
  3. PRINT TAB(32); "ANIMAL"
  4. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  6. PRINT "PLAY 'GUESS THE ANIMAL'"
  8. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  10. DIM SHARED A$(200), K, N, T$
  11. FOR I = 0 TO 3
  12.    90 READ A$(I)
  14. N = VAL(A$(0))
  15.  
  16. MAIN
  18.  
  19. '         MAIN CONTROL SECTION
  20. SUB MAIN ()
  21.     DO
  22.         DO
  23.             INPUT "ARE YOU THINKING OF AN ANIMAL (Y/N)"; A$: A$ = UCASE$(A$)
  24.         LOOP UNTIL A$ = "LIST" OR LEFT$(A$, 1) = "Y" OR LEFT$(A$, 1) = "N"
  25.         IF A$ = "LIST" THEN SHOWLIST: MAIN
  26.         IF LEFT$(A$, 1) = "N" THEN SYSTEM
  27.         K = 1
  28.         DO
  29.             SHOWQUESTION
  30.             IF LEN(A$(K)) = 0 THEN SYSTEM
  31.         LOOP WHILE LEFT$(A$(K), 2) = "\Q"
  32.         PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  33.         INPUT A$
  34.         A$ = LEFT$(A$, 1)
  35.         IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": MAIN
  36.         INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  37.         PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  38.         PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  39.         INPUT X$
  40.         DO
  41.             PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  42.             INPUT A$
  43.         A$ = LEFT$(A$, 1): LOOP UNTIL A$ = "Y" OR A$ = "N"
  44.         IF A$ = "Y" THEN B$ = "N"
  45.         IF A$ = "N" THEN B$ = "Y"
  46.         Z1 = VAL(A$(0))
  47.         A$(0) = STR$(Z1 + 2)
  48.         A$(Z1) = A$(K)
  49.         A$(Z1 + 1) = "\A" + V$
  50.         A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  51.     LOOP
  53.  
  54. '  SUBROUTINE TO PRINT QUESTIONS
  55. SUB SHOWQUESTION ()
  56.     Q$ = A$(K)
  57.     DO
  58.         FOR Z = 3 TO LEN(Q$)
  59.             IF MID$(Q$, Z, 1) = "\" THEN EXIT FOR ELSE PRINT MID$(Q$, Z, 1);
  60.         NEXT Z
  61.         INPUT C$: C$ = UCASE$(C$)
  62.         C$ = LEFT$(C$, 1)
  63.     LOOP UNTIL C$ = "Y" OR C$ = "N"
  64.     T$ = "\" + C$
  65.     FOR X = 3 TO LEN(Q$) - 1
  66.         IF MID$(Q$, X, 2) = T$ THEN EXIT FOR
  67.     NEXT X
  68.     FOR Y = X + 1 TO LEN(Q$)
  69.         IF MID$(Q$, Y, 1) = "\" THEN EXIT FOR
  70.     NEXT Y
  71.     K = VAL(MID$(Q$, X + 2, Y - X - 2))
  73.  
  74. SUB SHOWLIST ()
  75.     PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  76.     X = 0
  77.     FOR I = 1 TO 200
  78.        620 IF LEFT$(A$(I), 2) = "\A" THEN
  79.            624 PRINT TAB(15 * X);
  80.            630 FOR Z = 3 TO LEN(A$(I))
  81.                640 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  82.            642 NEXT Z
  83.            645 X = X + 1: IF X = 4 THEN X = 0: PRINT
  84.         END IF
  85.     NEXT I
  86.     PRINT
  87.     PRINT
  89.  
  90.  
  91.  
  92. /code]
Title: Re: Guess the Animal
Post by: MidnightOwl on November 09, 2020, 07:06:37 am
Here is a version that saves a data file so that the program doesn't forget what it learned
Code: QB64: [Select]
  1. DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  2.  
  3. PRINT TAB(32); "ANIMAL"
  4. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  6. PRINT "PLAY 'GUESS THE ANIMAL'"
  8. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  10. DIM SHARED A$(200), K, N, T$
  11. ON ERROR GOTO NOFILE
  12. OPEN "ANIMAL.DAT" FOR INPUT AS #3
  13. FOR I = 0 TO 200
  14.     INPUT #3, A$(I)
  17. NOFILE:
  18. FOR I = 0 TO 3
  19.     READ A$(I)
  22.  
  23. N = VAL(A$(0))
  24.  
  25. MAIN
  27.  
  28. '         MAIN CONTROL SECTION
  29. SUB MAIN ()
  30.     DO
  31.         DO
  32.             INPUT "ARE YOU THINKING OF AN ANIMAL (Y/N)"; A$: A$ = UCASE$(A$)
  33.         LOOP UNTIL A$ = "LIST" OR LEFT$(A$, 1) = "Y" OR LEFT$(A$, 1) = "N"
  34.         IF A$ = "LIST" THEN SHOWLIST: MAIN
  35.         IF LEFT$(A$, 1) = "N" THEN KEEPDATA: SYSTEM
  36.         K = 1
  37.         DO
  38.             SHOWQUESTION
  39.             IF LEN(A$(K)) = 0 THEN KEEPDATA: SYSTEM
  40.         LOOP WHILE LEFT$(A$(K), 2) = "\Q"
  41.         PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  42.         INPUT A$
  43.         A$ = LEFT$(A$, 1)
  44.         IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": MAIN
  45.         INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  46.         PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  47.         PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  48.         INPUT X$
  49.         DO
  50.             PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  51.             INPUT A$
  52.         A$ = LEFT$(A$, 1): LOOP UNTIL A$ = "Y" OR A$ = "N"
  53.         IF A$ = "Y" THEN B$ = "N"
  54.         IF A$ = "N" THEN B$ = "Y"
  55.         Z1 = VAL(A$(0))
  56.         A$(0) = STR$(Z1 + 2)
  57.         A$(Z1) = A$(K)
  58.         A$(Z1 + 1) = "\A" + V$
  59.         A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  60.     LOOP
  62.  
  63. '  SUBROUTINE TO PRINT QUESTIONS
  64. SUB SHOWQUESTION ()
  65.     Q$ = A$(K)
  66.     DO
  67.         FOR Z = 3 TO LEN(Q$)
  68.             IF MID$(Q$, Z, 1) = "\" THEN EXIT FOR ELSE PRINT MID$(Q$, Z, 1);
  69.         NEXT Z
  70.         INPUT C$: C$ = UCASE$(C$)
  71.         C$ = LEFT$(C$, 1)
  72.     LOOP UNTIL C$ = "Y" OR C$ = "N"
  73.     T$ = "\" + C$
  74.     FOR X = 3 TO LEN(Q$) - 1
  75.         IF MID$(Q$, X, 2) = T$ THEN EXIT FOR
  76.     NEXT X
  77.     FOR Y = X + 1 TO LEN(Q$)
  78.         IF MID$(Q$, Y, 1) = "\" THEN EXIT FOR
  79.     NEXT Y
  80.     K = VAL(MID$(Q$, X + 2, Y - X - 2))
  82.  
  83. SUB SHOWLIST ()
  84.     PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  85.     X = 0
  86.     FOR I = 1 TO 200
  87.         IF LEFT$(A$(I), 2) = "\A" THEN
  88.             PRINT TAB(15 * X);
  89.             FOR Z = 3 TO LEN(A$(I))
  90.                 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  91.             NEXT Z
  92.             X = X + 1: IF X = 4 THEN X = 0: PRINT
  93.         END IF
  94.     NEXT I
  95.     PRINT
  96.     PRINT
  98.  
  99. '        SUBROUTINE TO SAVE DATA FILE
  100. SUB KEEPDATA ()
  101.     OPEN "ANIMAL.DAT" FOR OUTPUT AS #2
  102.     FOR I = 0 TO 200
  103.         WRITE #2, A$(I)
  104.     NEXT I
  105.     CLOSE #2
Title: Re: Guess the Animal
Post by: Kiara87 on November 09, 2020, 08:01:26 am
Quote from: MidnightOwl on November 09, 2020, 07:06:37 am
Here is a version that saves a data file so that the program doesn't forget what it learned
Code: QB64: [Select]
  1. DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  2.  
  3. PRINT TAB(32); "ANIMAL"
  4. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  6. PRINT "PLAY 'GUESS THE ANIMAL'"
  8. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  10. DIM SHARED A$(200), K, N, T$
  11. ON ERROR GOTO NOFILE
  12. OPEN "ANIMAL.DAT" FOR INPUT AS #3
  13. FOR I = 0 TO 200
  14.     INPUT #3, A$(I)
  17. NOFILE:
  18. FOR I = 0 TO 3
  19.     READ A$(I)
  22.  
  23. N = VAL(A$(0))
  24.  
  25. MAIN
  27.  
  28. '         MAIN CONTROL SECTION
  29. SUB MAIN ()
  30.     DO
  31.         DO
  32.             INPUT "ARE YOU THINKING OF AN ANIMAL (Y/N)"; A$: A$ = UCASE$(A$)
  33.         LOOP UNTIL A$ = "LIST" OR LEFT$(A$, 1) = "Y" OR LEFT$(A$, 1) = "N"
  34.         IF A$ = "LIST" THEN SHOWLIST: MAIN
  35.         IF LEFT$(A$, 1) = "N" THEN KEEPDATA: SYSTEM
  36.         K = 1
  37.         DO
  38.             SHOWQUESTION
  39.             IF LEN(A$(K)) = 0 THEN KEEPDATA: SYSTEM
  40.         LOOP WHILE LEFT$(A$(K), 2) = "\Q"
  41.         PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  42.         INPUT A$
  43.         A$ = LEFT$(A$, 1)
  44.         IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": MAIN
  45.         INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  46.         PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  47.         PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  48.         INPUT X$
  49.         DO
  50.             PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  51.             INPUT A$
  52.         A$ = LEFT$(A$, 1): LOOP UNTIL A$ = "Y" OR A$ = "N"
  53.         IF A$ = "Y" THEN B$ = "N"
  54.         IF A$ = "N" THEN B$ = "Y"
  55.         Z1 = VAL(A$(0))
  56.         A$(0) = STR$(Z1 + 2)
  57.         A$(Z1) = A$(K)
  58.         A$(Z1 + 1) = "\A" + V$
  59.         A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  60.     LOOP
  62.  
  63. '  SUBROUTINE TO PRINT QUESTIONS
  64. SUB SHOWQUESTION ()
  65.     Q$ = A$(K)
  66.     DO
  67.         FOR Z = 3 TO LEN(Q$)
  68.             IF MID$(Q$, Z, 1) = "\" THEN EXIT FOR ELSE PRINT MID$(Q$, Z, 1);
  69.         NEXT Z
  70.         INPUT C$: C$ = UCASE$(C$)
  71.         C$ = LEFT$(C$, 1)
  72.     LOOP UNTIL C$ = "Y" OR C$ = "N"
  73.     T$ = "\" + C$
  74.     FOR X = 3 TO LEN(Q$) - 1
  75.         IF MID$(Q$, X, 2) = T$ THEN EXIT FOR
  76.     NEXT X
  77.     FOR Y = X + 1 TO LEN(Q$)
  78.         IF MID$(Q$, Y, 1) = "\" THEN EXIT FOR
  79.     NEXT Y
  80.     K = VAL(MID$(Q$, X + 2, Y - X - 2))
  82.  
  83. SUB SHOWLIST ()
  84.     PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  85.     X = 0
  86.     FOR I = 1 TO 200
  87.         IF LEFT$(A$(I), 2) = "\A" THEN
  88.             PRINT TAB(15 * X);
  89.             FOR Z = 3 TO LEN(A$(I))
  90.                 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  91.             NEXT Z
  92.             X = X + 1: IF X = 4 THEN X = 0: PRINT
  93.         END IF
  94.     NEXT I
  95.     PRINT
  96.     PRINT
  98.  
  99. '        SUBROUTINE TO SAVE DATA FILE
  100. SUB KEEPDATA ()
  101.     OPEN "ANIMAL.DAT" FOR OUTPUT AS #2
  102.     FOR I = 0 TO 200
  103.         WRITE #2, A$(I)
  104.     NEXT I
  105.     CLOSE #2

big thank you for transforming the program

this is what bplus intends to translate the code from one structure to another structure

obviously for those who do not have much practice it is more tiring

but i will try to study above and thanks for translating the program
Title: Re: Guess the Animal
Post by: bplus on November 09, 2020, 11:11:21 am
Quote from: MidnightOwl on November 09, 2020, 07:06:37 am
Here is a version that saves a data file so that the program doesn't forget what it learned
Code: QB64: [Select]
  1. DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  2.  
  3. PRINT TAB(32); "ANIMAL"
  4. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  6. PRINT "PLAY 'GUESS THE ANIMAL'"
  8. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  10. DIM SHARED A$(200), K, N, T$
  11. ON ERROR GOTO NOFILE
  12. OPEN "ANIMAL.DAT" FOR INPUT AS #3
  13. FOR I = 0 TO 200
  14.     INPUT #3, A$(I)
  17. NOFILE:
  18. FOR I = 0 TO 3
  19.     READ A$(I)
  22.  
  23. N = VAL(A$(0))
  24.  
  25. MAIN
  27.  
  28. '         MAIN CONTROL SECTION
  29. SUB MAIN ()
  30.     DO
  31.         DO
  32.             INPUT "ARE YOU THINKING OF AN ANIMAL (Y/N)"; A$: A$ = UCASE$(A$)
  33.         LOOP UNTIL A$ = "LIST" OR LEFT$(A$, 1) = "Y" OR LEFT$(A$, 1) = "N"
  34.         IF A$ = "LIST" THEN SHOWLIST: MAIN
  35.         IF LEFT$(A$, 1) = "N" THEN KEEPDATA: SYSTEM
  36.         K = 1
  37.         DO
  38.             SHOWQUESTION
  39.             IF LEN(A$(K)) = 0 THEN KEEPDATA: SYSTEM
  40.         LOOP WHILE LEFT$(A$(K), 2) = "\Q"
  41.         PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  42.         INPUT A$
  43.         A$ = LEFT$(A$, 1)
  44.         IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": MAIN
  45.         INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  46.         PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  47.         PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  48.         INPUT X$
  49.         DO
  50.             PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  51.             INPUT A$
  52.         A$ = LEFT$(A$, 1): LOOP UNTIL A$ = "Y" OR A$ = "N"
  53.         IF A$ = "Y" THEN B$ = "N"
  54.         IF A$ = "N" THEN B$ = "Y"
  55.         Z1 = VAL(A$(0))
  56.         A$(0) = STR$(Z1 + 2)
  57.         A$(Z1) = A$(K)
  58.         A$(Z1 + 1) = "\A" + V$
  59.         A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  60.     LOOP
  62.  
  63. '  SUBROUTINE TO PRINT QUESTIONS
  64. SUB SHOWQUESTION ()
  65.     Q$ = A$(K)
  66.     DO
  67.         FOR Z = 3 TO LEN(Q$)
  68.             IF MID$(Q$, Z, 1) = "\" THEN EXIT FOR ELSE PRINT MID$(Q$, Z, 1);
  69.         NEXT Z
  70.         INPUT C$: C$ = UCASE$(C$)
  71.         C$ = LEFT$(C$, 1)
  72.     LOOP UNTIL C$ = "Y" OR C$ = "N"
  73.     T$ = "\" + C$
  74.     FOR X = 3 TO LEN(Q$) - 1
  75.         IF MID$(Q$, X, 2) = T$ THEN EXIT FOR
  76.     NEXT X
  77.     FOR Y = X + 1 TO LEN(Q$)
  78.         IF MID$(Q$, Y, 1) = "\" THEN EXIT FOR
  79.     NEXT Y
  80.     K = VAL(MID$(Q$, X + 2, Y - X - 2))
  82.  
  83. SUB SHOWLIST ()
  84.     PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  85.     X = 0
  86.     FOR I = 1 TO 200
  87.         IF LEFT$(A$(I), 2) = "\A" THEN
  88.             PRINT TAB(15 * X);
  89.             FOR Z = 3 TO LEN(A$(I))
  90.                 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  91.             NEXT Z
  92.             X = X + 1: IF X = 4 THEN X = 0: PRINT
  93.         END IF
  94.     NEXT I
  95.     PRINT
  96.     PRINT
  98.  
  99. '        SUBROUTINE TO SAVE DATA FILE
  100. SUB KEEPDATA ()
  101.     OPEN "ANIMAL.DAT" FOR OUTPUT AS #2
  102.     FOR I = 0 TO 200
  103.         WRITE #2, A$(I)
  104.     NEXT I
  105.     CLOSE #2

Nice! you fixed the parsing problem for asking the questions and converted everything to SUBs AND saved the new learning to file!  I recommend UCASE$ conversions for all INPUTs so can type INPUTs in lower case and will be automatically converted to upper and remain consistent to the other parts of program.

 

See? the dog lesson didn't take though it did ask the right question, it thinks it hasn't guessed it yet.

Ha! I've still not analysed the structure to the A$() array, I wanted to see how that N got used at the start, looks like MidnightOwl... no  he SHARED it along with some others with his SUBs.

Oh there's the data, right at the top, allready to go if a file hadn't been started yet!
Now what does file look like after I started dog?

Animal.DAT the saved lesson on DOG, I see N is increased to 6
Quote
" 6"
"\QDOES IT SWIM\Y2\N3\"
"\AFISH"
"\QDOES IT FLY\N 5\Y 4\"
"\ABIRD"
"\ADOG"

So N is left at A$(0) and tracks the last line number in the file or A$() array. I still need to go over structure for storing data in array. MidnightOwl had to solve all that.


So how do we get practice for Kiara using arrays and then SUBs and FUNCTIONs? This might have been too hard but maybe a demo of what you can do with some practice behind you.

All newbies need this practice, they are the bigger hurdles for novice.





Title: Re: Guess the Animal
Post by: bplus on November 09, 2020, 11:31:48 am
I just added UCASE$ to all INPUTs of MidnightOwl's transformed code:

Code: QB64: [Select]
  1.  
  2. DATA "4","\QDOES IT SWIM\Y2\N3\","\AFISH","\ABIRD"
  3.  
  4. PRINT TAB(32); "ANIMAL"
  5. PRINT TAB(15); "CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY"
  7. PRINT "PLAY 'GUESS THE ANIMAL'"
  9. PRINT "THINK OF AN ANIMAL AND THE COMPUTER WILL TRY TO GUESS IT."
  11. DIM SHARED A$(200), K, N, T$
  12. ON ERROR GOTO NOFILE
  13. OPEN "ANIMAL.DAT" FOR INPUT AS #3
  14. FOR I = 0 TO 200
  15.     INPUT #3, A$(I)
  18. NOFILE:
  19. FOR I = 0 TO 3
  20.     READ A$(I)
  23.  
  24. N = VAL(A$(0))
  25.  
  26. MAIN
  28.  
  29. '         MAIN CONTROL SECTION
  30. SUB MAIN ()
  31.     DO
  32.         DO
  33.             INPUT "ARE YOU THINKING OF AN ANIMAL (Y/N)"; A$: A$ = UCASE$(A$)
  34.         LOOP UNTIL A$ = "LIST" OR LEFT$(A$, 1) = "Y" OR LEFT$(A$, 1) = "N"
  35.         IF A$ = "LIST" THEN SHOWLIST: MAIN
  36.         IF LEFT$(A$, 1) = "N" THEN KEEPDATA: SYSTEM
  37.         K = 1
  38.         DO
  39.             SHOWQUESTION
  40.             IF LEN(A$(K)) = 0 THEN KEEPDATA: SYSTEM
  41.         LOOP WHILE LEFT$(A$(K), 2) = "\Q"
  42.         PRINT "IS IT A "; RIGHT$(A$(K), LEN(A$(K)) - 2);
  43.         INPUT A$
  44.         A$ = UCASE$(LEFT$(A$, 1)) '<<<<<<<<<<<<<<  fix to ucase$
  45.         IF LEFT$(A$, 1) = "Y" THEN PRINT "WHY NOT TRY ANOTHER ANIMAL?": MAIN
  46.         INPUT "THE ANIMAL YOU WERE THINKING OF WAS A "; V$
  47.         V$ = UCASE$(V$) '<<<<<<<<<<<<<<  fix to ucase$
  48.         PRINT "PLEASE TYPE IN A QUESTION THAT WOULD DISTINGUISH A"
  49.         PRINT V$; " FROM A "; RIGHT$(A$(K), LEN(A$(K)) - 2)
  50.         INPUT X$
  51.         X$ = UCASE$(X$) '<<<<<<<<<<<<<<  fix to ucase$
  52.         DO
  53.             PRINT "FOR A "; V$; " THE ANSWER WOULD BE ";
  54.             INPUT A$
  55.             A$ = UCASE$(A$) '<<<<<<<<<<<<<<  fix to ucase$
  56.         A$ = LEFT$(A$, 1): LOOP UNTIL A$ = "Y" OR A$ = "N"
  57.         IF A$ = "Y" THEN B$ = "N"
  58.         IF A$ = "N" THEN B$ = "Y"
  59.         Z1 = VAL(A$(0))
  60.         A$(0) = STR$(Z1 + 2)
  61.         A$(Z1) = A$(K)
  62.         A$(Z1 + 1) = "\A" + V$
  63.         A$(K) = "\Q" + X$ + "\" + A$ + STR$(Z1 + 1) + "\" + B$ + STR$(Z1) + "\"
  64.     LOOP
  66.  
  67. '  SUBROUTINE TO PRINT QUESTIONS
  68. SUB SHOWQUESTION ()
  69.     Q$ = A$(K)
  70.     DO
  71.         FOR Z = 3 TO LEN(Q$)
  72.             IF MID$(Q$, Z, 1) = "\" THEN EXIT FOR ELSE PRINT MID$(Q$, Z, 1);
  73.         NEXT Z
  74.         INPUT C$: C$ = UCASE$(C$)
  75.         C$ = LEFT$(C$, 1)
  76.     LOOP UNTIL C$ = "Y" OR C$ = "N"
  77.     T$ = "\" + C$
  78.     FOR X = 3 TO LEN(Q$) - 1
  79.         IF MID$(Q$, X, 2) = T$ THEN EXIT FOR
  80.     NEXT X
  81.     FOR Y = X + 1 TO LEN(Q$)
  82.         IF MID$(Q$, Y, 1) = "\" THEN EXIT FOR
  83.     NEXT Y
  84.     K = VAL(MID$(Q$, X + 2, Y - X - 2))
  86.  
  87. SUB SHOWLIST ()
  88.     PRINT: PRINT "ANIMALS I ALREADY KNOW ARE:"
  89.     X = 0
  90.     FOR I = 1 TO 200
  91.         IF LEFT$(A$(I), 2) = "\A" THEN
  92.             PRINT TAB(15 * X);
  93.             FOR Z = 3 TO LEN(A$(I))
  94.                 IF MID$(A$(I), Z, 1) <> "\" THEN PRINT MID$(A$(I), Z, 1);
  95.             NEXT Z
  96.             X = X + 1: IF X = 4 THEN X = 0: PRINT
  97.         END IF
  98.     NEXT I
  99.     PRINT
  100.     PRINT
  102.  
  103. '        SUBROUTINE TO SAVE DATA FILE
  104. SUB KEEPDATA ()
  105.     OPEN "ANIMAL.DAT" FOR OUTPUT AS #2
  106.     FOR I = 0 TO 200
  107.         WRITE #2, A$(I)
  108.     NEXT I
  109.     CLOSE #2
  111.  
  112.  
Title: Re: Guess the Animal
Post by: Kiara87 on November 09, 2020, 03:42:14 pm
Quote from: bplus on November 08, 2020, 09:30:02 pm
REMline is a .bas program that needs the program name for the .BAS Source file to remove the line numbers from.

Store the remline.bas program in same folder where your .bas file is that you want to remove line numbers from.
RUN the program to compile it. (Make sure the Save EXE in same folder as Source is bulleted in the RUN menu of IDE)
Run the program again and input the name of the bas file to remove the numbers from (looks like it does quotes too.)

What I do is look for every GOTO and GOSUB and comment those line numbers then I remove all line numbers not commented then I remove comments to line numbers and make sure the program still works correctly.

now i understand REMLINE  thanks
Title: Re: Guess the Animal
Post by: bplus on November 10, 2020, 09:01:46 pm
Complete makeover from 73 Lines of Code (LOC) to 64! More traces of old style removed including all CAPITALIZATION.

Code: QB64: [Select]
  1. _TITLE "Guess Animal - QB64 Conversion of Morristown Version" 'watching LOC, see code notes at bottom
  2. REDIM A$(200)
  3. L$ = CHR$(10) ' L is for line or next line
  4. PRINT L$ + SPC(35) + "Guess Animal" + L$ + L$ + SPC(11) + "Originally from: CREATIVE COMPUTING  MORRISTOWN, NEW JERSEY" + L$ + L$ + L$
  5. PRINT " Think of an animal and the computer will try and guess it." + L$
  6. IF _FILEEXISTS("ANIMAL.DAT") THEN
  7.     OPEN "ANIMAL.DAT" FOR INPUT AS #3
  8.     FOR I = 0 TO 200
  9.         INPUT #3, A$(I)
  10.     NEXT
  11.     CLOSE #3
  13.     FOR I = 0 TO 3
  14.         READ A$(I)
  15.     NEXT I
  17. N = VAL(A$(0))
  19.     DO
  20.         A$ = LCASE$(npt$(L$ + " Are you thinking of an animal (y/n/list)"))
  21.         IF A$ = "list" THEN
  22.             PRINT L$ + " Animals I already know are:" ' listing computers aimals
  23.             FOR I = 1 TO 200
  24.                 IF LEFT$(A$(I), 2) = "\A" THEN PRINT "   " + MID$(A$(I), 3),
  25.             NEXT I
  26.             PRINT L$ + L$
  27.         END IF
  28.     LOOP UNTIL LEFT$(A$, 1) = "y" OR LEFT$(A$, 1) = "n"
  29.     IF LEFT$(A$, 1) = "n" THEN EXIT DO 'bug out main DO doesn't want to play
  30.     K = 1
  31.     WHILE LEFT$(A$(K), 2) = "\Q"
  32.         Q$ = A$(K)
  33.         DO 'parse question and use as prompt to get c$
  34.             C$ = UCASE$(LEFT$(npt$(" " + MID$(Q$, 3, INSTR(3, Q$, "\") - 3)), 1))
  35.         LOOP UNTIL C$ = "Y" OR C$ = "N"
  36.         X = INSTR(3, LEFT$(Q$, LEN(Q$) - 1), "\" + C$)
  37.         Y = INSTR(X + 1, Q$, "\")
  38.         K = VAL(MID$(Q$, X + 2, Y - X - 2))
  39.         IF LEN(A$(K)) = 0 THEN EXIT DO ' bug out of main DO loop, out of questions
  40.     WEND
  41.     A$ = UCASE$(npt$(" Is it a " + RIGHT$(A$(K), LEN(A$(K)) - 2)))
  42.     IF LEFT$(A$, 1) = "Y" THEN PRINT " Why not try another animal?": _CONTINUE 'skip rest of this loop
  43.     V$ = LCASE$(npt$(" The animal you were thinking of is a "))
  44.     X$ = npt$(" Please type a question that would distinguish a " + V$ + " from a " + RIGHT$(A$(K), LEN(A$(K)) - 2))
  45.     DO
  46.         A$ = UCASE$(LEFT$(npt$(" For a " + V$ + " the answer would be "), 1))
  47.     LOOP UNTIL A$ = "Y" OR A$ = "N"
  48.     IF A$ = "Y" THEN B$ = "N" ELSE B$ = "Y"
  49.     Z1 = VAL(A$(0))
  50.     A$(0) = _TRIM$(STR$(Z1 + 2))
  51.     A$(Z1) = A$(K)
  52.     A$(Z1 + 1) = "\A" + V$
  53.     A$(K) = "\Q" + X$ + "\" + A$ + _TRIM$(STR$(Z1 + 1)) + "\" + B$ + _TRIM$(STR$(Z1)) + "\"
  55. OPEN "ANIMAL.DAT" FOR OUTPUT AS #2
  56. FOR I = 0 TO 200
  57.     WRITE #2, A$(I)
  60. DATA "4","\QDoes it live in water\Y2\N3\","\Afish","\Abird"
  61. FUNCTION npt$ (prompt$) ' nice way to get more variable data into the prompt!
  62.     PRINT prompt$;
  63.     INPUT npt$
  65.  
  66. '===================================== Code Notes down here to watch LOC of this app =======================================
  67.  
  68. ' 2020-11-10 b+ Makeover = 2nd go at Midnight Owl's great start on conversion
  69. ' note: first mod of Midnight's converstion added UCASE$ to all INPUTs solving a little user friendly problem.
  70. ' 2020-11-10 A step further was to revise PRINT prompt : INPUT A$ : UCASE$(A$) into a single function.
  71. ' Then one time call sub routines I put back into main code includeing the MAIN SUB!
  72. ' That includes: the LIST animals SUB for LIST option (which I made known in prompt).
  73. ' The SHOW QUESTION SUB and the KEEPDATA SUB.
  74. ' I also removed the ON error and used more modern check _FILEEXISTS
  75.  
  76. ' savings: admittedly some of this makes understanding of code less clear
  77. ' for X, Y use INSTR to skip FOR... NEXT loops
  78.  
  79. ' From this:
  80. ' T$ = "\" + C$
  81. ' FOR X = 3 TO LEN(Q$) - 1
  82. '     IF MID$(Q$, X, 2) = T$ THEN EXIT FOR
  83. ' NEXT X
  84.  
  85. ' to this
  86. ' X = INSTR(3, LEFT$(Q$, LEN(Q$) - 1), "\" + C$)
  87.  
  88. ' and from this
  89. ' FOR Y = X + 1 TO LEN(Q$)
  90. '     IF MID$(Q$, Y, 1) = "\" THEN EXIT FOR
  91. ' NEXT Y
  92. ' to this!
  93. ' Y = INSTR(X + 1, Q$, "\")
  94.  
  95. ' I decided to get rid of all the CAPITALIZATION and make normal looking sentences. So I modified the INPUT Function
  96. ' renaming it npt$ (input$ without vowels). Now if you want all caps use: UCASE$(npt$(prompt$)), same for lower
  97. ' case. Since humans swim I changed the first question: Does it live in water? Now how would you answer that for beaver?
  98. ' I hope not yes :) Nor do beavers or rabbits hibernate, I am learning myself!
  99. ' 2020-11-10 post 64 LOC down from original 73, not bad since it is complete makeover.
  100.  
  101.  



Text Only | Text with Attachments