Post by: Petr on June 22, 2020, 04:40:26 pm
I will develop individual functions gradually. For a start, I had to solve the most basic thing. Select the folder that is the root. The search will start from it. To make this possible on network drives as well, I chose our wiki on QB64 and used the windows dialog. The same then to get a short name. This is required for compatibility if, for example, the music album contains unicode characters in the name.
Here is the absolute beginning: Selecting a folder. No mask filtering yet. Several libraries are used, including the SteveMcNeill DirEntry library. This will be absolutely crucial in this program.
Code: QB64: [Select]
- TYPE FileList
- Path$ = SelectDIR$
- SPath$ = ShortName$(Path$) ' is need for access to files and directories, which use unicode characters in name
- PRINT Path$, SPath$
- CHDIR SPath$ ' if short name not exists, function ShortName return long name as result.
- mask$ = "AVI,MPG,MKV,MPG,MPEG,WAV,ACC,MP4,MP3,MP2,VOC,S3M,MOD,XM,TS,MOV,AC3,WMA,WMV,FLAC"
- SearchFiles mask$, files_found()
- PrintIt FileNew(), DirNew()
- _DELAY .1
- _DELAY 1
- _DELAY .1
- DirCount = 0: FileCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- close_dir
- FUNCTION SelectDIR$
- hwnd& = _WINDOWHANDLE
- TYPE BROWSEINFO ' typedef struct _browseinfo 'Microsoft MSDN
- b.hwndOwner = hwnd
- o = SHBrowseForFolder(b)
- ' Path$ = LEFT$(s$, INSTR(s$, CHR$(0)) - 1)
- PRINT "Directory not selected, using current directory"
- SelectDIR$ = _CWD$
Post by: SMcNeill on June 22, 2020, 07:11:54 pm
Code: [Select]
IF _FILEEXISTS("C:\ProgramData\PhotoList.txt") = 0 OR AlwaysRefreshListing THEN
'will create the new listing if your directory doesn't contain one,
'OR, will create one every time you run the program, if you set the flag to make it do so.
PhotoList$ = PhotoFolder + "*.bmp " + PhotoFolder + "*.jpg " + PhotoFolder + "*.png " + PhotoFolder + "*.gif "
SHELL "DIR " + PhotoList$ + "/b /s /a-d >C:\ProgramData\PhotoList.txt"
END IFIf you look at my little wallpaper changer, you'll see the above is the simple way I use to get my various image files. https://www.qb64.org/forum/index.php?topic=1008.msg112746#msg112746
It's about as short and simple of a process as you can get, and might work sufficiently enough for your needs. ;)
Post by: Petr on June 24, 2020, 04:27:24 pm
Post by: bplus on June 24, 2020, 05:12:40 pm
Just to clarify, are you going for cross platform solution which uses DirEntry, I think, or Windows only with Shell (which works fine for Windows users) or a Windows File Dialog like what Spriggsy helped me with recently?
Post by: Petr on June 24, 2020, 06:45:05 pm
I cheered prematurely. DIR turned out to be - nice bitch again. He works nicely. NO UNICODE characters in filenames! He replaces unicode characters beautifully with SPACES!!!
I'm really pissed. BPlus, I'll start all over again. Absolutely again. I will use DIRENTRY.H which means that I will really have to write a directory listing function. None DIR. This time I'll make it compatible with Linux. (Windows begin stay as is now, in Linux i'll write special SUB using ls for folder finding)
Post by: bplus on June 24, 2020, 07:16:13 pm
It might do to replace FILES statement.
Code: QB64: [Select]
- ' direntry.h needs to be in QB64 folder
- 'D$ = _CWD$
- D$ = "C:\\"
- GetFileList D$, Dir(), File()
- DirCount = 0: FileCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- close_dir
Post by: SMcNeill on June 24, 2020, 08:07:48 pm
IF load_dir(SearchDirectory) THEN
....
close_dir
ELSE
END IF
You have a call to load a directory, but if it fails, you don't have a call to try and close it. (Notice the lack of close_dir in the ELSE statement?)
Try moving that close_dir AFTER the END IF and see if your issue with multiple calls clears up.
Post by: bplus on June 24, 2020, 09:15:35 pm
Update:
That's it! It is working well now. BIG THANKYOU! SMcNeill :)
I do run into snags when I try directories Windows doesn't want me in like Cookies and there is a little snag when I reach C:\\Users\(me) and try to go up, getting 0 selections so nowhere to go. Try 0 anyway, I hacked a little fixer for such events, or when you have to exit the Directory Selection List. Hopefully you can figure it out as you go, nothing crashes like before.
Now maybe Tiny Navigator is cross platform (The majority of this code is for selecting items from large array lists, select by mouse, arrows, page up/dwn, home end, and enter, or type in number and enter as I recall from 10 months ago (Yes, I recall correctly)):
Code: QB64: [Select]
- ' B+ started 2019-08-22 restart 2020-06-24
- ' 2019-08-22 orig post at https://www.qb64.org/forum/index.php?topic=1646.msg108682#msg108682
- ' 2019-08-23_13-25 try fix (to nav all directories) with one place for tmpFile, theory can't write files in some dir's
- ' For some reason Windows won't write to a fully pathed file in my user folder???from a SHELL command
- ' Try testing if dir exists "C:\temp" exists and making one if not, yes! and I can write my temp files there
- ' and now I can chDir anywhere!!!!
- ' 2019-08-23_14-25 Take Steve's Advice to use users tmp directory for temp files
- ' 2019-08-23_23+ Have files window working for file selection
- ' ============================================ all above using SHELL to get lists
- ' 2020-06-24 restart using DirEntry.h, wow looks like Steve's fix helped ALLOT! Thanks SMcNeill
- ' I am hitting glitches where Windows wont let me access I think. So I am offering a c enter option
- ' to restart at the root but this might not work cross platform.
- ' direntry.h needs to be in QB64 folder
- _TITLE "Tiny Navigator using DirEntry: press f to Start a Select a File list of current directory"
- mySelection& = getArrayItemNumber&(5, 5, 50, 30, DIRs())
- PRINT "You selected a file: "; selectedFile
- INPUT "Press enter to continue navigator, any + enter to quit... "; done$
- selectedFile = ""
- PRINT "Nothing selected."
- PRINT "There are some places your OS might not allow us to go."
- PRINT "If you get stuck with 0 slections, press c (for root C:\\) enter..."
- INPUT "Press enter to continue navigator, any + enter to quit... "; done$
- _LIMIT 60
- DIM nam$
- DirCount = 0: FileCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- 'close_dir 'move to after end if might correct the multi calls problem
- close_dir 'this might correct the multi calls problem
- ' "Escape returns -1719 to allow a Cancel function and signal no slection."
- 'Notes: locateRow, locateColumn for top right corner of selection box on screen in characters for LOCATE.
- 'boxWidth and boxHeight are in character units, again for locate and print at correct places.
- 'All displaying is restricted to inside the box, which has PgUP and PgDn as top and bottom lines in the display.
- 'save old settings to restore at end ofsub
- curRow = CSRLIN
- fg = _DEFAULTCOLOR
- bg = _BACKGROUNDCOLOR
- maxWidth = boxWidth ' number of characters in box
- maxHeight = boxHeight - 2 ' number of lines displayed of array at one time = 1 page
- page = 0
- hlite = 0 ' line in display ready for selection by spacebar or if no number is started, enter
- GOSUB update ' show the beginning of the array items for selection
- 'signal cancel selection process, exit sub with this unlikely index to signal canel
- choice = -1719 'primes 7 and 8, not likely to be a select index of an array
- DO 'until get a selection or demand exit
- 'handle the key stuff
- kh& = _KEYHIT
- 'REDIM FILs(0) AS STRING 'hopefully this is already ready
- 'loadFiles FILs()
- selNum& = getArrayItemNumber&(5, 60, 60, 30, FILs())
- CLS 'need to signal out of file selection
- 'back to directory select
- ELSE 'clear b$ to show some response to enter
- choice = hlite + page * maxHeight + lba 'must mean to select the highlighted item
- 'handle the mouse stuff
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- choice = my + page * maxHeight + lba - 1 'select item clicked
- ELSE 'PgUp bar clicked
- ELSE ' mouse over highlighting, only if mouse has moved!
- hlite = my - 1
- lastMX = mx: lastMY = my
- GOSUB update
- _LIMIT 200
- getArrayItemNumber& = choice
- COLOR fg, bg
- 'clear key presses
- LOCATE curRow, curCol
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- update: '--------------- display of array sections and controls on screen
- 'fix hlite if it has dropped below last array item
- hlite = hlite - 1
- 'main display of array items at page * maxHeight (lines high)
- index = row + page * maxHeight + lba
- 'make page up and down bars to click, print PgUp / PgDn if available
- 'make exit sign for mouse click
- PRINT " X "
- 'if a number selection has been started show it's build = b$
- PRINT b$;
- _LIMIT 100
I can only test in Windows, so would specially appreciate feedback from Linux or other OS users.
FYI DirEnter.h is at the start of this thread for downloading.
Post by: Petr on June 25, 2020, 04:20:59 am
Let me tell you one thing. It hasn't been that long since Pete and me have written here about how clear it is in the morning where you made a mistake in the evening. Well, man. It was confirmed again. Imagine just enclosing a DIR statement listing in quotation marks. And... then it works.... So on Linux, I find a command that does the same thing as a DIR with the parameters provided by Steve. Now i can continue. Here is current harddrive listening - use space for next record in array and enter for running it under windows media player. I use actaully BAT file - it is better when is program developed.
Added mask decomposition (the program correctly places files in the list according to the mask), solved access to files using long file names.
Request. Create a folder that has unicode characters in the name. Insert a supported audio and / or video format (preferably also with unicode characters in the name). Run the program. Select this or the parent folder at the beginning. Use the space bar to scroll to this file and try to run it with the enter key.
Source upgraded. Now you can see difference between system file access and QB64 file access. Some file are unacessible with QB64. But access is needed for next work...
Code: QB64: [Select]
- TYPE FileList
- Path$ = SelectDIR$
- SPath$ = ShortName$(Path$) ' is need for access to files and directories, which use unicode characters in name
- PRINT Path$, SPath$
- CurrentPath$ = _CWD$
- mask$ = "AVI,MPG,MKV,MPG,MPEG,WAV,ACC,MP4,MP3,MP2,VOC,S3M,MOD,XM,TS,MOV,AC3,WMA,WMV,FLAC," ' on end must be comma!
- SearchFiles mask$, files_found(), SPath$
- PrintIt files_found()
- current$ = _CWD$
- CHDIR Path$
- i = i + 1
- PRINT "Creating database..."
- WorkDir$ = "C:\users\public"
- t$ = "DIR " + msk$ + "/b /s /a-d >" + WorkDir$ + "\FilesList.txt"
- ff = FREEFILE
- i = 0
- FL(i).LngName = LLL$
- FL(i).ShtName = ShortName$(FL(i).LngName)
- i = i + 1
- CLOSE ff
- CHDIR current$
- ' PRINT D(p).LngName
- K$ = INKEY$
- ff = FREEFILE
- CLOSE #ff
- 'KILL "dswap.bat"
- K$ = ""
- FUNCTION SelectDIR$
- hwnd& = _WINDOWHANDLE
- TYPE BROWSEINFO ' typedef struct _browseinfo 'Microsoft MSDN
- b.hwndOwner = hwnd
- ' _SCREENHIDE
- o = SHBrowseForFolder(b)
- ' _SCREENSHOW
- ' Path$ = LEFT$(s$, INSTR(s$, CHR$(0)) - 1)
- PRINT "Directory not selected, using current directory"
- SelectDIR$ = _CWD$
As you see: Windows Media Player run music correctly using long names. But the same string is invalid path for QB64.
Post by: Petr on June 25, 2020, 05:14:07 am
Post by: SpriggsySpriggs on June 25, 2020, 07:08:57 am
Usage:
Code: QB64: [Select]
Code: QB64: [Select]
Code: QB64: [Select]
- D$ = D$ + "\"
- DirCount = 0: FileCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- close_dir
- copy = Expression
- curpos = 1
- arrpos = 0
- arrpos = arrpos + 1
Post by: SMcNeill on June 25, 2020, 07:22:03 am
close_dir
ELSE
END IF
There's no close_dir call in the ELSE segment of the code, which can cause issues as Bplus pointed out above.
Lots of folks have made use of direntry.h, and it seems I glitched the original, which propagated into everyone else's stuff later. Move that close_dir to after the END IF, and it should help prevent possible issues in the future in your code. ;D
Post by: SpriggsySpriggs on June 25, 2020, 07:42:36 am
Lots of folks have made use of direntry.h, and it seems I glitched the original, which propagated into everyone else's stuff later. Move that close_dir to after the END IF, and it should help prevent possible issues in the future in your code. ;DThanks, Steve! I'll fix that right away.
Post by: Petr on June 25, 2020, 12:04:59 pm
Run it in the directory with QB64 (let's have the same directory structure):
The program first finds the first directories: internal, licenses, programs, source. Adds these 4 directories to the global G field. The G field will be the field of all directories. The next step is to open these 4 directories one by one (the first is the internals folder), find out the subdirectories, write them in the G field, go back one folder, open the next one (licenses), an empty field should be returned here. But it will not return empty. This causes invalid records to be added to the G field. The question is - what is the problem why the field does not return zero.
If you go all the way down in the listing, you'll find a shocking thing: the level entry contains meaningless values ​​that came from nowhere. Localized this error here on line 38. After Disabling AddDirsToGlobal does not cause this error. The current state of the program is incomprehensible. Can someone find the bug? (yes, it is to very long time)
How is this bad Level value incomming to the array?
Code: QB64: [Select]
- TYPE GlobalDir
- SA Begin()
- AddDirsToGlobal Begin(), 1
- ShowGlobal
- 'PRINT Begin(S)
- SA D()
- AddDirsToGlobal D(), 2 ' comment this
- CHDIR ".."
- ShowGlobal
- SUB ShowGlobal
- G(a).Path = s(i)
- G(a).Level = level
- i = i + 1
- 'my modification just for directory names:
- DirCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirCount = DirCount - 3
- Dirl(PlaceIt) = DirList(PlaceIt + 2)
- DirList(PlaceIt) = Dirl(PlaceIt)
- ERASE Dirl
- close_dir
Post by: bplus on June 25, 2020, 12:19:02 pm
Looks like you are trying to build a TREE, a listing of all directories or paths. There might be a utility floating around for that but don't know if cross platform. It would probably work by a recursive method.
Post by: Petr on June 25, 2020, 12:22:07 pm
Post by: bplus on June 25, 2020, 12:33:12 pm
:) so again I ask, "Are you going for Cross Platform or Windows only."
Windows only will have kick butt utilities for TREE that you might research but Cross Platform might be nice programming challenge. ;-))
The deciding factor, I think, is if you intend to use Windows only apps for playing these files we are digging around for?
Post by: SpriggsySpriggs on June 25, 2020, 12:38:39 pm
Post by: bplus on June 25, 2020, 12:42:31 pm
Post by: SpriggsySpriggs on June 25, 2020, 12:47:43 pm
Yeah, I am thinking Shell or Powershell, why reinvent the wheel, if Windows only.Well there is even a cross-platform PowerShell now :)
Post by: Petr on June 25, 2020, 01:27:15 pm
Post by: bplus on June 25, 2020, 02:05:42 pm
BPlus, let's do this for windows first. When it's done, I can study on the Internet which Linux commands can be useful for the same purpose and then add functionality for Linux. But still - why it works not? I have big head from it...
;-)) "Big heads" love company.
I will look again when I finish errands.
Quote
Well there is even a cross-platform PowerShell now :)
Well then another one to learn. :)
Post by: SpriggsySpriggs on June 25, 2020, 02:19:39 pm
Code: QB64: [Select]
Post by: SpriggsySpriggs on June 25, 2020, 02:26:06 pm
BPlus, let's do this for windows first. When it's done, I can study on the Internet which Linux commands can be useful for the same purpose and then add functionality for Linux.For Linux, according to the internet:
Code: QB64: [Select]
Post by: bplus on June 25, 2020, 05:08:53 pm
Couldn't figure out what you were doing when adding dirs from s to G so I did it my own way and now not a bunch of empty fills.
This looks better to me but not sure it ends correctly:
Code: QB64: [Select]
- _DELAY .25
- TYPE GlobalDir
- SA Begin()
- AddDirsToGlobal Begin(), 1
- ShowGlobal
- DIM s
- 'PRINT Begin(S)
- SA D()
- AddDirsToGlobal D(), 2 ' comment this
- ShowGlobal ' <<<<<<<<<<<<<<<<<<< lets look at Global at each loop iteration
- CHDIR ".."
- ShowGlobal
- DIM s
- SUB ShowGlobal
- PRINT "Start of next Golbal: keep pressing any again until see End of global and then press 1 more time"
- DIM s
- PRINT "End of Global, press spacebar again..."
- DIM a
- sAppend G(), s(a), level
- 'my modification just for directory names:
- DirCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirCount = DirCount - 3
- Dirl(placeIt) = DirList(placeIt + 2)
- DirList(placeIt) = Dirl(placeIt)
- close_dir
Post by: SpriggsySpriggs on June 25, 2020, 11:21:24 pm
Code: QB64: [Select]
If you don't add the -Encoding ASCII then qb64 cannot locate the directories because of hidden characters.
Here is a screenshot showing the program running and using _DIREXISTS to make sure it can find the directories retrieved from PowerShell.
[ This attachment cannot be displayed inline in 'Print Page' view ]
Post by: bplus on June 26, 2020, 01:02:27 am
This is a cleaner version of reply #24,
https://www.qb64.org/forum/index.php?topic=2742.msg119796#msg119796
upper bounds of arrays reflect actual item counts.
I am setting this up for a recursive TREE build.
Code: QB64: [Select]
- _DELAY .25
- SA Begin()
- AddDirsToGlobal Begin()
- ShowGlobal
- INPUT "Enter to continue... "; w$
- SA D()
- AddDirsToGlobal D()
- ShowGlobal
- PRINT "Last Global List: press any... "
- ShowGlobal
- DIM s
- PRINT "Start of SubDirs List: press any until End SubDirs."
- PRINT "End of SubDirs List: press any..."
- SUB ShowGlobal
- PRINT "Start of next Golbal: keep pressing any again until see End of global and then press 1 more time"
- DIM s
- DIM a
- sAppend G(), s(a)
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- close_dir
Post by: bplus on June 26, 2020, 02:53:15 am
Code: QB64: [Select]
I start in QB64 folder, looks like it gets pretty deep into some directories but not \programs with one sub folder and then more in it. I am only getting 125 directories.
Post by: SMcNeill on June 26, 2020, 10:19:57 am
Code: QB64: [Select]
Edit: Something still seems off here. I'm thinking it's because you're not building the directories with the "\" as the last character.
Print the results as you go, and you'll see things such as : C:\QB64\internal.. -- this should instead be C:\QB64\internal\.. Save the directories with that \ on the end of them, and it seems to work much better.
I'd dig deeper into this, but my stupid mouse has died on me, and it's a total PITA to try and work without one. I'll make a trip to the store later today for a set of batteries (wherever my wife has them hidden in the house is beyond my ability to snoop and find), and once I get it back up and going, I'll delve into this once again. ;)
Post by: bplus on June 26, 2020, 12:01:59 pm
I see one line changed mine:
DirList(DirCount) = _CWD$ + "\" + nam$
Yours:
DirList(DirCount) = SearchDirectory + "\" + nam$
Am I missing any others?
Same exact results. 125 Sub-Directories.
Quote
I'd dig deeper into this,It is cool problem ;-))
Post by: Petr on June 26, 2020, 12:31:17 pm
I didn't realize one thing. That I have written the full path in array. So I'm not going to go back one directory level, so I don't need to write down the current nesting level. Now, looking at the BPlus and Steve code, I've figured it out. It just occurred to me now. I did it absolutely wrong.
I think, maybe... see to BPlus source. To MakeTree SUB. If is this SUB recursive running, then source list of arrays is deleted in next step (in recursive call), or not?
Post by: bplus on June 26, 2020, 12:44:03 pm
According to his version, we are shooting for 607 sub-dirs, so 125 is definitely falling short.
Post by: bplus on June 26, 2020, 12:54:49 pm
Glad to have cleared the "big head", working on your code did inspire me to try the recursive tree making.
Quote
I think, maybe... see to BPlus source. To MakeTree SUB. If is this SUB recursive running, then source list of arrays is deleted in next step (in recursive call), or not?
In recursive call (when setup properly), every new call to sub makes it's own set of variables including arrays, be careful with the calling parameters sometimes making a copy of them helps in case they get altered by code. Hey... is that what I missed?
The calls go down and down and down until no more down, then up one level and finish laterally, then up next level and finish that. I learned this by watching recursive drawings.
Post by: SpriggsySpriggs on June 26, 2020, 01:22:14 pm
I just tried modified version of @SpriggsySpriggs, very nice!@bplus Perhaps not, actually. That version might have been bugged. Try this one:
According to his version, we are shooting for 607 sub-dirs, so 125 is definitely falling short.
Code: QB64: [Select]
- Path$ = _STARTDIR$
- DIRECTORIES = FREEFILE
- n = 0
- n = n + 1
- Dirs(n) = Directory$
- h = h + 1
- c = ""
- r$ = a
- String.Remove = r$
- Array_String.FirstOrDefault = i
- Array_String.FirstOrDefault = i
Post by: Petr on June 26, 2020, 01:29:18 pm
Which PowerShell version is need? I use Win 7.
Post by: SpriggsySpriggs on June 26, 2020, 01:31:39 pm
Hi SpriggsySpriggs, your program create empty file directorylist.txt here.That would probably be because your PowerShell failed and didn't create a file. Don't end the Path$ with a backslash. The backslash is an escape character to escape the quotes in the SHELL string and pass the quoted path. If you add a backslash it fails unless you add two.
Post by: bplus on June 26, 2020, 02:24:04 pm
@bplus Perhaps not, actually. That version might have been bugged. Try this one:Code: QB64: [Select]
This has obvious errors from get go InForm files. What did you think was buggy from first version?
Post by: SpriggsySpriggs on June 26, 2020, 02:30:42 pm
This has obvious errors from get go InForm files. What did you think was buggy from first version?I don't get two InForm folders when I run it.
Oh crap, I think I see something wrong. Maybe permissions? Apologies, let me investigate further.
Post by: SpriggsySpriggs on June 26, 2020, 02:37:57 pm
Post by: bplus on June 26, 2020, 02:42:12 pm
I ran your 2nd version from a straight copy/paste from forum. It is possible the forum editor changed something.
BTW what determines the Console Width, man Spriggsy, yours looks to have acre's of room!
Don't go by my Tree, I was getting (125 sub-dirs), kind of fails to get more sub-Folders after License (that has no sub-dirs).
Time for an independent evaluation of QB64 folder, I am thinking your first was right. ;-) too!
Post by: SpriggsySpriggs on June 26, 2020, 02:44:46 pm
@SpriggsySpriggsThe first one was literally just reading in the file and then printing the results. It doesn't quite follow the tree structure, though. I'm going to have to see about how to make PowerShell organize it as such or how to sort the array (argh). So yeah, more work :( Thank you for catching that issue.
I ran your 2nd version from a straight copy/paste from forum. It is possible the forum editor changed something.
BTW what determines the Console Width, man Spriggsy, yours looks to have acre's of room!
Don't go by my Tree, I was getting (125 sub-dirs), kind of fails to get more sub-Folders after License (that has no sub-dirs).
Time for an independent evaluation of QB64 folder, I am thinking your first was right. ;-) too!
Post by: SpriggsySpriggs on June 26, 2020, 03:43:19 pm
@SpriggsySpriggs@bplus It wasn't your fault at all. I neglected to sort the items. They were there all along! I sorted them using the SHELL with Sort-Object and now they are in the correct recursive order and with the 700~ directories. Check it out:
I ran your 2nd version from a straight copy/paste from forum. It is possible the forum editor changed something.
Code: QB64: [Select]
- Path$ = _STARTDIR$
- DIRECTORIES = FREEFILE
- n = 0
- n = n + 1
- Dirs(n) = Directory$
- CLOSE #DIRECTORIES
- c = ""
- r$ = a
- STRING.Remove = r$
Post by: SpriggsySpriggs on June 26, 2020, 03:48:06 pm
@SpriggsySpriggsI just maximized the console window. I'm on a 24 inch monitor so I guess that's why I have so much space.
BTW what determines the Console Width, man Spriggsy, yours looks to have acre's of room!
Post by: bplus on June 26, 2020, 04:11:17 pm
I get 607 folders. I don't think I've added any folders to QB64 folder, plenty of files but no folders. What is the difference I wonder. Update: oh I thought it was 700+ the first time, no, same as first 607. OK consistency is good!
I've been messing with my recursive thing, got the recursive up to 267 files was it? but forgot what I did.
Man I am making little changes to variables and getting differences in counts, but nothing like 600 listings.
Oh! I might be loosing folders with decimal points!
Post by: SpriggsySpriggs on June 26, 2020, 05:35:32 pm
Code: QB64: [Select]
PowerShell has a built in function for displaying folders and files in a tree format
Post by: bplus on June 26, 2020, 06:22:03 pm
but no file was getting created. My DOS command lines is rusty, maybe some CHR$(34)'s were needed?
I forgot that you didn't get full paths on each line.
Post by: SMcNeill on June 26, 2020, 06:46:28 pm
Repeat after me: "I'm a big dummy. I'm a big dummy. I'm a big dummy." Repeat for the next several minutes, then read WHY we're all such failures with such simple code -- yours truly included....
C strings are NOT the same as QB64 strings!!!
Everyone knows this, and yet, we all let it bite us in the ass, in this case!
Let's take for example a simple call to our function like so:
Code: [Select]
cd$ = _CWD$ 'testing in QB64 folder
MakeTree cd$
This fails to perform as expected. (In some ways, I'm surprised to find that it performs at all!)
WHY??
Because _CWD$ returns a QB64 formatted string, and *NOT* a string as we'd normally expect to find in C. It's *not* null terminated!!
Maketree cd$ + CHR$(0) is probably what we need to get it to work, in all honesty! At least, playing around with my own little recursive routine, it's what was needed to (mostly) fix things. My problem now is that I'm capturing too many recursions, and rechecking everything over and over endlessly... The exit to my loop is broken somewhere. :P
Anyway, I'd think if you want to sort out the bugs in your routines, you might want to null terminate your strings, and then a lot of the issues might end up going away for you guys. It's worth a shot anyways. I'm going to keep playing around with my own little thing, and I'll keep you updated with what I come up with as I progress. ;)
Post by: SMcNeill on June 26, 2020, 06:58:12 pm
Code: QB64: [Select]
Biggest and most important change??
As I pointed out above -- null terminate your strings: IF load_dir(SearchDirectory + CHR$(0)) THEN
NOTE: This change should probably carry over to ANY routine which uses load_dir with direntry.h. I think we've all been goofing on calling the function all this time, and I'm surprised nobody has noticed or found the glitch before now. Multiple, repetitive calls, all in a row, is a good way to stress test these routines, I guess. :D
Anywho.... Test it out, see if it looks and acts about like it should, and we'll debug and sort out any issues with things as we go. ;D
Post by: bplus on June 26, 2020, 07:42:54 pm
Curiously, I get one more Directory with your code, that I like because you eliminated the need to CHDIR.
Post by: SpriggsySpriggs on June 26, 2020, 10:10:11 pm
I forgot that you didn't get full paths on each line.It doesn't matter because since you have the formatting of the tree, you always know what the path is. You would just have to write a function to parse that tree.
Post by: SpriggsySpriggs on June 26, 2020, 10:18:06 pm
See if this works as expected for getting the directories:@SMcNeill I'm thinking the tree structure isn't correct, Steve. Or maybe this is intentional but see my screenshot from running your code:
Shouldn't all the folders in that auto\ folder be together and not separated out? Same for include\
Something seems to be amiss in the sorting, perhaps.
It appears to do that in several spots from what I can see. I would have assumed that the tree structure puts all subdirectories of a folder with the parent folder and then move on to the next folder like my version:
Post by: SMcNeill on June 26, 2020, 11:17:08 pm
Post by: SpriggsySpriggs on June 26, 2020, 11:20:27 pm
Easy way to test that Spriggsy: run both routines, sort them, and then compare line by line entries to see what's different (if anything). To be honest, I'm not certain why there's jumps in the output like that either, yet. ;)Both programs give me the same number of directories. It's just a matter of the structure.
Post by: SMcNeill on June 26, 2020, 11:42:43 pm
Both programs give me the same number of directories. It's just a matter of the structure.
It's just the sorting method. I'm thinking, if you look close, my little routine finds the directories in levels deep that it goes.
....\auto\core is 14 levels deep.
....\build\vc10 is 14 levels deep.
....\auto\core\gl is 15 levels deep.
As long as it finds all the directories properly, they can be sorted and arraigned as desired later. ;)
Post by: bplus on June 27, 2020, 12:12:56 am
This looks to be in pretty good order:
Code: QB64: [Select]
- 'Tree builder recursive.bas b+ Petr 2020-06-26 now with SMCNeill Fix!! add CHR$(0) to C string
- MakeTree _CWD$
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = SearchDirectory + "\" + nam$
- close_dir 'Steve first fix that got navigator working
- GetSubDirs startDir, D()
- sAppend Tree(), D(i)
- MakeTree D(i)
Post by: SpriggsySpriggs on June 27, 2020, 12:18:34 am
As long as it finds all the directories properly, they can be sorted and arraigned as desired later. ;)Your logic is showing a file in the QB64 directory as a folder but is just a file without an extension.
\internal\c\c_compiler\licenses\libffi\LICENSE
I can run a sort on your file using a PowerShell command and the entire program takes around 6 seconds to complete from getting the directories to spitting out the sorted version.
If I run my program using the PowerShell version, it only takes 3 seconds because it is already sorted. I verified this by using the PowerShell script to sort my file and then compared it in Notepad ++. The files were identical.
EDIT: It looks like @bplus has solved the issue with using direntry
Post by: bplus on June 27, 2020, 12:22:40 am
Post by: SpriggsySpriggs on June 27, 2020, 12:28:37 am
See screenshot:
Post by: bplus on June 27, 2020, 12:39:24 am
Quote
I thought for sure that mine would lose against yours.
Ha! mine was probably slowed down by all the CHDIR's. Your's is working under the Power of Power Shell ;-))
Post by: SpriggsySpriggs on June 27, 2020, 12:42:19 am
Ha! mine was probably slowed down by all the CHDIR's. Your's is working under the Power of Power Shell ;-))I expected that with shelling out to PowerShell that I would lose precious time because I'm having to wait on an external process to complete. I know that when I generate my WPF Message Boxes from PowerShell they are much slower than calling a native message box (of course, mine are more graphical and the script is quite long. Eh, whatever)
Post by: SMcNeill on June 27, 2020, 12:47:31 am
Code: QB64: [Select]
- DEFLNG A-Z
- _DELAY .25
- PRINT "Creating tree."
- MakeTree _CWD$ 'testing in QB64 folder
- PRINT "Tree created."
- PRINT "Showing Tree"
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- PRINT "Dir not loaded"
- close_dir
- Tree(0) = Dir$
- GetSubDirs Tree(OnDir)
- OnDir = OnDir + 1
- gap = 10 * gap \ 13
- i = 0
- swapped = 0
- swapped = -1
- i = i + 1
Post by: SpriggsySpriggs on June 27, 2020, 12:51:45 am
List retrieved and sorted in about 1 second, on my PC.@SMcNeill
Steve,
I was timing the printing of the output as well. Not only the creation of the array. When I run your code and put the timers in the same spot as I did for bplus and myself, I get 4.301 seconds.
Post by: SMcNeill on June 27, 2020, 12:52:49 am
Your logic is showing a file in the QB64 directory as a folder but is just a file without an extension.
\internal\c\c_compiler\licenses\libffi\LICENSE
Running on my machine, I'm not getting this false result. What system are you running under? Is this difference something in 32-bit versions of QB64 vs 64-bit? Linux vs Windows? On Win 10, QB64x64, I'm not seeing LICENSE in the file listing.
Post by: SpriggsySpriggs on June 27, 2020, 12:53:40 am
Running on my machine, I'm not getting this false result. What system are you running under? Is this difference something in 32-bit versions of QB64 vs 64-bit? Linux vs Windows? On Win 10, QB64x64, I'm not seeing LICENSE in the file listing.I'm running QB64 x64 v1.4 on Windows 10 build 1909
Post by: SMcNeill on June 27, 2020, 12:56:39 am
@SMcNeill
Steve,
I was timing the printing of the output as well. Not only the creation of the array. When I run your code and put the timers in the same spot as I did for bplus and myself, I get 4.301 seconds.
I'm still only getting about 1.2 seconds to get, sort, and print the listing. I have no idea why it'd take 3+ seconds to print the results on your machine. Something seems off there.
Code: QB64: [Select]
- DEFLNG A-Z
- _DELAY .25
- PRINT "Creating tree."
- MakeTree _CWD$ 'testing in QB64 folder
- PRINT "Showing Tree"
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- PRINT "Dir not loaded"
- close_dir
- Tree(0) = Dir$
- GetSubDirs Tree(OnDir)
- OnDir = OnDir + 1
- gap = 10 * gap \ 13
- i = 0
- swapped = 0
- swapped = -1
- i = i + 1
Post by: SpriggsySpriggs on June 27, 2020, 12:58:10 am
I'm still only getting about 1.2 seconds to get, sort, and print the listing. I have no idea why it'd take 3+ seconds to print the results on your machine. Something seems off there.I'm placing the timer variable at the beginning of the program. First line for both mine and bplus's. Then showing the time for everything being completed at the end after everything has been printed completely. If I run your code you just posted I still get an output slower than both mine and bplus's at a speed of 3.709 seconds. I also have many more directories than you and bplus do (about 1300) , so that's why I'm in the 3 seconds + range on my PC.
internal\c\c_compiler\x86_64-w64-mingw32\include\GL
internal\c\c_compiler\x86_64-w64-mingw32\lib\ldscripts
And, your program still finds the libffi\LICENSE file as a folder.
Also, the sort isn't sorting in the order I would expect. After InForm I would expect internal to be next as it is the next folder alphabetically, even in File Explorer. However, yours goes to LICENSE then jumps to my folder called QB64Library then goes to internal. I guess you are sorting alphabetically by capital letters first, then lowercase?
Post by: SMcNeill on June 27, 2020, 01:34:04 am
Code: [Select]
IF _DIREXISTS("internal\c\c_compiler\licenses\libffi\LICENSE") THEN
PRINT "QB64 is recognizing this as a directory on my PC, for some odd reason."
ELSE
PRINT "It either doesn't exist, as I typed it in, or else QB64 recognizes it as a file."
IF _FILEEXISTS("internal\c\c_compiler\licenses\libffi\LICENSE") THEN
PRINT "QB64 found it, recognized it as a file."
ELSE
PRINT "File not found at all, as entered into the search parameters."
END IF
END IF
We're relying on QB64 to basically tell us if it's a file or a directory, and for some odd reason, you see to be generating a false positive on your machine. I dunno if that's a glitch in the version of QB64 you're using, something odd that Windows is reporting wrong, or where the problem actually comes from, but it's not from the direntry routines themselves.
As for sorting, I just did a basic combsort alphabetically, which places uppercase separate from lowercase. If you want to sort without comparing case, change the sort to using _STRICMP instead of the simple > which I tossed in there. ;)
Post by: SpriggsySpriggs on June 27, 2020, 01:39:22 am
As for sorting, I just did a basic combsort alphabetically, which places uppercase separate from lowercase. If you want to sort without comparing case, change the sort to using _STRICMP instead of the simple > which I tossed in there. ;)I did this and it sorts incorrectly once more, placing some subdirectories in the wrong spots on the tree. For instance, this is how it should sort:
x86_64-w64-mingw32\lib
x86_64-w64-mingw32\lib\ldscripts
x86_64-w64-mingw32\lib32\
How your program sorts using _STRICMP:
x86_64-w64-mingw32\lib
x86_64-w64-mingw32\lib32\
x86_64-w64-mingw32\lib\ldscripts
Also, see below from testing your _DIREXISTS for that file/folder issue: (And yes, it is a file. I opened it in Notepad to be sure)
The issue appears to be your flag IS_DIR. If I remove that from the check to see if it is a directory, it doesn't show up. It only appears if I leave the flag as an argument to your IF statement for determining a directory.
Post by: SMcNeill on June 27, 2020, 01:41:56 am
Well the disadvantage of not using CHDIR is having to sort later?
It's not the lack of CHDIR which dictates the order which mine shows up in -- its the fact that mine's a non-recursive routine, compared to yours. Mine does one whole level first, before going to the next depth of directories and then doing them next. ;)
Post by: codeguy on June 27, 2020, 03:59:16 am
Modified your code slightly, Steve
Code: [Select]
DEFLNG A-Z
DECLARE CUSTOMTYPE LIBRARY ".\direntry"
FUNCTION load_dir& (s AS STRING)
FUNCTION has_next_entry& ()
SUB close_dir ()
SUB get_next_entry (s AS STRING, flags AS LONG, file_size AS LONG)
END DECLARE
REDIM SHARED Tree(0) AS STRING
SCREEN _NEWIMAGE(1280, 740, 32)
_DELAY .25
_SCREENMOVE 80, 0
DIM cd$, i, w$
PRINT "Creating tree."
t# = TIMER(0.001)
MakeTree _CWD$ 'testing in QB64 folder
PRINT "Tree created."
PRINT USING "##.##### seconds creating and sorting tree."; TIMER - t#
SLEEP
CLS
_KEYCLEAR
PRINT "Showing Tree"
FOR i = 0 TO UBOUND(Tree) 'show tree
PRINT _TRIM$(STR$(i)); ": "; Tree(i)
IF i MOD 40 = 0 AND i > 0 THEN INPUT "Press enter to continue... "; w$: CLS
NEXT
SUB GetSubDirs (SearchDirectory AS STRING)
CONST IS_DIR = 1
DIM flags AS LONG, file_size AS LONG, length, nam$
IF load_dir(SearchDirectory + CHR$(0)) THEN
DO
length = has_next_entry
IF length > -1 THEN
nam$ = SPACE$(length)
get_next_entry nam$, flags, file_size
IF RIGHT$(nam$, 1) <> "." AND RIGHT$(nam$, 2) <> ".." THEN
IF flags = IS_DIR OR _DIREXISTS(SearchDirectory + "\" + nam$) THEN
REDIM _PRESERVE Tree(UBOUND(Tree) + 1)
Tree(UBOUND(Tree)) = SearchDirectory + "\" + nam$
END IF
END IF
END IF
LOOP UNTIL length = -1
ELSE
PRINT "Dir not loaded"
END IF
close_dir
END SUB
SUB MakeTree (Dir$)
DIM OnDir AS LONG
REDIM Tree(0) AS STRING
Tree(0) = Dir$
DO
GetSubDirs Tree(OnDir)
OnDir = OnDir + 1
LOOP UNTIL OnDir > UBOUND(Tree)
QuickSortIterativeString Tree(), LBOUND(tree), OnDir - 1, 1
'gap = UBOUND(Tree)
'DO
' gap = 10 * gap \ 13
' IF gap < 1 THEN gap = 1
' i = 0
' swapped = 0
' DO
' IF Tree(i) > Tree(i + gap) THEN
' SWAP Tree(i), Tree(i + gap)
' swapped = -1
' END IF
' i = i + 1
' LOOP UNTIL i + gap > UBOUND(Tree)
'LOOP UNTIL gap = 1 AND swapped = 0
END SUB
SUB QuickSortIterativeString (CGSortLibArr() AS String, QSIStart AS LONG, QSIFinish AS LONG, order&)
DIM QSI_Local_Compare AS String '* MUST be same type as element of CGSortLibArr()
'* These MUST be the appropriate type for the range being sorted
DIM QSI_Local_I AS LONG
DIM QSI_local_J AS LONG
DIM QSI_Local_Hi AS LONG
DIM QSI_Local_Low AS LONG
DIM QSI_Local_Mid AS LONG
'****************************************************************
'* Integer suffices for QSI_Local_MinStackPtr unless you're sorting more than 2^32767 elements.
DIM QSI_Local_MinStackPtr AS INTEGER: QSI_Local_MinStackPtr = 0
DIM QSI_Local_QSI_local_CurrentStackPtr AS INTEGER: QSI_Local_QSI_local_CurrentStackPtr = 0
DIM QSI_Local_FinishMinusStart AS LONG: QSI_Local_FinishMinusStart = QSIFinish - QSIStart
DIM QSI_local_Remainder AS INTEGER
'* yes, the equation log(QSIfinish-QSIstart)/log(2)+1 works too
DO
QSI_local_Remainder = QSI_Local_FinishMinusStart - (2 * INT(QSI_Local_FinishMinusStart / 2))
QSI_Local_FinishMinusStart = (QSI_Local_FinishMinusStart - QSI_local_Remainder) / 2
QSI_Local_MinStackPtr = QSI_Local_MinStackPtr + 1
LOOP UNTIL QSI_Local_FinishMinusStart < 1
'* MUST be appropriate type to handle the range (QSIfinish-QSIstart) being sorted
DIM QSI_LStack(0 TO QSI_Local_MinStackPtr, 0 TO 1) AS LONG
QSI_local_CurrentStackPtr = 0
QSI_LStack(QSI_local_CurrentStackPtr, 0) = QSIStart
QSI_LStack(QSI_local_CurrentStackPtr, 1) = QSIFinish
DO
QSI_Local_Low = QSI_LStack(QSI_local_CurrentStackPtr, 0)
QSI_Local_Hi = QSI_LStack(QSI_local_CurrentStackPtr, 1)
DO
QSI_Local_I = QSI_Local_Low
QSI_local_J = QSI_Local_Hi
QSI_Local_Mid = QSI_Local_Low + (QSI_Local_Hi - QSI_Local_Low) \ 2
QSI_Local_Compare = CGSortLibArr(QSI_Local_Mid)
SELECT CASE order&
CASE 1
DO
DO WHILE CGSortLibArr(QSI_Local_I) < QSI_Local_Compare
QSI_Local_I = QSI_Local_I + 1
LOOP
DO WHILE CGSortLibArr(QSI_local_J) > QSI_Local_Compare
QSI_local_J = QSI_local_J - 1
LOOP
IF QSI_Local_I <= QSI_local_J THEN
SWAP CGSortLibArr(QSI_Local_I), CGSortLibArr(QSI_local_J)
QSI_Local_I = QSI_Local_I + 1
QSI_local_J = QSI_local_J - 1
END IF
LOOP UNTIL QSI_Local_I > QSI_local_J
CASE ELSE
DO
DO WHILE CGSortLibArr(QSI_Local_I) > QSI_Local_Compare
QSI_Local_I = QSI_Local_I + 1
LOOP
DO WHILE CGSortLibArr(QSI_local_J) < QSI_Local_Compare
QSI_local_J = QSI_local_J - 1
LOOP
IF QSI_Local_I <= QSI_local_J THEN
SWAP CGSortLibArr(QSI_Local_I), CGSortLibArr(QSI_local_J)
QSI_Local_I = QSI_Local_I + 1
QSI_local_J = QSI_local_J - 1
END IF
LOOP UNTIL QSI_Local_I > QSI_local_J
END SELECT
IF QSI_local_J - QSI_Local_Low < QSI_Local_Hi - QSI_Local_I THEN
IF QSI_Local_I < QSI_Local_Hi THEN
QSI_LStack(QSI_local_CurrentStackPtr, 0) = QSI_Local_I
QSI_LStack(QSI_local_CurrentStackPtr, 1) = QSI_Local_Hi
QSI_local_CurrentStackPtr = QSI_local_CurrentStackPtr + 1
END IF
QSI_Local_Hi = QSI_local_J
ELSE
IF QSI_Local_Low < QSI_local_J THEN
QSI_LStack(QSI_local_CurrentStackPtr, 0) = QSI_Local_Low
QSI_LStack(QSI_local_CurrentStackPtr, 1) = QSI_local_J
QSI_local_CurrentStackPtr = QSI_local_CurrentStackPtr + 1
END IF
QSI_Local_Low = QSI_Local_I
END IF
LOOP WHILE QSI_Local_Low < QSI_Local_Hi
QSI_local_CurrentStackPtr = QSI_local_CurrentStackPtr - 1
LOOP UNTIL QSI_local_CurrentStackPtr < 0
END SUB
Post by: Petr on June 27, 2020, 06:35:40 am
Now that we get the valid subdirectory names (and thank you again), I want to go through the individual folders and do list the files in each of them. If the file in a particular folder contains a name with a valid mask extension (this is at the beginning of this thread), the file name, including the path, will be added to the field.
After I get the valid names of all these files by mask, I will open each individual file for reading in binary mode and retrieve some information from the files (according to the file type), I will need to study the entries in the heads of specific files or, if someone knows about to any library that would do this for us, it would be another great easing of work. This information is:
- ID3 TAG - records in music files such as WAV, MP3, MP2, MP4 (I have already written this program, but it does not support all possible tags, it will need a heavy upgrade), but it can extract a photo from the file, if it is attached,
- sound length (this is the simplest, QB64 returns it to us with its own function)
- sound format (in some music formats it will be a purely sadomasochistic work)
- resolution (for video formats)
- number of frames per second
and other information, as required. Of course, this is a long job.
It would also like to set a rule for related photos right at the beginning. Suppose you want to add a photo of the band to the list (in this band folder), this photo will not be part of ID3. What rules do we set? Does the photo have to have the same name as its folder? Or will any photo in this folder be used? Or make it optional?
As you can see, there is still a lot.
Post by: SpriggsySpriggs on June 27, 2020, 10:10:21 am
This information is:Which tags do you already have code to get? Here is code I have for tags:
- ID3 TAG - records in music files such as WAV, MP3, MP2, MP4 (I have already written this program, but it does not support all possible tags, it will need a heavy upgrade), but it can extract a
Code: QB64: [Select]
Post by: bplus on June 27, 2020, 11:19:13 am
Did you guys figure out already why Steve shows an extra folder?
BTW Steve's sorting is case sensitive and Windows is not.
Post by: SpriggsySpriggs on June 27, 2020, 11:23:48 am
Here is the timings I get on my Windows 10 System (not brand new) putting everyone's in Console window and timing from start to print of listing.@bplus
Did you guys figure out already why Steve shows an extra folder?
As for the speed, less directories will mean that your function will be faster than mine because I have to shell out to PowerShell. You can shave off some time by replacing my LTRIM$ and RTRIM with just _TRIM$. I shaved half a second with that. More directories, like the 1300 I have, will do better on mine because PowerShell quickly catches up on a larger process as proven by only having 3.109 seconds for 1300 directories where your computer spent that long on half that. As for the extra file, it's because of his flag IS_DIR. When I remove it, I don't have that file giving a false positive as a folder. It only shows up when I leave his flag in the statement.
Post by: bplus on June 27, 2020, 12:20:55 pm
@bplus
As for the speed, less directories will mean that your function will be faster than mine because I have to shell out to PowerShell. You can shave off some time by replacing my LTRIM$ and RTRIM with just _TRIM$. I shaved half a second with that. More directories, like the 1300 I have, will do better on mine because PowerShell quickly catches up on a larger process as proven by only having 3.109 seconds for 1300 directories where your computer spent that long on half that. As for the extra file, it's because of his flag IS_DIR. When I remove it, I don't have that file giving a false positive as a folder. It only shows up when I leave his flag in the statement.
I just spent morning going over the tiny differences between Steve's, SUB GetSubDirs, the one that makes the calls to DirEntry.h
This line is very, very interesting!
Code: QB64: [Select]
Steves basically only needs IF _DIREXISTS(SearchDirectory + "\" + nam$) THEN
and the extra Directory, the false positive, is eliminated! without flags = IS_DIR
his won't even work without checking if _DIREXISTS, mine wont work without checking flags = IS_DIR
What is interesting is that when I don't double check _DIREXISTS(SearchDirectory + "\" + nam$)
my run time is significantly reduced!!! and I still get the 607 files on my system without the false positive.
I cut about a half second off my build and print time and if I can do this without changing directories (which should be quite possible) will have another big time savings.
Post by: Petr on June 27, 2020, 12:26:08 pm
Quote
Which tags do you already have code to get? Here is code I have for tags:
Hi, SpriggsySpriggs i find my source code now. It is from 7.3.2017 :) so it is really not fresh in my memory.
Here:
Code: QB64: [Select]
- 'After writing ID3v1.1 decoder for Qb64 I wrote this decoder ID3TAGV2.3.0 for QB64. I want in first thank Clippy for sharing his program, which dealt with the same thing in another way.
- 'Hardest of all was to understand how the author ID3TAG thinks with the calculation of the size HEAD in binary code. If he wrote it straight - sort by itself without the eighth bit and convert to decimal form,
- 'probably would have consumed much paper. That gave me the most work.
- 'this is extended version. Program first use V2.3.0 program. IF this ends with error (no record found), is automatically runned upgraded version ID3V1.1. Only when one can not find even a record
- 'identifier TAG, then the program will report that in the file is none ID3 and ends. Read NOT ID3V2.2 (V2.2 is with 3 characters indetificator), but read ID3V2.4
- _TITLE "ID3V2.3 PLUS ID3V1.1 (V1.1 upgraded) Reader"
- INPUT "Input MP3 filename without extension to view ID3:"; file$
- file$ = file$ + ".MP3"
- 'file$ = "14.mp3" 's.mp3 hav e APIC.
- TYPE ID3HEAD
- TYPE FRAME
- IDENTIT$ = Version$
- h = HEAD(headd$) / 2
- '----------- cteni framu -------------- frames reading
- w = 0 ' FRAME head is 10 bytes long. 4 byte = name "AENC" or other, 4 byte size, 2 byte flags. Size is calculated as ASC sum of all four
- home: ' bytes.
- GET #1, , FRM ' hlava ma 10 bytu: 4 byty jmeno, 4 byty velikost, 2 byty flags. Vse je psano klasicky hexadecimalne, uz zadny nesmysly s bitama.
- ' minimalni krok k dalsimu zaznamu ma byt 11 bytu (1byt je minimum pro kazdy identifikator, 10 byt
- ' je velikost hlavy. Velikost framu je dana souctem ASC ctyr bytu v hlave Framu.
- q$ = FRM.Id$
- 'GET #1, , InFrame$ ' first muss i analyzing metadata
- PRINT textencod1, textencod2
- OUTList$(w) = q$ + InFrame$
- InFrame$ = ""
- readet = readet + 10 + FrameSize
- 'PRINT readet, FrameSize
- EndRec:
- PRINT "End of file"
- SLEEP 1
- PRINT "List: "; IDENTIT$
- NEXT z
- PRINT "Press any key to end"
- ID3V11: 'upgraded ID3V1.1 program (upgraded in end file access, many better)
- PRINT "Wait..."
- 'UPGRADE ////
- 'UPGRADE END
- re$ = re0$ + re2$ ' After several attempts, I realized that the begin of the last record may not be the very last recording at the end of the file... :-D
- 'PRINT re$, e: SLEEP
- NEXT scan
- dal:
- 'COLOR , 5 i have here tested long text arrays
- READ genre$
- NEXT gnr
- none:
- 'PRINT re$ ' If you delete this mark "'", you see as its writed in file
- PRINT IDENTIT$
- genre:
- DATA Blues,Classic Rock,Country,Dance,Disco,Funk,Grunge,Hip-Hop,Jazz,Metal,New Age,Oldies,Other,Pop,R&B,Rap,Reggae,Rock,Techno,Industrial,Alternative,Ska,Death Metal,Pranks,Soundtrack,Eurotechno,Ambient
- DATA Gothic,Darkwave,Techno-Industrial,Electronic,Jungle,Pop-Folk,Eurodance,Dream,Southern Rock,Comedy,Cult,Gangsta,Top 40,Christian Rap,Pop/Funk,Native American,Cabaret,New Wave,Psychadelic,Rave,Show Tunes
- DATA Trailer,Lo-Fi,Tribal,Acid Punk,Acid Jazz,Polka,Retro,Musical,Rock & Roll,Hard Rock,Folk,Folk/Rock,National Folk,Swing,Fast-Fusion,Bebop,Latin,Revival,Celtic,Bluegrass,Avantgarde,Gothic Rock,Progressive Rock
- DATA Psychedelic Rock,Symphonic Rock,Slow Rock,Big Band,Chorus,Easy Listening,Acoustic,Humour,Speech,Chanson,Opera,Chamber Music,Sonata,Symphony,Booty Bass,Primus,Porn Groove,Satire,Slow Jam,Club,Tango,Samba
- DATA Folklore,Ballad,Power Ballad,Rhytmic Soul,Freestyle,Duet,Punk Rock,Drum Solo,Acapella,Euro-House,Dance Hall,Goa,Drum & Bass,Club-House,Hardcore,Terror,Indie,BritPop,Negerpunk,Polsk Punk,Beat,Christian Gangsta Rap
- ' HAPPY CODING!
- SUB USLTSUB
- SHARED InFrame$, a
- 'FOR a = 1 TO LEN(InFrame$)
- 'r$ = LEFT$(MID$(InFrame$, a), 1)
- 'PRINT a, r$, ASC(r$)
- 'SLEEP
- 'NEXT a
- SUB APICSUB
- ' FOR a = 1 TO LEN(InFrame$)
- ' r$ = LEFT$(MID$(InFrame$, a), 1)
- ' PRINT a, r$, ASC(r$)
- ' SLEEP
- ' NEXT a ' LADENI (program setup)
- PRINT "MIME TYPE:"; mime$
- ext$ = ".jpg"
- 'GOTO pokus
- 'HERE is comming a very BIG problem for me: HOW TO FIND PICTURE SIZE? All sources was i can are bad. Also i use one old method - because record in image head is unussable - bytes with size are bad - or
- 'WIKI specification is not correct, author ID3 write about this nothing and frame lenght is bad, i muss scanning file for next idetificator after "APIC". This write to array and the one that is closest
- 'to me precisely determines the length of the picture. Although this is smut, but i do not know how else to achieve results - if cant right bytes with size.
- 'if you need repairing me, so: image is MIME format and this is NOT JPEG! its other format with the same name.
- RESTORE IDENTIT
- READ IDENTIT$
- ' LOCATE 13, 5: PRINT LOF(1), "/", FATALITY, IDENTIT$, iScan, Identity$
- NEXT D4FF
- NEXT iScan
- NEXT FATALITY
- Size = new - oll
- 'PRINT "LOOPSIZE", Size, new, oll, IDENTIT$: BEEP: SLEEP
- Size = Size + 64
- REM ///////////////////////////////
- POKUS:
- Size = pokusnavelikost
- REM //////////////////////////////
- CLOSE #4
- 'InFrame$ = ""
- IDENTIT:
- DATA AENC,APIC,COMM,COMR,ENCR,EQUA,ETCO,GEOB,GRID,IPLS,LINK,MCDI,MLLT,OWNE,PRIV,PCNT,POPM,POSS,RBUF,RVAD,RVRB,SYLT,SYTC,TALB,TBPM,TCOM,TCON,TCOP,TDAT,TDLY,TENC,TEXT,TFLT,TIME,TIT1,TIT2,TIT3
- DATA TKEY,TLAN,TLEN,TMED,TOAL,TOFN,TOLY,TOPE,TORY,TOWN,TPE1,TPE2,TPE3,TPE4,TPOS,TPUB,TRCK,TRDA,TRSN,TRSO,TSIZ,TSRC,TSSE,TYER,TXXX,UFID,USER,USLT,WCOM,WCOP,WOAF,WOAR,WOAS,WORS,WPAY,WPUB,WXXX
- 'Although it works, but if no other identifiers after APIC file, so it will end up in long loop. So if this view, then, alone with previous tests of that there is a trailing support, the identifier
- 'or simply not show. It's stupid, but a master programmer ID3 tag is inherently inconsistent to man. Head ID3 tag fits binary level, and here size does not deliver. That would put a medal.
- 'co taky chtit od svedu. Maximalne ten Hulmiho Ukolen by jeste sel...
- DECtoBI2 = DECtoBI2 + (c * 2 ^ Sj)
- NEXT Si
- PRINT "Si:"; Si
- HEAD = DECtoBI2
- '---- FUNCTIONs TEST ---- if is this copyed alone as new program
- 'b$ = DECtoBIN$(255)
- 'b = BINtoDEC(b$)
- 'c$ = HEX$(b)
- 'c = HEXtoDEC(c$)
- 'PRINT b$, b, c$, c
- FUNCTION DECtoBIN$ (vstup) 'DEC to BIN ok vystup je string, vstup je integer decimal to binar number convertor - FROM QB64WIKI
- ' BINARY$ = ""
- NEXT rj
- DECtoBIN$ = BINtoDE$
- Sj = 7 - Si
- DECtoBI = DECtoBI + (c * 2 ^ Sj)
- NEXT Si
- BINtoDEC = DECtoBI
- c = BINtoDEC(bi$) ' binar to hexadecimal number convertor (use binar to decimal convertor)
i think, it is for first and one new id3 version. The first id3 is always writed in end the file, new versions are in begin file.
Post by: Petr on June 27, 2020, 12:28:17 pm
Post by: SpriggsySpriggs on June 27, 2020, 12:53:44 pm
What is interesting is that when I don't double check _DIREXISTS(SearchDirectory + "\" + nam$)Good work, @bplus ! When I get home I'll try your new code if you post it and see how fast it runs on my system.
my run time is significantly reduced!!! and I still get the 607 files on my system without the false positive.
I cut about a half second off my build and print time and if I can do this without changing directories (which should be quite possible) will have another big time savings.
Post by: SpriggsySpriggs on June 27, 2020, 12:55:43 pm
List directories using Steve version in QB64 folder duration is 1.5 sec here.@Petr Yes, but his code returns false positives and doesn't sort correctly. Also, he places his timer in a spot differently from where I timed mine and bplus's. So far, @bplus has the most efficient code as his sorts exactly right and doesn't display false positives
Post by: SMcNeill on June 27, 2020, 01:02:15 pm
Code: [Select]
DEFLNG A-Z
DECLARE CUSTOMTYPE LIBRARY ".\direntry"
FUNCTION load_dir& (s AS STRING)
FUNCTION has_next_entry& ()
SUB close_dir ()
SUB get_next_entry (s AS STRING, flags AS LONG, file_size AS LONG)
END DECLARE
REDIM SHARED Tree(0) AS STRING
SCREEN _NEWIMAGE(1280, 740, 32)
_DELAY .25
_SCREENMOVE 80, 0
DIM cd$, i, w$
PRINT "Creating tree."
t# = TIMER(0.001)
MakeTree _CWD$ 'testing in QB64 folder
PRINT "Showing Tree"
FOR i = 0 TO UBOUND(Tree) 'show tree
PRINT Tree(i)
NEXT
PRINT USING "##.##### seconds creating, printing, and sorting tree."; TIMER - t#
SUB GetSubDirs (SearchDirectory AS STRING)
DIM flags AS LONG, file_size AS LONG, length, nam$
IF load_dir(SearchDirectory + CHR$(0)) THEN
DO
length = has_next_entry
IF length > -1 THEN
nam$ = SPACE$(length)
get_next_entry nam$, flags, file_size
IF nam$ <> "." AND nam$ <> ".." THEN
t$ = SearchDirectory + "\" + nam$
IF flags AND 1 THEN
u = UBOUND(Tree) + 1
REDIM _PRESERVE Tree(u)
Tree(u) = t$
END IF
END IF
END IF
LOOP UNTIL length = -1
ELSE
PRINT "Dir not loaded"
END IF
close_dir
END SUB
SUB MakeTree (Dir$)
DIM OnDir AS LONG, gap AS LONG, i AS LONG, swapped AS LONG
REDIM Tree(0) AS STRING
Tree(0) = Dir$
DO
GetSubDirs Tree(OnDir)
OnDir = OnDir + 1
LOOP UNTIL OnDir > UBOUND(Tree)
gap = UBOUND(Tree)
DO
gap = 10 * gap \ 13
IF gap < 1 THEN gap = 1
i = 0
swapped = 0
DO
IF Tree(i) > Tree(i + gap) THEN
SWAP Tree(i), Tree(i + gap)
swapped = -1
END IF
i = i + 1
LOOP UNTIL i + gap > UBOUND(Tree)
LOOP UNTIL gap = 1 AND swapped = 0
END SUB
This lists the root directories of our folder and flags them properly, but then it fails to properly identify any of the subfolders. Some digging into the C source will be required to sort out what the heck is going on with the false flag results, and with my current schedule, I can't promise how long that might take me. For now, I'd go the route Sprigg and bplus suggested: Remove the IS_DIR flag from consideration completely and just let QB64 use _DIREXISTS and _FILEEXISTS to verify if it's a file or directory.
Post by: SMcNeill on June 27, 2020, 01:17:14 pm
@Petr Yes, but his code returns false positives and doesn't sort correctly. Also, he places his timer in a spot differently from where I timed mine and bplus's. So far, @bplus has the most efficient code as his sorts exactly right and doesn't display false positives
The single false positive can be removed just by taking out the flags AND IS_DIR check. That's something which POSIX is tossing us, and then it's only tossing the result on some systems. I imagine debugging it is going to be a PITA.
I'd say as for sorting, that's just a matter of preference and how you decide to order your data. You can sort by file name, extension, size -- whatever you like. The only difference is bplus's routine runs recursively -- which expands folders and subfolders as it finds them -- and mine runs a whole level at once before expanding the next level of subfolders.
As for the placement of the timer, you only want to time how quickly you find and build your data tree. Counting time for printing and stuff is a waste of time. One could toss a _DISPLAY in there and completely change the result. If one was using Inform and printing to a form's list box, it'd have a different time. Printing to console vs a graphical window would give different times. What you want to know is, "how long does it take to build this data tree" -- not, "How long does everything in my program take from start to finish".
Heck, on my system, since I'm printing to a RAMdrive, it's faster for me to dump the results to a file than it is to print them and scroll the screen with them... Time and optimize your tree creation routine first; then worry about timing and optimizing the rest of your program after. :)
Post by: bplus on June 27, 2020, 02:13:04 pm
I've spent a little time digging into the flags issue. The problem arises when we're dealing with the subfolders. Somehow the path isn't working properly with them, as illustrated with the quick demo here:Code: [Select]DEFLNG A-Z
DECLARE CUSTOMTYPE LIBRARY ".\direntry"
FUNCTION load_dir& (s AS STRING)
FUNCTION has_next_entry& ()
SUB close_dir ()
SUB get_next_entry (s AS STRING, flags AS LONG, file_size AS LONG)
END DECLARE
REDIM SHARED Tree(0) AS STRING
SCREEN _NEWIMAGE(1280, 740, 32)
_DELAY .25
_SCREENMOVE 80, 0
DIM cd$, i, w$
PRINT "Creating tree."
t# = TIMER(0.001)
MakeTree _CWD$ 'testing in QB64 folder
PRINT "Showing Tree"
FOR i = 0 TO UBOUND(Tree) 'show tree
PRINT Tree(i)
NEXT
PRINT USING "##.##### seconds creating, printing, and sorting tree."; TIMER - t#
SUB GetSubDirs (SearchDirectory AS STRING)
DIM flags AS LONG, file_size AS LONG, length, nam$
IF load_dir(SearchDirectory + CHR$(0)) THEN
DO
length = has_next_entry
IF length > -1 THEN
nam$ = SPACE$(length)
get_next_entry nam$, flags, file_size
IF nam$ <> "." AND nam$ <> ".." THEN
t$ = SearchDirectory + "\" + nam$
IF flags AND 1 THEN
u = UBOUND(Tree) + 1
REDIM _PRESERVE Tree(u)
Tree(u) = t$
END IF
END IF
END IF
LOOP UNTIL length = -1
ELSE
PRINT "Dir not loaded"
END IF
close_dir
END SUB
SUB MakeTree (Dir$)
DIM OnDir AS LONG, gap AS LONG, i AS LONG, swapped AS LONG
REDIM Tree(0) AS STRING
Tree(0) = Dir$
DO
GetSubDirs Tree(OnDir)
OnDir = OnDir + 1
LOOP UNTIL OnDir > UBOUND(Tree)
gap = UBOUND(Tree)
DO
gap = 10 * gap \ 13
IF gap < 1 THEN gap = 1
i = 0
swapped = 0
DO
IF Tree(i) > Tree(i + gap) THEN
SWAP Tree(i), Tree(i + gap)
swapped = -1
END IF
i = i + 1
LOOP UNTIL i + gap > UBOUND(Tree)
LOOP UNTIL gap = 1 AND swapped = 0
END SUB
This lists the root directories of our folder and flags them properly, but then it fails to properly identify any of the subfolders. Some digging into the C source will be required to sort out what the heck is going on with the false flag results, and with my current schedule, I can't promise how long that might take me. For now, I'd go the route Sprigg and bplus suggested: Remove the IS_DIR flag from consideration completely and just let QB64 use _DIREXISTS and _FILEEXISTS to verify if it's a file or directory.
This explains why my recursive function falls flat when I don't change directory before each call to GetSubDirs. I am beginning to think startDirectory is meaningless in part of the call, it's just flagging the directories directly under the current directory, which is why my recursive only works with changing directories and reading flags.
Post by: bplus on June 27, 2020, 03:10:51 pm
Code: QB64: [Select]
- 'Tree builder recursive.bas b+ Petr 2020-06-26 now with SMCNeill Fix!! add CHR$(0) to C string
- DEFLNG A-Z
- MakeTree _CWD$
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = SearchDirectory + "\" + nam$
- close_dir 'Steve first fix that got navigator working
- copyStart$ = startDir
- GetSubDirs copyStart$, D()
- sAppend Tree(), D(i)
- MakeTree D(i)
Recursion will work without changing directories but you have to check
Code: QB64: [Select]
Code: QB64: [Select]
- 'Tree builder recursive.bas b+ Petr 2020-06-26 now with SMCNeill Fix!! add CHR$(0) to C string
- DEFLNG A-Z
- MakeTree _CWD$
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = SearchDirectory + "\" + nam$
- close_dir 'Steve first fix that got navigator working
- copyStart$ = startDir
- GetSubDirs copyStart$, D()
- sAppend Tree(), D(i)
- MakeTree D(i)
Now if you want all files and directories (I get 19279 items in ~15.59 secs) without checking anything do this:
Code: QB64: [Select]
- 'Tree builder recursive.bas b+ Petr 2020-06-26 now with SMCNeill Fix!! add CHR$(0) to C string
- DEFLNG A-Z
- MakeTree _CWD$
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- 'IF _DIREXISTS(SearchDirectory + "\" + nam$) THEN
- DirCount = DirCount + 1
- DirList(DirCount) = SearchDirectory + "\" + nam$
- 'END IF
- close_dir 'Steve first fix that got navigator working
- copyStart$ = startDir
- GetSubDirs copyStart$, D()
- sAppend Tree(), D(i)
- MakeTree D(i)
It's probably as fast as you can get through QB64.
Post by: SpriggsySpriggs on June 27, 2020, 04:04:23 pm
As for the placement of the timer, you only want to time how quickly you find and build your data tree. Counting time for printing and stuff is a waste of time. One could toss a _DISPLAY in there and completely change the result. If one was using Inform and printing to a form's list box, it'd have a different time. Printing to console vs a graphical window would give different times. What you want to know is, "how long does it take to build this data tree" -- not, "How long does everything in my program take from start to finish".In that case, for the speed, just checking the amount of time it takes to use @bplus code to build the array it takes 0.8 seconds on my machine and my code only takes 1.29 seconds to build an array that is already presorted. bplus's code seems to be the absolute best. I have no way of beating that with PowerShell calls. Less than one second to build an array containing 659 directories is great. I removed the other 600+ directories. They were backups from my synced folder.
Post by: SMcNeill on June 27, 2020, 04:12:45 pm
In that case, for the speed, just checking the amount of time it takes to use @bplus code to build the array it takes 0.8 seconds on my machine and my code only takes 1.29 seconds to build an array that is already presorted. bplus's code seems to be the absolute best. I have no way of beating that with PowerShell calls. Less than one second to build an array containing 659 directories is great. I removed the other 600+ directories. They were backups from my synced folder.
Aye, and it's cross-platform compatible. Powershell calls only work in Windows. ;)
Post by: SpriggsySpriggs on June 27, 2020, 04:15:08 pm
Aye, and it's cross-platform compatible. Powershell calls only work in Windows. ;)@SMcNeill
PowerShell has a cross platform version :) And I know it is available for both Mac and Linux. Found here: https://aka.ms/pscore6
PowerShell advertises it every time I launch it.
Post by: SpriggsySpriggs on June 27, 2020, 04:33:20 pm
I ran your (bplus) code on my "C:\Program Files (x86)\Steam\steamapps\common" folder and returned nothing. Is there some issue with read/write access, perhaps? I gave "Everyone" read/write access and it still failed to list any directories. Hmmm. I get 5,557 directories added to a presorted array in about 3.75 seconds through PowerShell. And running Steve's code, it took over 9 seconds to create and sort an array using strictly his code copy and pasted from the forum on his latest post. It had no trouble going through the directories but listed about 100 extra files as folders due to the false positive. So the false positive problem is much more than just "the one file". It's going to be happening in many places as a lot of programs create files without extensions and those appear to be the ones getting flagged as directories. Not sure why bplus's code fails completely.
Post by: bplus on June 27, 2020, 04:48:46 pm
@bplus There seems to be an issue:
I ran your code on my "C:\Program Files (x86)\Steam\steamapps\common" folder and returned nothing. Is there some issue with read/write access, perhaps? I gave "Everyone" read/write access and it still failed to list any directories. Hmmm. I get 5,557 directories listed in about 3.75 seconds through PowerShell.
You have to change directory every step to the folder in question because sub-dir Flag only works when you are directly above that.
Here is my Tiny Navigator that steps you through your hard drive hopefully C:\\ is root.
You can see if you can navigate to that folder, sorry it is constant CHDIR if want the fastest Tree code.
Code: QB64: [Select]
- ' B+ started 2019-08-22 restart 2020-06-24
- ' 2019-08-22 orig post at https://www.qb64.org/forum/index.php?topic=1646.msg108682#msg108682
- ' 2019-08-23_13-25 try fix (to nav all directories) with one place for tmpFile, theory can't write files in some dir's
- ' For some reason Windows won't write to a fully pathed file in my user folder???from a SHELL command
- ' Try testing if dir exists "C:\temp" exists and making one if not, yes! and I can write my temp files there
- ' and now I can chDir anywhere!!!!
- ' 2019-08-23_14-25 Take Steve's Advice to use users tmp directory for temp files
- ' 2019-08-23_23+ Have files window working for file selection
- ' 2020-06-24 restart using DirEntry.h, wow looks like Steve's fix helped ALLOT! Thanks SMcNeill
- ' I am hitting glitches where Windows wont let me access I think. So I am offering a c enter option
- ' to restart at the root but this might not work cross platform.
- ' 2020-06-26 another fix to DirEntry.h usage add CHR$(0) to string when calling a C program. This fixed a snag
- ' between marka and next folder up when heading to root with .. calls.
- ' direntry.h needs to be in QB64 folder
- _TITLE "Tiny Navigator using DirEntry: press f to Start a Select a File list of current directory"
- mySelection& = getArrayItemNumber&(5, 5, 50, 30, DIRs())
- PRINT "You selected a file: "; selectedFile
- INPUT "Press enter to continue navigator, any + enter to quit... "; done$
- selectedFile = ""
- PRINT "Nothing selected."
- PRINT "There are some places your OS might not allow us to go."
- PRINT "If you get stuck with 0 slections, press c (for root C:\\) enter..."
- INPUT "Press enter to continue navigator, any + enter to quit... "; done$
- _LIMIT 60
- DIM nam$
- DirCount = 0: FileCount = 0
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- DirCount = DirCount + 1
- DirList(DirCount) = nam$
- FileCount = FileCount + 1
- FileList(FileCount) = nam$
- 'close_dir 'move to after end if might correct the multi calls problem
- close_dir 'this might correct the multi calls problem
- ' "Escape or Red X box returns -1719 to allow a Cancel function and signal no slection."
- 'Notes: locateRow, locateColumn for top right corner of selection box on screen in characters for LOCATE.
- 'boxWidth and boxHeight are in character units, again for locate and print at correct places.
- 'All displaying is restricted to inside the box, which has PgUP and PgDn as top and bottom lines in the display.
- 'save old settings to restore at end ofsub
- curRow = CSRLIN
- fg = _DEFAULTCOLOR
- bg = _BACKGROUNDCOLOR
- maxWidth = boxWidth ' number of characters in box
- maxHeight = boxHeight - 2 ' number of lines displayed of array at one time = 1 page
- page = 0
- hlite = 0 ' line in display ready for selection by spacebar or if no number is started, enter
- GOSUB update ' show the beginning of the array items for selection
- 'signal cancel selection process, exit sub with this unlikely index to signal canel
- choice = -1719 'primes 7 and 8, not likely to be a select index of an array
- DO 'until get a selection or demand exit
- 'handle the key stuff
- kh& = _KEYHIT
- 'REDIM FILs(0) AS STRING 'hopefully this is already ready
- 'loadFiles FILs()
- selNum& = getArrayItemNumber&(5, 60, 60, 30, FILs())
- CLS 'need to signal out of file selection
- 'back to directory select
- ELSE 'clear b$ to show some response to enter
- choice = hlite + page * maxHeight + lba 'must mean to select the highlighted item
- 'handle the mouse stuff
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- choice = my + page * maxHeight + lba - 1 'select item clicked
- ELSE 'PgUp bar clicked
- ELSE ' mouse over highlighting, only if mouse has moved!
- hlite = my - 1
- lastMX = mx: lastMY = my
- GOSUB update
- _LIMIT 200
- getArrayItemNumber& = choice
- COLOR fg, bg
- 'clear key presses
- LOCATE curRow, curCol
- 'clear mouse clicks
- WHILE mb 'OK!
- _LIMIT 100
- update: '--------------- display of array sections and controls on screen
- 'fix hlite if it has dropped below last array item
- hlite = hlite - 1
- 'main display of array items at page * maxHeight (lines high)
- index = row + page * maxHeight + lba
- 'make page up and down bars to click, print PgUp / PgDn if available
- 'make exit sign for mouse click
- PRINT " X "
- 'if a number selection has been started show it's build = b$
- PRINT b$;
- _LIMIT 100
Oh hey! Just CHDIR to that Folder and then Tree code should work.
Post by: bplus on June 27, 2020, 04:57:41 pm
Hope you get flags fixed.
We don't have another Type problem between C code and QB64 with Flags and Length... do we?
Ie is a C Long the same as a QB64 Long? or worry about _signed and _unsigned?
Post by: SpriggsySpriggs on June 27, 2020, 05:01:29 pm
Oh hey! Just CHDIR to that Folder and then Tree code should work.yep! That worked! Good thinking, @bplus ! Your code finished in 4.66 seconds on my machine (5,557 directories), simply building and sorting the array whereas Steve's took over 9 seconds to do it. Nice! See, in this case, with PowerShell, mine works faster because it is a huge directory. Mine wins against yours coming in at 3.15 seconds because the large process can be handled by PowerShell much quicker. Small folders, your code. Big folders, my code. I wish I had a way to figure out whether or not to use yours or mine in a program depending on the number of subdirectories..... Hmmm.... I could do a PowerShell call to return the number of subdirectories and if it was greater than 1000 then run mine. Less than, run yours
Post by: bplus on June 27, 2020, 05:09:26 pm
yep! That worked! Good thinking, @bplus ! Your code finished in 4.66 seconds on my machine, simply building and sorting the array whereas Steve's took over 9 seconds to do it. Nice! See, in this case, with PowerShell, mine works faster because it is a huge directory. Mine wins against yours coming in at 3.15 seconds because the large process can be handled by PowerShell much quicker. Small folders, your code. Big folders, my code. I wish I had a way to figure out whether or not to use yours or mine in a program depending on the number of subdirectories..... Hmmm.... I could do a PowerShell call to return the number of subdirectories and if it was greater than 1000 then run mine. Less than, run yours
Well we'll see some better times I think when/if Steve can find still another fix for using the DirEntry.h method. I sure hope so because of cross platform potential but I bet we have some other issues to settle with Linux (at least) once we get Windows part working to it's full potential.
In meantime, what's 2-3 secs anyway? ;-))
Post by: SpriggsySpriggs on June 27, 2020, 05:10:41 pm
Well we'll see some better times I think when/if Steve can find still another fix for using the DirEntry.h method. I sure hope so because of cross platform potential but I bet we have some other issues to settle with Linux (at least) once we get Windows part working to it's full potential.Like I was telling Steve, PowerShell IS cross-platform now! I haven't had a chance to try it on Linux yet but I'll be sure to give it a whirl next week.
In meantime, what's 2-3 secs anyway? ;-))
Post by: bplus on June 27, 2020, 05:14:42 pm
Like I was telling Steve, PowerShell IS cross-platform now! I haven't had a chance to try it on Linux yet but I'll be sure to give it a whirl next week.
Hey you have Linux? Do you have QB64 up and running in there?
Post by: SpriggsySpriggs on June 27, 2020, 05:19:47 pm
Hey you have Linux? Do you have QB64 up and running in there?Yes, and yes, but it's a small laptop. It does, however, have a solid state drive so it might get good numbers.
Post by: SpriggsySpriggs on June 27, 2020, 05:56:51 pm
Also, it looks like your ( @bplus ) program isn't displaying anything more than the first level of folders. It doesn't CHDIR to the next folder. Not sure if that is a Linux incompatibility with QB64.
Post by: bplus on June 27, 2020, 06:44:53 pm
Post by: SpriggsySpriggs on June 27, 2020, 07:02:46 pm
Post by: Petr on July 05, 2020, 11:42:56 am
I did not sleep. I really continued to develop and I will continue to do so. I used BPlus' method to create a directory tree and then my own procedure to divide into file name / folder name. I am shocked, when found that even though the file on the disk is named track01.mp3, the listing will return it with the name from ID3 (I don't understand where DirEntry read it) but it is a valid file name, it is accessible for both QB64 and Windows Media Player. So the confusion is absolutely perfect :)
Here is another intermediate development stage, now with a known bug, the first file is not displayed in the file list (this happens during development). The program screen is a very rough preview of what I mean by that. At the top there will be icons for color settings, for print output settings and so on, in the right part of the screen there will be information read from files. For the scrolling speed, I set the condition in future version, that the file selection must take 0.3 seconds and only then the information for the file will be read.
Since last time, the program has gained for us a bit. It now creates a configuration INI file (which cannot be set otherwise yet), reads the locale code, and sets unicode characters relative to it. So you should all have legible file names in your national alphabet. What do we have next? Labels in the program. They will be adjustable according to your speech settings. The configuration already thinks about this setting. So instead of English labels you will be able to set any other, for example German, Italian and so on.
The current version does not retrieve any detailed information from the files, it only displays file names. The enter key starts the default player. There will be a lot of work to be done.
Code: QB64: [Select]
- 'Tree builder recursive.bas b+ Petr 2020-06-26 now with SMCNeill Fix!! add CHR$(0) to C string
- $COLOR:32
- _TITLE "Video and music detective V0.1 alpha"
- DEFLNG A-Z
- mask$ = "AVI,MPG,MKV,MPG,MPEG,WAV,ACC,MP4,MP3,MP2,VOC,S3M,MOD,XM,TS,MOV,AC3,WMA,WMV,FLAC,M3U," ' on end must be comma!
- ReturnMASK mask(), mask$
- path$ = SelectDIR$
- PRINT "Loading config..."
- LoadINI SortStyle&, ViewStyle&
- PRINT "Detecting country (for MAPUNICODE use)...";
- PRINT "Dynamic Library output: "; COUNTRY
- PRINT "Creating subdirectories + files list in "; path$
- MakeTree path$
- PRINT "Sorting files by mask:"
- RealFiles(RealCount) = Tree(s)
- RealCount = RealCount + 1
- NEXT s
- NEXT m
- ERASE Tree
- PRINT "Loading font arial.ttf..."
- _FONT font, my&
- PRINT "Sorting..."
- SORT RealFiles(), SortStyle&
- PRINT "Sort done, Separating name to file name, folder name and full path..."
- SeparateFileName RealFiles(), FileName(), FolderName() 'RealFiles obsahuje plnou cestu k souboru. FileName osahuje jen jmeno souboru. FolderName obsahuje jen jmeno prvniho nadrazeneho adresare. Indexy vsech se shoduji.
- PRINT "Mapping characters by country..."
- CountryA
- SCREEN my&
- DrawMyScreen ForegroundColor~&, BackgroundColor~& 'static draw
- CopyARR FileName(), arr()
- '----------------------------------------------------------------------------------- file browsing init (now contains bug, first file in the list is not visible)
- x = 25: Y = 120: Lenght = 112: Height = 40: NumDirs = 0: UseWheel = 1: first = 1
- Lb = 0
- Le = Lb + Height
- ListColor& = Black '_RGB32(166, 244, 244) nema ucinek
- InPosColor& = Red '_RGB32(67, 72, 238)
- DirColor& = Green '_RGB32(238, 22, 28)
- k$ = INKEY$
- oldposX = posX
- 'mouse support ---
- k$ = Up$
- IF _MOUSEBUTTON(1) AND MoX > (8 * Lenght) + x AND MoY > Y + (Height * 20) + 24 THEN 'mouse / down arrow
- k$ = Dn$
- '------------------
- ' --- keyboard inputs
- ' -------------------
- 'if is link selected (not dir):
- 'end of bug repair
- textpos = 0
- ' IF Le - Lb > height THEN Le = Lb + height
- LINE (x + 1, Y + 1)-(x + 3 + (8 * Lenght) + 16, Y + 3 + (20 * Height) + 38), White, BF 'erase screen
- rfs$ = RealFiles(posX)
- ' K& = _KEYHIT
- textpos = textpos + 20 'row is 20 pixel height
- text$ = arr(V)
- possss = posX + 1
- GOTO notthia
- '----------------------------------------------------------------------- extremne zpomaluje pri bezpodminecnem tisku
- WindowHeight = (23 + Height * 20) - 40
- OldGC = GC
- GC = Y + WindowHeight * Posuvnik_V_Procentech!
- COLOR Black '_RGB32(0, 0, 0)
- COLOR Black '_RGB32(127, 127, 127)
- '---------------------------------------------------------------------------
- notthia:
- NEXT V
- act = 0
- k$ = ""
- first = 2
- Browse = posX
- _SCREENCLICK MoX, MoY 'aby okno bylo stale aktivni a neprebiral ho Windows media player (moznost toto nastavit) For stay your program window still active
- command = 0
- _DELAY .3
- _LIMIT 100
- B = backgroundcolor~&
- F = foregroundcolor~&
- CLS , B
- 'Labels. Labels in this program can be set to your own language, use SETUP icon in program for creating own language file. NOT IMPLANTED IN THIS ALPHA VERSION
- 'index list: (in english lng file)
- '0 = file list:
- '1 = file details:
- '2 = Full path to file:
- COLOR Black, White
- FUNCTION GetLCiD
- FUNCTION GetUserDefaultLCID%
- FUNCTION GetSystemDefaultLangID%
- GetLCiD = GetUserDefaultLCID%
- ff = FREEFILE
- SortStyle& = 1
- ViewStyle& = 1
- BackgroundColor~& = Black
- ForegroundColor~& = White
- UsedCOUNTRY$ = "english"
- CLOSE ff
- ff = FREEFILE
- Label(i) = Label$
- i = i + 1
- SLEEP 2
- LoadNationalLabels "MaV-english.lng"
- Y = X + 1
- Y = Y + 1
- X = X + 1
- mask(i) = f$
- i = i + 1
- s$ = "\"
- S$ = "/"
- ' PRINT "Full path: ";
- ' PRINT SOURCEarr(sep)
- ' PRINT "File name: ";
- ' PRINT DESTarrFileName(sep)
- ' PRINT Miss$
- ' PRINT "Folder name: ";
- ' PRINT DESTarrFolderName(sep)
- ' PRINT Miss(sep)
- FUNCTION SelectDIR$
- hwnd& = _WINDOWHANDLE
- TYPE BROWSEINFO ' typedef struct _browseinfo 'Microsoft MSDN
- b.hwndOwner = hwnd
- ' _SCREENHIDE
- o = SHBrowseForFolder(b)
- ' _SCREENSHOW
- ' Path$ = LEFT$(s$, INSTR(s$, CHR$(0)) - 1)
- PRINT "Directory not selected, using current directory"
- SelectDIR$ = _CWD$
- length = has_next_entry
- get_next_entry nam$, flags, file_size
- 'IF _DIREXISTS(SearchDirectory + "\" + nam$) THEN
- DirCount = DirCount + 1
- DirList(DirCount) = SearchDirectory + "\" + nam$
- 'END IF
- close_dir 'Steve first fix that got navigator working
- copyStart$ = startDir
- GetSubDirs copyStart$, D()
- sAppend Tree(), D(i)
- MakeTree D(i)
- 'nation.bm my FIRST attempt for INTERNATIONAL QB64 language support.
- 'function find code page need for correct text show on screen and set (if is right font used) unicode characters.
- SUB CountryA
- c = FREEFILE
- CLOSE c
- PRINT "Alpha version developing: CountryA PowerShell output is: "; LCID_DECIMAL
- 'try find with dynamic library:
- LCID_DECIMAL = GetLCiD
- ELSE 'LINUX
- ch = FREEFILE
- CLOSE ch
- ' language code page
- 'Divehi Dhivehi Maldivian dv dv unknown code and CP
- 'Divehi Dhivehi Maldivian dv dv unknown code and CP
- KILL "nation.txt"
- 'INPUT "input text with your national characters, if is displayed wrong, try other font (set it in line 392):"; text$
- f2 = FREEFILE
- PRINT text$
- CLOSE f2
- Microsoft_pc_cp437:
- Microsoft_pc_cp737:
- Microsoft_pc_cp775:
- Microsoft_pc_cp850:
- Microsoft_pc_cp852:
- Microsoft_pc_cp855:
- Microsoft_pc_cp857:
- Microsoft_pc_cp860:
- Microsoft_pc_cp861:
- Microsoft_pc_cp862:
- Microsoft_pc_cp863:
- Microsoft_pc_cp864:
- Microsoft_pc_cp865:
- Microsoft_pc_cp866:
- Microsoft_pc_cp869:
- Microsoft_pc_cp874:
- Microsoft_windows_cp1250:
- Microsoft_windows_cp1251:
- Microsoft_windows_cp1252:
- Microsoft_windows_cp1253:
- Microsoft_windows_cp1254:
- Microsoft_windows_cp1255:
- Microsoft_windows_cp1256:
- Microsoft_windows_cp1257:
- Microsoft_windows_cp1258:
- FUNCTION WIN
- start = start + 1
- d(start) = s(start)
Post by: SpriggsySpriggs on August 17, 2020, 08:26:46 pm
Here is a screenshot of the demo app working:
[ This attachment cannot be displayed inline in 'Print Page' view ]
And here is the source code for the demo:
Code: QB64: [Select]
- _TITLE "OMDB API - Poster"
- _CONSOLETITLE "OMDB API - Movie Info"
- URL = "http://www.omdbapi.com/?apikey=a6984482&t="
- _DEST 0
- omdb = API_request(URL + FormatAsHTTP(movietitle), "omdbreq")
- poster = GetKey(omdb, "Poster")
- DIM i&
- i& = OnlineImage(poster, "testposter")
- SCREEN i&
- DIM a%
- DIM i&
- U = FREEFILE
- CLOSE #U
- KILL File
- i& = 0
- CLOSE #U
- KILL File
- OnlineImage = i&
- DIM a%
- U = FREEFILE
- CLOSE #U
- KILL File
- CLOSE #U
- KILL File
- API_request = ""
- API_request = apireq
- 'FUNCTION CURL$ (URL AS STRING, File AS STRING)
- ' DIM curlrequest AS STRING
- ' SHELL _HIDE "curl " + CHR$(34) + URL + CHR$(34) + " -o " + CHR$(34) + File + CHR$(34)
- ' DIM U AS INTEGER
- ' U = FREEFILE
- ' OPEN File FOR BINARY AS #U
- ' IF LOF(U) <> 0 THEN
- ' curlrequest = SPACE$(LOF(U))
- ' GET #U, , curlrequest
- ' CLOSE #U
- ' KILL File
- ' ELSE
- ' CLOSE #U
- ' KILL File
- ' CURL = ""
- ' EXIT FUNCTION
- ' END IF
- ' CURL = curlrequest
- 'END FUNCTION
- jkey = JSON
- GetKey = ""
- GetKey = jkey
- DIM x
- unchangejson = JSON
- x = x + 1
- jkey = unchangejson
- ParseKey(x) = jkey
- DIM j
- DIM r
- DIM r$
- r$ = a
- String.Replace = r$
- Request = paramater
- DIM start%
- DIM position%
- start% = 1
- start% = position% + 1
- FormatAsHTTP = Request