QB64.org Forum

Active Forums => Programs => Topic started by: Aeveus on April 05, 2020, 03:09:08 am

Title: Help with program
Post by: Aeveus on April 05, 2020, 03:09:08 am

Hello, I'm having trouble with this program. When I run it it seems like it's looping the menu over and over or something and it won't let me do inputs, and I'm not sure why (or even if that's the case). Any help is appreciated! :)

Code: QB64: [Select]

1. '******************************* Program Mainline **************************
2. DO
3.     GOSUB DisplayMainMenu
4.     SELECT CASE Choice$
5.         CASE "1"
6.             GOSUB UStoPounds
7.             CASE "2"
8.             GOSUB PoundstoUS
9.             CASE "3"
10.             GOSUB UStoCanadian
11.             CASE "4"
12.             GOSUB CanadiantoUS
13.     END SELECT
14. LOOP UNTIL Choice$ = "5"
15. END
16. '******************************* Display Main Menu ***********************
17. DisplayMainMenu:
18. GOSUB PrintMainTitle
19. LOCATE 5, 26
20. PRINT "CURRENCY CONVERTER"
21. LOCATE 8, 18
22. PRINT "1. CONVERT US DOLLARS TO POUNDS"
23. LOCATE 10, 18
24. PRINT "2. CONVERT POUNDS TO US DOLLARS"
25. LOCATE 12, 18
26. PRINT "3. CONVERT US DOLLARS TO CANADIAN DOLLARS"
27. LOCATE 14, 18
28. PRINT "4. CONVERT CANADIAN DOLLARS TO US DOLLARS"
29. LOCATE 16, 18
30. PRINT "5. END"
31. LOCATE 19, 16
32. PRINT "ENTER SELECTION:";
33. RETURN
34. '*************************Print Main Title *******************************
35. PrintMainTitle:
36. CLS
37. LOCATE 3, 12
38. PRINT " C O N V E R T  C U R R E N C Y "
39. RETURN
40. '**************************UstoPounds************************************
41. UStoPounds:
42. PRINT "ENTER AMOUNT:"; Amount
43. ConvertedAmount = AMOUNT * .81
44. PRINT ConvertedAmount
45. RETURN
46. '****************************PoundstoUS***************************
47. PoundstoUS:
48. PRINT "ENTER AMOUNT:"; Amount
49. ConvertedAmount = AMOUNT * 1.23
50. PRINT ConvertedAmount
51. RETURN
52. '**************************UStoCanadian****************************
53. UStoCanadian:
54. PRINT "ENTER AMOUNT:"; Amount
55. ConvertedAmount = AMOUNT * 1.42
56. PRINT ConvertedAmount
57. RETURN
58. '*******************************CanadiantoUS************************
59. CanadiantoUS:
60. PRINT "ENTER AMOUNT:"; Amount
61. ConvertedAmount = AMOUNT * .7
62. PRINT ConvertedAmount
63. RETURN
64.  

Title: Re: Help with program
Post by: TerryRitchie on April 05, 2020, 03:26:03 am

This may work out better for you.

Code: QB64: [Select]

1. '******************************* Program Mainline **************************
2.  
3. DO
4.     GOSUB DisplayMainMenu
5.     DO
6.         _LIMIT 30
7.         choice$ = INKEY$
8.     LOOP UNTIL VAL(choice$) > 0 AND VAL(choice$) < 6
9.     ON VAL(choice$) GOSUB UStoPounds, PoundstoUS, UStoCanadian, CanadiantoUS
10.     IF VAL(choice$) = 5 THEN END
11.     PRINT "press a key to return to menu"
12.     SLEEP
13. LOOP
14. '******************************* Display Main Menu ***********************
15. DisplayMainMenu:
16. GOSUB PrintMainTitle
17. LOCATE 5, 26
18. PRINT "CURRENCY CONVERTER"
19. LOCATE 8, 18
20. PRINT "1. CONVERT US DOLLARS TO POUNDS"
21. LOCATE 10, 18
22. PRINT "2. CONVERT POUNDS TO US DOLLARS"
23. LOCATE 12, 18
24. PRINT "3. CONVERT US DOLLARS TO CANADIAN DOLLARS"
25. LOCATE 14, 18
26. PRINT "4. CONVERT CANADIAN DOLLARS TO US DOLLARS"
27. LOCATE 16, 18
28. PRINT "5. END"
29. LOCATE 19, 16
30. PRINT "ENTER SELECTION:"
31. RETURN
32. '*************************Print Main Title *******************************
33. PrintMainTitle:
34. CLS
35. LOCATE 3, 12
36. PRINT " C O N V E R T  C U R R E N C Y "
37. RETURN
38. '**************************UstoPounds************************************
39. UStoPounds:
40. INPUT "ENTER AMOUNT:", Amount
41. ConvertedAmount = Amount * .81
42. PRINT ConvertedAmount
43. RETURN
44. '****************************PoundstoUS***************************
45. PoundstoUS:
46. INPUT "ENTER AMOUNT:", Amount
47. ConvertedAmount = Amount * 1.23
48. PRINT ConvertedAmount
49. RETURN
50. '**************************UStoCanadian****************************
51. UStoCanadian:
52. INPUT "ENTER AMOUNT:", Amount
53. ConvertedAmount = Amount * 1.42
54. PRINT ConvertedAmount
55. RETURN
56. '*******************************CanadiantoUS************************
57. CanadiantoUS:
58. INPUT "ENTER AMOUNT:", Amount
59. ConvertedAmount = Amount * .7
60. PRINT ConvertedAmount
61. RETURN
62.  
63.  

Title: Re: Help with program
Post by: bplus on April 05, 2020, 10:43:27 am

HI @Aeveus, you are missing INPUT statement, you have PRINT at the critical points where you need INPUT

eg

Code: QB64: [Select]

1. PRINT "Enter selection"

should be

Code: QB64: [Select]

1. INPUT "Enter selection "; choice$

You also needed a SLEEP or _DELAY to stop code from looping around menu after the converted value has been displayed.

Also as programming style goes all those GOSUBs makes for too much unneeded jumping around code.

The menu can all be combined under the mission to display whats available and get a selection.

I would do the whole thing like this:

Code: QB64: [Select]

1. OPTION _EXPLICIT '<<< checks for typos requires dim ofall your variables
2. DIM choice AS INTEGER, amt AS SINGLE, cvrt$, from$, to$
3. DO ' main loop present menu, get choice and convert amount
4.     CLS
5.     LOCATE 3, 26
6.     PRINT "CURRENCY CONVERTER"
7.     LOCATE 6, 18
8.     PRINT "1. CONVERT US DOLLARS TO POUNDS"
9.     LOCATE 8, 18
10.     PRINT "2. CONVERT POUNDS TO US DOLLARS"
11.     LOCATE 10, 18
12.     PRINT "3. CONVERT US DOLLARS TO CANADIAN DOLLARS"
13.     LOCATE 12, 18
14.     PRINT "4. CONVERT CANADIAN DOLLARS TO US DOLLARS"
15.     LOCATE 14, 18
16.     PRINT "5. END"
17.     LOCATE 17, 22
18.     INPUT "ENTER SELECTION: "; choice
19.     LOCATE 19, 22
20.     IF choice < 5 THEN
21.         INPUT "Enter amount to convert "; amt
22.         SELECT CASE choice
23.             CASE 1: cvrt$ = _TRIM$(STR$(UStoPounds(amt))): from$ = "US$": to$ = " Pounds"
24.             CASE 2: cvrt$ = _TRIM$(STR$(PoundstoUS(amt))): from$ = "Pounds": to$ = " US$"
25.             CASE 3: cvrt$ = _TRIM$(STR$(UStoCanadian(amt))): from$ = "US$": to$ = " Canadian$"
26.             CASE 4: cvrt$ = _TRIM$(STR$(CanadiantoUS(amt))): from$ = "Canadian$": to$ = " US$"
27.         END SELECT
28.         LOCATE 21, 19
29.         PRINT amt; from$; " converts to "; cvrt$; to$
30.         _DELAY 3 ' <<< pause screen before cls and next menu display
31.     END IF
32. LOOP UNTIL choice = 5
33. END
34.  
35. FUNCTION UStoPounds (amount)
36.     UStoPounds = amount * .81
37. END FUNCTION
38.  
39. FUNCTION PoundstoUS (amount)
40.     PoundstoUS = amount * 1.23
41. END FUNCTION
42.  
43. FUNCTION UStoCanadian (amount)
44.     UStoCanadian = amount * 1.42
45. END FUNCTION
46.  
47. FUNCTION CanadiantoUS (amount)
48.     CanadiantoUS = amount * .7
49. END FUNCTION
50.  
51.  

Title: Re: Help with program
Post by: gaslouk on April 05, 2020, 12:08:16 pm

Code: QB64: [Select]

1. '******************************* Program Mainline **************************
2. OPTION _EXPLICIT '<<< checks for typos requires dim for all your variables
3. DIM SHARED choice AS LONG
4. DIM SHARED amount AS LONG
5. DIM SHARED convertedamount AS LONG
6.  
7. 1 GOSUB DisplayMainMenu
8.  
9. SELECT CASE choice
10.   CASE 1
11.     GOSUB UStoPounds
12.   CASE 2
13.     GOSUB PoundstoUS
14.   CASE 3
15.     GOSUB UStoCanadian
16.   CASE 4
17.     GOSUB CanadiantoUS
18.   CASE 5
19.     SYSTEM
20. END SELECT
21. LOCATE 19, 34
22. INPUT "Your Choise:"; choice
23. GOSUB 1
24. END
25. '******************************* Display Main Menu ***********************
26. DisplayMainMenu:
27. GOSUB PrintMainTitle
28. LOCATE 5, 26
29. PRINT "CURRENCY CONVERTER"
30. LOCATE 8, 18
31. PRINT "1. CONVERT US DOLLARS TO POUNDS"
32. LOCATE 10, 18
33. PRINT "2. CONVERT POUNDS TO US DOLLARS"
34. LOCATE 12, 18
35. PRINT "3. CONVERT US DOLLARS TO CANADIAN DOLLARS"
36. LOCATE 14, 18
37. PRINT "4. CONVERT CANADIAN DOLLARS TO US DOLLARS"
38. LOCATE 16, 18
39. PRINT "5. END"
40. LOCATE 19, 16
41. PRINT "ENTER SELECTION:";
42. RETURN
43. '*************************Print Main Title *******************************
44. PrintMainTitle:
45. CLS
46. LOCATE 3, 12
47. PRINT " C O N V E R T  C U R R E N C Y "
48. RETURN
49. '**************************UstoPounds************************************
50. UStoPounds:
51. LOCATE 20, 16
52. INPUT "ENTER AMOUNT:"; amount
53. convertedamount = amount * .81
54. LOCATE 21, 16
55. PRINT "Your Somthing is: "; convertedamount
56. RETURN
57. '****************************PoundstoUS***************************
58. PoundstoUS:
59. LOCATE 20, 16
60. INPUT "ENTER AMOUNT:"; amount
61. convertedamount = amount * 1.23
62. LOCATE 21, 16
63. PRINT "Your Somthing is: "; convertedamount
64. RETURN
65. '**************************UStoCanadian****************************
66. UStoCanadian:
67. LOCATE 20, 16
68. INPUT "ENTER AMOUNT:"; amount
69. convertedamount = amount * 1.42
70. LOCATE 21, 16
71. PRINT "Your Somthing is: "; convertedamount
72. RETURN
73. '*******************************CanadiantoUS************************
74. CanadiantoUS:
75. LOCATE 20, 16
76. INPUT "ENTER AMOUNT:"; amount
77. convertedamount = amount * .7
78. LOCATE 21, 16
79. PRINT "Your Somthing is: "; convertedamount
80. RETURN

Aeveus this is your program.

Title: Re: Help with program
Post by: odin on April 05, 2020, 12:10:31 pm

Please use code boxes (click the QB64 button when writing a post and paste your code inside the [code] and [/code] tags.

It has been done for you in the post above.

Text Only | Text with Attachments