Text Only | Text with Attachments

QB64.org Forum

Active Forums => Programs => Topic started by: SMcNeill on December 26, 2019, 04:30:09 pm

Title: A new Keyhit
Post by: SMcNeill on December 26, 2019, 04:30:09 pm
For a long time now, I realized that there were a few keys which mapped wrongly with _KEYHIT, but they were never really much of an issue in my code, so I didn't bother to dig extensively into them.  A few times, I've dug into the qb64 source in libqb.cpp to try and see if I could sort out what was wrong with a few of them (CTRL-TAB is generally the one which affects me the most, as I use it for a reverse tab process normally.), but I've never been able to decipher exactly what the heck is going on in there to correct things.

So, now I'm working on a new project (or at least trying to, though it seems I have to keep rebuilding basic development tools before I can actually go anywhere with it like I want), and once again, I need some of those "lost" or "misplaced" keys.  This morning, I sorted out how to get the values of every key with GetAsyncKeyState (you can look at it here: https://www.qb64.org/forum/index.php?topic=2030.0), but it returns values and codes which I'm not that used to using.  Normally I use _KEYHIT and _KEYDOWN for my programs, and I really don't want to have to swap everything over to the virtual key codes...

So, I sat down and started to write a patch to fix and fill in those missing codes in _KEYHIT for me.  The work is definitely a work-in-progress, as I'm still finding and patching issues, but I wanted to go ahead and share what I've came up with so far.

Code: QB64: [Select]
  1. DECLARE LIBRARY 'function is already used by QB64 so "User32" is not required
  2.     FUNCTION GetAsyncKeyState% (BYVAL vkey AS LONG)
  4.  
  5.  
  6.  
  8.     k = Keyhit(oldkeyhit&)
  9.     IF k <> 0 THEN PRINT k, oldkeyhit&
  10.     _LIMIT 30
  12.  
  13. FUNCTION Keyhit& (oldkeyhit&)
  14.     STATIC MenuDelay AS _FLOAT, MenuDown AS _BYTE
  15.     STATIC TabDelay AS _FLOAT, TabDown AS _BYTE
  16.     STATIC BackspaceDelay AS _FLOAT, BackspaceDown AS _BYTE
  17.     STATIC TildeDelay AS _FLOAT, BackQuoteDelay AS _FLOAT
  18.     STATIC NumDelay(0 TO 19) AS _FLOAT
  19.     STATIC JDelay AS _FLOAT, JDown AS _BYTE
  20.     STATIC SysDelay AS _FLOAT, SysDown AS _BYTE
  21.     STATIC ScrollDelay AS _FLOAT, ScrollDown AS _BYTE
  22.     STATIC PauseDelay AS _FLOAT, PauseDown AS _BYTE
  23.     STATIC NumDelay AS _FLOAT, NumDown AS _BYTE 'num lock
  24.     STATIC Num5Delay AS _FLOAT, Num5Down AS _BYTE 'number 5 key on the num pad
  25.     DIM RepeatRate AS _FLOAT: RepeatRate = 0.2 'necessary so we don't spam key returns with GetAsyncKeyState
  26.  
  27.     k = _KEYHIT: oldkeyhit& = k
  28.  
  30.         'Fix for number 5 on the num pad, when numlock is active
  31.         IF GetAsyncKeyState(12) THEN 'pause key, which has no value (and probably still won't, as QB64 uses it as a command code for pausing program execution
  32.             'and gives a false result on a keyup
  33.             IF ExtendedTimer > Num5Delay THEN k = 19456: Num5Down = -1: Num5Delay = ExtendedTimer + RepeatRate ELSE k = 0
  34.         ELSE
  35.             IF Num5Down THEN k = -19456: Num5Down = 0
  36.         END IF
  37.  
  38.         'Fix for Pause Key
  39.         IF GetAsyncKeyState(19) THEN 'pause key, which has no value (and probably still won't, as QB64 uses it as a command code for pausing program execution
  40.             'and gives a false result on a keyup
  41.             IF ExtendedTimer > PauseDelay THEN k = 100019: PauseDown = -1: PauseDelay = ExtendedTimer + RepeatRate ELSE k = 0
  42.         END IF
  43.  
  44.         'Fix for the Menu Key
  45.         IF GetAsyncKeyState(93) THEN 'menu key, which doesn't work at all on keydown
  46.             'and gives a false result on a keyup
  47.             IF ExtendedTimer > MenuDelay THEN k = 100319: MenuDown = -1: MenuDelay = ExtendedTimer + RepeatRate ELSE k = 0
  48.         END IF
  49.  
  50.         'Fix for SYS Key
  51.         IF GetAsyncKeyState(44) THEN 'SYS key, which currently thinks it's a comma
  52.             'and gives a false result on a keyup
  53.             IF ExtendedTimer > SysDelay THEN k = 100316: SysDown = -1: SysDelay = ExtendedTimer + RepeatRate ELSE k = 0
  54.         END IF
  55.         'Fix for NUM LOCK Key
  56.         IF GetAsyncKeyState(144) THEN 'num lock key, which currently toggles itself with the down value
  57.             'changing from a up code to a down code, depending on numlock status
  58.             'and gives a false result on keyup
  59.             IF ExtendedTimer > NumDelay THEN k = 100300: NumDelay = ExtendedTimer + RepeatRate ELSE k = 0
  60.         END IF
  61.  
  62.         'FIX for SCROLL LOCK Key
  63.         IF GetAsyncKeyState(145) THEN 'scroll lock key, which has no down value
  64.             'and gives a false result on keyup
  65.             IF ExtendedTimer > ScrollDelay THEN k = 100302: ScrollDelay = ExtendedTimer + RepeatRate ELSE k = 0
  66.         END IF
  67.  
  68.  
  69.  
  70.         IF _KEYDOWN(100305) OR _KEYDOWN(100306) THEN 'control is down
  71.             'Fix for CTRL-Tab
  72.             IF GetAsyncKeyState(9) THEN 'ctrl-tab; return tab, not CTRL-I
  73.                 IF ExtendedTimer > TabDelay THEN k = 9: TabDown = -1: TabDelay = ExtendedTimer + RepeatRate ELSE k = 0
  74.             END IF
  75.             'Fix for CTRL-Backspace
  76.             IF GetAsyncKeyState(8) THEN 'ctrl-backspace; return backspace, not CTRL-Delete
  77.                 IF ExtendedTimer > BackspaceDelay THEN k = 8: BackspaceDown = -1: BackspaceDelay = ExtendedTimer + RepeatRate ELSE k = 0
  78.             END IF
  79.             'Fix for CTRL-J
  80.             IF GetAsyncKeyState(74) THEN 'CTRL-J; return ctrl-j, not ctrl-return
  81.                 IF ExtendedTimer > JDelay THEN k = 106: JDown = -1: JDelay = ExtendedTimer + RepeatRate ELSE k = 0
  82.             END IF
  83.  
  84.             'Fix for CTRL-Tilde, CTRL-Backquote
  85.             IF GetAsyncKeyState(192) THEN 'ctrl-tilde, ctrl-backquote -- neither are supported
  86.                 IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'determine which it is, via if shift is down
  87.                     IF ExtendedTimer > TildeDelay THEN k = 126: TildeDelay = ExtendedTimer + RepeatRate ELSE k = 0
  88.                 ELSE
  89.                     IF ExtendedTimer > BackQuoteDelay THEN k = 96: BackQuoteDelay = ExtendedTimer + RepeatRate ELSE k = 0
  90.                 END IF
  91.             END IF
  92.             'Fix for CTRL-0 to CTRL-9
  93.             FOR i = 0 TO 9
  94.                 IF GetAsyncKeyState(i + 48) THEN 'ctrl-0 to ctrl-9
  95.                     IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'determine which it is, via if shift is down
  96.                         IF ExtendedTimer > NumDelay(i) THEN
  97.                             SELECT CASE i 'WTF are these key codes all over the damn place??
  98.                                 CASE 0: k = 41
  99.                                 CASE 1: k = 33
  100.                                 CASE 2: k = 64
  101.                                 CASE 3: k = 35
  102.                                 CASE 4: k = 36
  103.                                 CASE 5: k = 37
  104.                                 CASE 6: k = 94
  105.                                 CASE 7: k = 38
  106.                                 CASE 8: k = 42
  107.                                 CASE 9: k = 40
  108.                             END SELECT
  109.                             NumDelay(i) = ExtendedTimer + RepeatRate
  110.                         END IF
  111.                     ELSE
  112.                         IF ExtendedTimer > NumDelay(i) THEN k = 48 + i: NumDelay(i) = ExtendedTimer + RepeatRate ELSE k = 0
  113.                     END IF
  114.                 END IF
  115.             NEXT
  116.         END IF
  117.  
  118.  
  119.         'Key up releases for the keys which we've been remapping
  120.  
  121.         SELECT CASE k
  122.             CASE 0 'We didn't read a keypress at all
  123.                 IF PauseDown THEN k = -100019: PauseDown = 0
  124.             CASE 13: JDown = 0 'Enter was hit, not CTRL-J
  125.             CASE 93: MenuDown = 0 '] was hit after menu
  126.             CASE 105: TabDown = 0 'CTRL-I was hit, rather than CTRL-Tab
  127.             CASE 21248: BackspaceDown = 0 'Delete was hit, rather than CTRL-Backspace
  128.             CASE -13 '-13 is the release code for both ENTER and CTRL-J
  129.                 IF JDown THEN k = -106: MenuDown = 0
  130.             CASE -16, -17, -18 'shift release, ctrl release, alt release
  131.                 k = 0 'no need to report these as release codes, if we don't report them as down codes.
  132.                 'Instead, we report these as LEFT/RIGHT shift, ctrl, alt key releases and not just a generic "SHIFT WAS RELEASED" code.
  133.             CASE -44 '-44 is the release code for both SYS and comma
  134.                 IF SysDown THEN k = -100316: SysDown = 0
  135.             CASE -48 TO -57 '0 to 9 shares the same release codes, regardless of if shift is pressed
  136.                 IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'if shift is down
  137.                     SELECT CASE k
  138.                         CASE -48: k = -41 'it's ), not 0
  139.                         CASE -49: k = -33 '!, not 1
  140.                         CASE -50: k = -64 '@, not 2
  141.                         CASE -51: k = -35 '#, not 3
  142.                         CASE -52: k = -36 '$, not 4
  143.                         CASE -53: k = -37 '%, not 5
  144.                         CASE -54: k = -94 '^, not 6
  145.                         CASE -55: k = -38 '&, not 7
  146.                         CASE -56: k = -42 '*, not 8
  147.                         CASE -57: k = -40 '(, not 9
  148.                     END SELECT
  149.                 END IF
  150.             CASE -93 '-93 is the release code for both MENU and ]
  151.                 IF MenuDown THEN k = -100319: MenuDown = 0
  152.             CASE -105 '-105 is the release code for both CTRL-TAB and CTRL-I
  153.                 IF TabDown THEN k = -9: TabDown = 0
  154.             CASE -106 '-106 is the release code for both CTRL-J and ENTER
  155.                 IF JDown THEN k = -106: TabDown = 0
  156.             CASE -144: k = -100300 'Num lock key currently returns virtual code release values/
  157.             CASE -145: k = -100302 'Scroll lock key currently returns virtual code release values
  158.             CASE -192 'CTRL-` and CTRL-~ both  map to this key, but only up a key up event
  159.                 IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'determine which it is, via if shift is down
  160.                     k = -126
  161.                 ELSE
  162.                     k = -96
  163.                 END IF
  164.             CASE -21248 '-21248 is the release code for both CTRL-Backspace and Delete
  165.                 IF BackspaceDown THEN k = -8: BackspaceDown = 0
  166.         END SELECT
  167.     END IF
  168.     Keyhit = k
  170.  
  171. FUNCTION ExtendedTimer##
  172.     'modified extendedtimer to store the old day's count, and not have to recalculate it every time the routine is called.
  173.  
  174.     STATIC olds AS _FLOAT, old_day AS _FLOAT
  175.     DIM m AS INTEGER, d AS INTEGER, y AS INTEGER
  176.     DIM s AS _FLOAT, day AS STRING
  177.     IF olds = 0 THEN 'calculate the day the first time the extended timer runs
  178.         day = DATE$
  179.         m = VAL(LEFT$(day, 2))
  180.         d = VAL(MID$(day, 4, 2))
  181.         y = VAL(RIGHT$(day, 4)) - 1970
  182.         SELECT CASE m 'Add the number of days for each previous month passed
  183.             CASE 2: d = d + 31
  184.             CASE 3: d = d + 59
  185.             CASE 4: d = d + 90
  186.             CASE 5: d = d + 120
  187.             CASE 6: d = d + 151
  188.             CASE 7: d = d + 181
  189.             CASE 8: d = d + 212
  190.             CASE 9: d = d + 243
  191.             CASE 10: d = d + 273
  192.             CASE 11: d = d + 304
  193.             CASE 12: d = d + 334
  194.         END SELECT
  195.         IF (y MOD 4) = 2 AND m > 2 THEN d = d + 1 'add a day if this is leap year and we're past february
  196.         d = (d - 1) + 365 * y 'current month days passed + 365 days per each standard year
  197.         d = d + (y + 2) \ 4 'add in days for leap years passed
  198.         s = d * 24 * 60 * 60 'Seconds are days * 24 hours * 60 minutes * 60 seconds
  199.         old_day = s
  200.     END IF
  201.     IF TIMER < oldt THEN 'we went from 23:59:59 (a second before midnight) to 0:0:0 (midnight)
  202.         old_day = s + 83400 'add another worth of seconds to our counter
  203.     END IF
  204.     oldt = TIMER
  205.     olds = old_day + oldt
  206.     ExtendedTimer## = olds
  208.  

The list of issues which I've found so far boggles my mind!  I thought this was just a small issue, limited to a very few number of select keys which was affected.  From what I've actually discovered, I'm now wondering why the heck _KEYHIT and _KEYDOWN are used by anyone!!  Things are broken BAD, and I had no idea...

The Menu key is completely broken.
CTRL-Tab reports itself as CTRL-I.
CTRL-Backspace reports itself as Delete.
CTRL-Tilde and CTRL-Backquote aren't supported at all.
CTRL- 0 to CTRL-9 have no keydown codes, only keyup codes.
CTRL-) to CTRL-( have no codes whatsoever.  They just report themselves as CTRL-0 to CTRL-9 codes.

And that's only the glitches which I've sorted out this afternoon, while playing around with the values.  Some of these return no values whatsoever, others return values which are completely unfathomable (CTRL-@ returns a value of 200000, or so.), and others return duplicate values on things...

Try the program above and test it out with some of the CTRL-key presses as mentioned in the comments in the code, and you can see the differences for yourself.  Who knew the command was broken so badly?!!

If anyone finds code combinations which don't work as they should, kindly report them to me and I'll add them to this little routine for now, so it can be used as a patch until someone can actually sort out what the heck is so wrong with QB64 itself.  :)


EDIT: Code assembled into Library format and attached to the bottom of this post.

Just $INCLUDE the file below, at the bottom of your desired QB64 program, and then make use of Keyhit instead of _KEYHIT.  Only works for Windows.  Linux/Mac users will need to find a different way to patch the incorrect return values, if they need to.
Title: Re: A new Keyhit
Post by: RhoSigma on December 26, 2019, 05:54:05 pm
Quote from: SMcNeill on December 26, 2019, 04:30:09 pm
... Things are broken BAD, and I had no idea ...
... Who knew the command was broken so badly?!! ...

Oh holy Steve, finally....
...finally somebody else recognized it, it's not only _KEYHIT, it's all keyboard based  input, INKEY$, INPUT$, (LINE) INPUT.

I was complaining about this at least a dozens times over at the old qb64(.)net forum since 2013 when Galleon switched from SDL to GL. Never anything happend until I got really wiry about, then most told me I shall forget about, as SDL behavior will never come back and I should better adopt myself to GL or go away.

Even here https://qb64forum.alephc.xyz/index.php?topic=304.msg104079#msg104079 I mentioned it again when v1.3 was released, but nobody picked it up (again), because it was more important how _INSTRREV works and I was so evil to be completely on Fellippes side here.

Then, later in the year I came up with my own INKEY$ replacement (https://qb64forum.alephc.xyz/index.php?topic=1385.msg105704#msg105704) to be at least able to work in german with CP437 again, as I knew & loved it from the old SDL version. Unfortunately this approch does not work international, as every country has other KB layouts and returns different values.

So, yes Steve, I know how severly this is broken since the birth of QB64 GL...
Title: Re: A new Keyhit
Post by: SMcNeill on December 26, 2019, 06:30:50 pm
Test the other input routine out, Rho; see if it’ll work for your needs.  https://www.qb64.org/forum/index.php?topic=2030.0

The issue with the keys seems to be things just returning cross-values.  A lot of the faulty keyhit codes are actually the proper return codes for the virtual keyboard codes...  (like the 192 for tilde and backquote). 

I’ve dug into libqb a few times in the past, but can’t decipher how it decides which value to return back to us (or why it skips over several of them completely).  For now, the best I can do is Fraken-patch two different input methods together to get them to return the proper codes for us — which is what the code in the topic here is all about.  ;)
Title: Re: A new Keyhit
Post by: RhoSigma on December 26, 2019, 07:27:27 pm
I've tested the routine from this topic. It works until it comes to the international chars, which require an accent key or AltGr, or in short extended ASCII 128-255. In general I don't need _KEYHIT so much, INKEY$ is much more important for me, that's why I made my mentioned german keyboard to CP437 INKEY$ replacement.

As far as I could figure out the differences in the input behavior between SDL vs. GL it seems to me as in the old SDL version raw key codes were collected from keyboard, which then were mapped by SDL to the CP437 or whatever CP was selected in the IDE.

For GL it seems that not raw key codes are collected, but the codes already mapped to the systems default CP and then without further mapping by GL these codes are simply returned to the IDE, hence it works only if your selected IDE codepage does match the systems default codepage.

Another thinkable scenario is, that still raw key codes are collected, but GL does always map these to the systems default codepage, instead of the selected IDE codepage.

However, you guys out there, who not have an AltGr key on their keyboards should still keep the possibility of such an AltGr in mind when checking for the ALT modifier, cause AltGr is a complete other (4th) modifier. For correct behavior you should always use the following logic:

Code: QB64: [Select]
  1. '--- get modifiers ---
  2. shift% = _KEYDOWN(100303) OR _KEYDOWN(100304)
  3. ctrl% = _KEYDOWN(100305) OR _KEYDOWN(100306)
  4. altgr% = _KEYDOWN(100307) AND _KEYDOWN(100306)
  5. alt% = (_KEYDOWN(100307) OR _KEYDOWN(100308)) AND NOT altgr%
  6.  
Title: Re: A new Keyhit
Post by: SMcNeill on December 26, 2019, 08:02:39 pm
Isn’t the AltGr key just a combination CTRL-ALT key?  At least, I think Ctrl-Alt is the method used to generate AltGr keystrokes on a keyboard without that key.  Or it used to be.  Or else my memory is crap anymore and it was just some program I used that substituted Alt-Ctrl for AltGr.
Title: Re: A new Keyhit
Post by: RhoSigma on December 26, 2019, 08:31:31 pm
To be exact AltGr internally is a combination of right ALT + left CTRL, and used to generate chars, it should  otherwise not trigger activation of the menu bar, which is unfortunately the case in many programs (even in big comercial apps sometimes).

E.g. InForm has this problem too. As the backslash is an AltGr char on german keyboards, I can't do such simple things like writing a path\file into an input field, because I need to press the AltGr key to get the \, but that's immediately activating the menu and more worse deletes the already written path, because it wasn't confirmed yet with enter. The only way to enter such a path\file for me is to write it in a text editor, copy it and then paste it into InForm.

Same is for instance the alternative ALT + number input method. It should not work with AltGr, because here on my german keyboard I've lots of AltGr chars on the number keys (²³{[]}).

So the easiest is to treat it as a complete different modifier as I show in my code snippet above.
Title: Re: A new Keyhit
Post by: SMcNeill on December 26, 2019, 09:09:52 pm
Do you have a list of the keys and scan codes for the AltGr keys?  I’ll add them to my work here while I’m at it.  If not, I might be able to get them from the QB64 SDL version.  As long as I know what values they should be, I can tweak the output, as above, to produce suitable results. 
Title: Re: A new Keyhit
Post by: SMcNeill on December 27, 2019, 03:42:21 am
Updated the original post to make several more corrections.  So far, the list of bugs here are:


Are there more glitches than those in _KEYHIT?  I'm willing to bet that there sure are!  I don't have a copy of the AltGr codes which Rho was talking about above, so I can't code those into the routine.  I wouldn't swear that every change here will work with all languages or keyboard layouts (not without a lot of people testing things).  I've probably missed various other keystroke combinations like CTRL-ALT-SHIFT-W or some odd tweak like that.

If anyone ever comes up with a missing code/incorrect combo/wrong value, then let me know and I'll do my best to correct the issue and map the values back to what they should be for us.


One thing I want to point out for all users of this patched _KEYHIT routine:

Code: [Select]
    DIM RepeatRate AS _FLOAT: RepeatRate = 0.2 'necessary so we don't spam key returns with GetAsyncKeyState
Since a lot of these codes don't have any sort of keydown code associated with them, I had to use GetAsyncKeyState to find their status.  GetAsyncKeyState works a lot like a _KEYDOWN event, moreso than a _KEYHIT event, so it'd endlessly spam up with keyhit codes.  To stop this, I've added in a RepeatRate where it won't return a second keystroke until the proper amount of time has passed.  For me, 0.2 seconds works perfect, or at least close enough to perfect, so that it mimics my keyboard's natural repeat rate.

If you have a slower repeat rate for your keyboard then you might increase that pause.  If you want faster duplicates, decrease the pause between them.  It's a simple variable, for ease of user alteration.

Note 2: These changes only work on Window's Systems, since this uses a window library call.  Sorry Linux/Mac folks; you'll need to work out a different patchwork system for the changes.  At least with this, you can have a list of what's broken, to make fixing it on your own system work better.  (I'm certain Linux/Mac has a substitute GetAsyncKeyState% command.  I just don't know what it is.  Sorry -- I'm a Window's guy!)

Title: Re: A new Keyhit
Post by: RhoSigma on December 27, 2019, 08:21:32 am
I think you go to far with this Steve, according to the CTRL combos, as long as I code (~30yrs) I know the CTRL synonymes for those keys (or better chars):

Esc = CHR$(27) = CTRL+[
Tab = CHR$(9) = CTRL-I
Enter (as CR (CHR$(13))) = CTRL-J
Enter (as LF (CHR$(10))) = CTRL-M

and there were some more for vertical tab, form feed, and backspace which I don't remember. I guess this comes from the ancient DOS days and was probably also used to control printers. How much sense it still makes these days is on another piece of paper.

As to the AltGr chars, I don't know if its a good idea to hardcode those into your routine, as they are probably very depenend on language or even regions of the same language. E.g. German KBs are also different between Germany, Switzerland and Luxemburg, its all german, but different :) Usually you find the AltGr triggered chars in the bottom-right corner of the Keys you have to press while holding down AltGr.

However, do you know how the brake on your car works? Maybe yes, maybe no, and it doesn't matter. What's important is, that you slow down immediately when you kick the pedal.
Same here, I'm not interrested in scancodes, or if a key is currently pressed or released, what's really important is, that an @ appears on the screen at my INPUT prompt, when I press the key(s) to get an @, dosen't matter if this @ got its own key on the KB, is an AltGr combo or even a impossible multiple key combo which would break your fingers. And also it shouldn't matter which codepage is selected in the IDE or your program. If the @ is available on that specific CP (and it should in all), then print it, done. And this must work with all chars, doesn't matter how many keys you've to press to get them.

That's, as far as I experience it from my daily work with QB64, works in the SDL version, but not in GL. There must be checked what's broken with the transition from SDL to GL, and if required the complete keyboard input system might need to rewritten from scratch in the GL version. To plug in a custom input routine in every program and for every country and every codepage is no solution.

I'm afraid, this will never change, as Galleons coding style and formatting is simply to horrible to get through to the deeply hidden truth.
Title: Re: A new Keyhit
Post by: SMcNeill on December 27, 2019, 08:56:07 am
Quote
Esc = CHR$(27) = CTRL+[
Tab = CHR$(9) = CTRL-I
Enter (as CR (CHR$(13))) = CTRL-J
Enter (as LF (CHR$(10))) = CTRL-M

Those, and all the A-Z keys, were part of the terminal control code set back in the day.

CTRL-0 gave a CHR$(0) value.
CTRL-A gave CHR$(1).
CTRL-Z gave CHR$(26).

The problem with the way KEYHIT implements the scancodes though, is that it only works for a limited few of them and not others.  Why use CTRL-I for Tab (CHR$(9)), when you don’t use CTRL-A for CHR$(1)?  Or CTRL-H for backspace (CHR$(8))?

Keyhit should map a code for each key hit, and then a user can interpret if those codes hold special meaning or not.  As it currently exists, CTRL-I is a duplicate of TAB, so what is CTRL-Tab?  A CTRL-CTRL-I keystroke — which breaks down to a CTRL-I keystroke...

There’s no way to map those as independent process in our code, as they currently exist in the GL version.  CTRL-TAB = CTRL-I.

Going back to the SDL version, as you mentioned, the keys return different values.  TAB is 9, I is 103(?; I’m guessing from my poor memory), and CTRL is a modifier key.  You can tell one from the other, at all times, and that’s the behavior I’ve reimplemented here.  ;)

If one likes CTRL-@ to CTRL ] for CHR$(0) to CHR$(31), they should code those combinations into their program’s input handling/processing routines, rather than have _KEYHIT map multiple buttons to the same code. 

If we keep them separate, we can code CTRL-J for a CHR$(13) key, and CTRL-ENTER can be something different than just a CTRL-CTRL-J keypress.

(And, btw, the return values are even reversed for CTRL-J and CTRL-M, if you compare them to the old control code values.  A to Z represented CHR$(1) to CHR$(26)...  CTRL-J should be CHR$(10), while CTRL-M is CHR$(13) — or ENTER.)


Quote
I'm afraid, this will never change, as Galleons coding style and formatting is simply to horrible to get through to the deeply hidden truth.

I’ve tried a few times, but I just can’t sort it out at all.  Honestly, I think at some point, we should consider going back and add SDL 2 into our library mix, and let it handle the font and keyboard routines for us.  Eventually, I might try and go that route for my own repo sometime in the future.


Edit:  CTRL-@ to CTRL-_ for 0 to 31.  https://www.windmill.co.uk/ascii-control-codes.html

13 was ENTER (CTRL-M), so CTRL-J is still returning a wrong value, no matter how you look at it.  ;)
Title: Re: A new Keyhit
Post by: SMcNeill on December 27, 2019, 05:13:45 pm
Code: QB64: [Select]
  2.     k = Keyhit
  3.     IF k <> 0 THEN PRINT k, oldkeyhit&
  4.     _LIMIT 30
  6.  
  7.  
  8. $IF WIN THEN
  9.     FUNCTION Keyhit&
  10.         DECLARE LIBRARY 'function is already used by QB64 so "User32" is not required
  11.             FUNCTION GetAsyncKeyState% (BYVAL vkey AS LONG)
  12.         END DECLARE
  13.  
  14.         CONST AcceptMouseKeys = -1, AcceptMusicKeys = -1
  15.  
  16.  
  17.         STATIC MenuDelay AS _FLOAT, MenuDown AS _BYTE
  18.         STATIC TabDelay AS _FLOAT, TabDown AS _BYTE
  19.         STATIC BackspaceDelay AS _FLOAT, BackspaceDown AS _BYTE
  20.         STATIC TildeDelay AS _FLOAT, BackQuoteDelay AS _FLOAT
  21.         STATIC NumDelay(0 TO 19) AS _FLOAT
  22.         STATIC JDelay AS _FLOAT, JDown AS _BYTE
  23.         STATIC SysDelay AS _FLOAT, SysDown AS _BYTE
  24.         STATIC ScrollDelay AS _FLOAT, ScrollDown AS _BYTE
  25.         STATIC PauseDelay AS _FLOAT, PauseDown AS _BYTE
  26.         STATIC NumDelay AS _FLOAT, NumDown AS _BYTE 'num lock
  27.         STATIC Num5Delay AS _FLOAT, Num5Down AS _BYTE 'number 5 key on the num pad
  28.         STATIC RepeatRate AS _FLOAT: RepeatRate = 0.2 'necessary so we don't spam key returns with GetAsyncKeyState
  29.         STATIC MouseDelay(1 TO 6) AS _FLOAT, MouseDown(1 TO 6) AS _BYTE
  30.         STATIC MusicDelay(173 TO 179) AS _FLOAT, MusicDown(173 TO 179) AS _BYTE
  31.  
  32.         k = _KEYHIT
  33.  
  34.         IF _WINDOWHASFOCUS THEN
  35.             'Fix for number 5 on the num pad, when numlock is active
  36.             IF GetAsyncKeyState(12) THEN 'pause key, which has no value (and probably still won't, as QB64 uses it as a command code for pausing program execution
  37.                 'and gives a false result on a keyup
  38.                 IF ExtendedTimer > Num5Delay THEN k = 19456: Num5Down = -1: Num5Delay = ExtendedTimer + RepeatRate ELSE k = 0
  39.             ELSE
  40.                 IF Num5Down THEN k = -19456: Num5Down = 0
  41.             END IF
  42.  
  43.             'Fix for Pause Key
  44.             IF GetAsyncKeyState(19) THEN 'pause key, which has no value (and probably still won't, as QB64 uses it as a command code for pausing program execution
  45.                 'and gives a false result on a keyup
  46.                 IF ExtendedTimer > PauseDelay THEN k = 100019: PauseDown = -1: PauseDelay = ExtendedTimer + RepeatRate ELSE k = 0
  47.             END IF
  48.  
  49.             'Fix for the Menu Key
  50.             IF GetAsyncKeyState(93) THEN 'menu key, which doesn't work at all on keydown
  51.                 'and gives a false result on a keyup
  52.                 IF ExtendedTimer > MenuDelay THEN k = 100319: MenuDown = -1: MenuDelay = ExtendedTimer + RepeatRate ELSE k = 0
  53.             END IF
  54.  
  55.             'Fix for SYS Key
  56.             IF GetAsyncKeyState(44) THEN 'SYS key, which currently thinks it's a comma
  57.                 'and gives a false result on a keyup
  58.                 IF ExtendedTimer > SysDelay THEN k = 100316: SysDown = -1: SysDelay = ExtendedTimer + RepeatRate ELSE k = 0
  59.             END IF
  60.             'Fix for NUM LOCK Key
  61.             IF GetAsyncKeyState(144) THEN 'num lock key, which currently toggles itself with the down value
  62.                 'changing from a up code to a down code, depending on numlock status
  63.                 'and gives a false result on keyup
  64.                 IF ExtendedTimer > NumDelay THEN k = 100300: NumDelay = ExtendedTimer + RepeatRate ELSE k = 0
  65.             END IF
  66.  
  67.             'FIX for SCROLL LOCK Key
  68.             IF GetAsyncKeyState(145) THEN 'scroll lock key, which has no down value
  69.                 'and gives a false result on keyup
  70.                 IF ExtendedTimer > ScrollDelay THEN k = 100302: ScrollDelay = ExtendedTimer + RepeatRate ELSE k = 0
  71.             END IF
  72.  
  73.  
  74.  
  75.             IF _KEYDOWN(100305) OR _KEYDOWN(100306) THEN 'control is down
  76.                 'Fix for CTRL-Tab
  77.                 IF GetAsyncKeyState(9) THEN 'ctrl-tab; return tab, not CTRL-I
  78.                     IF ExtendedTimer > TabDelay THEN k = 9: TabDown = -1: TabDelay = ExtendedTimer + RepeatRate ELSE k = 0
  79.                 END IF
  80.                 'Fix for CTRL-Backspace
  81.                 IF GetAsyncKeyState(8) THEN 'ctrl-backspace; return backspace, not CTRL-Delete
  82.                     IF ExtendedTimer > BackspaceDelay THEN k = 8: BackspaceDown = -1: BackspaceDelay = ExtendedTimer + RepeatRate ELSE k = 0
  83.                 END IF
  84.                 'Fix for CTRL-J
  85.                 IF GetAsyncKeyState(74) THEN 'CTRL-J; return ctrl-j, not ctrl-return
  86.                     IF ExtendedTimer > JDelay THEN k = 106: JDown = -1: JDelay = ExtendedTimer + RepeatRate ELSE k = 0
  87.                 END IF
  88.  
  89.                 'Fix for CTRL-Tilde, CTRL-Backquote
  90.                 IF GetAsyncKeyState(192) THEN 'ctrl-tilde, ctrl-backquote -- neither are supported
  91.                     IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'determine which it is, via if shift is down
  92.                         IF ExtendedTimer > TildeDelay THEN k = 126: TildeDelay = ExtendedTimer + RepeatRate ELSE k = 0
  93.                     ELSE
  94.                         IF ExtendedTimer > BackQuoteDelay THEN k = 96: BackQuoteDelay = ExtendedTimer + RepeatRate ELSE k = 0
  95.                     END IF
  96.                 END IF
  97.                 'Fix for CTRL-0 to CTRL-9
  98.                 FOR i = 0 TO 9
  99.                     IF GetAsyncKeyState(i + 48) THEN 'ctrl-0 to ctrl-9
  100.                         IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'determine which it is, via if shift is down
  101.                             IF ExtendedTimer > NumDelay(i) THEN
  102.                                 SELECT CASE i 'WTF are these key codes all over the damn place??
  103.                                     CASE 0: k = 41
  104.                                     CASE 1: k = 33
  105.                                     CASE 2: k = 64
  106.                                     CASE 3: k = 35
  107.                                     CASE 4: k = 36
  108.                                     CASE 5: k = 37
  109.                                     CASE 6: k = 94
  110.                                     CASE 7: k = 38
  111.                                     CASE 8: k = 42
  112.                                     CASE 9: k = 40
  113.                                 END SELECT
  114.                                 NumDelay(i) = ExtendedTimer + RepeatRate
  115.                             END IF
  116.                         ELSE
  117.                             IF ExtendedTimer > NumDelay(i) THEN k = 48 + i: NumDelay(i) = ExtendedTimer + RepeatRate ELSE k = 0
  118.                         END IF
  119.                     END IF
  120.                 NEXT
  121.             END IF
  122.             IF AcceptMouseKeys = -1 THEN
  123.                 FOR i = 1 TO 6
  124.                     IF GetAsyncKeyState(i) THEN 'mouse left, right, nothing, center, button4, button5
  125.                         IF ExtendedTimer > MouseDelay(i) THEN
  126.                             k = i
  127.                             MouseDelay(i) = ExtendedTimer + RepeatRate
  128.                             MouseDown(i) = True
  129.                         ELSE
  130.                             k = 0
  131.                         END IF
  132.                     ELSE
  133.                         IF MouseDown(i) THEN k = -i: MouseDown(i) = 0
  134.                     END IF
  135.                 NEXT
  136.             END IF
  137.             IF AcceptMusicKeys = -1 THEN
  138.                 FOR i = 173 TO 179
  139.                     IF GetAsyncKeyState(i) THEN 'mouse left, right, nothing, center, button4, button5
  140.                         IF ExtendedTimer > MusicDelay(i) THEN
  141.                             k = i
  142.                             MusicDelay(i) = ExtendedTimer + RepeatRate
  143.                             MusicDown(i) = True
  144.                         ELSE
  145.                             k = 0
  146.                         END IF
  147.                     ELSE
  148.                         IF MusicDown(i) THEN k = -i: MusicDown(i) = 0
  149.                     END IF
  150.                 NEXT
  151.             END IF
  152.  
  153.             'Key up releases for the keys which we've been remapping
  154.  
  155.             SELECT CASE k
  156.                 CASE 0 'We didn't read a keypress at all
  157.                     IF PauseDown THEN k = -100019: PauseDown = 0
  158.                 CASE 13: JDown = 0 'Enter was hit, not CTRL-J
  159.                 CASE 93: MenuDown = 0 '] was hit after menu
  160.                 CASE 105: TabDown = 0 'CTRL-I was hit, rather than CTRL-Tab
  161.                 CASE 21248: BackspaceDown = 0 'Delete was hit, rather than CTRL-Backspace
  162.                 CASE -13 '-13 is the release code for both ENTER and CTRL-J
  163.                     IF JDown THEN k = -106: MenuDown = 0
  164.                 CASE -16, -17, -18 'shift release, ctrl release, alt release
  165.                     k = 0 'no need to report these as release codes, if we don't report them as down codes.
  166.                     'Instead, we report these as LEFT/RIGHT shift, ctrl, alt key releases and not just a generic "SHIFT WAS RELEASED" code.
  167.                 CASE -44 '-44 is the release code for both SYS and comma
  168.                     IF SysDown THEN k = -100316: SysDown = 0
  169.                 CASE -48 TO -57 '0 to 9 shares the same release codes, regardless of if shift is pressed
  170.                     IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'if shift is down
  171.                         SELECT CASE k
  172.                             CASE -48: k = -41 'it's ), not 0
  173.                             CASE -49: k = -33 '!, not 1
  174.                             CASE -50: k = -64 '@, not 2
  175.                             CASE -51: k = -35 '#, not 3
  176.                             CASE -52: k = -36 '$, not 4
  177.                             CASE -53: k = -37 '%, not 5
  178.                             CASE -54: k = -94 '^, not 6
  179.                             CASE -55: k = -38 '&, not 7
  180.                             CASE -56: k = -42 '*, not 8
  181.                             CASE -57: k = -40 '(, not 9
  182.                         END SELECT
  183.                     END IF
  184.                 CASE -93 '-93 is the release code for both MENU and ]
  185.                     IF MenuDown THEN k = -100319: MenuDown = 0
  186.                 CASE -105 '-105 is the release code for both CTRL-TAB and CTRL-I
  187.                     IF TabDown THEN k = -9: TabDown = 0
  188.                 CASE -106 '-106 is the release code for both CTRL-J and ENTER
  189.                     IF JDown THEN k = -106: TabDown = 0
  190.                 CASE -144: k = -100300 'Num lock key currently returns virtual code release values/
  191.                 CASE -145: k = -100302 'Scroll lock key currently returns virtual code release values
  192.                 CASE -192 'CTRL-` and CTRL-~ both  map to this key, but only up a key up event
  193.                     IF _KEYDOWN(100303) OR _KEYDOWN(100304) THEN 'determine which it is, via if shift is down
  194.                         k = -126
  195.                     ELSE
  196.                         k = -96
  197.                     END IF
  198.                 CASE -21248 '-21248 is the release code for both CTRL-Backspace and Delete
  199.                     IF BackspaceDown THEN k = -8: BackspaceDown = 0
  200.             END SELECT
  201.         END IF
  202.         Keyhit = k
  205.  
  206. FUNCTION ExtendedTimer##
  207.     'modified extendedtimer to store the old day's count, and not have to recalculate it every time the routine is called.
  208.  
  209.     STATIC olds AS _FLOAT, old_day AS _FLOAT
  210.     DIM m AS INTEGER, d AS INTEGER, y AS INTEGER
  211.     DIM s AS _FLOAT, day AS STRING
  212.     IF olds = 0 THEN 'calculate the day the first time the extended timer runs
  213.         day = DATE$
  214.         m = VAL(LEFT$(day, 2))
  215.         d = VAL(MID$(day, 4, 2))
  216.         y = VAL(RIGHT$(day, 4)) - 1970
  217.         SELECT CASE m 'Add the number of days for each previous month passed
  218.             CASE 2: d = d + 31
  219.             CASE 3: d = d + 59
  220.             CASE 4: d = d + 90
  221.             CASE 5: d = d + 120
  222.             CASE 6: d = d + 151
  223.             CASE 7: d = d + 181
  224.             CASE 8: d = d + 212
  225.             CASE 9: d = d + 243
  226.             CASE 10: d = d + 273
  227.             CASE 11: d = d + 304
  228.             CASE 12: d = d + 334
  229.         END SELECT
  230.         IF (y MOD 4) = 2 AND m > 2 THEN d = d + 1 'add a day if this is leap year and we're past february
  231.         d = (d - 1) + 365 * y 'current month days passed + 365 days per each standard year
  232.         d = d + (y + 2) \ 4 'add in days for leap years passed
  233.         s = d * 24 * 60 * 60 'Seconds are days * 24 hours * 60 minutes * 60 seconds
  234.         old_day = s
  235.     END IF
  236.     IF TIMER < oldt THEN 'we went from 23:59:59 (a second before midnight) to 0:0:0 (midnight)
  237.         old_day = s + 83400 'add another worth of seconds to our counter
  238.     END IF
  239.     oldt = TIMER
  240.     olds = old_day + oldt
  241.     ExtendedTimer## = olds
  243.  

Added support for NEW STUFF!!

This now returns us a keyhit code of:

1) Left Mouse
2) Right Mouse
4) Middle Mouse
5) Extra Mouse Button 1
6) Extra Mouse Button 2
173) Mute
174) Vol Down
175) Vol Up
176) Fast Forward/Next
177) Rewind/Back
178) Stop
179) Play/Pause

+ value is key down, - value is key up.

These aren't normally key returns that are available to us via _KEYHIT, but they're all keys on my keyboard, and values which I can read and test for with GetAsyncKeyState, so I added them into the patch for my own personal use.  If somebody else doesn't care for the extended button checking, just go in and change the following two CONST values to 0 and you can remove them from the process:

Code: [Select]
        CONST AcceptMouseKeys = -1, AcceptMusicKeys = -1 
Title: Re: A new Keyhit
Post by: TempodiBasic on December 28, 2019, 07:26:09 am
Hi
it is an huge and interesting work to decode for _Keyhit

In my old posts on .net I have noted that I can get different keycode depending if I use the original notebook keyboard or an USB keyboard the same are IT keyboards.

So the question that I pass you to let think... How much does _Keyhit recognize the keycode indipendently from hardware keyboard?
My fear is that you are going to do a very hard work that I can use only if you sell me your keyboard!
Thanks to read
Text Only | Text with Attachments